Re: [dpdk-dev] [PATCH 1/2] hash: add lock free support for extendable bucket

2019-03-22 Thread Wang, Yipeng1
Thanks for the patch! Comments inlined: >-Original Message- >From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] >Sent: Wednesday, March 20, 2019 3:35 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo >; Mcnamara, John >; Kovacevic, Marko >Cc: dev

Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-22 Thread Ye Xiaolong
On 03/22, Stephen Hemminger wrote: >On Fri, 22 Mar 2019 10:15:23 +0800 >Ye Xiaolong wrote: > >> On 03/21, Stephen Hemminger wrote: >> >On Thu, 21 Mar 2019 17:18:41 +0800 >> >Xiaolong Ye wrote: >> > >> >> + if (ret != 0) { >> >> + RTE_LOG(ERR, AF_XDP, "getsockopt() failed

Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-22 Thread Ye Xiaolong
On 03/22, Stephen Hemminger wrote: >On Fri, 22 Mar 2019 10:01:57 +0800 >Ye Xiaolong wrote: > >> On 03/21, Stephen Hemminger wrote: >> >On Thu, 21 Mar 2019 17:18:41 +0800 >> >Xiaolong Ye wrote: >> > >> >> + >> >> + if (ret < 0) >> >> + return -EINVAL; >> >> + >> >> + return 0; >> > >>

[dpdk-dev] [PATCH v4 7/8] doc: add documention for windows

2019-03-22 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS |

[dpdk-dev] [PATCH v4 8/8] build: meson changes to build on windows

2019-03-22 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app/

[dpdk-dev] [PATCH v4 4/8] eal: sys/queue.h implementation for windows

2019-03-22 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions(

[dpdk-dev] [PATCH v4 5/8] eal: add headers for compatibility with windows environment

2019-03-22 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/lib

[dpdk-dev] [PATCH v4 6/8] eal: add minimum viable code for eal on windows

2019-03-22 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v4 3/8] kvargs: adding a module definition file

2019-03-22 Thread Anand Rawat
adding a DEF file for kvargs to specify the exports for the creation of the shared library. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_kvargs/rte_kvargs_exports.def | 7 +++ 1 file changed, 7 insertions(+)

[dpdk-dev] [PATCH v4 1/8] eal: eal stub to add windows support

2019-03-22 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86/meson.b

[dpdk-dev] [PATCH v4 0/8] HelloWorld example for windows

2019-03-22 Thread Anand Rawat
Includes Windows-specific EAL changes and meson changes to build the code on windows. v4 Changes: 1. Exposed more functions for eal DLL in the module definition file 2. Moved disabling meson logic to sub directories v3 Changes: 1. Separated meson workarounds from the essential code changes 2. Add

[dpdk-dev] [PATCH v4 2/8] eal: add header files to support windows

2019-03-22 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_common.h to include rte_windows.h for windows build. Updated lib/meson.build to create shared libraries on windows. Added def file to list the exports for the eal library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam

Re: [dpdk-dev] [PATCH v2] kni: fix possible kernel crash with va2pa

2019-03-22 Thread Ferruh Yigit
On 3/12/2019 9:22 AM, Yangchao Zhou wrote: > va2pa depends on the physical address and virtual address offset of > current mbuf. It may get the wrong physical address of next mbuf which > allocated in another hugepage segment. > > In rte_mempool_populate_default(), trying to allocate whole block o

Re: [dpdk-dev] [PATCH] rte_reciprocal: make arg to rte_reciprocal_divide_u64 const

2019-03-22 Thread Maxime Coquelin
On 3/21/19 8:59 PM, Stephen Hemminger wrote: The divisor is not modified here. Doesn't really matter for optimizaton since the function is inline already; but helps with expressing intent. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/rte_reciprocal.h | 2 +- 1 file c

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-22 Thread Thomas Monjalon
22/03/2019 16:30, Pradeep Satyanarayana: > Thomas Monjalon wrote on 03/22/2019 01:49:03 AM: > > 22/03/2019 02:40, Pradeep Satyanarayana: > > > - rte_[rw]mb (general memory barrier) --> should be lwsync > > > > This is what may be discussed. > > The assumption is that the general memory barrier sho

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

2019-03-22 Thread David Marchand
On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko wrote: > On 22.03.2019 16:37, David Marchand wrote: > > Having the standard stats and the rx burst stats on the same line gives a > > really long line and is not consistent with the rest. > > > > Before: > >RX-packets: 3542977TX-packets

Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value

2019-03-22 Thread Ananyev, Konstantin
> -Original Message- > From: Wiles, Keith > Sent: Wednesday, March 20, 2019 5:53 PM > To: Ananyev, Konstantin > Cc: dpdk-dev ; akhil.go...@nxp.com; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx > offload value > > > > > On Mar

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

2019-03-22 Thread Andrew Rybchenko
On 22.03.2019 16:37, David Marchand wrote: Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2 pk

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

2019-03-22 Thread Andrew Rybchenko
On 22.03.2019 20:23, David Marchand wrote: On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin mailto:maxime.coque...@redhat.com>> wrote: On 3/22/19 2:37 PM, David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

2019-03-22 Thread David Marchand
On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin wrote: > > > On 3/22/19 2:37 PM, David Marchand wrote: > > Having the standard stats and the rx burst stats on the same line gives a > > really long line and is not consistent with the rest. > > > > Before: > >RX-packets: 3542977TX-packe

Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-22 Thread Maxime Coquelin
On 3/22/19 2:37 PM, David Marchand wrote: Add a new "show/clear fwd stats all" command to display fwd and port statistics on the fly. To be able to do so, the (testpmd only) rte_port structure can't be used to maintain any statistics. Moved the stats dump parts from stop_packet_forwarding() a

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

2019-03-22 Thread Maxime Coquelin
On 3/22/19 2:37 PM, David Marchand wrote: Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2

Re: [dpdk-dev] [PATCH v4 3/4] app/testpmd: remove useless casts on statistics

2019-03-22 Thread Maxime Coquelin
On 3/22/19 2:37 PM, David Marchand wrote: Caught by code review while investigating the fwd stats display code. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko --- Changelog since v2: - focused on useless casts on

Re: [dpdk-dev] [PATCH v4 2/4] app/testpmd: extend fwd statistics to 64bits

2019-03-22 Thread Maxime Coquelin
On 3/22/19 2:37 PM, David Marchand wrote: fwd engine statistics are stored as unsigned int (32bits) and can wrap quite quickly. Example: sending 7mpps for 614s gives us 429800 packets => 0x1002e4680 larger than 32bits. testpmd reports forwarding stats as: RX-packets: 3500381TX-pac

Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

2019-03-22 Thread Maxime Coquelin
On 3/22/19 2:37 PM, David Marchand wrote: Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2

[dpdk-dev] [PATCH v7] ci: Introduce travis builds for github repositories

2019-03-22 Thread Michael Santana
GitHub is a service used by developers to store repositories. GitHub provides service integrations that allow 3rd party services to access developer repositories and perform actions. One of these services is Travis-CI, a simple continuous integration platform. This series introduces the ability

Re: [dpdk-dev] 18.08.1 patches review and test

2019-03-22 Thread Kevin Traynor
On 30/01/2019 16:27, Kevin Traynor wrote: > Hi all, > > Here is a list of patches targeted for stable release 18.08.1. Please > help review and test. The tentative date for the final release is 28, > February. Before that, please shout if anyone has objections with these > patches being applied. >

Re: [dpdk-dev] [PATCH 1/3] rcu: add RCU library supporting QSBR mechanism

2019-03-22 Thread Ananyev, Konstantin
Hi Honnappa, > diff --git a/lib/librte_rcu/rte_rcu_qsbr.c b/lib/librte_rcu/rte_rcu_qsbr.c > new file mode 100644 > index 0..0fc4515ea > --- /dev/null > +++ b/lib/librte_rcu/rte_rcu_qsbr.c > @@ -0,0 +1,99 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * > + * Copyright (c) 2018 Arm Limi

[dpdk-dev] [PATCH v3] doc: add cryptodev xform deprecation notice

2019-03-22 Thread Fan Zhang
This patch adds the deprecation notice of changing Cryptodev symmetric xform structure. The proposed change is to making key pointers in the crypto xforms (cipher, auth, aead) to indicate neither the library or the drivers will not change the content of the key buffer. Signed-off-by: Fan Zhang --

[dpdk-dev] [PATCH v3] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-22 Thread lironh
From: Liron Himi - mbuf_size and mtu are now being calculated according to the given mb-pool. - max_mtu is now being set according to the given mtu the above two changes provide the ability to work with jumbo frames Signed-off-by: Liron Himi --- doc/guides/nics/kni.rst

Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-22 Thread Stephen Hemminger
On Fri, 22 Mar 2019 10:15:23 +0800 Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + if (ret != 0) { > >> + RTE_LOG(ERR, AF_XDP, "getsockopt() failed for > >> XDP_STATISTICS.\n"); > >> +

Re: [dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-22 Thread Stephen Hemminger
On Fri, 22 Mar 2019 10:01:57 +0800 Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye wrote: > > > >> + > >> + if (ret < 0) > >> + return -EINVAL; > >> + > >> + return 0; > > > >You could propogate kernel errno into DPDK? >

[dpdk-dev] [PATCH] ethdev: fix a typo

2019-03-22 Thread Rami Rosen
This patch fixes a trivial typo in rte_ethdev.h. retieve=>retrieve Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information") Cc: sta...@dpdk.org Signed-off-by: Rami Rosen --- lib/librte_ethdev/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librt

[dpdk-dev] 18.11.1 patches review and test

2019-03-22 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.1. Please help review and test. The planned date for the final release is April 8th. Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression tests,

Re: [dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done

2019-03-22 Thread Akhil Goyal
On 2/20/2019 9:30 PM, Shally Verma wrote: > >> -Original Message- >> From: dev On Behalf Of Fiona Trahe >> Sent: 17 January 2019 23:06 >> To: dev@dpdk.org >> Cc: pablo.de.lara.gua...@intel.com; fiona.tr...@intel.com; >> akhil.go...@nxp.com; paul.e.l...@intel.com >> Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v2 0/3] add XTS support for Intel QAT

2019-03-22 Thread Akhil Goyal
On 3/13/2019 11:21 PM, Trahe, Fiona wrote: > >> -Original Message- >> From: Nowak, DamianX >> Sent: Wednesday, March 13, 2019 2:52 PM >> To: dev@dpdk.org >> Cc: Trahe, Fiona ; Nowak, DamianX >> >> Subject: [PATCH v2 0/3] add XTS support for Intel QAT >> >> This patchset adds XTS support

Re: [dpdk-dev] [PATCH v2] app/test: fix possible overflow using strlcat

2019-03-22 Thread Akhil Goyal
On 3/22/2019 8:01 PM, Akhil Goyal wrote: > > On 3/18/2019 6:06 PM, Chaitanya Babu Talluri wrote: >> strcat does not check the destination length and there might be >> chances of string overflow so instead of strcat, strlcat is used. >> >> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit te

Re: [dpdk-dev] [PATCH v2 1/1] fips_validation: Add plain SHA support

2019-03-22 Thread Akhil Goyal
On 3/19/2019 3:13 PM, Damian Nowak wrote: > This patch enables plain SHA algorithm CAVP test support > in fips_validation sample application. > > Signed-off-by: Damian Nowak > Acked-by: Fan Zhang > Acked-by: Marko Kovacevic > --- > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 1/3] common/cpt: improve structures used in datapath

2019-03-22 Thread Akhil Goyal
On 3/19/2019 10:06 AM, Anoob Joseph wrote: > Hi Akhil, > > Can you review this series and share your thoughts? > > Thanks, > Anoob Patchset applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v5 0/5] ipsec: support AES-CTR and 3DES-CBC

2019-03-22 Thread Akhil Goyal
On 3/20/2019 9:08 PM, Fan Zhang wrote: > This patchset adds the AES-CTR and 3DES-CBC cipher algorithms > support to ipsec library. The test scripts for ipsec-secgw > sample application are added. > > v5: > - updated ipsec-secgw run_test.sh script > - updated release note > > v4: > - changed patch

Re: [dpdk-dev] [PATCH] doc: fix a typo in procinfo guide

2019-03-22 Thread Varghese, Vipin
Thanks for the correction. Reviewed-by: Vipin Varghese > -Original Message- > From: Rami Rosen > Sent: Friday, March 22, 2019 4:07 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Varghese, Vipin > ; Kovacevic, Marko > ; Rami Rosen > Subject: [PATCH] doc: fix a typo in procinfo guide > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string parser for flow API

2019-03-22 Thread Ferruh Yigit
On 3/22/2019 3:15 AM, Wei Zhao wrote: > There is need for users to set configuration of HEX number for RSS > key. The key byte should be pass down as hex number not as char > string. This patch enable cmdline flow parse HEX number, > in order to not using string which pass ASIC number. > > Fixes:

Re: [dpdk-dev] [PATCH v2] test: add snow3g test cases when digest is encrypted

2019-03-22 Thread Akhil Goyal
Hi Lukasz, On 3/1/2019 11:06 PM, Kusztal, ArkadiuszX wrote: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lukasz Krakowiak >> Sent: Wednesday, February 27, 2019 11:18 AM >> To: De Lara Guarch, Pablo >> Cc: dev@dpdk.org; Trahe, Fiona ; Krakowiak, >> Lukasz

Re: [dpdk-dev] [PATCH v4 4/5] net/af_xdp: use mbuf mempool for buffer management

2019-03-22 Thread Maxime Coquelin
On 3/22/19 2:01 PM, Xiaolong Ye wrote: Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf be s/mbuf be allocated/mbuf allocated/ allocated from rte_mempool can be convert to xdp_desc's address and vice s/convert/converted/ versa. Signed-off-by: Xiaolong Ye --- drivers

Re: [dpdk-dev] [PATCH v4 2/5] lib/mbuf: introduce helper to create mempool with flags

2019-03-22 Thread Maxime Coquelin
On 3/22/19 2:01 PM, Xiaolong Ye wrote: This allows applications to create mbuf mempool with specific flags such as MEMPOOL_F_NO_SPREAD if they want fixed size memory objects. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mbuf/rte_mbuf.c | 29 +++-

Re: [dpdk-dev] [PATCH v4 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-22 Thread Maxime Coquelin
On 3/22/19 2:01 PM, Xiaolong Ye wrote: Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.

Re: [dpdk-dev] [PATCH v2] app/test: fix possible overflow using strlcat

2019-03-22 Thread Akhil Goyal
On 3/18/2019 6:06 PM, Chaitanya Babu Talluri wrote: > strcat does not check the destination length and there might be > chances of string overflow so instead of strcat, strlcat is used. > > Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") > Cc: sta...@dpdk.org > > Signed-off-by: Ch

Re: [dpdk-dev] [PATCH v2] test/ipsec: fix test initialisation

2019-03-22 Thread Akhil Goyal
Hi Bernard, On 3/22/2019 7:17 PM, Bernard Iremonger wrote: > Fix xform initialisation. > Fix testsuite_setup. > Loop on rte_cryptodev_dequeue_burst() calls. > Remove unused variables. > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > Fixes: 59d7353b0df0 ("test/ipsec: fix test sui

Re: [dpdk-dev] [PATCH v1 0/6] ethdev: add min/max MTU to device info

2019-03-22 Thread Ferruh Yigit
On 3/22/2019 1:05 PM, Ian Stokes wrote: > On 3/21/2019 1:03 PM, Ian Stokes wrote: >> On 3/19/2019 4:30 PM, Ferruh Yigit wrote: >>> On 2/27/2019 9:45 PM, Ian Stokes wrote: Building upon the discussion around [1], this series introduces MTU min and MTU max variables. It also provides update

[dpdk-dev] [PATCH v2] test/ipsec: fix test initialisation

2019-03-22 Thread Bernard Iremonger
Fix xform initialisation. Fix testsuite_setup. Loop on rte_cryptodev_dequeue_burst() calls. Remove unused variables. Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") Signed-off-by: Bernard Iremonger --- Changes in v2: Increase

[dpdk-dev] [PATCH v4 3/4] app/testpmd: remove useless casts on statistics

2019-03-22 Thread David Marchand
Caught by code review while investigating the fwd stats display code. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko --- Changelog since v2: - focused on useless casts only - Cc'd stable --- app/test-pmd/testpmd.c |

[dpdk-dev] [PATCH v4 4/4] app/testpmd: display/clear forwarding stats on demand

2019-03-22 Thread David Marchand
Add a new "show/clear fwd stats all" command to display fwd and port statistics on the fly. To be able to do so, the (testpmd only) rte_port structure can't be used to maintain any statistics. Moved the stats dump parts from stop_packet_forwarding() and merge with fwd_port_stats_display() into fwd

[dpdk-dev] [PATCH v4 2/4] app/testpmd: extend fwd statistics to 64bits

2019-03-22 Thread David Marchand
fwd engine statistics are stored as unsigned int (32bits) and can wrap quite quickly. Example: sending 7mpps for 614s gives us 429800 packets => 0x1002e4680 larger than 32bits. testpmd reports forwarding stats as: RX-packets: 3500381TX-packets: 3500010TX-dropped: 371 While the

[dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics

2019-03-22 Thread David Marchand
Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: RX-packets: 3542977TX-packets: 3542971TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] TX-burst

[dpdk-dev] [PATCH v4 0/4] display testpmd forwarding engine stats on the fly

2019-03-22 Thread David Marchand
Here is a little series that makes it possible to display and clear testpmd fwd engines while they run without having to stop them. This is mostly handy when running stress tests and you look for packets drops without having to stop/start testpmd forwarding. Example: testpmd> show fwd stats all

Re: [dpdk-dev] [PATCH v2 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices

2019-03-22 Thread Kusztal, ArkadiuszX
Hi Akhil, Sure, I will try to eliminate as many checkpatch warnings as possible in v3 then. > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, March 22, 2019 1:34 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org; > Trahe, Fiona > Cc: Nowak, DamianX > Subje

Re: [dpdk-dev] [PATCH v2] net/i40e: add warning info when no perfect RSS key

2019-03-22 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, March 22, 2019 11:07 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; ktray...@redhat.com; > Zhao1, Wei > Subject: [PATCH v2] net/i40e: add warning info when no perfect RSS key > > There need a warning info when no perfe

Re: [dpdk-dev] [PATCH] doc: note validation commitment required for stables

2019-03-22 Thread Luca Boccassi
On Fri, 2019-03-22 at 11:44 +, Kevin Traynor wrote: > If a stable branch for a specific DPDK release is to proceed, > along with needing a maintainer, there should also be commitment > from major contributors for validation of the releases. > > Signed-off-by: Kevin Traynor > --- > doc/guides

Re: [dpdk-dev] [PATCH] doc: update DPDK LTS versions

2019-03-22 Thread Luca Boccassi
On Fri, 2019-03-22 at 11:29 +, Kevin Traynor wrote: > Support for 16.11 has ended. 17.11 and 18.11 are the current LTSs. > > Signed-off-by: Kevin Traynor > --- > doc/guides/contributing/stable.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/contributi

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto

2019-03-22 Thread Akhil Goyal
Hi Bernard, On 3/7/2019 8:27 PM, Bernard Iremonger wrote: > Inline crypto installs a flow rule in the NIC. This flow > rule must be installed before the first inbound packet is > received. > > The create_session() function installs the flow rule, > create_session() has been refactored into create_

[dpdk-dev] [PATCH] devtools: select patches to check with git range

2019-03-22 Thread David Marchand
Rather than default to origin/master.., it can be handy to choose the range you want to check. Example on a branch rebased on next-net: Before: [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh ... ... 67/69 valid patches After: [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh -r next-net

[dpdk-dev] [PATCH v4 3/5] lib/mempool: allow page size aligned mempool

2019-03-22 Thread Xiaolong Ye
Allow create a mempool with page size aligned base address. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mempool/rte_mempool.c | 3 +++ lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 4 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempo

[dpdk-dev] [PATCH v4 4/5] net/af_xdp: use mbuf mempool for buffer management

2019-03-22 Thread Xiaolong Ye
Now, af_xdp registered memory buffer is managed by rte_mempool. mbuf be allocated from rte_mempool can be convert to xdp_desc's address and vice versa. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 117 +--- 1 file changed, 72 insertions(+), 45 dele

[dpdk-dev] [PATCH v4 5/5] net/af_xdp: enable zero copy

2019-03-22 Thread Xiaolong Ye
Try to check if external mempool (from rx_queue_setup) is fit for af_xdp, if it is, it will be registered to af_xdp socket directly and there will be no packet data copy on Rx and Tx. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 129 1 file ch

[dpdk-dev] [PATCH v4 2/5] lib/mbuf: introduce helper to create mempool with flags

2019-03-22 Thread Xiaolong Ye
This allows applications to create mbuf mempool with specific flags such as MEMPOOL_F_NO_SPREAD if they want fixed size memory objects. Signed-off-by: Qi Zhang Signed-off-by: Xiaolong Ye --- lib/librte_mbuf/rte_mbuf.c | 29 +++- lib/librte_mbuf/rte_mbuf.h | 45 ++

[dpdk-dev] [PATCH v4 1/5] net/af_xdp: introduce AF XDP PMD driver

2019-03-22 Thread Xiaolong Ye
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://

Re: [dpdk-dev] [PATCH v1 0/6] ethdev: add min/max MTU to device info

2019-03-22 Thread Ian Stokes
On 3/21/2019 1:03 PM, Ian Stokes wrote: On 3/19/2019 4:30 PM, Ferruh Yigit wrote: On 2/27/2019 9:45 PM, Ian Stokes wrote: Building upon the discussion around [1], this series introduces MTU min and MTU max variables. It also provides updates to PMD implementations for ixgbe, i40e and IGB device

[dpdk-dev] [PATCH v4 0/5] Introduce AF_XDP PMD

2019-03-22 Thread Xiaolong Ye
Overview This patchset adds a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux, see below links [1] [2] for details of AF_XDP introduction: AF_XDP roadmap == - AF_XDP is included in upstream kernel since 4.18, and AF_XDP support i

[dpdk-dev] [PATCH v2 6/7] net/e1000: set min and max MTU for igb devices

2019-03-22 Thread Ian Stokes
This commit sets the min and max supported MTU values for igb devices via the eth_igb_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. To aid in these calculations a new MACRO 'E1000_ETH_OVERHEA

[dpdk-dev] [PATCH v2 3/7] net/i40e: set min and max MTU for i40e VF devices

2019-03-22 Thread Ian Stokes
This commit sets the min and max supported MTU values for i40e VF devices via the i40evf_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Ian Stokes --- drivers/net/i40e/i4

[dpdk-dev] [PATCH v2 7/7] app/testpmd: verify mtu with rte_eth_dev_info_get()

2019-03-22 Thread Ian Stokes
This commit uses the mtu fields populated in rte_eth_dev_info_get() to validate the mtu value being passed in port_mtu_set(). Signed-off-by: Ian Stokes --- app/test-pmd/config.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index b9e5dd923.

[dpdk-dev] [PATCH v2 5/7] net/ixgbe: set min and max MTU for ixgbe VF devices

2019-03-22 Thread Ian Stokes
This commit sets the min and max supported MTU values for ixgbe VF devices via the ixgbevf_dev_set_mtu() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. As transport overhead is the same for VF and PF ixg

[dpdk-dev] [PATCH v2 4/7] net/ixgbe: set min and max MTU for ixgbe devices

2019-03-22 Thread Ian Stokes
This commit sets the min and max supported MTU values for ixgbe devices via the ixgbe_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. To aid in these calculations a new MACRO 'IXGBE_ETH_OVE

[dpdk-dev] [PATCH v2 2/7] net/i40e: set min and max MTU for i40e devices

2019-03-22 Thread Ian Stokes
This commit sets the min and max supported MTU values for i40e devices via the i40e_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Ian Stokes --- drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH v2 1/7] ethdev: add min/max MTU to device info

2019-03-22 Thread Ian Stokes
From: Stephen Hemminger This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existing structure. The initial version sets max mtu to normal Ethernet, it is up to PMD to

Re: [dpdk-dev] [PATCH v5 1/5] ipsec: support AES-CTR

2019-03-22 Thread Akhil Goyal
Hi Konstantin, On 3/22/2019 6:16 PM, Ananyev, Konstantin wrote: > Hi Akhil, > >> On 3/20/2019 9:08 PM, Fan Zhang wrote: >>> This patch adds AES-CTR cipher algorithm support to ipsec >>> library. >>> >>> Signed-off-by: Fan Zhang >>> Acked-by: Akhil Goyal >>> Acked-by: Konstantin Ananyev >>> ---

[dpdk-dev] [PATCH v2 0/7] ethdev: add min/max MTU to device info

2019-03-22 Thread Ian Stokes
Building upon the discussion around [1], this series introduces MTU min and MTU max variables. It also provides updates to PMD implementations for ixgbe, i40e and IGB devices so that these variables are populated for use when retrieving device info. This series was tested with OVS DPDK and functio

Re: [dpdk-dev] [PATCH v5 1/5] ipsec: support AES-CTR

2019-03-22 Thread Ananyev, Konstantin
Hi Akhil, > > On 3/20/2019 9:08 PM, Fan Zhang wrote: > > This patch adds AES-CTR cipher algorithm support to ipsec > > library. > > > > Signed-off-by: Fan Zhang > > Acked-by: Akhil Goyal > > Acked-by: Konstantin Ananyev > > --- > > lib/librte_ipsec/crypto.h | 17 ++ > > lib/librte_ipse

Re: [dpdk-dev] [PATCH v2 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices

2019-03-22 Thread Akhil Goyal
Hi Fiona, Could you please review/ack this series. Hi Arek, I can see a few checkpatch warnings. Could you please correct those. Thanks, Akhil On 3/18/2019 6:15 PM, Arek Kusztal wrote: > This patchset adds Poll Mode Driver to use asymmetric cryptography > functions using Intel QuickAssist Tech

[dpdk-dev] [PATCH v5] net/nfb: new netcope driver

2019-03-22 Thread Rastislav Cernay
From: Rastislav Cernay Added new net driver for Netcope nfb cards Signed-off-by: Rastislav Cernay --- v2: remove unnecessary cast remove unnecessary zeroing move declaration to not mix with code restore skeleton example v3: add release notes add doc to doc index add architec

[dpdk-dev] [RFC v5] /net: memory interface (memif)

2019-03-22 Thread Jakub Grajciar
Memory interface (memif), provides high performance packet transfer over shared memory. Signed-off-by: Jakub Grajciar --- MAINTAINERS |6 + config/common_base |5 + config/common_linux |1 + doc/guides/n

Re: [dpdk-dev] [PATCH v3 2/4] power: extend guest channel api for reading

2019-03-22 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Friday, March 22, 2019 11:00 AM > To: Hajkowski, MarcinX ; Hunt, David > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/4] power: extend guest channel api for > reading > > >

Re: [dpdk-dev] [PATCH v5 1/5] ipsec: support AES-CTR

2019-03-22 Thread Akhil Goyal
Hi Fan, On 3/20/2019 9:08 PM, Fan Zhang wrote: > This patch adds AES-CTR cipher algorithm support to ipsec > library. > > Signed-off-by: Fan Zhang > Acked-by: Akhil Goyal > Acked-by: Konstantin Ananyev > --- > lib/librte_ipsec/crypto.h | 17 ++ > lib/librte_ipsec/sa.c | 133 > +

[dpdk-dev] [PATCH v12] eal_interrupts: add option for pending callback unregister

2019-03-22 Thread Jakub Grajciar
use case: if callback is used to receive message form socket, and the message received is disconnect/error, this callback needs to be unregistered, but cannot because it is still active. With this patch it is possible to mark the callback to be unregistered once the interrupt process is done with

[dpdk-dev] [PATCH] doc: note validation commitment required for stables

2019-03-22 Thread Kevin Traynor
If a stable branch for a specific DPDK release is to proceed, along with needing a maintainer, there should also be commitment from major contributors for validation of the releases. Signed-off-by: Kevin Traynor --- doc/guides/contributing/stable.rst | 3 ++- 1 file changed, 2 insertions(+), 1 d

Re: [dpdk-dev] [PATCH v7 3/3] test/ticketlock: add ticket lock test case

2019-03-22 Thread Ananyev, Konstantin
> > Add test cases for ticket lock, recursive ticket lock, > and ticket lock performance. > > Signed-off-by: Joyce Kong > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang > --- > MAINTAINERS| 1 + > app/test/Makefile | 1 + > app/test/autotest_data.py | 6 +

[dpdk-dev] [PATCH] doc: update DPDK LTS versions

2019-03-22 Thread Kevin Traynor
Support for 16.11 has ended. 17.11 and 18.11 are the current LTSs. Signed-off-by: Kevin Traynor --- doc/guides/contributing/stable.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/stable.rst b/doc/guides/contributing/stable.rst index 2ac4f0a88..421

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix more incorrect slave id types

2019-03-22 Thread Maxime Coquelin
On 3/21/19 9:28 PM, David Marchand wrote: From: Zhaohui mode_bond_id and mode_band_id are slave ids, stored on 16bits. Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: sta...@dpdk.org Signed-off-by: Zhaohui Signed-off-by: David Marchand --- drivers/net/bonding/rte_eth_bond_80

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix oob access in "other" aggregator modes

2019-03-22 Thread Maxime Coquelin
On 3/21/19 9:28 PM, David Marchand wrote: From: Zhaohui slave aggregator_port_id is in [0, RTE_MAX_ETHPORTS-1] range. If RTE_MAX_ETHPORTS is > 8, we can hit out of bound accesses on agg_bandwidth[] and agg_count[] arrays. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: s

Re: [dpdk-dev] [PATCH v3 2/4] power: extend guest channel api for reading

2019-03-22 Thread Maxime Coquelin
On 3/21/19 11:55 AM, Hajkowski wrote: From: Marcin Hajkowski Added new experimental API rte_power_guest_channel_receive_msg which gives possibility to receive messages send to guest. Signed-off-by: Marcin Hajkowski --- lib/librte_power/channel_commands.h| 5 ++ lib/librte_power/gue

Re: [dpdk-dev] [PATCH v3 1/4] power: fix invalid socket indicator value

2019-03-22 Thread Maxime Coquelin
On 3/21/19 11:55 AM, Hajkowski wrote: From: Marcin Hajkowski Currently 0 is being used for not connected slot indication. This is not consistent with linux doc which identifies 0 as valid (connected) slot, thus modification was done to change it. Fixes: cd0d5547 ("power: vm communication ch

Re: [dpdk-dev] [PATCH v7 1/3] eal/ticketlock: ticket based to improve fairness

2019-03-22 Thread Ananyev, Konstantin
Hi Joyce, > > The spinlock implementation is unfair, some threads may take locks > aggressively while leaving the other threads starving for long time. > > This patch introduces ticketlock which gives each waiting thread a > ticket and they can take the lock one by one. First come, first service

Re: [dpdk-dev] DPDK short term stable maintenance

2019-03-22 Thread Kevin Traynor
On 12/03/2019 20:46, Luca Boccassi wrote: > On Tue, 2019-03-12 at 19:12 +, Kevin Traynor wrote: >> Hi All, >> >> This is about short term stable maintenance, ~3 months based on >> n.02/05/08 DPDK. It is **not** referring/impacting DPDK LTS, >> maintained >> for ~2 years based on n.11 DPDK. >> >

[dpdk-dev] [PATCH] doc: fix a typo in procinfo guide

2019-03-22 Thread Rami Rosen
This patch fixes a trivial info in proc info section. informationi=>information. Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") Signed-off-by: Rami Rosen --- doc/guides/tools/proc_info.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/tools/proc_info.rst

Re: [dpdk-dev] [dpdk-stable] [EXT] [PATCH v8] drivers/net: fix possible overflow using strlcat

2019-03-22 Thread Ferruh Yigit
On 3/22/2019 8:02 AM, Shahed Shaikh wrote: >> -Original Message- >> From: Chaitanya Babu Talluri >> Sent: Friday, March 22, 2019 1:22 PM >> To: dev@dpdk.org >> Cc: reshma.pat...@intel.com; jananeex.m.parthasara...@intel.com; Rasesh >> Mody ; Shahed Shaikh ; >> beilei.x...@intel.com; qi.z.z

Re: [dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests

2019-03-22 Thread Zhang, Roy Fan
Tried with vhost_crypto sample APP and virtio_crypto PMD, unit test and perf test works like a charm! Thanks Maxime! Regards, Fan > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, March 21, 2019 9:21 AM > To: Stojaczyk, Dariusz

Re: [dpdk-dev] [PATCH v5 6/8] net/ice: support Rx AVX2 vector

2019-03-22 Thread Maxime Coquelin
On 3/22/19 3:58 AM, Wenzhuo Lu wrote: Signed-off-by: Wenzhuo Lu --- drivers/net/ice/Makefile| 19 ++ drivers/net/ice/ice_rxtx.c | 16 +- drivers/net/ice/ice_rxtx.h | 2 + drivers/net/ice/ice_rxtx_vec_avx2.c | 622 dr

Re: [dpdk-dev] [PATCH v5 5/8] net/ice: support Tx SSE vector

2019-03-22 Thread Maxime Coquelin
On 3/22/19 3:58 AM, Wenzhuo Lu wrote: Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 2 + drivers/net/ice/ice_rxtx.c| 17 + drivers/net/ice/ice_rxtx.h| 4 + drivers/net/ice/ice_rxtx_vec_common.h | 133 +++

Re: [dpdk-dev] [PATCH] rte_ring: add newline to error message

2019-03-22 Thread Rami Rosen
On Fri, Mar 22, 2019 at 1:04 AM Stephen Hemminger < step...@networkplumber.org> wrote: > Log message should end with newline. > > Fixes: 4e32101f9b01 ("ring: support freeing") > Signed-off-by: Stephen Hemminger > --- > Reviewed-by: Rami Rosen

Re: [dpdk-dev] [PATCH v5 3/8] net/ice: support vector SSE in RX

2019-03-22 Thread Maxime Coquelin
On 3/22/19 3:58 AM, Wenzhuo Lu wrote: Signed-off-by: Wenzhuo Lu --- doc/guides/nics/features/ice_vec.ini | 33 +++ drivers/net/ice/Makefile | 3 + drivers/net/ice/ice_ethdev.c | 2 - drivers/net/ice/ice_ethdev.h | 2 + drivers/net/ice/ice_rxtx.c

  1   2   >