Hi Akhil, Sure, I will try to eliminate as many checkpatch warnings as possible in v3 then.
> -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, March 22, 2019 1:34 PM > To: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com>; dev@dpdk.org; > Trahe, Fiona <fiona.tr...@intel.com> > Cc: Nowak, DamianX <damianx.no...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 0/4] Add PMD for asymmetric > cryptography operations using Intel QuickAssist Technology devices > > Hi Fiona, > > Could you please review/ack this series. > > Hi Arek, > > I can see a few checkpatch warnings. Could you please correct those. > > Thanks, > Akhil > > On 3/18/2019 6:15 PM, Arek Kusztal wrote: > > This patchset adds Poll Mode Driver to use asymmetric cryptography > > functions using Intel QuickAssist Techology devices. > > > > Following functions are available with this patchset: > > * Modular Exponentiation > > * Modular Inverse > > > > This patch depends on a QAT PF driver for device initialization. See > > the file docs/guides/cryptodevs/qat.rst for configuration details. > > > > Limitations: > > * Maximum parameter size: 4096 bits > > - For both modular exponentiaion and modular multiplicative > inverse > > > > This patchset depends on following patches: > > - [v2,1/3] cryptodev: add result field to mod exp and inverse > > operations > > (http://patchwork.dpdk.org/patch/50256/) > > - [v2] lib/cryptodev: fix driver name comparison > > (http://patchwork.dpdk.org/patch/51027/) > > > > v2: > > - added Meson build > > - fixed segfault on cookie > > - fixed mod inverse problem > > > > Arek Kusztal (4): > > common/qat: add headers for asymmetric crypto > > crypto/qat: add asymmetric cryptography PMD > > crypto/qat: add modular exponentiation to qat asym pmd > > crypto/qat: add modular multiplicative inverse to qat asym pmd > > > > config/common_base | 1 + > > doc/guides/cryptodevs/qat.rst | 10 + > > drivers/common/qat/Makefile | 8 + > > drivers/common/qat/qat_adf/icp_qat_fw_mmp_ids.h | 1538 > ++++++++++++++++++++ > > drivers/common/qat/qat_adf/icp_qat_fw_pke.h | 426 ++++++ > > .../qat/qat_adf/qat_pke_functionality_arrays.h | 52 + > > drivers/common/qat/qat_device.h | 12 +- > > drivers/common/qat/qat_qp.c | 8 + > > drivers/crypto/qat/meson.build | 5 +- > > drivers/crypto/qat/qat_asym.c | 407 ++++++ > > drivers/crypto/qat/qat_asym.h | 106 ++ > > drivers/crypto/qat/qat_asym_capabilities.h | 42 + > > drivers/crypto/qat/qat_asym_pmd.c | 310 ++++ > > drivers/crypto/qat/qat_asym_pmd.h | 46 + > > drivers/crypto/qat/qat_sym_pmd.c | 1 - > > drivers/crypto/qat/qat_sym_pmd.h | 3 +- > > 16 files changed, 2970 insertions(+), 5 deletions(-) > > create mode 100644 > drivers/common/qat/qat_adf/icp_qat_fw_mmp_ids.h > > create mode 100644 drivers/common/qat/qat_adf/icp_qat_fw_pke.h > > create mode 100644 > drivers/common/qat/qat_adf/qat_pke_functionality_arrays.h > > create mode 100644 drivers/crypto/qat/qat_asym.c > > create mode 100644 drivers/crypto/qat/qat_asym.h > > create mode 100644 drivers/crypto/qat/qat_asym_capabilities.h > > create mode 100644 drivers/crypto/qat/qat_asym_pmd.c > > create mode 100644 drivers/crypto/qat/qat_asym_pmd.h > >
