[dpdk-dev] rte_eth_rx_queue_count support in DPDK FM10k driver.

2019-02-20 Thread Jags N
Hi, I am running a DPDK application on host processor. The application is bind to PCIe Host Interface of an FM10k switch. To prevent FM10k switch from sending more packets than what the DPDK application can process, the idea is to have DPDK application check the Rx Queue build up and send pause fr

[dpdk-dev] [dpdk-announce] DPDK 17.11.5 released

2019-02-20 Thread Yongseok Koh
Hi all, Finally, a new stable release is being announced: https://fast.dpdk.org/rel/dpdk-17.11.5.tar.xz (MD5 b970f74e48b6477a406b43d6451c185f) The git tree is at: https://git.dpdk.org/dpdk-stable/log/?h=17.11 Please note that the list of missing patches is attached at the

[dpdk-dev] [PATCH] net/kni: calc mbuf&mtu according to given mb_pool

2019-02-20 Thread lironh
From: Liron Himi - mbuf_size and mtu are now being calculated according to the given mb-pool. - max_mtu is now being set according to the given mtu the above two changes provide the ability to work with jumbo frames Signed-off-by: Liron Himi --- drivers/net/kni/rte_eth_kni.c | 10 +++---

Re: [dpdk-dev] [PATCH v3 2/2] net/ixgbe: add support of loopback for X540/X550

2019-02-20 Thread Zhao1, Wei
Acked-by: Wei Zhao > -Original Message- > From: Julien Meunier [mailto:julien.meun...@nokia.com] > Sent: Thursday, February 21, 2019 5:06 AM > To: Zhao1, Wei ; Zhang, Qi Z ; > Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: [PATCH v3 2/2] net/ixgbe: add support of loop

Re: [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level

2019-02-20 Thread Stephen Hemminger
On Wed, 20 Feb 2019 17:00:20 -0600 Dharmik Thakkar wrote: > Currently, in test code, for printing extra information, > compilation time options are used. This approach does not compile the > code always. Macro needs to be set for the code to compile. > > This patchset replaces compilation time o

[dpdk-dev] [PATCH v3 2/3] test/efd: enable unit test compilation always

2019-02-20 Thread Dharmik Thakkar
This patch enables compilation of print_key_info() always using log-level based approach instead of a macro. Need to set efd log type to debug to print debug information, using the following eal parameter: --log-type=efd,8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by:

[dpdk-dev] [PATCH v3 3/3] test/timer: enable unit test compilation always

2019-02-20 Thread Dharmik Thakkar
This patch replaces macro with log-level based approach to print debug information. Need to set timer log type to debug using the following eal parameter: --log-level=timer,8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu R

[dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level

2019-02-20 Thread Dharmik Thakkar
Currently, in test code, for printing extra information, compilation time options are used. This approach does not compile the code always. Macro needs to be set for the code to compile. This patchset replaces compilation time option with log level based approach, thus enabling compilation of code

[dpdk-dev] [PATCH v3 1/3] test/hash: replace macro with log-level approach

2019-02-20 Thread Dharmik Thakkar
Need to set hash log type to debug to print debug information, using following eal parameter: --log-type=hash,8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Phil Yang Reviewed-by: Ferruh Yigit --- v3: * Res

[dpdk-dev] [PATCH v2 1/3] test/hash: replace macro with log-level approach

2019-02-20 Thread Dharmik Thakkar
Need to set hash log type to debug to print debug information, using following eal parameter: --log-type=hash,8 Change-Id: I19c56d6e79c0b6d5c20284be3576a80e6bcca920 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by:

[dpdk-dev] [PATCH v2 2/3] test/efd: enable unit test compilation always

2019-02-20 Thread Dharmik Thakkar
This patch enables compilation of print_key_info() always using log-level based approach instead of a macro. Need to set efd log type to debug to print debug information, using the following eal parameter: --log-type=efd,8 Change-Id: I5ca3a943ac0d0de16ca4a9fe36f370b1dc5c6015 Suggested-by: Thomas M

[dpdk-dev] [PATCH v2 3/3] test/timer: enable unit test compilation always

2019-02-20 Thread Dharmik Thakkar
This patch replaces macro with log-level based approach to print debug information. Need to set timer log type to debug using the following eal parameter: --log-level=timer,8 Change-Id: I31e660e31b556ccade314a948226f0f076231a15 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Review

[dpdk-dev] [PATCH v2 0/3] Replace compilation time options with log level

2019-02-20 Thread Dharmik Thakkar
Currently, in test code, for printing extra information, compilation time options are used. This approach does not compile the code always. Macro needs to be set for the code to compile. This patchset replaces compilation time option with log level based approach, thus enabling compilation of code

[dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-02-20 Thread Thomas Monjalon
If multiple ports share the same hardware device (rte_device), they are siblings and can be found thanks to the new functions and loop macros. One iterator takes a port id as reference, while the other one directly refers to the parent device. The ownership is not checked because siblings may have

[dpdk-dev] [PATCH v2 4/4] app/testpmd: use port sibling iterator in device cleanup

2019-02-20 Thread Thomas Monjalon
When removing a rte_device on a port-based request, all the sibling ports must be marked as closed. The iterator loop can be simplified by using the dedicated macro. Signed-off-by: Thomas Monjalon --- app/test-pmd/testpmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/a

[dpdk-dev] [PATCH v2 0/4] ethdev iterators for multi-ports device

2019-02-20 Thread Thomas Monjalon
Add port iterators in order to allow listing easily the ports of the same device. The iterators can be tested by using mlx5 or testpmd. Thomas Monjalon (4): ethdev: simplify port state comparisons ethdev: add siblings iterators net/mlx5: use port sibling iterators app/testpmd: use port s

[dpdk-dev] [PATCH v2 3/4] net/mlx5: use port sibling iterators

2019-02-20 Thread Thomas Monjalon
Iterating over siblings was done with RTE_ETH_FOREACH_DEV() which skips the owned ports. The new iterators RTE_ETH_FOREACH_DEV_SIBLING() and RTE_ETH_FOREACH_DEV_OF() are more appropriate and more correct. Signed-off-by: Thomas Monjalon --- drivers/net/mlx5/mlx5.c| 34 +---

[dpdk-dev] [PATCH v2 1/4] ethdev: simplify port state comparisons

2019-02-20 Thread Thomas Monjalon
There are three states for an ethdev port. Checking that the port is unused looks simpler than checking it is neither attached nor removed. Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/librte_ethde

[dpdk-dev] [PATCH v3] test/pmd_perf: fix the way to drain the port

2019-02-20 Thread Julien Meunier
If the port has received less than ``pkt_per_port`` packets (for example, the port has missed some packets), the test is in an infinite loop. Instead of expecting a number of packet to receive, let the port to be drained by itself. If no more packets are received, the test can continue. Fixes: 00

[dpdk-dev] [PATCH v3 1/2] net/ixgbe: do not start on unsupported loopback mode

2019-02-20 Thread Julien Meunier
Only TX->RX loopback is supported currently on 82599EB. If a user wants to apply an another loopback configuration (!= IXGBE_LPBK_82599_TX_RX), ixgbe PMD ignores it and continues the configuration without raising any error. Let's robustify this part by checking if the requested loopback mode is co

[dpdk-dev] [PATCH v3 2/2] net/ixgbe: add support of loopback for X540/X550

2019-02-20 Thread Julien Meunier
Loopback mode is also supported on X540 and X550 NICs, according to their datasheet (section 15.2). The way to set it up is a little different of the 82599. Signed-off-by: Julien Meunier --- v3: - reorganize and merge common code - restore MACC_FLU on stop v2: - disable / enable autoneg when loop

Re: [dpdk-dev] [PATCH v3] mem: Fix anonymous mapping on Power9.

2019-02-20 Thread Burakov, Anatoly
On 20-Feb-19 4:27 PM, Thomas Monjalon wrote: 20/02/2019 17:04, Burakov, Anatoly: On 16-Nov-18 5:35 PM, David Wilder wrote: Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The MAP_HUGETLB had previously been added to workaround issues on IBM Power8 systems when mapping /dev/zero

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/bonding: avoid the next active slave going out of bound

2019-02-20 Thread Ferruh Yigit
On 2/18/2019 3:25 PM, Ferruh Yigit wrote: > On 2/11/2019 10:25 AM, Parthasarathy, JananeeX M wrote: >> Hi >> >>> -Original Message- >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams >>> Sent: Saturday, February 09, 2019 6:47 PM >>> To: Hyong Youb Kim ; Yigit, Ferruh >>>

Re: [dpdk-dev] [PATCH v3] mem: Fix anonymous mapping on Power9.

2019-02-20 Thread Thomas Monjalon
20/02/2019 17:04, Burakov, Anatoly: > On 16-Nov-18 5:35 PM, David Wilder wrote: > > Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The > > MAP_HUGETLB had previously been added to workaround issues on IBM Power8 > > systems when mapping /dev/zero (see: commit > > 284ae3e9ff9a92575c

Re: [dpdk-dev] [RFC v4] /net: memory interface (memif)

2019-02-20 Thread Stephen Hemminger
On Wed, 20 Feb 2019 12:52:54 +0100 Jakub Grajciar wrote: > +static int > +memif_msg_enq_init(struct rte_eth_dev *dev) > +{ > + struct pmd_internals *pmd = dev->data->dev_private; > + struct memif_msg_queue_elt *e = memif_msg_enq(pmd->cc); > + if (e == NULL) > + return -1

Re: [dpdk-dev] [PATCH v3] mem: Fix anonymous mapping on Power9.

2019-02-20 Thread Burakov, Anatoly
On 16-Nov-18 5:35 PM, David Wilder wrote: Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The MAP_HUGETLB had previously been added to workaround issues on IBM Power8 systems when mapping /dev/zero (see: commit 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the MA

[dpdk-dev] Polar bbdev

2019-02-20 Thread John Soares
Hi, Does anyone know if Polar BBDEV will be on the roadmap or it is not intended to be ever implemented? Please let me know which mailing list the right one to ask this question if this is not the right one. Thank you, John

Re: [dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done

2019-02-20 Thread Shally Verma
>-Original Message- >From: dev On Behalf Of Fiona Trahe >Sent: 17 January 2019 23:06 >To: dev@dpdk.org >Cc: pablo.de.lara.gua...@intel.com; fiona.tr...@intel.com; >akhil.go...@nxp.com; paul.e.l...@intel.com >Subject: [dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where

Re: [dpdk-dev] [PATCH v2] eal: fix check when retrieving current cpu affinity

2019-02-20 Thread Burakov, Anatoly
On 19-Feb-19 8:38 PM, David Marchand wrote: pthread_getaffinity_np returns a >0 value when failing. This is mainly for the sake of correctness. The only case where it could fail is when passing an incorrect cpuset size wrt to the kernel. Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection"

Re: [dpdk-dev] [PATCH v3 1/2] eal: fix potential incorrect pinning for ctrl threads

2019-02-20 Thread Burakov, Anatoly
On 19-Feb-19 8:41 PM, David Marchand wrote: pthread_setaffinity_np returns a >0 value on error. We could end up letting the ctrl threads on the current process cpu affinity. Fixes: d651ee4919cd ("eal: set affinity for control threads") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- Rev

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2019-02-20 Thread Ian Stokes
On 2/7/2019 12:00 PM, Ananyev, Konstantin wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin From: dev on behalf of Stephen Hemminger On Wed, 6 Feb 2019 14:05:34 +0100 Morten Brørup wrote: Good work, Stephen. It should also be documented how PMDs should inter

Re: [dpdk-dev] [PATCH v3 2/2] eal: restrict ctrl threads to startup cpu affinity

2019-02-20 Thread Burakov, Anatoly
On 19-Feb-19 8:41 PM, David Marchand wrote: Spawning the ctrl threads on anything that is not part of the eal coremask is not that polite to the rest of the system, especially when you took good care to pin your processes on cpu resources with tools like taskset (linux) / cpuset (freebsd). Rathe

[dpdk-dev] [RFC 6/6] net/e1000: set min and max MTU for igb devices

2019-02-20 Thread Ian Stokes
This commit sets the min and max supported MTU values for igb devices via the eth_igb_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. To aid in these calculations a new MACRO 'E1000_ETH_OVERHEA

[dpdk-dev] [RFC 4/6] net/ixgbe: set min and max MTU for ixgbe devices

2019-02-20 Thread Ian Stokes
This commit sets the min and max supported MTU values for ixgbe devices via the ixgbe_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. To aid in these calculations a new MACRO 'IXGBE_ETH_OVE

[dpdk-dev] [RFC 0/6] ethdev: add min/max MTU to device info

2019-02-20 Thread Ian Stokes
Building upon the discussion around [1], this series introduces MTU min and MTU max variables. It also provides updates to PMD implementations for ixgbe, i40e and IGB devices so that these variables are populated for use when retrieving device info. This series was tested with OVS DPDK and functio

[dpdk-dev] [RFC 5/6] net/ixgbe: set min and max MTU for ixgbe VF devices

2019-02-20 Thread Ian Stokes
This commit sets the min and max supported MTU values for ixgbe VF devices via the ixgbevf_dev_set_mtu() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. As transport overhead is the same for VF and PF ixg

[dpdk-dev] [RFC 2/6] net/i40e: set min and max MTU for i40e devices

2019-02-20 Thread Ian Stokes
This commit sets the min and max supported MTU values for i40e devices via the i40e_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Ian Stokes --- drivers/net/i40e/i40e_et

[dpdk-dev] [RFC 3/6] net/i40e: set min and max MTU for i40e VF devices

2019-02-20 Thread Ian Stokes
This commit sets the min and max supported MTU values for i40e VF devices via the i40evf_dev_info_get() function. Min MTU supported is set to ETHER_MIN_MTU and max mtu is calculated as the max packet length supported minus the transport overhead. Signed-off-by: Ian Stokes --- drivers/net/i40e/i4

[dpdk-dev] [RFC 1/6] ethdev: add min/max MTU to device info

2019-02-20 Thread Ian Stokes
From: Stephen Hemminger This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existing structure. The initial version sets max mtu to normal Ethernet, it is up to PMD to

Re: [dpdk-dev] [RFC v4] /net: memory interface (memif)

2019-02-20 Thread Stephen Hemminger
On Wed, 20 Feb 2019 12:52:54 +0100 Jakub Grajciar wrote: > +static int > +memif_msg_receive_add_ring(struct rte_eth_dev *dev, memif_msg_t *msg, int fd) > +{ > + struct pmd_internals *pmd = dev->data->dev_private; > + memif_msg_add_ring_t *ar = &msg->add_ring; > + > + if (fd < 0) { > +

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-20 Thread Anoob Joseph
Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts? Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Monday, February 4, 2019 4:56 PM > To: Akhil Goyal ; Declan Doherty > ; Pablo de Lara > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Narayana P

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix reset active slave

2019-02-20 Thread Hyong Youb Kim
On Wed, Feb 20, 2019 at 02:56:36PM +, Radu Nicolau wrote: > > > On 2/20/2019 12:33 PM, Ferruh Yigit wrote: > > On 2/18/2019 3:58 PM, Radu Nicolau wrote: > > > > > > On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: > > > > test_alb_reply_from_client test fails due to incorrect active slave > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix reset active slave

2019-02-20 Thread Radu Nicolau
On 2/20/2019 12:33 PM, Ferruh Yigit wrote: On 2/18/2019 3:58 PM, Radu Nicolau wrote: On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: test_alb_reply_from_client test fails due to incorrect active slave array's index. This was due to invalid active slave count. Count of internals->active_sla

Re: [dpdk-dev] [PATCH] maintainers: update Marvell PMDs

2019-02-20 Thread Tomasz Duszynski
On Wed, Feb 20, 2019 at 05:01:59PM +0200, lir...@marvell.com wrote: > From: Liron Himi > > Natalie and Dmitri are no longer involved in PMDs maintenance hence > update the list. > Also append new active maintainers to the list. > Acked-by: Tomasz Duszynski > Signed-off-by: Liron Himi > --- >

[dpdk-dev] [PATCH] maintainers: update Marvell PMDs

2019-02-20 Thread lironh
From: Liron Himi Natalie and Dmitri are no longer involved in PMDs maintenance hence update the list. Also append new active maintainers to the list. Signed-off-by: Liron Himi --- MAINTAINERS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS b/MAINT

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix reset active slave

2019-02-20 Thread Ferruh Yigit
On 2/18/2019 3:58 PM, Radu Nicolau wrote: > > > On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: >> test_alb_reply_from_client test fails due to incorrect active slave >> array's index. This was due to invalid active slave count. >> >> Count of internals->active_slave is not updated even when acti

[dpdk-dev] [RFC v4] /net: memory interface (memif)

2019-02-20 Thread Jakub Grajciar
Memory interface (memif), provides high performance packet transfer over shared memory. Signed-off-by: Jakub Grajciar --- MAINTAINERS |6 + config/common_base |5 + config/common_linuxapp |1 + doc/guides/n

Re: [dpdk-dev] [PATCH v2 0/5] consolidate testing apps to app dir

2019-02-20 Thread Ferruh Yigit
On 2/19/2019 2:53 PM, Bruce Richardson wrote: > The apps for testing are split between the "test" and "app" directories, > with a not-very-clear distinction between the two (at least to my mind). > > Given how the apps are being built, the easiest path to having > cmdline_test, test-acl and test-p

Re: [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder

2019-02-20 Thread Thomas Monjalon
20/02/2019 10:39, Bruce Richardson: > On Wed, Feb 20, 2019 at 09:35:02AM +, Ananyev, Konstantin wrote: > > From: Richardson, Bruce > > > > > > The bpf folder didn't actual contain a test application, but instead > > > basic examples of BPF code for use with testpmd. > > > > Might be the bette

Re: [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder

2019-02-20 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, February 20, 2019 9:40 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; tho...@monjalon.net > Subject: Re: [PATCH v2 4/5] test/bpf: move to examples folder > > On Wed, Feb 20, 2019 at 09:35:02AM +, Ananyev, Konstanti

Re: [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder

2019-02-20 Thread Bruce Richardson
On Wed, Feb 20, 2019 at 09:35:02AM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Tuesday, February 19, 2019 2:53 PM > > To: dev@dpdk.org; tho...@monjalon.net > > Cc: Richardson, Bruce ; Ananyev, Konstantin > > > > Subject: [PATCH v2 4

Re: [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder

2019-02-20 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, February 19, 2019 2:53 PM > To: dev@dpdk.org; tho...@monjalon.net > Cc: Richardson, Bruce ; Ananyev, Konstantin > > Subject: [PATCH v2 4/5] test/bpf: move to examples folder > > The bpf folder didn't actual contain a test

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-20 Thread David Marchand
Hello Konstantin, On Sat, Feb 16, 2019 at 1:50 PM Ananyev, Konstantin < konstantin.anan...@intel.com> wrote: > > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Friday, February 15, 2019 7:39 PM > > To: Ananyev, Konstantin > > Cc: David Marchand ;

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] mem: Fix anonymous mapping on Power9.

2019-02-20 Thread Chao Zhu
+Pradeep > -Original Message- > From: Thomas Monjalon > Sent: Monday, February 18, 2019 11:47 PM > To: David Wilder > Cc: dev@dpdk.org; chao...@linux.vnet.ibm.com > Subject: Re: [dpdk-stable] [PATCH v3] mem: Fix anonymous mapping on > Power9. > > Hi, > > Long time no talk about the IBM P