On Wed, Feb 20, 2019 at 02:56:36PM +0000, Radu Nicolau wrote:
>
>
> On 2/20/2019 12:33 PM, Ferruh Yigit wrote:
> > On 2/18/2019 3:58 PM, Radu Nicolau wrote:
> > >
> > > On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote:
> > > > test_alb_reply_from_client test fails due to incorrect active slave
> > > > array's index. This was due to invalid active slave count.
> > > >
> > > > Count of internals->active_slave is not updated even when active slave
> > > > is deactivated.
> > > > Hence active slave count always keeps incrementing beyond the actual
> > > > active slaves.
> > > >
> > > > Fix is to set the internals->active_slave to starting index 0 whenever
> > > > it exceeds the number of slaves in active slave list and also update
> > > > the active slave count during slave de-activation.
> > > >
> > > > Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness")
> > > > Cc: sta...@dpdk.org
> > > >
> > > > Signed-off-by: Hari Kumar Vemula <hari.kumarx.vem...@intel.com>
> > > > ---
> > > >
> > > Acked-by: Radu Nicolau <radu.nico...@intel.com
> > > <mailto:radu.nico...@intel.com>>
> > Hi Radu, Hari,
> >
> > There is another bonding patch, can you please check how related are they
> > and if
> > are these fixing same root cause:
> >
> > net/bonding: avoid the next active slave going out of bound
> > https://patches.dpdk.org/patch/49573/
> >
> Hi, it's a similar fix for the same root cause, but this one covers more (or
> all) situations that can cause active_slave to go out of bounds.
If it covers more cases, please go with the new patch and drop mine. I
just want to see the issue fixed :-)
Thanks.
-Hyong
