On 2/19/2019 2:53 PM, Bruce Richardson wrote: > The apps for testing are split between the "test" and "app" directories, > with a not-very-clear distinction between the two (at least to my mind). > > Given how the apps are being built, the easiest path to having > cmdline_test, test-acl and test-pipeline build using meson is to > consolidate all these apps back into the app folder and use the logic > there. The bpf folder doesn't contain an actual application, but > rather example bpf code which can be loaded into testpmd. That is > possibly best moved to the examples folder, but I'm open to feedback > on the best place for it. > > With these changes, the "test" folder then becomes the location for > unit tests only. However, we can simplify things a little by moving > that too to the app folder, eliminating the need for the separate > "test-build" make target, and aligning the output folder for the > binary from "make test-build" with the source file location in app.
I agree distinction between the "test" and "app" is not very clear, my motivation to split them was make building test code optional. But when split them we have a few cases that tests broken but not recognized for a while, since we don't have continuous integration that verifies tests perhaps it can be better to force developers to build them each time to detect issues. And as far as I understand this split is causing complications for adding meson support, if this will make easy to extend meson support overall patchset looks good to me. Thanks, ferruh > > --- > V2: * Following some discussion with Thomas, moved the autotests to the > app folder too. > * Updated maintainers file appropriately in each patch. > > Bruce Richardson (5): > test/cmdline_test: move to app directory > test/test-acl: move to app directory > test/test-pipeline: move to app directory > test/bpf: move to examples folder > test/test: move to app folder
