Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx offload search error

Tested-by: Peng, Yuan - Tested Branch: master - Tested Commit: c59b06294fb4531792a4c74ca63fa79a4cb53457 - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Conne

[dpdk-dev] A bug of ixgbevf kernel module

Hi all, I'm running OVS-DPDK on server: OVS-2.3.0 DPDK-2.2.0 kernel-centos7.3.1611 And sometimes, VF port could NOT send specific flow packet. So how to deal with this problem and where to report this issue? Thank you~

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix callback issue for hot-unplug

matan On 11/6/2018 2:36 PM, Matan Azrad wrote: Hi Jeff From: Jeff Guo Before detach device when device be hot-unplugged, the failure process in user space and kernel space both need to be finished, such as eal interrupt callback need to be inactive before the callback be unregistered when d

[dpdk-dev] [PATCH v2 2/2] eal: fix build issue

Some toolchain has fls() definition in string.h as argument type int, which is conflicting uint32_t argument type. /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: error: conflicting types for ‘fls’ static inline int fls(uint32_t x) ^~~ /opt/marvell-tools-201/aarc

[dpdk-dev] [PATCH v2 1/2] eal: introduce rte version of fls

The function returns the last (most-significant) bit set. Added unit testcase to verify rte_fls_u32(). Signed-off-by: Jerin Jacob --- v2: - Introduce rte_fls_u32() --- lib/librte_eal/common/include/rte_common.h | 19 + test/test/test_common.c| 32 +

[dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)" will never happen. Fixes: 22561383ea17 ("app: replace dump_cfg by

[dpdk-dev] [PATCH] app/testpmd: fix Rx offload search error

There is an error in function in function search_rx_offload(), it will break when get unexpected return value from function rte_eth_dev_rx_offload_name(), but rte_eth_dev_rx_offload_name() will return some unexpected value indead. Fixes: c73a9071877a ("app/testpmd: add commands to test new offload

Re: [dpdk-dev] [PATCH 1/4] net/failsafe: avoid rte_memcpy if rte_realloc fails

On 11/6/18 10:30 PM, Stephen Hemminger wrote: There is a potential issue seen by static tools if number of multicast addresses is zero, and rte_realloc of zero size fails (ie returns NULL). This won't happen in real world for a couple of reasons: Azure doesn't support multicast (ie this is dead c

Re: [dpdk-dev] [PATCH 2/3] vfio: fix to add handler lock for hot-unplug

On 11/6/2018 2:23 PM, Matan Azrad wrote: Hi Jeff Can you detail more in the commit log that we can understand the synchronization problematic scenario. And how does this commit fix it? Please check my reply in the 1/3 mail. And explain more here is that, when device be hot-unplugged in vf

Re: [dpdk-dev] [PATCH 1/3] eal: fix lock issue for hot-unplug

hi matan On 11/6/2018 2:22 PM, Matan Azrad wrote: Hi Jeff Can you detail more in the commit log that we can understand the deadlock scenario. And how does this commit fix it? Before i add more detail in the commit log of next version, i would explain to you here at first here. When the d

Re: [dpdk-dev] [PATCH] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

Hi Burakov, Please find my test case below. Thanks! Br, Tone -Original Message- From: Burakov, Anatoly Sent: Tuesday, November 6, 2018 7:03 PM To: Tone Zhang (Arm Technology China) ; dev@dpdk.org Cc: nd Subject: Re: [dpdk-dev] [PATCH] pci_vfio: Support 64KB kernel page_size with vfio

[dpdk-dev] [PATCH v2] doc/linux_gsg: fix numa lib name error

The library for handling NUMA is not libnuma-devel, but numactl-devel in Red Hat/Fedora and libnuma-dev in Debian/Ubuntu. Signed-off-by: Yong Wang --- v2: * Add lib name in Ubuntu. --- doc/guides/linux_gsg/sys_reqs.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc

Re: [dpdk-dev] [PATCH] examples/flow_filtering: fix capability setting

Acked-by: Wei Zhao > -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Tuesday, November 6, 2018 2:32 PM > To: Ori Kam ; Zhao1, Wei > Cc: dev@dpdk.org > Subject: [PATCH] examples/flow_filtering: fix capability setting > > The tx offloads should be compared to tx ca

Re: [dpdk-dev] [PATCH] net/avf/base: fix shifting 32 bits signed variable 31 times

> -Original Message- > From: Yigit, Ferruh > Sent: Monday, November 5, 2018 10:31 PM > To: Zhao1, Wei ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/avf/base: fix shifting 32 bits signed > variable 31 times > > On 10/31/2018 3:34

[dpdk-dev] rte_eth_tx_burst send packet fail when upgrade dpdk from 17.02 to 18.02

Hi, My user-space TCP/IP stack works fine on DPDK 17.02, now I upgrade it to 18.02. And then I use wrk http benchmark to test my stack, it work well fine, but after a while, it couldn't send packet. I debug with gdb and find the rte_eth_tx_burst always return 0, which means there is no a

Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write concurrency

>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Monday, November 5, 2018 10:08 PM >To: Jerin Jacob >Cc: Richardson, Bruce ; De Lara Guarch, Pablo >; dev@dpdk.org; Wang, >Yipeng1 ; Dharmik Thakkar ; >Gavin Hu (Arm Technology China) >; nd ; tho.

Re: [dpdk-dev] [PATCH v2] bus/pci: update device devargs on each rescan

On Tue, Nov 06, 2018 at 10:21:38PM +, Zhang, Qi Z wrote: > > > > -Original Message- > > From: Dariusz Stojaczyk [mailto:darek.stojac...@gmail.com] > > Sent: Monday, November 5, 2018 10:40 PM > > To: dev@dpdk.org; gaetan.ri...@6wind.com > > Cc: Stojaczyk, Dariusz ; Zhang, Qi Z > > > >

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

On Tue, Nov 06, 2018 at 09:36:22PM +0100, Thomas Monjalon wrote: > 06/11/2018 16:46, Zhang, Qi Z: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > Hi, > > > > > > 06/11/2018 01:31, Qi Zhang: > > > > When probe the same device at second time > > > > > > Sorry I stop on this firs

Re: [dpdk-dev] [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

> -Original Message- > From: Chas Williams [mailto:3ch...@gmail.com] > Sent: Monday, November 5, 2018 11:19 AM > To: Zhang, Qi Z ; Luca Boccassi ; > dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; sta...@dpdk.org > Subject: Re: [PATCH v3 1/2] net/ixgbe: fix x550 code to handle un

Re: [dpdk-dev] [RFC 4/5] eal/memory: avoid double munmap in error path

06/11/2018 22:49, Stephen Hemminger: > Don't call munmap of hugepage memory twice in the error path. > > Coverity issue: 325730 > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > Signed-off-by: Stephen Hemminger Thank you Anatoly submitted the same fix: https://patches.dpd

Re: [dpdk-dev] [PATCH] mem: fix use after free in legacy mem init

06/11/2018 15:13, Anatoly Burakov: > Adding an additional failure path in DMA mask check has exposed an > issue where `hugepage` pointer may point to memory that has already > been unmapped, but pointer value is still not NULL, so failure > handler will attempt to unmap it second time if DMA mask c

[dpdk-dev] [PATCH] Added jumboframe RX offload flag in example using 9KB packets

I apologize if any formatting is wrong here, since this is my first post. I noticed with i40e jumboframes cannot be received without the offload flag set, even though the max_rx_pkt_len is set to 9000. This is the case in the ip_pipeline example, so I don't think packets that large would work un

Re: [dpdk-dev] [PATCH v2] bus/pci: update device devargs on each rescan

> -Original Message- > From: Dariusz Stojaczyk [mailto:darek.stojac...@gmail.com] > Sent: Monday, November 5, 2018 10:40 PM > To: dev@dpdk.org; gaetan.ri...@6wind.com > Cc: Stojaczyk, Dariusz ; Zhang, Qi Z > > Subject: [PATCH v2] bus/pci: update device devargs on each rescan > > From:

[dpdk-dev] [RFC 1/5] bus/pci: fix allocation of pci device path

The pci_resource_by_index called strlen() on uninitialized memory which would lead to the wrong size of memory allocated for the path portion of the resource map. This would either cause excessively large allocation, or worse memory corruption. Coverity Issue: 300868 Fixes: ea9d56226e72 ("pci: int

[dpdk-dev] [RFC 0/5] more Coverity related bug fixes

There are some real bugs in here, not just noise. Labeling this version as RFC since compile tested only. Stephen Hemminger (5): bus/pci: fix allocation of pci device path bus/pci: fix TOCTOU issue bpf: fix validation of eal_divmod eal/memory: avoid double munmap in error path pipeline:

[dpdk-dev] [RFC 2/5] bus/pci: fix TOCTOU issue

Using access followed by open causes a static analysis warning about Time of check versus Time of use. Also, access() and open() have different UID permission checks. This is not a serious problem; but easy to fix by using errno instead. Coverity issue: 300870 Fixes: 4a928ef9f611 ("bus/pci: enabl

[dpdk-dev] [RFC 5/5] pipeline: remove dead code

Coverity detected dead code since pointer into a global array can never be NULL. Coverity issue: 323523 Fixes: 96303217a606 ("pipeline: add symmetric crypto table action") Signed-off-by: Stephen Hemminger --- lib/librte_pipeline/rte_table_action.c | 2 -- 1 file changed, 2 deletions(-) diff --g

[dpdk-dev] [RFC 3/5] bpf: fix validation of eal_divmod

Coverity spotted self assignment in BPF eval_divmod. This looks like a bug where the incoming source register should have been used instead. Coverity issue: 302850 Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program") Signed-off-by: Stephen Hemminger --- lib/librte_bpf/bpf_vali

[dpdk-dev] [RFC 4/5] eal/memory: avoid double munmap in error path

Don't call munmap of hugepage memory twice in the error path. Coverity issue: 325730 Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal_memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linu

Re: [dpdk-dev] [PATCH v2] build: disable compiler AVX512F support

> On Nov 5, 2018, at 6:06 AM, Wiles, Keith wrote: > > > >> On Nov 2, 2018, at 9:04 PM, Yongseok Koh wrote: >> >> This is a workaround to prevent a crash, which might be caused by >> optimization of newer gcc (7.3.0) on Intel Skylake. > > Should the code below not also test for the gcc vers

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

06/11/2018 16:46, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Hi, > > > > 06/11/2018 01:31, Qi Zhang: > > > When probe the same device at second time > > > > Sorry I stop on this first sentence. > > How and why do you probe a vdev twice? > > if we do rte_dev_hotplu

Re: [dpdk-dev] [PATCH] eal: fix build issue

06/11/2018 14:31, Jerin Jacob: > From: Thomas Monjalon > > 06/11/2018 12:45, Jerin Jacob: > > > Some toolchain has fls() definition in string.h as argument type int, > > > which is conflicting uint32_t argument type. > > > > > > /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: > > >

Re: [dpdk-dev] [PATCH] test: fix build

On Tue, Nov 06, 2018 at 02:35:01PM +, Ferruh Yigit wrote: > With "make -C test/" command getting following warnings: > awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/' > for reading (No such file or directory) > awk: cmd. line:1: fatal: cannot open file > `/

[dpdk-dev] [PATCH 4/4] net/tap: fix warning about comparison of fd

Static analysis tools don't like the fact that fd could be zero in the error path. This won't happen in real world because stdin would have to be closed, then other error occurring. Coverity issue: 14079 Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH 1/4] net/failsafe: avoid rte_memcpy if rte_realloc fails

There is a potential issue seen by static tools if number of multicast addresses is zero, and rte_realloc of zero size fails (ie returns NULL). This won't happen in real world for a couple of reasons: Azure doesn't support multicast (ie this is dead code); and rte_realloc of zero size will never fa

[dpdk-dev] [PATCH 3/4] net/tap: fix file descriptor leak on error

If netlink socket setup fails the file descriptor was leaked. Coverity issue: 257040 Fixes: 7c25284e30c2 ("net/tap: add netlink back-end for flow API") Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_netlink.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/tap/tap_ne

[dpdk-dev] [PATCH 2/4] bus/vmbus: fix directory handle leak on error

If sysfs directory was incorrectly formatted then the vmbus setup code would leak a directory handle in the error path. Coverity issue: 302848 Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 12 +++-

[dpdk-dev] [PATCH 0/4] Coverity issue fixes

These are all error path issues and should not matter in a real application; most of the error are impossible to cause and applications just fail if setup fails. Stephen Hemminger (4): net/failsafe: avoid rte_memcpy if rte_realloc fails bus/vmbus: fix directory handle leak on error net/tap:

Re: [dpdk-dev] [PATCH] net/mlx5: fix L4 protocol validation

Tuesday, November 6, 2018 10:14 AM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix L4 protocol validation > > - Currently, no device supports partial mask for protocol in IP header. > - As there could be multiple IP items, next_protocol variable in flow > validation has to be reset for inner lay

Re: [dpdk-dev] [PATCH] net/mlx5: fix misuse of device flow reference

Tuesday, November 6, 2018 9:43 AM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix misuse of device flow reference > > dev_flow->verbs is mistakenly used instead of dev_flow->dv. A sanity check > is added for debugging purpose. > > Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items")

[dpdk-dev] Hyperscan Boot Camp 2018 on Nov 9th Friday, Santa Clara.

We still have a few seats available for the first Hyperscan boot camp training day at Intel office, Santa Clara on Nov 9th 2018. If you are interested to join us, please come to this website and complete the registration. Below please find the initial ag

[dpdk-dev] [PATCH v2] vhost/crypto: fix incorrect copy

This patch fixes the incorrect packet content copy in the chaining mode. Originally the content before cipher offset is overwritten by all zeros. This patch fixes the problem by making sure the correct write back source and destination settings during set up. Signed-off-by: Fan Zhang --- v2: - fi

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, November 6, 2018 2:01 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; gaetan.ri...@6wind.com; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice > > Hi, > > 06/11/

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

>-Original Message- >From: Jozwiak, TomaszX >Sent: 06 November 2018 14:36 >To: Verma, Shally ; dev@dpdk.org; Trahe, Fiona >; akhil.go...@nxp.com >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance >measurement > >External Email > >> -Original Message- >> Fr

Re: [dpdk-dev] [PATCH v2 2/3] app/compress-perf: add performance measurement

>-Original Message- >From: Jozwiak, TomaszX >Sent: 06 November 2018 14:19 >To: Verma, Shally ; dev@dpdk.org; Trahe, Fiona >; akhil.go...@nxp.com >Subject: RE: [PATCH v2 2/3] app/compress-perf: add performance measurement > >External Email > >> -Original Message- >> From: Verma,

[dpdk-dev] [PATCH] test: fix build

With "make -C test/" command getting following warnings: awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/' for reading (No such file or directory) awk: cmd. line:1: fatal: cannot open file `/test-pipeline/test-pipeline/' for reading (No such file or directo

[dpdk-dev] [PATCH] mem: fix use after free in legacy mem init

Adding an additional failure path in DMA mask check has exposed an issue where `hugepage` pointer may point to memory that has already been unmapped, but pointer value is still not NULL, so failure handler will attempt to unmap it second time if DMA mask check fails. Fix it by setting `hugepage` po

Re: [dpdk-dev] [PATCH] eal: fix build issue

-Original Message- > Date: Tue, 06 Nov 2018 13:29:19 +0100 > From: Thomas Monjalon > To: Jerin Jacob > Cc: "dev@dpdk.org" , "Jacob, Jerin" > , "sta...@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH] eal: fix build issue > > > 06/11/2018 12:45, Jerin Jacob: > > Some toolchain has fls() def

Re: [dpdk-dev] [PATCH v2 5/7] mem: modify error message for DMA mask check

On Tue, Nov 6, 2018 at 10:48 AM Burakov, Anatoly wrote: > On 06-Nov-18 10:37 AM, Alejandro Lucero wrote: > > > > > > On Tue, Nov 6, 2018 at 10:31 AM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 06-Nov-18 9:32 AM, Alejandro Lucero wrote: > > > > > > > >

[dpdk-dev] [PATCH v4 9/9] doc/procinfo: add information for debug options

Document update for debug options and information for PMD instances like port, traffic manager, crypto, mempool and ring instances. Signed-off-by: Vipin Varghese --- V3: - update document from dbg to show - Vipin Varghese V2: - update word style for content - Vipin Varghese --- doc/guides/to

[dpdk-dev] [PATCH v4 6/9] app/procinfo: add support for show crypto

Function show_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- v4: - add space to compare - Vipin Varghese V3: - replace MACRO to function - Reshma Pathan & Stephen Hemminger - add memset for struct elements - Reshma Pathan - change d

[dpdk-dev] [PATCH v4 8/9] app/procinfo: add support for show mempool

Function show_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- v4: - add spacing for flag compare - Vipin Varghese V3: - add avail and in use - Vipin Varghese - add flag split -

[dpdk-dev] [PATCH v4 7/9] app/procinfo: add support for debug ring

Function show_ring is used for displaying the RING of the primary process. Signed-off-by: Vipin Varghese --- V3: - replace space to tab in printf - Reshma Pathan - change ring display information - Vipin Varghese --- app/proc-info/main.c | 34 +- 1 file changed

[dpdk-dev] [PATCH v4 2/9] app/procinfo: add compare for new options

Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- V3: - variables from debug to show - Vipin Varghese V2: - compare string from dbg to show - Stephen Hemminger --- app/proc-info/main.c | 30 ++ 1 file ch

[dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with stats. Signed-off-by: Vipin Varghese --- V3: - memset for struct elements - Vipin Varghese - code cleanup for TM - Vipin Varghese - fetch for leaf nodes if node exis

[dpdk-dev] [PATCH v4 3/9] app/procinfo: add prototype for debug instances

Add prototype function calls for the show functions. Signed-off-by: Vipin Varghese --- V3: - update function names from debug to show - Vipin Varghese V2: - removed if else ladder - Vipin Varghese --- app/proc-info/main.c | 42 ++ 1 file changed, 42 in

[dpdk-dev] [PATCH v4 4/9] app/procinfo: add support for show port

Function show_port is used for displaying the port PMD information under under primary process. The information shows basic, per queue and security. Signed-off-by: Vipin Varghese --- V3: - fix meson build - Reshma Pattan - change 100 to MAX_STRING_LEN - Reshma Pattan - memset to struct elemen

[dpdk-dev] [PATCH v4 1/9] app/procinfo: add usage for new debug

Update the file with MACRO for stats border, usage text information and string comparision. Signed-off-by: Vipin Varghese --- V3: - change the usage details - Vipin Varghese V2: - change word dbg to show - Stephen Hemminger --- app/proc-info/main.c | 16 +++- 1 file changed, 15 i

Re: [dpdk-dev] [PATCH] eal: fix build issue

06/11/2018 12:45, Jerin Jacob: > Some toolchain has fls() definition in string.h as argument type int, > which is conflicting uint32_t argument type. > > /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: > error: conflicting types for ‘fls’ > static inline int fls(uint32_t x) >

[dpdk-dev] Coverity defects in DPDK

Hi, We currently have 126 open defects in Coverity, our community static code analysis tool. The defects and current assignees are shown in the table below. If you are on the To: line of this email can you please submit patches to fix these defects, if you haven't done so already. You can review

Re: [dpdk-dev] [PATCH] ppc64: fix compilation of when AltiVec is enabled

Thomas Monjalon wrote on 11/05/2018 06:15:53 AM: > From: Thomas Monjalon > To: Christian Ehrhardt > Cc: dev@dpdk.org, t...@jp.ibm.com, adrien.mazarg...@6wind.com, > Gowrishankar Muthukrishnan , Chao > Zhu , Luca Boccassi , > Pradeep Satyanarayana , dwil...@us.ibm.com > Date: 11/05/2018 06:1

[dpdk-dev] [PATCH] eal: fix build issue

Some toolchain has fls() definition in string.h as argument type int, which is conflicting uint32_t argument type. /export/dpdk.org/lib/librte_eal/common/rte_reciprocal.c:47:19: error: conflicting types for ‘fls’ static inline int fls(uint32_t x) ^~~ /opt/marvell-tools-201/aarc

Re: [dpdk-dev] [PATCH v2 2/2] ip_frag: use key length for key comparision

> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, November 6, 2018 10:54 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: sta...@dpdk.org; Hall, Ryan E ; Gutkin, Alexander > V > Subject: Re: [dpdk-dev] [PATCH v2 2/2] ip_frag: use key length for key > comparision > > On 0

Re: [dpdk-dev] ubuntu 14.04 and intel controller 82574L not working

On 02-Nov-18 9:06 PM, Avinash Chaurasia wrote: Hi, I am using ubuntu 14.04 with intel controller 82574L and I am neither able to send any packets or receive. My dpdk version is 17.11. However, when I switched to ubuntu 16.04, it worked with vfio-pci driver. Is something wrong with 82574L driver i

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix compilation issue

06/11/2018 11:28, Marko Kovacevic: > Fixed compilation issue with variable which may > be used uninitialized > > Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing") > Cc: marko.kovace...@intel.com > > Signed-off-by: Marko Kovacevic Applied, thanks

Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail

On 2018-11-05 22:51, Honnappa Nagarahalli wrote: I've also run an out-of-tree DSW throughput benchmark, and I've found that going from Non-C11 to C11 gives a 4% slowdown. After this patch, the slowdown is only 2,8%. This is interesting. The general understanding seems to be that C11 atomics sho

Re: [dpdk-dev] [PATCH] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

On 03-Nov-18 5:46 AM, Tone Zhang (Arm Technology China) wrote: Hi Burakov, Thanks! Please check my feedback below. Br, Tone -Original Message- From: dev On Behalf Of Burakov, Anatoly Sent: Thursday, November 1, 2018 6:01 PM To: Tone Zhang (Arm Technology China) ; dev@dpdk.org Cc: nd

Re: [dpdk-dev] RFC 4115 variant for rte_meter_trtcm_color_blind/aware_check()

On 6 Nov 2018, at 11:53, Dumitrescu, Cristian wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Eelco Chaudron Sent: Tuesday, November 6, 2018 10:32 AM To: dev@dpdk.org Subject: [dpdk-dev] RFC 4115 variant for rte_meter_trtcm_color_blind/aware_check() Hi All

Re: [dpdk-dev] [PATCH 1/2] vhost: fix IOVA access for packed ring

On 11/6/18 7:40 AM, Tiwei Bie wrote: We should apply for RO access when receiving packets from the VM and apply for RW access when sending packets to the VM. Fixes: a922401f35cc ("vhost: add Rx support for packed ring") Fixes: ae999ce49dcb ("vhost: add Tx support for packed ring") Cc: sta...@

Re: [dpdk-dev] [PATCH v2 2/2] ip_frag: use key length for key comparision

On 05-Nov-18 12:18 PM, Konstantin Ananyev wrote: Right now reassembly code relies on src_dst[] being all zeroes to determine is it free/occupied entry in the fragments table. This is suboptimal and error prone - user can crash DPDK ip_reassembly app by something like the following scapy script:

Re: [dpdk-dev] RFC 4115 variant for rte_meter_trtcm_color_blind/aware_check()

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Eelco Chaudron > Sent: Tuesday, November 6, 2018 10:32 AM > To: dev@dpdk.org > Subject: [dpdk-dev] RFC 4115 variant for > rte_meter_trtcm_color_blind/aware_check() > > Hi All, > > Was wondering if anyone is pla

Re: [dpdk-dev] [PATCH v2 5/7] mem: modify error message for DMA mask check

On 06-Nov-18 10:37 AM, Alejandro Lucero wrote: On Tue, Nov 6, 2018 at 10:31 AM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 06-Nov-18 9:32 AM, Alejandro Lucero wrote: > > > On Mon, Nov 5, 2018 at 4:35 PM Burakov, Anatoly > mailto:anatoly.bura...@intel

Re: [dpdk-dev] [PATCH] doc/linux_gsg: fix numa lib name error

On 06-Nov-18 10:41 AM, Burakov, Anatoly wrote: On 06-Nov-18 6:15 AM, Yong Wang wrote: The library for handling NUMA is numactl-devel, not libnuma-devel. Signed-off-by: Yong Wang --- Acked-by: Anatoly Burakov Actually, scratch that. numactl-devel is on Fedora, but AFAIK on Ubuntu this li

Re: [dpdk-dev] [PATCH] doc/linux_gsg: fix numa lib name error

On 06-Nov-18 6:15 AM, Yong Wang wrote: The library for handling NUMA is numactl-devel, not libnuma-devel. Signed-off-by: Yong Wang --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2] app/proc-info:fix port mask parse bug

Hi, > -Original Message- > From: Li Han [mailto:han@zte.com.cn] > Sent: Tuesday, November 6, 2018 3:04 AM > To: Pattan, Reshma > Cc: dev@dpdk.org; Li Han > Subject: [PATCH v2] [dpdk-dev] app/proc-info:fix port mask parse bug > > parse_portmask return type is int,but global variable

Re: [dpdk-dev] [PATCH v2 5/7] mem: modify error message for DMA mask check

On Tue, Nov 6, 2018 at 10:31 AM Burakov, Anatoly wrote: > On 06-Nov-18 9:32 AM, Alejandro Lucero wrote: > > > > > > On Mon, Nov 5, 2018 at 4:35 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 05-Nov-18 3:33 PM, Alejandro Lucero wrote: > > > > > > > >

[dpdk-dev] RFC 4115 variant for rte_meter_trtcm_color_blind/aware_check()

Hi All, Was wondering if anyone is planning to add an RFC 4115 equivalent of the rte_meter_trtcm_color_blind/aware_check() check APIs? If not I can go ahead and sent a patch to add it, i.e. something like rte_meter_trtcm_rfc4115_color_blind/aware_check(). Cheers, Eelco

Re: [dpdk-dev] [PATCH v2 5/7] mem: modify error message for DMA mask check

On 06-Nov-18 9:32 AM, Alejandro Lucero wrote: On Mon, Nov 5, 2018 at 4:35 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 05-Nov-18 3:33 PM, Alejandro Lucero wrote: > > > On Mon, Nov 5, 2018 at 3:12 PM Burakov, Anatoly > mailto:anatoly.bura...@intel.c

[dpdk-dev] [PATCH] examples/fips_validation: fix compilation issue

Fixed compilation issue with variable which may be used uninitialized Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing") Cc: marko.kovace...@intel.com Signed-off-by: Marko Kovacevic --- examples/fips_validation/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[dpdk-dev] [PATCH v3] app/testpmd: fix memory alloc for dscp table

The patch fixes the memory allocation for the meter dscp table. Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") cc: sta...@dpdk.org Signed-off-by: Jasvinder Singh Reviewed-by: Ferruh Yigit --- v3 - change title - cc to sta...@dpdk.org v2 - fix checkpatch errors app/

[dpdk-dev] [PATCH v2] app/testpmd: fix memory leak for tm object

Fixes memory leak for shared shaper object of the traffic manager. Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") Cc: sta...@dpdk.org Signed-off-by: Jasvinder Singh Reviewed-by: Ferruh Yigit --- v2 - cc to sta...@dpdk.org app/test-pmd/softnicfwd.c | 2 ++ 1 file c

Re: [dpdk-dev] [PATCH v2] test/bpf: use hton instead of _builtin_bswap

Hi Malvika, > -Original Message- > From: Malvika Gupta [mailto:malvika.gu...@arm.com] > Sent: Friday, November 2, 2018 7:08 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; gavin...@arm.com; honnappa.nagaraha...@arm.com; > n...@arm.com; Malvika Gupta ; > Malvika Gupta > Subject: [PATC

Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write concurrency

-Original Message- > Date: Tue, 06 Nov 2018 10:13:53 +0100 > From: Thomas Monjalon > To: Jerin Jacob > Cc: Honnappa Nagarahalli , > "bruce.richard...@intel.com" , > "pablo.de.lara.gua...@intel.com" , > "dev@dpdk.org" , "yipeng1.w...@intel.com" > , Dharmik Thakkar , > "Gavin Hu (Arm T

Re: [dpdk-dev] [PATCH v2 5/7] mem: modify error message for DMA mask check

On Mon, Nov 5, 2018 at 4:35 PM Burakov, Anatoly wrote: > On 05-Nov-18 3:33 PM, Alejandro Lucero wrote: > > > > > > On Mon, Nov 5, 2018 at 3:12 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 05-Nov-18 10:13 AM, Alejandro Lucero wrote: > > > On Mon, Nov 5, 201

Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write concurrency

06/11/2018 10:10, Jerin Jacob: > From: Honnappa Nagarahalli > > Jerin, thank you for running this test and all the analysis. I have not run > > this test. I was focused on simultaneous reads and writes. You can look at > > file test_hash_readwrite_lf.c to look for the kind of the use cases. > >

Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write concurrency

-Original Message- > Date: Tue, 6 Nov 2018 06:07:43 + > From: Honnappa Nagarahalli > To: Jerin Jacob > CC: "bruce.richard...@intel.com" , > "pablo.de.lara.gua...@intel.com" , > "dev@dpdk.org" , "yipeng1.w...@intel.com" > , Dharmik Thakkar , > "Gavin Hu (Arm Technology China)" , nd

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Tuesday, November 6, 2018 9:16 AM > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance > measurement > > >

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

Hi, 06/11/2018 01:31, Qi Zhang: > When probe the same device at second time Sorry I stop on this first sentence. How and why do you probe a vdev twice?

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

Hi, On Tue, Nov 06, 2018 at 08:31:50AM +0800, Qi Zhang wrote: > When probe the same device at second time, devargs will be > replaced in devargs_list, old version is destoried but they > are still referenced by vdev->device. So we break the link > between vdev->device to devargs_list by clone, and

Re: [dpdk-dev] [PATCH v2 3/3] doc/guides/tools: add doc files

> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, November 5, 2018 9:58 AM > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; akhil.go...@nxp.com > Subject: RE: [PATCH v2 3/3] doc/guides/tools: add doc files > > > > >-Original Message

Re: [dpdk-dev] [PATCH v2 2/3] app/compress-perf: add performance measurement

> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, November 5, 2018 9:57 AM > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; akhil.go...@nxp.com > Subject: RE: [PATCH v2 2/3] app/compress-perf: add performance > measurement > > > > >

Re: [dpdk-dev] [PATCH v2 1/3] app/compress-perf: add parser

>-Original Message- >From: Jozwiak, TomaszX >Sent: 06 November 2018 14:01 >To: Verma, Shally ; dev@dpdk.org; Trahe, Fiona >; akhil.go...@nxp.com >Subject: RE: [PATCH v2 1/3] app/compress-perf: add parser > >External Email > ... >> >+ if (strcmp(test_data->input_file, "") == 0) {

Re: [dpdk-dev] [PATCH v2 1/3] app/compress-perf: add parser

> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, November 5, 2018 9:40 AM > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; akhil.go...@nxp.com > Subject: RE: [PATCH v2 1/3] app/compress-perf: add parser > > > > >-Original Message--

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

>-Original Message- >From: Jozwiak, TomaszX >Sent: 06 November 2018 13:34 >To: Verma, Shally ; dev@dpdk.org; Trahe, Fiona >; akhil.go...@nxp.com >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance >measurement > >External Email > >Hi Shally, > >Please see my commen

[dpdk-dev] [PATCH] net/mlx5: fix L4 protocol validation

- Currently, no device supports partial mask for protocol in IP header. - As there could be multiple IP items, next_protocol variable in flow validation has to be reset for inner layer. Otherwise, inner TCP/UDP will see protocol number of outer IP header. - Remove redundant protocol checking fo

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

Hi Shally, Please see my comment inline. > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, November 5, 2018 9:34 AM > To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; akhil.go...@nxp.com; De Lara Guarch, Pablo > > Cc: d...@dpdk.org; l...@dpd