[dpdk-dev] Question about rte_manage_timer() and eal_intr_handle_interrupts

On Fri, Nov 2, 2018 at 9:30 AM Somnath Kotur wrote: > Hello, >I'm trying to launch a thread - lcore_mainloop( from > examples/timer/main.c ) that runs rte_manage_timer() every 2s from testpmd > to ensure the timers i've registered in my driver are checked for expiry ( > i even tried putt

[dpdk-dev] [PATCH v2] devtools: add explicit warning messages for forbidden tokens

Replace the content of warning in the forbidden tokens script from using the searched regex into using explicit messages Signed-off-by: Arnon Warshavsky --- v2 - spelling typo devtools/check-forbidden-tokens.awk | 7 +-- devtools/checkpatches.sh| 3 +++ 2 files changed, 4 inser

[dpdk-dev] [PATCH] devtools: add explicit warning messages for forbidden tokens

Replace the content of warning in the forbidden tokens script from using the searched regex into using explicit messages Signed-off-by: Arnon Warshavsky --- devtools/check-forbidden-tokens.awk | 7 +-- devtools/checkpatches.sh| 3 +++ 2 files changed, 4 insertions(+), 6 deletions

Re: [dpdk-dev] [PATCH 0/7] fix DMA mask check

On Wed, Oct 31, 2018 at 05:47:40PM +, Alejandro Lucero wrote: > On Wed, Oct 31, 2018 at 5:29 PM Alejandro Lucero < > alejandro.luc...@netronome.com> wrote: > > > A patchset sent introducing DMA mask checks has several critical > > issues precluding apps to execute. The patchset was reviewed an

[dpdk-dev] [PATCH] net/enic: use rte macro for attribute weak

Fixes: 8a6ff33d6d36 ("net/enic: add AVX2 based vectorized Rx handler") Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index e81c3f3b7..c3869de36 100644

[dpdk-dev] [Bug 104] "dpdk-procinfo" received signal SIGSEGV, Segmentation fault.

https://bugs.dpdk.org/show_bug.cgi?id=104 Bug ID: 104 Summary: "dpdk-procinfo" received signal SIGSEGV, Segmentation fault. Product: DPDK Version: unspecified Hardware: All OS: All Status: CONFIR

Re: [dpdk-dev] Issue with DPDK bonding with Mellanox

Hi Matan, Thanks for your reply. I have not removed Mellanox interfaces those were still up in linux domain . Thanks, Chetan Bhasin On Thu, Nov 1, 2018 at 3:20 PM Matan Azrad wrote: > Hi Chetan > > From: chetan bhasin > > Hi, > > > > We are using Dpdk 17.11.4 and facing issue in bringing set

Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

  On Thu, 1 Nov 2018 17:53:51 +0800 Gavin Hu wrote: > +* **Updated the ring library with C11 memory model.** > + > + Updated the ring library with C11 memory model including the following > changes: > + > + * Synchronize the load and store of the tail > + * Move

[dpdk-dev] Question about rte_manage_timer() and eal_intr_handle_interrupts

Hello, I'm trying to launch a thread - lcore_mainloop( from examples/timer/main.c ) that runs rte_manage_timer() every 2s from testpmd to ensure the timers i've registered in my driver are checked for expiry ( i even tried putting this thread in my driver as well, no difference in results

Re: [dpdk-dev] Question about jumbo frame support on ixgbe

Hi Thanks for your answering to my question. Please see inline. > Hi, Hideyuki Yamashita > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hideyuki Yamashita > > Sent: Wednesday, October 31, 2018 4:22 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] Que

Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

Hi Stephen, There is no api changes, but this is a significant change as ring is fundamental and widely used, it decreases latency by 25% in our tests, it may do even better for cases with more contending producers/consumers or deeper depth of rings. Best regards Gavin Best regards Gavin ___

Re: [dpdk-dev] [PATCH v3 12/13] net/mlx5: add e-switch VXLAN encapsulation rules

On Thu, Nov 01, 2018 at 05:19:34AM -0700, Slava Ovsiienko wrote: > VXLAN encap rules are applied to the VF ingress traffic and have the > VTEP as actual redirection destinations instead of outer PF. > The encapsulation rule should provide: > - redirection action VF->PF > - VF port ID > - some inner

Re: [dpdk-dev] [PATCH v3 13/13] net/mlx5: add e-switch VXLAN rule cleanup routines

On Thu, Nov 01, 2018 at 05:19:35AM -0700, Slava Ovsiienko wrote: > The last part of patchset contains the rule cleanup routines. > These ones is the part of outer interface initialization at > the moment of VXLAN VTEP attaching. These routines query > the list of attached VXLAN devices, the list of

Re: [dpdk-dev] [PATCH v3 11/13] net/mlx5: add e-switch VXLAN tunnel devices management

On Thu, Nov 01, 2018 at 05:19:33AM -0700, Slava Ovsiienko wrote: > VXLAN interfaces are dynamically created for each local UDP port > of outer networks and then used as targets for TC "flower" filters > in order to perform encapsulation. These VXLAN interfaces are > system-wide, the only one device

[dpdk-dev] [PATCH v2 4/4] doc/hash: deprecate lock ellision and read/write concurreny flags

RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY and RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT configuration flags are deprecated. Reader/Writer concurrency is provided by default. Transactional memory will be used if the platform supports it. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Rev

[dpdk-dev] [PATCH v2 3/4] test/hash: stop using lock ellision and read/write concurreny flags

With the deprecation of RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY and RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT flags, the test cases can be simplified. This results in shorter run times. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu --- lib/librte_hash/rte_hash

[dpdk-dev] [PATCH v2 2/4] hash: deprecate lock ellision and read/write concurreny flags

Hash library should provide read/write concurrency by default as most of the use cases require read/write concurrency. Hence the flag RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY is deprecated. The library will decide if locking is required to provide the concurrency based on other configuration flags. If

[dpdk-dev] [PATCH v2 0/4] hash: deprecate lock ellision and read/write concurreny flags

Various configuration flags in rte_hash library result in increase of number of test cases. Configuration flags for enabling transactional memory use and read/write concurrency are not required. These features should be supported by default. Please refer to [1] for more context. This patch marks t

[dpdk-dev] [PATCH v2 1/4] hash: prepare for deprecation of flags

Lock ellision and read/write concurreny flags need to be deprecated. Create the new version of the function and fix checkpatch issues. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu --- lib/librte_hash/rte_cuckoo_hash.c | 329

Re: [dpdk-dev] [PATCH] build: disable compiler AVX512F support

23/10/2018 23:23, Yongseok Koh: > This is a workaround to prevent a crash, which might be caused by > optimization of newer gcc (7.3.0) on Intel Skylake. > > Bugzilla ID: 97 > > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh I was asked to wait before applying this patch. 10 days passed a

Re: [dpdk-dev] [PATCH] eal: fix memleak on device hotplug rollback

31/10/2018 14:35, Zhang, Qi Z: > From: Stojaczyk, Dariusz > > > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > > Cc: qi.z.zh...@intel.com > > Cc: anatoly.bura...@intel.com > > > > Signed-off-by: Darek Stojaczyk > > Acked-by: Qi Zhang Would have been better with an explanatio

Re: [dpdk-dev] [PATCH] check-symbol-change: fix regex to match on end of map file

01/11/2018 14:54, Neil Horman: > the regex to determine the end of the map file chunk in a patch seems to > be wrong, It was using perl regex syntax, which awk doesn't appear to > support (I'm still not sure how it was working previously). Regardless, > it wasn't triggering and as a result symbol

Re: [dpdk-dev] [PATCH v3 10/13] net/mlx5: fix e-switch Flow counter deletion

On Thu, Nov 01, 2018 at 05:19:32AM -0700, Slava Ovsiienko wrote: > The counters for E-Switch rules were erroneously deleted in > flow_tcf_remove() routine. The counters deletion is moved to > flow_tcf_destroy() routine. > > Fixes: e1114ff6a5ab ("net/mlx5: support e-switch flow count action") > Cc:

Re: [dpdk-dev] [PATCH] drivers: remove useless constructor headers

28/10/2018 11:47, Thomas Monjalon: > A constructor is usually declared with RTE_INIT* macros. > As it is a static function, no need to declare before its definition. > The macro is used directly in the function definition. > > Signed-off-by: Thomas Monjalon Applied

Re: [dpdk-dev] [PATCH] test/compress: improve trace

> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, October 31, 2018 1:42 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; akhil.go...@nxp.com; Jozwiak, TomaszX > ; Daly, Lee ; Trahe, Fiona > > Subject: [PATCH] test/compress: improve trace > > Make clear which engine is compre

Re: [dpdk-dev] [PATCH v2] devtools: check wrong svg include in guides

31/10/2018 17:28, Thomas Monjalon: > Including svg files with the svg extension is a common mistake: > .. figure:: example.svg > must be > .. figure:: example.* > So it will work also when building pdf doc with figures converted > to png files. > > A check is added in checkpatches.sh.

Re: [dpdk-dev] [PATCH v3 09/13] net/mlx5: e-switch VXLAN netlink routines update

On Thu, Nov 01, 2018 at 05:19:31AM -0700, Slava Ovsiienko wrote: > This part of patchset updates Netlink exchange routine. Message > sequence numbers became not random ones, the multipart reply messages > are supported, not propagating errors to the following socket calls, > Netlink replies buffer

Re: [dpdk-dev] [PATCH v3 08/13] net/mlx5: add VXLAN support to flow translate routine

On Thu, Nov 01, 2018 at 05:19:30AM -0700, Slava Ovsiienko wrote: > This part of patchset adds support of VXLAN-related items and > actions to the flow translation routine. Later some tunnel types, > other than VXLAN can be addedd (GRE). No VTEP devices are created at > this point, the flow rule is

Re: [dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error

> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, October 31, 2018 1:40 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; akhil.go...@nxp.com; Jozwiak, TomaszX > ; jerin.ja...@caviumnetworks.com; Trahe, > Fiona > Subject: [PATCH] compress/qat: fix out-of-bounds error > > QAT

Re: [dpdk-dev] [PATCH v3 07/13] net/mlx5: add VXLAN support to flow prepare routine

On Thu, Nov 01, 2018 at 05:19:28AM -0700, Slava Ovsiienko wrote: > The e-switch Flow prepare function is updated to support VXLAN > encapsulation/and decapsulation actions. The function calculates > buffer size for Netlink message and Flow description structures, > including optional ones for tunne

Re: [dpdk-dev] [PATCH v2] compress/qat: display error in case IM buffer too small

> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, October 31, 2018 10:47 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; akhil.go...@nxp.com; Jozwiak, TomaszX > ; Trahe, Fiona > Subject: [PATCH v2] compress/qat: display error in case IM buffer too small > > Display trace if

Re: [dpdk-dev] [PATCH v3 06/13] net/mlx5: add e-switch VXLAN support to validation routine

On Thu, Nov 01, 2018 at 05:19:27AM -0700, Slava Ovsiienko wrote: > This patch adds VXLAN support for flow item/action lists validation. > The following entities are now supported: > > - RTE_FLOW_ITEM_TYPE_VXLAN, contains the tunnel VNI > > - RTE_FLOW_ACTION_TYPE_VXLAN_DECAP, if this action is spe

Re: [dpdk-dev] [PATCH v3 05/13] net/mlx5: swap items/actions validations for e-switch rules

On Thu, Nov 01, 2018 at 05:19:26AM -0700, Slava Ovsiienko wrote: > The rule validation function for E-Switch checks item list first, > then action list is checked. This patch swaps the validation order, > now actions are checked first. This is preparation for validation > function update with VXLAN

Re: [dpdk-dev] [PATCH v3 04/13] net/mlx5: add necessary structures for e-switch VXLAN

On Thu, Nov 01, 2018 at 05:19:25AM -0700, Slava Ovsiienko wrote: > This patch introduces the data structures needed to implement VXLAN > encapsulation/decapsulation hardware offload support for E-Switch. > > Suggested-by: Adrien Mazarguil > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yon

Re: [dpdk-dev] [PATCH v3 03/13] net/mlx5: add necessary definitions for e-switch VXLAN

On Thu, Nov 01, 2018 at 05:19:24AM -0700, Slava Ovsiienko wrote: > This patch contains tc flower related and some other definitions > needed to implement VXLAN encapsulation/decapsulation hardware > offload support for E-Switch. > > mlx5 driver dynamically creates and manages the VXLAN virtual > t

Re: [dpdk-dev] [PATCH v3 01/13] net/mlx5: prepare makefile for adding e-switch VXLAN

On Thu, Nov 01, 2018 at 05:19:22AM -0700, Slava Ovsiienko wrote: > This patch updates makefile before adding E-Switch VXLAN > encapsulation/decapsulation hardware offload support. > E-Switch rules are controlled via tc Netilnk commands, > so we need to include tc related headers, and check for > so

Re: [dpdk-dev] [PATCH v3 02/13] net/mlx5: prepare meson.build for adding e-switch VXLAN

On Thu, Nov 01, 2018 at 05:19:23AM -0700, Slava Ovsiienko wrote: > This patch updates meson.build before adding E-Switch VXLAN > encapsulation/decapsulation hardware offload support. > E-Switch rules are controlled via tc Netilnk commands, > so we need to include tc related headers, and check for >

Re: [dpdk-dev] [PATCH v3 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload

On Thu, Nov 01, 2018 at 05:19:21AM -0700, Slava Ovsiienko wrote: > This patchset adds the VXLAN encapsulation/decapsulation hardware > offload feature for E-Switch. > > A typical use case of tunneling infrastructure is port representors > in switchdev mode, with VXLAN traffic encapsulation perfo

[dpdk-dev] [PATCH v2 7/7] mem: add thread unsafe version for checking DMA mask

During memory initialization calling rte_mem_check_dma_mask leads to a deadlock because memory_hotplug_lock is locked by a writer, the current code in execution, and rte_memseg_walk tries to lock as a reader. This patch adds a thread_unsafe version which will call the final function specifying the

[dpdk-dev] [PATCH v2 6/7] eal/mem: use DMA mask check for legacy memory

If a device reports addressing limitations through a dma mask, the IOVAs for mapped memory needs to be checked out for ensuring correct functionality. Previous patches introduced this DMA check for main memory code currently being used but other options like legacy memory and the no hugepages opti

[dpdk-dev] [PATCH v2 5/7] mem: modify error message for DMA mask check

If DMA mask checks shows mapped memory out of the supported range specified by the DMA mask, nothing can be done but return an error an report the error. This can imply the app not being executed at all or precluding dynamic memory allocation once the app is running. In any case, we can advice the

[dpdk-dev] [PATCH v2 2/7] mem: use proper prefix

Current name rte_eal_check_dma_mask does not follow the naming used in the rest of the file. Signed-off-by: Alejandro Lucero --- doc/guides/rel_notes/release_18_11.rst | 2 +- drivers/bus/pci/linux/pci.c| 2 +- drivers/net/nfp/nfp_net.c | 2 +- lib/librte_eal

[dpdk-dev] [PATCH v2 4/7] bus/pci: avoid call to DMA mask check

Calling rte_mem_check_dma_mask when memory has not been initialized yet is wrong. This patch use rte_mem_set_dma_mask instead. Once memory initialization is done, the dma mask set will be used for checking memory mapped is within the specified mask. Fixes: fe822eb8c565 ("bus/pci: use IOVA DMA mas

[dpdk-dev] [PATCH v2 3/7] mem: add function for setting DMA mask

This patch adds the possibility of setting a dma mask to be used once the memory initialization is done. This is currently needed when IOVA mode is set by PCI related code and an x86 IOMMU hardware unit is present. Current code calls rte_mem_check_dma_mask but it is wrong to do so at that point be

[dpdk-dev] [PATCH v2 1/7] mem: fix call to DMA mask check

The param needs to be the maskbits and not the mask. Fixes: 223b7f1d5ef6 ("mem: add function for checking memseg IOVA") Signed-off-by: Alejandro Lucero --- lib/librte_eal/common/malloc_heap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/librte_eal/common/malloc_hea

[dpdk-dev] [PATCH v2 0/7] fix DMA mask check

A patchset sent introducing DMA mask checks has several critical issues precluding apps to execute. The patchset was reviewed and finally accepted after three versions. Obviously it did not go through the proper testing what can be explained, at least from my side, due to the big changes to the me

Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0

01/11/2018 19:21, Ferruh Yigit: > On 11/1/2018 5:45 PM, Bruce Richardson wrote: > > On Thu, Nov 01, 2018 at 10:42:31AM -0700, Stephen Hemminger wrote: > >> On Thu, 1 Nov 2018 13:19:50 + > >> Ferruh Yigit wrote: > >> > >>> build error: > >>> In function ‘fman_if_init’, > >>> .../drivers/bu

Re: [dpdk-dev] [PATCH 1/3] hash: deprecate lock ellision and read/write concurreny flags

> > > > diff --git a/lib/librte_hash/rte_cuckoo_hash.c > > b/lib/librte_hash/rte_cuckoo_hash.c > > index 5ddcccd87..a11de22be 100644 > > --- a/lib/librte_hash/rte_cuckoo_hash.c > > +++ b/lib/librte_hash/rte_cuckoo_hash.c > > @@ -121,7 +121,7 @@ get_alt_bucket_index(const struct rte_hash *h, } > >

Re: [dpdk-dev] [PATCH] test/bpf: use hton instead of __builtin_bswap

> > Hi Konstantin, > > > > At time of upstreaming the patch, I had compiled it on Cortex-A72 and it > had worked with the -I parameter. > > Just curious what is memory ordering on your box (BE/LE)? The memory ordering on my machine was little endian > > But when tried building it on > > x86-64,

Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0

On 11/1/2018 5:45 PM, Bruce Richardson wrote: > On Thu, Nov 01, 2018 at 10:42:31AM -0700, Stephen Hemminger wrote: >> On Thu, 1 Nov 2018 13:19:50 + >> Ferruh Yigit wrote: >> >>> build error: >>> In function ‘fman_if_init’, >>> .../drivers/bus/dpaa/base/fman/fman.c:186:2: >>> error: ‘s

[dpdk-dev] DPDK Release Status Meeting 1/11/2018

Minutes 1 November 2018 --- Agenda: * Dates * RC1 status * Subtrees * Bugzilla * OvS * Conferences * Opens Participants: * Broadcom * Debian * Intel * Mellanox Release Dates - * RC1 was out on Monday, 29 October. * RC2 date *pushed out* to *Monday, 5 November 2

Re: [dpdk-dev] [PATCH] net/ixgbe: check jumbo frame enable parameter

On Thu, 1 Nov 2018 15:55:26 +0800 wei zhao wrote: > + /* check that max packet size is within the allowed range */ > + if (max_rx_pkt_len < ETHER_MIN_MTU) { > + PMD_INIT_LOG(ERR, "max packet size is too small."); > + return -EINVAL; > + } > + > + if (max_r

Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0

On Thu, Nov 01, 2018 at 10:42:31AM -0700, Stephen Hemminger wrote: > On Thu, 1 Nov 2018 13:19:50 + > Ferruh Yigit wrote: > > > build error: > > In function ‘fman_if_init’, > > .../drivers/bus/dpaa/base/fman/fman.c:186:2: > > error: ‘strncpy’ output may be truncated copying 4095 bytes

Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0

On Thu, 1 Nov 2018 13:19:50 + Ferruh Yigit wrote: > build error: > In function ‘fman_if_init’, > .../drivers/bus/dpaa/base/fman/fman.c:186:2: > error: ‘strncpy’ output may be truncated copying 4095 bytes from a >string of length 4095 [-Werror=stringop-truncation] > st

Re: [dpdk-dev] [PATCH] test: reduce test time for hash multiwriter ut

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Naga Suresh > Somarowthu > Sent: Thursday, September 27, 2018 7:39 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; De Lara Guarch, Pablo > ; Pattan, Reshma > ; Somarowthu, Naga SureshX > > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH 0/7] fix DMA mask check

On 10/31/2018 5:29 PM, Alejandro Lucero wrote: > A patchset sent introducing DMA mask checks has several critical > issues precluding apps to execute. The patchset was reviewed and > finally accepted after three versions. Obviously it did not go > through the proper testing what can be explained,

Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

On Thu, 1 Nov 2018 17:53:51 +0800 Gavin Hu wrote: > +* **Updated the ring library with C11 memory model.** > + > + Updated the ring library with C11 memory model including the following > changes: > + > + * Synchronize the load and store of the tail > + * Move the atomic load of head above t

[dpdk-dev] [PATCH v3 1/2] net/mlx5: move device spawn configuration to probing

When a device is spawned, it does make more sense that the configuration parameters are passed by callee. Furthermore, setting default value for some configuration would need PCIe device ID which can be found in the probe function. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 54 +++

[dpdk-dev] [PATCH v3 2/2] net/mlx5: make vectorized Tx threshold configurable

Add txqs_max_vec parameter to configure the maximum number of Tx queues to enable vectorized Tx. And its default value is set according to the architecture and device type. Signed-off-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 16 +++- drivers/net/mlx5/mlx5.c |

[dpdk-dev] [PATCH v3 0/2] net/mlx5: make vectorized Tx threshold configurable

v3: * retouch commit log * fix logical error in switch-case * Make MLX5_VPMD_MAX_TXQS architecture dependent by removing MLX5_VPMD_MAX_TXQS_ARM64 v2: * add "net/mlx5: move device spawn configuration to probing" * rename txqs_min_vec to txqs_max_vec Yongseok Koh (2): net/mlx5: move device spaw

Re: [dpdk-dev] [PATCH v8 0/7] add encap and decap actions to Direct Verbs flow in MLX5 PMD

On 11/1/2018 12:51 PM, Shahaf Shuler wrote: > Thursday, November 1, 2018 11:37 AM, Dekel Peled: >> Subject: [dpdk-dev] [PATCH v8 0/7] add encap and decap actions to Direct >> Verbs flow in MLX5 PMD >> >> This series adds support of encap and decap actions in DV format. >> L2 tunnel support for VXLA

[dpdk-dev] [PATCH] doc/power: add info on jansson conditional build

Add more info to the docs on how to set environmental variable to correctly build the vm_power_manager sample app in a cross compile or multilib environment by setting PKG_CONFIG_LIBDIR. Signed-off-by: David Hunt --- .../sample_app_ug/vm_power_management.rst | 24 +++ 1 file

Re: [dpdk-dev] [PATCH 2/7] mem: use proper prefix

On Thu, Nov 1, 2018 at 3:03 PM Burakov, Anatoly wrote: > On 01-Nov-18 2:50 PM, Thomas Monjalon wrote: > > 01/11/2018 11:08, Burakov, Anatoly: > >> On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > >>> Current name rte_eal_check_dma_mask does not follow the naming > >>> used in the rest of the file.

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

On 01.11.2018 18:45, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Tuesday, October 30, 2018 5:21 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Ananyev, Konstantin >> ; Laurent Hardy >> ; Wei Dai ; >> sta...@dpdk.org; Zhang, Qi

[dpdk-dev] [PATCH v2] net/ixgbe: fix busy polling while fiber link update

If the multispeed fiber link is in DOWN state, ixgbe_setup_link could take around a second of busy polling. This is highly inconvenient for the case where single thread periodically checks the link statuses. For example, OVS main thread periodically updates the link statuses and hangs for a really

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, October 30, 2018 5:21 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Laurent Hardy > ; Wei Dai ; > sta...@dpdk.org; Zhang, Qi Z ; Thomas Monjalon > ; Yigit, Ferruh > Subject: Re

Re: [dpdk-dev] JSON compilation in examples/vm_power_manager

01/11/2018 15:59, Richardson, Bruce: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Thursday, November 1, 2018 2:40 PM > > To: Hunt, David > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] JSON compilation in examples/vm_power_manag

Re: [dpdk-dev] [PATCH 2/7] mem: use proper prefix

On 01-Nov-18 2:50 PM, Thomas Monjalon wrote: 01/11/2018 11:08, Burakov, Anatoly: On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: Current name rte_eal_check_dma_mask does not follow the naming used in the rest of the file. Signed-off-by: Alejandro Lucero --- I don't think this belongs in the _

Re: [dpdk-dev] JSON compilation in examples/vm_power_manager

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, November 1, 2018 2:40 PM > To: Hunt, David > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] JSON compilation in examples/vm_power_manager > > 01/11/2018 15:26, Hunt, David: > > Hi

Re: [dpdk-dev] [PATCH 2/7] mem: use proper prefix

01/11/2018 11:08, Burakov, Anatoly: > On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > > Current name rte_eal_check_dma_mask does not follow the naming > > used in the rest of the file. > > > > Signed-off-by: Alejandro Lucero > > --- > > I don't think this belongs in the _mem_ namespace. It is us

[dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove

The functions rte_dev_probe() and rte_dev_remove() are new in DPDK 18.11 so they got the experimental tag by policy. However they are too much basic functions for being skipped by strict applications which do not use experimental functions. The alternative is to use rte_eal_hotplug_add() and rte_e

[dpdk-dev] [PATCH 2/2] ethdev: remove experimental tag for iterator API

After removing the function rte_eth_dev_attach(), there are two replacement solutions possible: one using probe event notification, and one using a new iterator. So the application can get the new probed ports either asynchronously or synchronously. The iterator API is new in DPDK 18.11 so they go

[dpdk-dev] [PATCH 0/2] remove experimental tag for hotplug API

There are new functions in 18.11 which are fixing some hotplug issues. OVS would like to use them but do not want to allow experimental functions. As these are major functions, fixing some issues, and replacing a deprecated function, an exception should be done. Thomas Monjalon (2): eal: remove

Re: [dpdk-dev] [PATCH 1/2] net/virtio: do not re-enter clean up routines

On Mon, 2017-07-17 at 19:05 -0400, Charles (Chas) Williams wrote: > .dev_uninit calls .dev_stop and .dev_close.  The work that is done in > those routines doesn't need repeated.  Use started and opened to > track > the adapter's status. > > Signed-off-by: Chas Williams > --- >  drivers/net/virtio

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

On Thu, 2018-11-01 at 14:04 +, Luca Boccassi wrote: > ixgbe_identify_phy_x550em() was missing the code to handle > unidentified > PHY that has been there in 82599 so it was not able to complete > initialization of ixgbe sequence if no sfp plugged in. > Port it over to return an appropriate type

Re: [dpdk-dev] JSON compilation in examples/vm_power_manager

01/11/2018 15:26, Hunt, David: > Hi Thomas, > > > On 1/11/2018 10:47 AM, Thomas Monjalon wrote: > > Hi Dave, > > > > In examples/vm_power_manager/Makefile, jansson lib availability > > is detected with pkg-config --exists. > > As we have seen for telemetry lib, we can detect jansson > > for the w

Re: [dpdk-dev] [PATCH 7/7] eal/mem: use DMA mask check for legacy memory

On Thu, Nov 1, 2018 at 2:28 PM Burakov, Anatoly wrote: > On 01-Nov-18 1:39 PM, Alejandro Lucero wrote: > > > > > > On Thu, Nov 1, 2018 at 10:40 AM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > > > If a device report

Re: [dpdk-dev] [PATCH 3/7] mem: add function for setting DMA mask

On Thu, Nov 1, 2018 at 11:30 AM Alejandro Lucero < alejandro.luc...@netronome.com> wrote: > > > On Thu, Nov 1, 2018 at 10:57 AM Burakov, Anatoly < > anatoly.bura...@intel.com> wrote: > >> On 01-Nov-18 10:48 AM, Alejandro Lucero wrote: >> > >> > >> > On Thu, Nov 1, 2018 at 10:11 AM Burakov, Anatoly

Re: [dpdk-dev] [PATCH 7/7] eal/mem: use DMA mask check for legacy memory

On 01-Nov-18 1:39 PM, Alejandro Lucero wrote: On Thu, Nov 1, 2018 at 10:40 AM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > If a device reports addressing limitations through a dma mask, > the IOVAs for mapped memory

Re: [dpdk-dev] JSON compilation in examples/vm_power_manager

Hi Thomas, On 1/11/2018 10:47 AM, Thomas Monjalon wrote: Hi Dave, In examples/vm_power_manager/Makefile, jansson lib availability is detected with pkg-config --exists. As we have seen for telemetry lib, we can detect jansson for the wrong arch and enable it no matter the arch being compiled.

Re: [dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error

On Wed, Oct 31, 2018 at 06:35:11AM +, Jerin Jacob wrote: > -Original Message- > > Date: Wed, 31 Oct 2018 00:39:54 + > > From: Fiona Trahe > > To: dev@dpdk.org > > CC: tho...@monjalon.net, akhil.go...@nxp.com, tomaszx.jozw...@intel.com, > > jerin.ja...@caviumnetworks.com, Fiona Tra

[dpdk-dev] [PATCH] vhost/crypto: fix inferred misuse of enum

Fix inffered misuse of enum rte_crypto_cipher_algorithm and rte_crypto_auth_algorithm Coverity issue 277202 Fixes: e80a98708166 ("vhost/crypto: add session message handler") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 6 +++--- 1 file changed, 3 insertion

Re: [dpdk-dev] [PATCH v2] devtools: check wrong svg include in guides

01/11/2018 14:59, Arnon Warshavsky: > > > >> Yes it is a good idea. > >> I think it can be a separate patch. Would you like to send it please? > >> > >> Sure. Will do > > > > Just to make sure - I am waiting for your patch to get in, so that I apply > the warning patch for both checks OK

Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

01/11/2018 14:53, Neil Horman: > On Wed, Oct 31, 2018 at 04:08:18PM +0100, Thomas Monjalon wrote: > > 31/10/2018 16:03, Neil Horman: > > > On Wed, Oct 31, 2018 at 10:20:46AM -0400, Cody Doucette wrote: > > > > Thanks for the suggestion. It looks like > > > > 49bcce138374458d1edd1c50d8e5726959108ef4

[dpdk-dev] [PATCH 2/2] net/ixgbe: add LHA ID to x550 code

ixgbe is able to recognize 1G SX and LX id, but it is missing the LHA. Add it, so that it can handle LHA sfp plugin. Fixes: d2e72774e58c ("ixgbe/base: support X550") Cc: sta...@dpdk.org Signed-off-by: Luca Boccassi --- drivers/net/ixgbe/base/ixgbe_82599.c | 2 ++ drivers/net/ixgbe/base/ixgbe_p

[dpdk-dev] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

ixgbe_identify_phy_x550em() was missing the code to handle unidentified PHY that has been there in 82599 so it was not able to complete initialization of ixgbe sequence if no sfp plugged in. Port it over to return an appropriate type and complete init sequence properly. Fixes: d2e72774e58c ("ixgbe

Re: [dpdk-dev] [PATCH v2] net/mlx5: set RSS key to NULL to indicate default RSS

Hi Ophir, Thursday, November 1, 2018 10:59 AM, Ophir Munk: > Subject: [PATCH v2] net/mlx5: set RSS key to NULL to indicate default RSS > > Applications which add RSS rules must supply an RSS key and length. > If an application is only interested in default RSS operation it should not > care > a

Re: [dpdk-dev] [PATCH v2] devtools: check wrong svg include in guides

> >> Yes it is a good idea. >> I think it can be a separate patch. Would you like to send it please? >> >> Sure. Will do > > Just to make sure - I am waiting for your patch to get in, so that I apply the warning patch for both checks -- *Arnon Warshavsky* *Qwilt | work: +972-72-2221634 | mobile

Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

On Wed, Oct 31, 2018 at 04:08:18PM +0100, Thomas Monjalon wrote: > 31/10/2018 16:03, Neil Horman: > > On Wed, Oct 31, 2018 at 10:20:46AM -0400, Cody Doucette wrote: > > > Thanks for the suggestion. It looks like > > > 49bcce138374458d1edd1c50d8e5726959108ef4 is already in my tree. I tried > > > app

[dpdk-dev] [PATCH] check-symbol-change: fix regex to match on end of map file

the regex to determine the end of the map file chunk in a patch seems to be wrong, It was using perl regex syntax, which awk doesn't appear to support (I'm still not sure how it was working previously). Regardless, it wasn't triggering and as a result symbols were getting added to the mapdb that

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

On 11/1/2018 1:40 PM, Thomas Monjalon wrote: > 01/11/2018 13:46, Ferruh Yigit: >> On 10/31/2018 6:43 PM, Thomas Monjalon wrote: >>> 31/10/2018 19:26, Ferruh Yigit: On 10/31/2018 6:26 PM, Ferruh Yigit wrote: > On 10/31/2018 5:16 PM, Thomas Monjalon wrote: >> 31/10/2018 18:19, Ferruh Yig

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

01/11/2018 13:46, Ferruh Yigit: > On 10/31/2018 6:43 PM, Thomas Monjalon wrote: > > 31/10/2018 19:26, Ferruh Yigit: > >> On 10/31/2018 6:26 PM, Ferruh Yigit wrote: > >>> On 10/31/2018 5:16 PM, Thomas Monjalon wrote: > 31/10/2018 18:19, Ferruh Yigit: > > rte_strerror uses strerror_r(), and

Re: [dpdk-dev] [PATCH 7/7] eal/mem: use DMA mask check for legacy memory

On Thu, Nov 1, 2018 at 10:40 AM Burakov, Anatoly wrote: > On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > > If a device reports addressing limitations through a dma mask, > > the IOVAs for mapped memory needs to be checked out for ensuring > > correct functionality. > > > > Previous patches intro

Re: [dpdk-dev] [PATCH] bus/pci: fix missing case for virtio-crypto

01/11/2018 13:10, Fan Zhang: > The recent change to rte_pci_read_config() caused virtio-crypto > device initialization always failed as it has a > RTE_KDRV_UIO_GENERIC driver type. This patch fixes the problem. Hi Fan, this issue is not related at all to virtio-crypto. It can happen with any PMD,

Re: [dpdk-dev] [PATCH 6/7] mem: add safe and unsafe versions for checking DMA mask

On Thu, Nov 1, 2018 at 10:38 AM Burakov, Anatoly wrote: > On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > > During memory initialization calling rte_mem_check_dma_mask > > leads to a deadlock because memory_hotplug_lock is locked by a > > writer, the current code in execution, and rte_memseg_walk

Re: [dpdk-dev] [PATCH] doc: clarify TSO Tx offload prerequisite

On 11/1/2018 8:46 AM, Jerin Jacob wrote: > Based on the PKT_TX_TCP_SEG definition, > the application needs to update PKT_TX_IPV4 or PKT_TX_IPV6 > based on IPV4 or IPV6 packet and PKT_TX_IP_CKSUM ol_flags > to enable Tx TSO offload. > > Fixes: dad1ec72a377 ("doc: document NIC features") > Cc: sta..

Re: [dpdk-dev] [PATCH v3] net/i40e: fix Rx instability with vector mode

> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, November 1, 2018 6:48 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: fix Rx instability with vector > mode > > > Hi > > > > > Previously, there i

Re: [dpdk-dev] [PATCH v8 0/7] add encap and decap actions to Direct Verbs flow in MLX5 PMD

Thursday, November 1, 2018 11:37 AM, Dekel Peled: > Subject: [dpdk-dev] [PATCH v8 0/7] add encap and decap actions to Direct > Verbs flow in MLX5 PMD > > This series adds support of encap and decap actions in DV format. > L2 tunnel support for VXLAN and NVGRE, and L2/L3 tunnel support using raw >

Re: [dpdk-dev] [PATCH v2] net/mlx5: enable loopback by configured mode

Thursday, November 1, 2018 9:11 AM, Dekel Peled: > Subject: [PATCH v2] net/mlx5: enable loopback by configured mode > > Enable NIC loopback mode based on rte_eth_conf.lpbk_mode configuration. > Added signed off-by Applied to next-net-mlx, thanks. > --- > v2: > * Undo parameter type change to

Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0

On Thursday 01 November 2018 06:49 PM, Ferruh Yigit wrote: > build error: > In function ‘fman_if_init’, > .../drivers/bus/dpaa/base/fman/fman.c:186:2: > error: ‘strncpy’ output may be truncated copying 4095 bytes from a > string of length 4095 [-Werror=stringop-truncation] >

  1   2   >