On 01-Nov-18 2:50 PM, Thomas Monjalon wrote:
01/11/2018 11:08, Burakov, Anatoly:
On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
Current name rte_eal_check_dma_mask does not follow the naming
used in the rest of the file.

Signed-off-by: Alejandro Lucero <alejandro.luc...@netronome.com>
---

I don't think this belongs in the _mem_ namespace. It is usually used
for things to do with memory, while the DMA mask IMO sits firmly in the
domain of EAL, specifically bus subsystem.

It is a memory allocation check, isn't it?

I think rte_mem_ prefix is more meaningful.
Anyway, we should avoid rte_eal which is too vague.
For device management, we use rte_bus, rte_dev, etc.


No strong feelings here, you can keep the mem namespace. Dem alphabets tho...

--
Thanks,
Anatoly

Reply via email to