[dpdk-dev] [PATCH v2] ethdev: add generic MAC address rewrite actions

There is a need to offload rewrite outermost MAC address for both destination and source from the matched flow The proposed actions could make above easily achieved Signed-off-by: Xiaoyu Min --- v2: - Updated description about the MAC address is the outermost one lib/librte_ethdev/rte_flow.h |

Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

On 30.08.2018 09:06, Tiwei Bie wrote: > On Wed, Aug 29, 2018 at 05:00:47PM +0300, Ilya Maximets wrote: >> Any thoughts on this? > > Hi Ilya, > > Currently, the errors happened during messages handling > aren't handled properly. E.g. in vhost_user_set_mem_table(), > similar issues [1] may happen t

Re: [dpdk-dev] [PATCH 0/3] security: support for pdcp

Hi Declan, Pablo, Radu, Anoob, On 8/28/2018 6:31 PM, akhil.go...@nxp.com wrote: From: Akhil Goyal Security library currently only has support for IPSec protocol. This patchset defines structures for pdcp protocol in rte_security and provide a sample driver implementation for lookaside protoco

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

On 8/29/2018 9:28 PM, eric zhang wrote: This patch adds a configuration option to force the IOVA mode to physical address (PA). There exists virtual devices that are not directly attached to the PCI bus, and therefore the auto detection of the IOVA mode based on probing the PCI bus and IOMMU conf

Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

On Wed, Aug 29, 2018 at 05:00:47PM +0300, Ilya Maximets wrote: > Any thoughts on this? Hi Ilya, Currently, the errors happened during messages handling aren't handled properly. E.g. in vhost_user_set_mem_table(), similar issues [1] may happen too. We might want to find a way to fix this once and

[dpdk-dev] [PATCH 4/5] event/dpaa2: support Max event port value

This shall be number of available cores. Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 4b56e2e..456b446 100644 --- a/drivers/event/dp

[dpdk-dev] [PATCH 5/5] event/dpaa2: affining portal at runtime during I/O

This patch restructure the code to have the QBMAN portal affliated at run time. The device cleanup is also improved. Signed-off-by: Sunil Kumar Kori Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 277 --- drivers/event/dpaa2/dpaa2_eventd

[dpdk-dev] [PATCH 3/5] event/dpaa2: enchance timeout handling

Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 19 --- drivers/event/dpaa2/dpaa2_eventdev.h | 1 + 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index c4064a4.

[dpdk-dev] [PATCH 2/5] event/dpaa2: rename evq info to dpaa2 eventq

Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 8 drivers/event/dpaa2/dpaa2_eventdev.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index ea9d868..c4064a4 1

[dpdk-dev] [PATCH 1/5] event/dpaa2: fix mbuf assignment in atomic processing

Fixes: 7b6edb640b73 ("event/dpaa2: have separate structure to hold dqrr entries") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_even

Re: [dpdk-dev] [RFC v2] ethdev: support metadata as flow rule criteria

Hi, Example command, including just the metadata item: flow create 0 egress pattern meta data is 666 / end actions vxlan_encap / end I will update the cmdline parser as part of the complete feature implementation. Regards, Dekel From: Somnath Kotur [mailto:somnath.ko...@broadcom.com] Sent: Wed

[dpdk-dev] [PATCH 08/10] crypto/dpaa2_sec: add out of place crypto support

Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 76 + 1 file changed, 76 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 99cc719..ca6ddad 100644 --- a/drivers/c

[dpdk-dev] [PATCH 10/10] crypto/dpaa_sec: ipsec offload add null algo support

Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 284 + 1 file changed, 165 insertions(+), 119 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index e5b18df..2f0a5d2 100644 --- a/drivers/

[dpdk-dev] [PATCH 07/10] crypto/dpaa2_sec: enable sequence no rollover

From: Akhil Goyal With this patch sequence number will be rolled over and SEC block will ignore the sequence number overflow error. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dp

[dpdk-dev] [PATCH 09/10] crypto/dpaa2_sec: multi algo support for ipsec session

Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 294 ++-- 1 file changed, 190 insertions(+), 104 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index ca6ddad..e3dafeb 100

[dpdk-dev] [PATCH 06/10] crypto/dpaa_sec: enable sequence no rollover

From: Akhil Goyal With this patch sequence number will be rolled over and SEC block will ignore the sequence number overflow error. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dp

[dpdk-dev] [PATCH 05/10] crypto/dpaa_sec: reduce the number of QP per device

Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h index e923942..f4b8784 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.h +++ b/drivers/cr

[dpdk-dev] [PATCH 04/10] crypto/dpaa_sec: session qp should match with given qp

From: Akhil Goyal if session->qp != qp to be enqueued, it should show an error and not try to re-attach another qp. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.

[dpdk-dev] [PATCH 03/10] crypto/dpaa_sec: add LOCK before Rx HW queue attach

From: Akhil Goyal This is to safegaurd as the session config can be done from multi-threads. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 6 ++ drivers/crypto/dpaa_sec/dpaa_sec.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c

[dpdk-dev] [PATCH 00/10] crypto: DPAA and DPAA2_SEC enhancements

This patch series includes enhancements for the dpaa and dpaa2_sec crypto drivers Akhil Goyal (5): crypto/dpaa_sec: session reset before init crypto/dpaa_sec: add LOCK before Rx HW queue attach crypto/dpaa_sec: session qp should match with given qp crypto/dpaa_sec: enable sequence no rollo

[dpdk-dev] [PATCH 02/10] crypto/dpaa_sec: session reset before init

From: Akhil Goyal Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 ++ drivers/crypto/dpaa_sec/dpaa_sec.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c inde

[dpdk-dev] [PATCH 01/10] crypto/dpaa2_sec: update the flib RTA to latest

Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c| 5 +- drivers/crypto/dpaa2_sec/hw/desc.h | 814 + drivers/crypto/dpaa2_sec/hw/desc/algo.h| 58 +- drivers/crypto/dpaa2_sec/hw/desc/ipsec.h | 195

[dpdk-dev] [PATCH 2/2] event/dpaa: add select based event support

Signed-off-by: Hemant Agrawal --- config/common_base | 1 + config/defconfig_arm64-dpaa-linuxapp-gcc | 1 + drivers/event/dpaa/dpaa_eventdev.c | 148 +++ drivers/event/dpaa/dpaa_eventdev.h | 8 +- 4 files changed, 115 insertions(

[dpdk-dev] [PATCH 1/2] event/dpaa: remove duplicate log macros

align and cleanup the debug log prints Signed-off-by: Hemant Agrawal --- drivers/event/dpaa/dpaa_eventdev.c | 58 +++--- drivers/event/dpaa/dpaa_eventdev.h | 7 - 2 files changed, 29 insertions(+), 36 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventde

Re: [dpdk-dev] [PATCH v3] net/virtio-user: check negotiated features before set

On Wed, Aug 29, 2018 at 11:55:21AM -0400, eric zhang wrote: > This patch checks negotiated features to see if necessary to offload > before set the tap device offload capabilities. It also checks if kernel > support the TUNSETOFFLOAD operation. Fixes: 5e97e4202563 ("net/virtio-user: enable offload

[dpdk-dev] [PATCH] linuxapp, eal: Fix the memory leak issue of logid

From: Ziye Yang This patch is used to fix the memory leak issue of logid. We use the ASAN test in SPDK when intergrating DPDK and find this issue. Signed-off-by: Ziye Yang --- lib/librte_eal/linuxapp/eal/eal.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-

Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion

> [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion s/defintion/definition/ Apart from that, Reviewed-by: Tiwei Bie Thanks On Sat, Aug 25, 2018 at 10:22:40PM +0300, Rami Rosen wrote: > This patch removes an unnecessary definition of MAX_PRINT_BUFF > in examples/vhost/main

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

On 08/29/2018 11:22 PM, Wiles, Keith wrote: On Aug 29, 2018, at 12:19 PM, Saber Rezvani wrote: On 08/29/2018 01:39 AM, Wiles, Keith wrote: On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: On 08/28/2018 11:39 PM, Wiles, Keith wrote: Which version of Pktgen? I just pushed a patch in

[dpdk-dev] [PATCH] net/i40e: add interface to choose latest vector path

Right now, vector path is limited to only use on later platform due to the frequency penalty. This patch adds a devarg enable-latest-vec to allow the users to use the latest vector path that the platform supported. Namely, using AVX2 vector path on broadwell is possible. Signed-off-by: Xiaoyun Li

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, 29 Aug 2018 19:41:23 -0300 Dan Gora wrote: > On Wed, Aug 29, 2018 at 7:12 PM, Dan Gora wrote: > > On Wed, Aug 29, 2018 at 7:00 PM, Stephen Hemminger > > wrote: > >>> >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK > >>> >> applications to update the link state fo

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, Aug 29, 2018 at 7:12 PM, Dan Gora wrote: > On Wed, Aug 29, 2018 at 7:00 PM, Stephen Hemminger > wrote: >>> >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >>> >> applications to update the link state for the KNI network interfaces >>> >> in the linux kernel. >>> >> >

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, Aug 29, 2018 at 7:00 PM, Stephen Hemminger wrote: >> >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >> >> applications to update the link state for the KNI network interfaces >> >> in the linux kernel. >> >> >> >> Note that the default carrier state is set to off whe

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, 29 Aug 2018 18:10:35 -0300 Dan Gora wrote: > On Wed, Aug 29, 2018 at 8:48 AM, Ferruh Yigit wrote: > > On 6/29/2018 2:55 AM, Dan Gora wrote: > >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK > >> applications to update the link state for the KNI network interfaces

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, 29 Aug 2018 18:02:06 -0300 Dan Gora wrote: > On Wed, Aug 29, 2018 at 12:54 PM, Stephen Hemminger > wrote: > > On Thu, 28 Jun 2018 18:55:08 -0700 > > Dan Gora wrote: > > > >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK > >> applications to update the link state f

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, Aug 29, 2018 at 8:48 AM, Ferruh Yigit wrote: > On 6/29/2018 2:55 AM, Dan Gora wrote: >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >> applications to update the link state for the KNI network interfaces >> in the linux kernel. >> >> Note that the default carrier sta

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, Aug 29, 2018 at 12:54 PM, Stephen Hemminger wrote: > On Thu, 28 Jun 2018 18:55:08 -0700 > Dan Gora wrote: > >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >> applications to update the link state for the KNI network interfaces >> in the linux kernel. >> >> Note that

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

> On Aug 29, 2018, at 12:19 PM, Saber Rezvani wrote: > > > > On 08/29/2018 01:39 AM, Wiles, Keith wrote: >> >>> On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: >>> >>> >>> >>> On 08/28/2018 11:39 PM, Wiles, Keith wrote: Which version of Pktgen? I just pushed a patch in 3.5.3 to fi

[dpdk-dev] [dpdk-announce] DPDK 16.11.8 (LTS) released

Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-16.11.8.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=16.11 Luca Boccassi --- MAINTAINERS| 10 +- app/test-pmd/testpmd.c

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

On 08/29/2018 01:39 AM, Wiles, Keith wrote: On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: On 08/28/2018 11:39 PM, Wiles, Keith wrote: Which version of Pktgen? I just pushed a patch in 3.5.3 to fix a performance problem. I use Pktgen verion 3.0.0, indeed it is O.k as far as I hav

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On Wed, 29 Aug 2018 15:09:47 +0100 "Burakov, Anatoly" wrote: > On 29-Aug-18 1:39 PM, Bruce Richardson wrote: > > On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: > >> Musl complains about pthread id being of wrong size. Fix it by > >> casting to 64-bit and printing 64-bit hex un

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On Wed, 29 Aug 2018 12:56:21 +0100 Anatoly Burakov wrote: > Musl complains about pthread id being of wrong size. Fix it by > casting to 64-bit and printing 64-bit hex unconditionally. > > Signed-off-by: Anatoly Burakov What is pthread_t on musl? On Linux it is unsigned long.

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

-Original Message- > Date: Wed, 29 Aug 2018 09:34:36 -0700 > From: Stephen Hemminger > To: Jerin Jacob > Cc: dev@dpdk.org, olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > External Email > > On Wed, 29 Aug 2018 21:29:05 +0530 > Jerin Jacob wrote:

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

On Wed, 29 Aug 2018 21:29:05 +0530 Jerin Jacob wrote: > -Original Message- > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > From: Stephen Hemminger > > To: Jerin Jacob > > Cc: dev@dpdk.org, olivier.m...@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > Exte

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

On Wed, 29 Aug 2018 21:29:05 +0530 Jerin Jacob wrote: > -Original Message- > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > From: Stephen Hemminger > > To: Jerin Jacob > > Cc: dev@dpdk.org, olivier.m...@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > Exte

Re: [dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info

On 8/29/2018 11:47 AM, Emma Finn wrote: > existing testpmd command "show port info" is too verbose. > Added a new summary command to print brief information on ports. > > console output: > testpmd> show port summary all > Number of available ports: 2 > Port MAC Address Name

[dpdk-dev] [PATCH] build: add configuration summary at end of config

After running meson to configure a DPDK build, it can be useful to know what was automatically enabled or disabled. Therefore, print out by way of summary a categorised list of libraries and drivers to be built. Signed-off-by: Bruce Richardson --- drivers/meson.build | 5 + lib/meson.build

[dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test

Add in a cross-file to enable 32-bit compile tests as part of the test-meson-builds script. Signed-off-by: Bruce Richardson --- NOTE: For ease of use, it's recommended that meson 0.47 be used for this testing. With earlier versions, it may be necessary to ensure that the same development packages

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

-Original Message- > Date: Wed, 29 Aug 2018 08:31:10 -0700 > From: Stephen Hemminger > To: Jerin Jacob > Cc: dev@dpdk.org, olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > External Email > > On Mon, 27 Aug 2018 18:08:35 +0530 > Jerin Jacob wrote:

[dpdk-dev] [PATCH] eal: force IOVA mode to physical

This patch adds a configuration option to force the IOVA mode to physical address (PA). There exists virtual devices that are not directly attached to the PCI bus, and therefore the auto detection of the IOVA mode based on probing the PCI bus and IOMMU configuration may not report the required addr

[dpdk-dev] [PATCH v3] net/virtio-user: check negotiated features before set

This patch checks negotiated features to see if necessary to offload before set the tap device offload capabilities. It also checks if kernel support the TUNSETOFFLOAD operation. Signed-off-by: eric zhang --- v3: * make other offloading features depend on CSUM * check IFF_VNET_HDR support when h

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Thu, 28 Jun 2018 18:55:08 -0700 Dan Gora wrote: > Add a new API function to KNI, rte_kni_update_link() to allow DPDK > applications to update the link state for the KNI network interfaces > in the linux kernel. > > Note that the default carrier state is set to off when the interface > is open

Re: [dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info

On Wed, 29 Aug 2018 11:47:29 +0100 Emma Finn wrote: > existing testpmd command "show port info" is too verbose. > Added a new summary command to print brief information on ports. > > console output: > testpmd> show port summary all > Number of available ports: 2 > Port MAC Ad

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

On Mon, 27 Aug 2018 18:08:35 +0530 Jerin Jacob wrote: > Add support for IGMP packet type. > > Signed-off-by: Jerin Jacob Could you add logic to recoginize IGMP to the software packet type identification rte_net_get_ptype used by drivers that don't have hardware support. Also shouldn't this b

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

From: Chas Williams >On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad wrote: > > >From: Chas Williams >>On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad >> wrote: > Because rings are generally quite efficient. >>> >>>But you are using a ri

Re: [dpdk-dev] [PATCH v5] app/testpmd: add forwarding mode to simulate a noisy neighbour

On 08/10/2018 03:49 PM, Jens Freimann wrote: > This adds a new forwarding mode to testpmd to simulate > more realistic behavior of a guest machine engaged in receiving > and sending packets performing Virtual Network Function (VNF). > Hi Jens, comments below, thanks, Kevin. > The goal is to ena

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

On Wed, Aug 29, 2018 at 3:16 PM Adrien Mazarguil wrote: > On Wed, Aug 29, 2018 at 10:27:03AM +0200, Christian Ehrhardt wrote: > > On Tue, Aug 28, 2018 at 5:02 PM Adrien Mazarguil < > adrien.mazarg...@6wind.com> > > wrote: > > > > > On Tue, Aug 28, 2018 at 02:38:35PM +0200, Christian Ehrhardt wrot

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad wrote: > > > From: Chas Williams > >On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad > wrote: > > >>>Because rings are generally quite efficient. > >> > >>But you are using a ring in addition to regular array management, it > mu

Re: [dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

On 29-Aug-18 1:35 PM, Bruce Richardson wrote: On Wed, Aug 29, 2018 at 12:56:16PM +0100, Anatoly Burakov wrote: Musl already has PAGE_SIZE defined, and our define clashed with it. Rename our define to SYS_PAGE_SIZE. Bugzilla ID: 36 Signed-off-by: Anatoly Burakov --- Would it not be easier to

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On 29-Aug-18 1:39 PM, Bruce Richardson wrote: On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: Musl complains about pthread id being of wrong size. Fix it by casting to 64-bit and printing 64-bit hex unconditionally. Signed-off-by: Anatoly Burakov --- Given that on linux pthre

Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

Any thoughts on this? Best regards, Ilya Maximets. On 17.08.2018 14:33, Ilya Maximets wrote: > Allocation failures of shadow used ring and batched copy array > are not recoverable and leads to the segmentation faults like > this on the receiving/transmission path: > > Program received signal S

[dpdk-dev] [PATCH v3] net/mlx: add meson build support

Compile Mellanox drivers when their external dependencies are met. A glue version of the driver can still be requested by using the -Denable_driver_mlx_glue=true To avoid modifying the whole sources and keep the compatibility with current build systems (e.g. make), the mlx{4,5}_autoconf.h is stil

Re: [dpdk-dev] [dpdk-stable] 16.11.8 (LTS) patches review and test

Great, thank you very much. I'll push the release later tonight. On Wed, 2018-08-29 at 15:28 +0200, Marco Varlese wrote: > Hi Luca & all, > > I confirm tests carried out via test_pmd and Ovs-DPDK do not show any > regression > for us. > > > Cheers, > Marco > > On Wed, 2018-08-29 at 10:55 +010

Re: [dpdk-dev] 16.11.8 (LTS) patches review and test

Hi Luca & all, I confirm tests carried out via test_pmd and Ovs-DPDK do not show any regression for us. Cheers, Marco On Wed, 2018-08-29 at 10:55 +0100, Luca Boccassi wrote: > On Mon, 2018-08-27 at 17:17 +0100, Luca Boccassi wrote: > > On Thu, 2018-08-23 at 09:55 +0100, Luca Boccassi wrote: > >

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

On Wed, Aug 29, 2018 at 10:27:03AM +0200, Christian Ehrhardt wrote: > On Tue, Aug 28, 2018 at 5:02 PM Adrien Mazarguil > wrote: > > > On Tue, Aug 28, 2018 at 02:38:35PM +0200, Christian Ehrhardt wrote: > > > --- a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h > > > +++ b/lib/librte_eal/

Re: [dpdk-dev] [PATCH] mem: fix undefined behavior in NUMA code

Hi. Thanks for the fix. Comments inline. Best regards, Ilya Maximets. On 29.08.2018 15:21, Anatoly Burakov wrote: > When NUMA-aware hugepages config option is set, we rely on > libnuma to tell the kernel to allocate hugepages on a specific > NUMA node. However, we allocate node mask before we che

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On Wed, Aug 29, 2018 at 01:39:26PM +0100, Bruce Richardson wrote: > On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: > > Musl complains about pthread id being of wrong size. Fix it by > > casting to 64-bit and printing 64-bit hex unconditionally. > > > > Signed-off-by: Anatoly Bura

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

On Wed, Aug 29, 2018 at 11:01:15AM +0100, Bruce Richardson wrote: > On Wed, Aug 29, 2018 at 11:34:10AM +0200, Nélio Laranjeiro wrote: > > Hi Bruce, > > > > Thanks for your comments I have address almost all of them in the v3 by > > doing what you suggest, I still have some comments, please see bel

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: > Musl complains about pthread id being of wrong size. Fix it by > casting to 64-bit and printing 64-bit hex unconditionally. > > Signed-off-by: Anatoly Burakov > --- Given that on linux pthread_t is a pointer type, will this not gi

Re: [dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

On Wed, Aug 29, 2018 at 12:56:16PM +0100, Anatoly Burakov wrote: > Musl already has PAGE_SIZE defined, and our define clashed with it. > Rename our define to SYS_PAGE_SIZE. > > Bugzilla ID: 36 > > Signed-off-by: Anatoly Burakov > --- Would it not be easier to just do? #ifndef PAGE_SIZE #define

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

On Wed, 2018-08-29 at 13:59 +0200, Nélio Laranjeiro wrote: > On Wed, Aug 29, 2018 at 11:00:54AM +0100, Luca Boccassi wrote: > > On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > > > Thanks for this, comments inline below. > > > > > > /Bruce > > > > > > On Mon, Aug 27, 2018 at 02:42:25P

[dpdk-dev] [PATCH] mem: fix undefined behavior in NUMA code

When NUMA-aware hugepages config option is set, we rely on libnuma to tell the kernel to allocate hugepages on a specific NUMA node. However, we allocate node mask before we check if NUMA is available in the first place, which, according to the manpage [1], causes undefined behaviour. Fix by only

Re: [dpdk-dev] [RFC v2] ethdev: support metadata as flow rule criteria

Hi Dekel, Could you please show with an example i.e how the corresponding 'flow create' cmd will look like in testpmd? Also I'm guessing you would need to change the cmdline_parser logic in testpmd application as well to recognize this new rte_flow_item? Thanks Som On Wed, Aug 29, 2018 at

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

On Wed, Aug 29, 2018 at 11:00:54AM +0100, Luca Boccassi wrote: > On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > > Thanks for this, comments inline below. > > > > /Bruce > > > > On Mon, Aug 27, 2018 at 02:42:25PM +0200, Nelio Laranjeiro wrote: > > > Mellanox drivers remains un-compil

[dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

Musl complains about pthread id being of wrong size. Fix it by casting to 64-bit and printing 64-bit hex unconditionally. Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal.c| 5 +++-- lib/librte_eal/linuxapp/eal/eal_thread.c | 5 +++-- 2 files changed, 6 insertions(+), 4

[dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

Musl already has PAGE_SIZE defined, and our define clashed with it. Rename our define to SYS_PAGE_SIZE. Bugzilla ID: 36 Signed-off-by: Anatoly Burakov --- drivers/bus/pci/linux/pci_vfio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/pci/linux/pci_vfio.

[dpdk-dev] [PATCH 4/7] eal/hugepage_info: improve musl compatibility

When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 33 Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c

[dpdk-dev] [PATCH 6/7] string_fns: improve musl compatibility

Musl wraps various string functions such as strlcpy in order to harden them. However, the fortify wrappers are included without including the actual string functions being wrapped, which throws missing definition compile errors. Fix by including string.h in string functions header. Signed-off-by:

[dpdk-dev] [PATCH 1/7] linuxapp: build with _GNU_SOURCE defined by default

We use _GNU_SOURCE all over the place, but often times we miss defining it, resulting in broken builds on musl. Rather than fixing every library's and driver's and application's makefile, fix it by simply defining _GNU_SOURCE by default for all Linuxapp builds. Signed-off-by: Anatoly Burakov ---

[dpdk-dev] [PATCH 3/7] fbarray: improve musl compatibility

When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 34 Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_fbarray.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/lib

[dpdk-dev] [PATCH 5/7] mem: improve musl compatibility

When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 31 Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 1 + lib/librte_eal/linuxapp/eal/eal_memory.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib

[dpdk-dev] [PATCH 0/7] Improve core EAL musl compatibility

This patchset fixes numerous issues with musl compatibility in the core EAL libraries. It does not fix anything beyond core EAL (so, PCI driver is still broken, so are a few other drivers), but it's a good start. Tested on container with Alpine Linux. Alpine dependencies: build-base bsd-compat-he

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On 6/29/2018 2:55 AM, Dan Gora wrote: > Add a new API function to KNI, rte_kni_update_link() to allow DPDK > applications to update the link state for the KNI network interfaces > in the linux kernel. > > Note that the default carrier state is set to off when the interface > is opened. Why set ca

Re: [dpdk-dev] [PATCH v2 02/10] kni: separate releasing netdev from freeing KNI interface

On 6/29/2018 2:55 AM, Dan Gora wrote: > Currently the rte_kni kernel driver suffers from a problem where > when the interface is released, it generates a callback to the DPDK > application to change the interface state to Down. However, after the > DPDK application handles the callback and generat

Re: [dpdk-dev] 16.11.8 (LTS) patches review and test

Hi Luca, On Wed, 2018-08-29 at 10:55 +0100, Luca Boccassi wrote: > On Mon, 2018-08-27 at 17:17 +0100, Luca Boccassi wrote: > > On Thu, 2018-08-23 at 09:55 +0100, Luca Boccassi wrote: > > > On Mon, 2018-08-13 at 19:21 +0100, luca.bocca...@gmail.com wrote: > > > > Hi all, > > > > > > > > Here is a

[dpdk-dev] [PATCH 11/13] net/dpaa: tune prefetch in Rx path

Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_rxtx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 2c57741..c4471c2 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c

[dpdk-dev] [PATCH 12/13] bus/dpaa: add check for re-definition in compat

Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/compat.h | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/bus/dpaa/include/compat.h b/drivers/bus/dpaa/include/compat.h index 92241d2..4122657 100644 --- a/drivers/bus/dpaa/include/compat.

[dpdk-dev] [PATCH 13/13] mempool/dpaa: change the debug log level to DP

Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c index 10c536b..1c12122 100644 --- a/drivers/mempool/dpaa/dpaa_mempool.c +++ b/driver

[dpdk-dev] [PATCH 10/13] net/dpaa: separate Rx function for LS1046

This is to avoid the checks in datapath Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 9 +-- drivers/net/dpaa/dpaa_rxtx.c | 60 +- drivers/net/dpaa/dpaa_rxtx.h | 3 +++ 3 files changed, 58 insertions(+), 14 deletions(-) diff

[dpdk-dev] [PATCH 09/13] net/dpaa: rearranging of atomic queue support code

From: Sunil Kumar Kori Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa/dpaa_rxtx.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 3a3a048..6698c97 100644 --- a/drivers/net/dpa

[dpdk-dev] [PATCH 08/13] bus/dpaa: avoid using be conversions for contextb

From: Nipun Gupta Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 71da275..dc64d08 100644 --- a/drivers/bus/dpaa/

[dpdk-dev] [PATCH 07/13] bus/dpaa: avoid tag Set for eqcr in Tx path

From: Nipun Gupta Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 8730550..71da275 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/drive

[dpdk-dev] [PATCH 06/13] bus/dpaa: add interrupt based portal fd support

Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/bman_driver.c | 17 ++ drivers/bus/dpaa/base/qbman/qman.c| 52 +++ drivers/bus/dpaa/base/qbman/qman_driver.c | 7 - drivers/bus/dpaa/include/fsl_qman.h | 20 drivers/b

[dpdk-dev] [PATCH 04/13] net/dpaa: set correct speed based on MAC type

From: Sachin Saxena Fixes: 799db4568c76 ("net/dpaa: support device info and speed capability") Cc: shreyansh.j...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH 05/13] net/dpaa: minor debug log enhancements

Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 4e5cc0f..df72510 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/d

[dpdk-dev] [PATCH 01/13] net/dpaa: configure frame queue on MAC ID basis

Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 25 ++--- drivers/net/dpaa/dpaa_ethdev.h | 2 +- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 7a950ac..009ef84 100644 -

[dpdk-dev] [PATCH 00/13] driver/net: NXP DPAA driver enhancements

Hemant Agrawal (9): net/dpaa: configure frame queue on MAC ID basis net/dpaa: fix jumbo buffer config net/dpaa: implement scatter offload support net/dpaa: minor debug log enhancements bus/dpaa: add interrupt based portal fd support net/dpaa: separate Rx function for LS1046 net/dpaa

[dpdk-dev] [PATCH 03/13] net/dpaa: implement scatter offload support

Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 62 +++--- drivers/net/dpaa/dpaa_ethdev.h | 3 +- drivers/net/dpaa/dpaa_rxtx.c | 8 +++--- drivers/net/dpaa/dpaa_rxtx.h | 2 -- 4 files changed, 64 insertions(+), 11 deletions(-) diff --

[dpdk-dev] [PATCH 02/13] net/dpaa: fix jumbo buffer config

Avoid return after the jumbo buffer config in dev config API Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info

existing testpmd command "show port info" is too verbose. Added a new summary command to print brief information on ports. console output: testpmd> show port summary all Number of available ports: 2 Port MAC Address Name Driver Status Link 011:2

Re: [dpdk-dev] [PATCH v2 01/10] kni: remove unused variables from struct kni_dev

On 6/29/2018 2:54 AM, Dan Gora wrote: > Remove the unused fields 'status' and 'synchro' from the struct > kni_dev. > > Signed-off-by: Dan Gora Acked-by: Ferruh Yigit

  1   2   >