Re: [dpdk-dev] [PATCH v3 16/16] net/dpaa: implement scatter offload support

2018-07-12 Thread Shreyansh Jain
On Thursday 12 July 2018 05:53 PM, Thomas Monjalon wrote: Title can be "net/dpaa: support scatter offload" 06/07/2018 10:10, Hemant Agrawal: + /* Max packet can fit in single buffer */ + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) { + ; Why an empty stat

Re: [dpdk-dev] [PATCH v3] net/mlx5: add support for 32bit systems

2018-07-12 Thread Shahaf Shuler
Thursday, July 12, 2018 3:02 PM, Mordechay Haimovsky: > Subject: [PATCH v3] net/mlx5: add support for 32bit systems > > This patch adds support for building and running mlx5 PMD on 32bit systems > such as i686. > > The main issue to tackle was handling the 32bit access to the UAR as quoted > fr

Re: [dpdk-dev] [PATCH v3] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, July 13, 2018 11:17 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH v3] net/i40e: fix FDIR check programming status error > > In i40e FDIR PMD code for checking programming status function

[dpdk-dev] [PATCH v3] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhao Wei
In i40e FDIR PMD code for checking programming status function i40e_check_fdir_programming_status(), the initial value of return value ret should be set to -1 not 0, because if DD bit of I40E_RX_DESC_STATUS_DD is not write back, this function will return 0 to upper function, this give an error info

[dpdk-dev] [PATCH v2] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhao Wei
In i40e FDIR PMD code for checking programming status function i40e_check_fdir_programming_status(), the initial value of return value ret should be set to -1 not 0, because if DD bit of I40E_RX_DESC_STATUS_DD is not write back, this function will return 0 to upper function, this give an error info

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, July 13, 2018 11:16 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix FDIR check programming status error > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: Friday, Ju

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, July 13, 2018 11:12 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix FDIR check programming status error > > This code change is ok also, I don't think so, with your change, it will

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhao1, Wei
This code change is ok also, but it seems need to add more Judging branch? IF you think it is almost the same, I WILL commit a new v2. > -Original Message- > From: Zhang, Qi Z > Sent: Friday, July 13, 2018 11:06 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PAT

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, July 11, 2018 4:25 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH] net/i40e: fix FDIR check programming status error > > In i40e FDIR PMD code for checking programming status function

[dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-07-12 Thread Wenzhuo Lu
The device information cannot be gotten correctly before the configuration is set. Because on some NICs the information has dependence on the configuration. Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters") Signed-off-by: Wenzhuo Lu --- lib/librte_ethdev/rte_ethdev.c | 21 ++

Re: [dpdk-dev] [PATCH] ethdev: fix device info getting

2018-07-12 Thread Lu, Wenzhuo
Hi Andrew, > -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Thursday, July 12, 2018 4:06 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix device info getting > > On 12.07.2018 08:27, Wenzhuo Lu wrote: > > The device

Re: [dpdk-dev] [PATCH v5 5/8] hash: add read and write concurrency support

2018-07-12 Thread Wang, Yipeng1
Thanks for pointing me to this patch. I guess the try-locks still does not solve the overhead of multiple readers contending the counter. It just provides a non-blocking version of the same algorithm. The relock function looks interesting. But it would be helpful if any special use case or ex

Re: [dpdk-dev] [PATCH v4 0/8] Add read-write concurrency to rte_hash library

2018-07-12 Thread Wang, Yipeng1
Hi, I guess your proposal is to let the user application to handle all the concurrency using RCU and locks. That could be complementary and orthogonal to our current implementation. User could choose to do this way if TSX is not available, and if they want more control over the concurrency impl

Re: [dpdk-dev] [PATCH v2 3/3] eal: make memory segment preallocation OS-specific

2018-07-12 Thread Thomas Monjalon
28/06/2018 13:41, Anatoly Burakov: > In the perfect world, it wouldn't matter how much memory was > preallocated because most of it was always going to be private > anonymous zero-page mappings for the duration of the program. > However, in practice, due to peculiarities of FreeBSD, we need > to ad

Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling

2018-07-12 Thread Thomas Monjalon
26/06/2018 12:53, Anatoly Burakov: > From: Jianfeng Tan > > Next commit will make asynchronous IPC requests rely on alarm API, > which in turn relies on interrupts to work. Therefore, move the EAL > interrupt initialization before IPC initialization to avoid breaking > IPC in the next commit. >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread

2018-07-12 Thread Thomas Monjalon
10/07/2018 12:44, Dariusz Stojaczyk: > From: Dariusz Stojaczyk > > The error is not fatal and we can physically continue > creating the thread. It simply won't have a name. > > If rte_thread_setname() fails, we will just print > a debug log now. EAL does the same for lcore threads. > > Signed-o

Re: [dpdk-dev] [PATCH v3 3/9] examples/vm_power: add oob monitoring functions

2018-07-12 Thread Stephen Hemminger
On Thu, 12 Jul 2018 21:13:26 +0200 Thomas Monjalon wrote: > 26/06/2018 11:23, David Hunt: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#

Re: [dpdk-dev] [PATCH] memory: do not use base-virtaddr in secondary processes

2018-07-12 Thread Thomas Monjalon
19/06/2018 11:21, Burakov, Anatoly: > On 18-Jun-18 8:53 PM, Dariusz Stojaczyk wrote: > > Since secondary process' address space is highly dictated > > by the primary process' mappings, it doesn't make much > > sense to use base-virtaddr for secondary processes. > > > > This patch is intended to fi

Re: [dpdk-dev] [PATCH v2] memory: make eal_get_virtual_area() aware of base-virtaddr alignment

2018-07-12 Thread Thomas Monjalon
15/06/2018 17:13, Dariusz Stojaczyk: > From: Dariusz Stojaczyk > > Whenever a calculated base-virtaddr offset had to be > manually aligned to requested page_sz, we did not take > account of that alignment in incrementing the base-virtaddr > offset further. The next requested virtual area could pr

[dpdk-dev] OSCON Meetup for Open Source Networking

2018-07-12 Thread Zhu, Heqing
Headed to OSCON next week? In Portland by your good fortune? Interested in open source networking? Then join us on Wednesday evening, July 18, for great food, free beer, awesome views, and an overview of the Linux Foundation Networking project, Tungsten Fabric: Open Source, Multi Cloud Networ

Re: [dpdk-dev] [dpdk-stable] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-07-12 Thread Thomas Monjalon
14/06/2018 09:29, Burakov, Anatoly: > On 13-Jun-18 8:08 PM, Dariusz Stojaczyk wrote: > > Although the alignment mechanism works as intended, the > > `no_align` bool flag was set incorrectly. We were aligning > > buffers that didn't need extra alignment, and weren't > > aligning ones that really nee

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] memory: fix segfault on rte_mem_virt2memseg() call with invalid addr

2018-07-12 Thread Thomas Monjalon
04/06/2018 07:33, Dariusz Stojaczyk: > When trying to use it with an address that's not > managed by DPDK it would segfault due to a missing > check. The doc says this function returns either > a pointer or NULL, so let it do so. > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area

2018-07-12 Thread Thomas Monjalon
01/06/2018 17:06, Burakov, Anatoly: > On 01-Jun-18 1:59 PM, Dariusz Stojaczyk wrote: > > EAL reserves a huge area in virtual address space > > to provide virtual address contiguity for e.g. > > future memory extensions (memory hotplug). During > > memory hotplug, if the hugepage mmap succeeds but >

Re: [dpdk-dev] [PATCH] ethdev: fix flow expansion matching types

2018-07-12 Thread Thomas Monjalon
11/07/2018 09:16, Adrien Mazarguil: > On Wed, Jul 11, 2018 at 08:49:35AM +0200, Nelio Laranjeiro wrote: > > Node RSS types are generally covering more RSS kind than the user is > > requesting, it should accept to expand even if only a single bit is > > remains after masking. Setting the correct RS

Re: [dpdk-dev] [PATCH] app/testpmd: distribute queues to cores

2018-07-12 Thread Thomas Monjalon
14/06/2018 12:51, Bruce Richardson: > On Sat, May 26, 2018 at 11:15:20PM +0800, Xueming Li wrote: > > Current topology distribute forwarding streams to lcores by port, this > > make unbalanced loading when port number larger than 2: > > lcore 0: P0Q0->P1Q0, P0Q1->P1Q1 > > locre 1: P1Q0->P0Q

Re: [dpdk-dev] [PATCH v5 0/8] Add read-write concurrency to rte_hash library

2018-07-12 Thread Thomas Monjalon
10/07/2018 18:59, Yipeng Wang: > This patch set adds the read-write concurrency support in rte_hash. > A new flag value is added to indicate if read-write concurrency is needed > during creation time. Test cases are implemented to do functional and > performance tests. > > The new concurrency mode

Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device

2018-07-12 Thread Wiles, Keith
> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom > wrote: > > This is the Distributed Software (DSW) event device, which distributes > the task of scheduling events among all the eventdev ports and their > lcore threads. > > DSW is primarily designed for atomic-only queues, but also supports >

Re: [dpdk-dev] [PATCH v5 5/8] hash: add read and write concurrency support

2018-07-12 Thread Thomas Monjalon
12/07/2018 03:22, Wang, Yipeng1: > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > For small windows, reader-writer locks are slower than a spin lock > > because there are more cache bounces. > > Hi, Stephen, > > You are correct and we understand that spinlock might be slightly

Re: [dpdk-dev] [PATCH v3] mempool/octeontx: fix pool to aura mapping

2018-07-12 Thread Thomas Monjalon
03/07/2018 06:50, Pavan Nikhilesh: > HW needs each pool to be mapped to an aura set of 16 auras. > Previously, pool to aura mapping was considered to be 1:1. > > Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh > Acked-by: Sant

Re: [dpdk-dev] [PATCH v11 0/4] Hyper-V/Azure netvsc PMD and bus support

2018-07-12 Thread Thomas Monjalon
The old offload API has been removed. Please could you adapt this PMD to the new API? The errors are: ../drivers/net/netvsc/hn_ethdev.c:185:4: error: ‘struct rte_eth_txconf’ has no member named ‘txq_flags’ ../drivers/net/netvsc/hn_ethdev.c:185:16: error: ‘ETH_TXQ_FLAGS_NOXSUMS’ undeclared (first

Re: [dpdk-dev] [PATCH v3 3/9] examples/vm_power: add oob monitoring functions

2018-07-12 Thread Thomas Monjalon
26/06/2018 11:23, David Hunt: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include >

Re: [dpdk-dev] [0/9] examples/vm_power: 100% Busy Polling

2018-07-12 Thread Thomas Monjalon
26/06/2018 11:23, David Hunt: > This patch set adds the capability to do out-of-band power > monitoring on a system. It uses a thread to monitor the branch > counters in the targeted cores, and calculates the branch ratio > if the running code. > > If the branch ratop is low (0.01), then > the cod

Re: [dpdk-dev] [PATCH 5/6] net/mlx5: add VLAN item and actions to switch flow rules

2018-07-12 Thread Yongseok Koh
On Thu, Jul 12, 2018 at 12:47:09PM +0200, Adrien Mazarguil wrote: > On Wed, Jul 11, 2018 at 06:10:25PM -0700, Yongseok Koh wrote: > > On Wed, Jun 27, 2018 at 08:08:18PM +0200, Adrien Mazarguil wrote: > > > This enables flow rules to explicitly match VLAN traffic (VLAN pattern > > > item) and perfor

Re: [dpdk-dev] [PATCH 2/6] net/mlx5: add framework for switch flow rules

2018-07-12 Thread Yongseok Koh
On Thu, Jul 12, 2018 at 12:46:46PM +0200, Adrien Mazarguil wrote: > On Wed, Jul 11, 2018 at 05:59:18PM -0700, Yongseok Koh wrote: > > On Wed, Jun 27, 2018 at 08:08:12PM +0200, Adrien Mazarguil wrote: > > > Because mlx5 switch flow rules are configured through Netlink (TC > > > interface) and have l

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-12 Thread Verma, Shally
HI Declan >-Original Message- >From: Doherty, Declan [mailto:declan.dohe...@intel.com] >Sent: 09 July 2018 20:25 >To: Verma, Shally ; pablo.de.lara.gua...@intel.com >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, Nidadavolu >; Sahu, Sunila ; Gupta, >Ashish ; Kartha, >Umesh >Subje

Re: [dpdk-dev] [PATCH 1/6] net/mlx5: lay groundwork for switch offloads

2018-07-12 Thread Yongseok Koh
> On Jul 12, 2018, at 3:46 AM, Adrien Mazarguil > wrote: > > On Wed, Jul 11, 2018 at 05:17:09PM -0700, Yongseok Koh wrote: >> On Wed, Jun 27, 2018 at 08:08:10PM +0200, Adrien Mazarguil wrote: >>> With mlx5, unlike normal flow rules implemented through Verbs for traffic >>> emitted and received

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

2018-07-12 Thread Thomas Monjalon
05/07/2018 16:45, Liang, Ma: > On 27 Jun 18:33, Kevin Traynor wrote: > > On 06/26/2018 12:40 PM, Radu Nicolau wrote: > > > From: Liang Ma > > > > > > 1. Abstract > > > > > > For packet processing workloads such as DPDK polling is continuous. > > > This means CPU cores always show 100% busy indep

Re: [dpdk-dev] [PATCH v2 1/3] power: add get capabilities API

2018-07-12 Thread Thomas Monjalon
26/06/2018 11:43, Hunt, David: > > On 11/6/2018 11:03 AM, Radu Nicolau wrote: > > New API added, rte_power_get_capabilities(), that allows the > > application to query the power and performance capabilities > > of the CPU cores. > > > > Signed-off-by: Radu Nicolau > > Acked-by: David Hunt Serie

Re: [dpdk-dev] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64

2018-07-12 Thread Jerin Jacob
-Original Message- > Date: Thu, 12 Jul 2018 11:44:14 +0900 > From: Takeshi Yoshimura > To: dev@dpdk.org > Cc: Takeshi Yoshimura , sta...@dpdk.org, Takeshi > Yoshimura > Subject: [dpdk-dev] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64 > X-Mailer: git-send-email 2.15.1 > > External

Re: [dpdk-dev] [PATCH v2] test: add unit tests for latencystats library

2018-07-12 Thread Pattan, Reshma
Hi, > -Original Message- > From: Parthasarathy, JananeeX M > Sent: Thursday, July 12, 2018 11:14 AM > To: dev@dpdk.org > Cc: Horton, Remy ; Pattan, Reshma > ; Parthasarathy, JananeeX M > ; Babu Radhakrishnan, AgalyaX > > Subject: [PATCH v2] test: add unit tests for latencystats library >

[dpdk-dev] [PATCH v6 08/16] compress/qat: setup queue-pairs for compression service

2018-07-12 Thread Fiona Trahe
Setup and clear queue-pairs for handling compression requests and responses. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.h | 2 ++ drivers/compress/qat/qat_comp_pmd.c | 61 + drivers/compress/qat/qat_comp_pm

[dpdk-dev] [PATCH v6 16/16] docs/qat: refactor docs adding compression guide

2018-07-12 Thread Fiona Trahe
Extend QAT guide to cover crypto and compression and common information, particularly about kernel driver dependency. Update release note. Update compression feature list for qat. Signed-off-by: Fiona Trahe --- config/common_base | 2 +- doc/guides/compressdevs/features/q

[dpdk-dev] [PATCH v6 13/16] compress/qat: create and populate the ops structure

2018-07-12 Thread Fiona Trahe
Create an ops structure and populate it with the qat-specific functions. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 38 - drivers/compress/qat/qat_comp_pmd.h | 30 - 2 files c

[dpdk-dev] [PATCH v6 07/16] compress/qat: add stats functions

2018-07-12 Thread Fiona Trahe
Add functions to get and clear compression queue-pair statistics. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 35 +++ drivers/compress/qat/qat_comp_pmd.h | 7 +++ 2 files changed, 42 insertions(+) diff

[dpdk-dev] [PATCH v6 12/16] compress/qat: add device start and stop fns

2018-07-12 Thread Fiona Trahe
There are no specific actions needed to start/stop a QAT comp device so these are just trivial fns to satisfy the pmd API. Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 11 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 17 insertions(+) diff

[dpdk-dev] [PATCH v6 10/16] compress/qat: add fn to return device info

2018-07-12 Thread Fiona Trahe
Add capabilities pointer to internal qat comp device and function to return this and other info. C Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 19 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 25 inse

[dpdk-dev] [PATCH v6 14/16] compress/qat: add fns to create and destroy the PMD

2018-07-12 Thread Fiona Trahe
Now that all the device operations are available, add the functions to create and destroy the pmd. Called on probe and remove of the qat pci device, these register the device with the compressdev API and plug in all the device functionality. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwia

[dpdk-dev] [PATCH v6 09/16] compress/qat: add fns to configure and clear device

2018-07-12 Thread Fiona Trahe
Add functions to configure and clear the qat comp device, including the creation and freeing of the xform pool and the freeing of queue-pairs. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 95 + drivers/com

[dpdk-dev] [PATCH v6 15/16] compress/qat: prevent device usage if incorrect firmware

2018-07-12 Thread Fiona Trahe
Previous check only causes op to fail on dequeue. This extends so once first fail is detected, application can no longer enqueue ops to the device and will also get an appropriate error if trying to reconfigure or setup the device. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- dr

[dpdk-dev] [PATCH v6 11/16] compress/qat: add enqueue/dequeue functions

2018-07-12 Thread Fiona Trahe
Wrap generic qat enqueue/dequeue functions with compressdev enqueue and dequeue fns. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 14 ++ drivers/compress/qat/qat_comp_pmd.h | 8 2 files changed, 22 insertions(+) diff -

[dpdk-dev] [PATCH v6 06/16] compress/qat: check that correct firmware is in use

2018-07-12 Thread Fiona Trahe
Check bit in response message to verify that correct firmware is in use for compression. If not return an error. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 16 +++- drivers/compress/qat/qat_comp.h | 2 ++ 2 files changed, 17 inser

[dpdk-dev] [PATCH v6 05/16] compress/qat: create fw request and process response

2018-07-12 Thread Fiona Trahe
Add functions to create the request message to send to firmware and to process the firmware response. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 101 drivers/compress/qat/qat_comp.h | 8 +++ drive

[dpdk-dev] [PATCH v6 04/16] compress/qat: add xform processing

2018-07-12 Thread Fiona Trahe
Add code to process compressdev rte_comp_xforms, creating private qat_comp_xforms with prepared firmware message templates. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 239 drivers/compress/qat/qat_comp.

[dpdk-dev] [PATCH v6 03/16] compress/qat: add meson build

2018-07-12 Thread Fiona Trahe
Add meson build files. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/Makefile | 2 +- drivers/compress/meson.build | 2 +- drivers/compress/qat/meson.build | 18 ++ drivers/compress/qat/rte_pmd_qat_

[dpdk-dev] [PATCH v6 01/16] common/qat: updated firmware headers

2018-07-12 Thread Fiona Trahe
Updated to latest firmware headers files for QuickAssist devices. Includes updates for symmetric crypto, PKE and Compression services. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_adf/icp_qat_fw.h | 69 +++- drivers/common/qat/qat_adf/icp_qat_fw_comp.h | 482 ++

[dpdk-dev] [PATCH v6 02/16] compress/qat: add makefiles for PMD

2018-07-12 Thread Fiona Trahe
Add Makefiles, directory and empty source files for compression PMD. Handle cases for building either symmetric crypto PMD or compression PMD or both and the common files both depend on. Change-Id: Ic162d05db77e3421311c7bc364e0da69be7f797c Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak

[dpdk-dev] [PATCH v6 00/16] compress/qat: add compression PMD

2018-07-12 Thread Fiona Trahe
Create compression PMD for Intel QuickAssist devices Currently only the C62x and c3xxx devices are supported. The qat comp PMD supports - stateless compression and decompression using the Deflate algorithm with Fixed Huffman encoding. Dynamic huffman encoding is not supported, it will be

Re: [dpdk-dev] [PATCH v2] add sample functions for packet forwarding

2018-07-12 Thread Pattan, Reshma
Hi Jananee, > -Original Message- > From: Parthasarathy, JananeeX M > Sent: Thursday, July 12, 2018 9:53 AM > To: dev@dpdk.org > Cc: Horton, Remy ; Pattan, Reshma > ; Parthasarathy, JananeeX M > ; Chaitanya Babu, TalluriX > > Subject: [PATCH v2] add sample functions for packet forwarding >

Re: [dpdk-dev] [PATCH v5 16/16] docs/qat: refactor docs adding compression guide

2018-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 11, 2018 12:57 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH v5 16/16] docs/qat: refactor docs adding compression guide > > Extend QAT guide to cover crypto and c

Re: [dpdk-dev] [PATCH v11 11/25] eal/dev: implement device iteration

2018-07-12 Thread Gaëtan Rivet
Hi Shreyansh, On Thu, Jul 12, 2018 at 04:28:27PM +0530, Shreyansh Jain wrote: > On Thursday 12 July 2018 03:15 AM, Gaetan Rivet wrote: > > Use the iteration hooks in the abstraction layers to perform the > > requested filtering on the internal device lists. > > > > Signed-off-by: Gaetan Rivet >

Re: [dpdk-dev] [pull-request] next-pipeline 18.08 pre-rc1

2018-07-12 Thread Thomas Monjalon
27/06/2018 19:31, Cristian Dumitrescu: > http://dpdk.org/git/next/dpdk-next-pipeline Pulled, thanks

[dpdk-dev] [PATCH v4 3/3] doc: add asym feature list

2018-07-12 Thread Shally Verma
From: Ashish Gupta Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- doc/guides/cryptodevs/features/openssl.ini | 11 +++ doc/guides/cryptodevs/openssl.rst | 1 + 2 files changed, 12 insertions(+) diff --git a/doc/guides/cryptodevs/featu

[dpdk-dev] [PATCH v4 2/3] crypto/openssl: add dh and dsa asym op

2018-07-12 Thread Shally Verma
From: Sunila Sahu - Add dh key generation and shared compute - Add dsa sign and verify operation Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/crypto/openssl/compat.h | 68 +++ drivers/crypto/openssl/rte_openssl_pmd.c

[dpdk-dev] [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op

2018-07-12 Thread Shally Verma
From: Sunila Sahu - Add compat.h to make pmd compatible to openssl-1.1.0 and backward version - Add rsa sign/verify/encrypt/decrypt and modular operation support Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/crypto/openssl/compat.h

[dpdk-dev] [PATCH v4 0/3]crypto/openssl: support asymmetric crypto

2018-07-12 Thread Shally Verma
This patch series add asymmetric crypto support in openssl pmd changes in v4: - add openssl 1.1.0h support in openssl PMD for asym operations. - A compat.h added for PMD compatibility with both 1.0.2 and 1.1.0 - update openssl document with asymmetric feature support For further history refer htt

[dpdk-dev] [PATCH 4/4] vfio: remove uneccessary IPC for group fd clear

2018-07-12 Thread Qi Zhang
Clear vfio_group_fd is not necessary to involve any IPC. Also, current IPC implementation for SOCKET_CLR_GROUP is not correct. rte_vfio_clear_group on secondary will always fail, that prevent device be detached correctly on a secondary process. The patch simply removes all IPC related stuff in rte_

[dpdk-dev] [PATCH 1/4] eal: fix hotplug add and hotplug remove

2018-07-12 Thread Qi Zhang
If hotplug add an already plugged PCI device, it will cause rte_pci_device->device.name be corrupted due to unexpected rte_devargs_remove. Also if try to hotplug remove an already unplugged device, it will cause segment fault due to unexpected bus->unplug on a rte_device whose driver is NULL. The p

[dpdk-dev] [PATCH 2/4] bus/pci: fix PCI address compare

2018-07-12 Thread Qi Zhang
When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a device. Fixes: 94c0776b1bad ("vfio: su

[dpdk-dev] [PATCH 3/4] bus/pci: enable vfio unmap resource for secondary

2018-07-12 Thread Qi Zhang
Subroutine to unmap VFIO resource is shared by secondary and primary, and it does not work on the secondary process. Since for secondary process, it is not necessary to close interrupt handler, set pci bus mastering and remove vfio_res from vfio_res_list. So, the patch adds a dedicate function to h

[dpdk-dev] [PATCH 0/4] couple hotplug fix

2018-07-12 Thread Qi Zhang
The patchset fix couple issues that related with hotplug add and hotplug remove. Qi Zhang (4): eal: fix hotplug add and hotplug remove bus/pci: fix PCI address compare bus/pci: enable vfio unmap resource for secondary vfio: remove uneccessary IPC for group fd clear drivers/bus/pci/linux/

Re: [dpdk-dev] [PATCH] eal/rwlocks: Try read/write and relock write to read locks added.

2018-07-12 Thread Thomas Monjalon
Hi, Unfortunately, after 2 months, nobody reviewed this patch. You could motivate some reviews by providing some explanations or context of use. 21/05/2018 11:08, Leonid Myravjev: > From: Leonid Myravjev > > Signed-off-by: Leonid Myravjev > --- > lib/librte_eal/common/include/generic/rte_rw

Re: [dpdk-dev] [PATCH] raw/dpaa2_qdma: fix the IOVA as VA flag for driver

2018-07-12 Thread Thomas Monjalon
21/06/2018 11:15, Hemant Agrawal: > Fixes: b1ee472fed58 ("raw/dpaa2_qdma: introduce the DPAA2 QDMA driver") > Cc: sta...@dpdk.org > > Signed-off-by: Hemant Agrawal Applied

Re: [dpdk-dev] [PATCH v3 01/16] bus/dpaa: fix phandle support for kernel 4.16

2018-07-12 Thread Thomas Monjalon
06/07/2018 10:09, Hemant Agrawal: > From: Alok Makhariya > > Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning") > Cc: Shreyansh Jain > Cc: sta...@dpdk.org > > Signed-off-by: Alok Makhariya > Acked-by: Shreyansh Jain Series applied without last patch (because must be reworked

[dpdk-dev] DPDK Release Status Meeting 12/07/2018

2018-07-12 Thread De Lara Guarch, Pablo
Minutes of 12 July 2018 --- Agenda: * Merge Deadline for 18.08 * Subtrees Participants: * Intel * Mellanox * NXP * Cavium Merge Deadline for 18.08 * *RC1* date pushed to *Friday 13 July*. * "Enable hotplug on multi-process" will not be included in 18

Re: [dpdk-dev] [PATCH v5 02/16] compress/qat: add makefiles for PMD

2018-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 11, 2018 12:57 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH v5 02/16] compress/qat: add makefiles for PMD > > Add Makefiles, directory and empty source files for

Re: [dpdk-dev] [PATCH v3 16/16] net/dpaa: implement scatter offload support

2018-07-12 Thread Thomas Monjalon
Title can be "net/dpaa: support scatter offload" 06/07/2018 10:10, Hemant Agrawal: > + /* Max packet can fit in single buffer */ > + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) { > + ; Why an empty statement? > + } else if (dev->data->dev_conf.rxmode.enable_s

Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent

2018-07-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 11, 2018 8:58 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent > > 05/07/2018 17:47, Jasvinde

[dpdk-dev] [PATCH v3] net/mlx5: add support for 32bit systems

2018-07-12 Thread Moti Haimovsky
This patch adds support for building and running mlx5 PMD on 32bit systems such as i686. The main issue to tackle was handling the 32bit access to the UAR as quoted from the mlx5 PRM: QP and CQ DoorBells require 64-bit writes. For best performance, it is recommended to execute the QP/CQ DoorBell a

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, July 12, 2018 5:32 PM > To: Burakov, Anatoly > Cc: Zhang, Qi Z ; tho...@monjalon.net; Ananyev, > Konstantin ; dev@dpdk.org; Richardson, > Bruce ; Yigit, Ferruh ; > Shelton, Benjamin H ; Vangati,

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, July 12, 2018 5:25 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > ; sta...@dpdk.org > Subject: Re: [PAT

Re: [dpdk-dev] [PATCH v2] mk: change TLS model for DPAA machine

2018-07-12 Thread Thomas Monjalon
04/07/2018 11:54, Hemant Agrawal: > From: Sachin Saxena > > Random corruptions observed on platfoms with using > the dpdk library in shared mode with VPP software (plugin). > > using traditional TLS scheme resolved the issue. > > Tested with VPP with DPDK as a plugin. > > Signed-off-by: Sachin

Re: [dpdk-dev] [PATCH v11 11/25] eal/dev: implement device iteration

2018-07-12 Thread Shreyansh Jain
On Thursday 12 July 2018 03:15 AM, Gaetan Rivet wrote: Use the iteration hooks in the abstraction layers to perform the requested filtering on the internal device lists. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 168 lib/librte_eal/com

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation for rdma-core v19

2018-07-12 Thread Shahaf Shuler
Thursday, July 12, 2018 1:54 PM, Ori Kam: > Subject: RE: [PATCH] net/mlx5: fix compilation for rdma-core v19 > > > > The flow counter support introduced by commit 9a761de8ea14 ("net/mlx5: > > flow counter support") was intend to work only with MLNX_OFED_4.3 as > > the upstream rdma-core libraries w

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation for rdma-core v19

2018-07-12 Thread Ori Kam
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Thursday, July 12, 2018 9:57 AM > To: Yongseok Koh > Cc: dev@dpdk.org; ferruh.yi...@intel.com; step...@networkplumber.org; > sta...@dpdk.org; Ori Kam > Subject: [PATCH] net/mlx5: fix compilation for rdma-c

[dpdk-dev] [PATCH v2] lib/bitratestats: add NULL sanity checks

2018-07-12 Thread Remy Horton
If rte_stats_bitrate_reg() or rte_stats_bitrate_calc() are passed NULL as the parameter for the stats structure, the result is a crash. Fixed by adding a sanity check that makes sure the passed-in pointer is not NULL. Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") Signed-off-by:

Re: [dpdk-dev] [PATCH v2] test: add unit tests for bitrate library

2018-07-12 Thread Remy Horton
Patch needs rebasing: Checking patch test/test/Makefile... error: while searching for: SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_blockcipher.c SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev.c ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y) SRCS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += tes

Re: [dpdk-dev] [PATCH 5/6] net/mlx5: add VLAN item and actions to switch flow rules

2018-07-12 Thread Adrien Mazarguil
On Wed, Jul 11, 2018 at 06:10:25PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 08:08:18PM +0200, Adrien Mazarguil wrote: > > This enables flow rules to explicitly match VLAN traffic (VLAN pattern > > item) and perform various operations on VLAN headers at the switch level > > (OF_POP_VLAN,

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: add to meson build

2018-07-12 Thread Bruce Richardson
On Thu, Jul 12, 2018 at 09:54:32AM +0200, Thomas Monjalon wrote: > 29/03/2018 16:04, Bruce Richardson: > > Add the ethtool example to the meson build. This example is more > > complicated than the previously added ones as it has files in two > > subdirectories. An ethtool "wrapper lib" in one, used

Re: [dpdk-dev] [PATCH 1/6] net/mlx5: lay groundwork for switch offloads

2018-07-12 Thread Adrien Mazarguil
On Wed, Jul 11, 2018 at 05:17:09PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 08:08:10PM +0200, Adrien Mazarguil wrote: > > With mlx5, unlike normal flow rules implemented through Verbs for traffic > > emitted and received by the application, those targeting different logical > > ports of

Re: [dpdk-dev] [PATCH 2/6] net/mlx5: add framework for switch flow rules

2018-07-12 Thread Adrien Mazarguil
On Wed, Jul 11, 2018 at 05:59:18PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 08:08:12PM +0200, Adrien Mazarguil wrote: > > Because mlx5 switch flow rules are configured through Netlink (TC > > interface) and have little in common with Verbs, this patch adds a separate > > parser function

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-12 Thread Thomas Monjalon
12/07/2018 10:05, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Review please? > > > > 31/05/2018 17:30, Honnappa Nagarahalli: > > > Validate RTE_HASH_BUCKET_ENTRIES during compilation instead of run > > > time. > > > > > > Signed-off-by: Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH v4 00/21] net/mlx5: flow rework

2018-07-12 Thread Shahaf Shuler
Thursday, July 12, 2018 12:31 PM, Nelio Laranjeiro: > Subject: [dpdk-dev] [PATCH v4 00/21] net/mlx5: flow rework > > Re-work flow engine to support port redirection actions through TC. > > This first series depends on [1] which is implemented in commit > "net/mlx5: support inner RSS computation"

Re: [dpdk-dev] [PATCH v2 0/8] Enable 32-bit native builds with meson

2018-07-12 Thread Thomas Monjalon
03/07/2018 12:31, Bruce Richardson: > This patchset enables building DPDK on 32-bit systems, and has been tested > using debian 32-bit on x86 i.e. doing an "i686" build in the old build > system. > > v2: > - fixed LIB_LIBRTE_KNI to RTE_LIBRTE_KNI in examples/kni patch [Ferruh] > - added patch to

[dpdk-dev] [PATCH v2] test: add unit tests for latencystats library

2018-07-12 Thread Jananee Parthasarathy
Unit Test Cases added for latencystats library. Dependency patch is "add sample functions for packet forwarding" Patch Link is http://patches.dpdk.org/patch/42946/ Signed-off-by: Agalya Babu RadhaKrishnan Reviewed-by: Reshma Pattan --- v2: Latency test is added to autotest_data.py. NUM_STATS

[dpdk-dev] [PATCH v2] test: add unit tests for bitrate library

2018-07-12 Thread Jananee Parthasarathy
Unit Test Cases for BitRate library. Dependency patch is "add sample functions for packet forwarding" Patch Link is http://patches.dpdk.org/patch/42946/ Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan --- v2: corrected data type for tx_portid and rx_portid --- test/test/Makefil

Re: [dpdk-dev] [PATCH v11 01/19] ethdev: add function to release port in local process

2018-07-12 Thread Andrew Rybchenko
On 12.07.2018 03:23, Zhang, Qi Z wrote: -Original Message- From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Thursday, July 12, 2018 12:05 AM To: Zhang, Qi Z ; tho...@monjalon.net; Burakov, Anatoly Cc: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce ; Yigit, Ferruh

Re: [dpdk-dev] [PATCH v11 08/25] devargs: add function to parse device layers

2018-07-12 Thread Shreyansh Jain
On Thursday 12 July 2018 03:14 AM, Gaetan Rivet wrote: This function is private to the EAL. It is used to parse each layers in a device description string, and store the result in an rte_devargs structure. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 144 +

Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing NULL point check

2018-07-12 Thread Remy Horton
Patch doesn't apply to latest master, but otherwise seems fine to me. On 02/07/2018 05:18, Qi Zhang wrote: Add missing NULL point check in ixgbe_pf_host_uninit, or it may cause segement fault when detach a device. Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Cc: sta...@d

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Gaëtan Rivet
Hi, On Thu, Jul 12, 2018 at 10:24:44AM +0100, Burakov, Anatoly wrote: > On 12-Jul-18 2:14 AM, Qi Zhang wrote: > > When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) > > is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr > > is valid. So compare the 8th b

[dpdk-dev] [PATCH v4 21/21] net/mlx5: add count flow action

2018-07-12 Thread Nelio Laranjeiro
This is only supported by Mellanox OFED. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow.c | 242 +++ 2 files changed, 244 insertions(+) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/ne

  1   2   >