On Thursday 12 July 2018 05:53 PM, Thomas Monjalon wrote:
Title can be "net/dpaa: support scatter offload"
06/07/2018 10:10, Hemant Agrawal:
+ /* Max packet can fit in single buffer */
+ if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) {
+ ;
Why an empty statement?
Its just a way of collating the cases without deep cascade. If we don't
do this, it would just mean having multiple if cases - either cascading
or segregated (non if-else). Either way achieves same result.
+ } else if (dev->data->dev_conf.rxmode.enable_scatter) {
error: ‘struct rte_eth_rxmode’ has no member named ‘enable_scatter’
As for this, it would be because of another patch on master: ab3ce1e0c19
which was not factored when the tree was reviewed. So, this is a merge
conflict. Or, maybe a rebase on an old tree before posting patches.
Also, for your comment in [1] - this patch doesn't really need a context
- it is a feature and the headline is self-explanatory for that.
[1] https://mails.dpdk.org/archives/dev/2018-July/107793.html
