Re: [dpdk-dev] [PATCH] mlx5: fix log initialization

2018-06-13 Thread Nélio Laranjeiro
On Wed, Jun 13, 2018 at 11:46:26AM -0700, Stephen Hemminger wrote: > The mlx5 driver had two init functions, but this could > cause log initialization to be done after the > other initialization. Also, the name of the function does > not match convention (cut/paste error?). Indeed an error in the

Re: [dpdk-dev] [PATCH] mk: change TLS model for ARMv8 and DPAA machine

2018-06-13 Thread Sachin Saxena
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, June 11, 2018 1:15 PM > To: Sachin Saxena > Cc: Hemant Agrawal ; dev@dpdk.org; > nitin.sax...@cavium.com; narayanaprasad.athr...@cavium.com > Subject: Re: [dpdk-dev] [PATCH] mk: change TLS mo

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-13 Thread Remy Horton
On 13/06/2018 16:39, Ferruh Yigit wrote: On 6/7/2018 9:15 AM, David Marchand wrote: Testpmd should not expect the xstats names and values arrays to be aligned: neither the arrays sizes, nor the order in which the values are. As far as I can see this assumption is everywhere in API implementa

Re: [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources

2018-06-13 Thread Hemant Agrawal
Hi Ferruh, On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote: > diff --git a/drivers/net/cxgbe/cxgbe_filter.h > b/drivers/net/cxgbe/cxgbe_filter.h > new file mode 100644 > index 0..d69c79e80 > --- /dev/null > +++ b/drivers/net/cxgbe/cxgbe_filter.h > @@ -0,0 +1,97 @@ > +/* SPDX-License-Identifie

Re: [dpdk-dev] [PATCH 06/16] crypto/cpt/base: add sym crypto request prepare for CPT

2018-06-13 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Jun 2018 22:15:15 +0530 > From: Anoob Joseph > To: Akhil Goyal , Pablo de Lara > , Thomas Monjalon > Cc: Ankur Dwivedi , Jerin Jacob > , Murthy NSSR > , Narayana Prasad > , Nithin Dabilpuram > , Ragothaman Jayaraman > , Srisivasubramanian Srinivasa

Re: [dpdk-dev] [PATCH 04/16] crypto/cpt/base: add hardware enq/deq API for CPT

2018-06-13 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Jun 2018 22:15:13 +0530 > From: Anoob Joseph > To: Akhil Goyal , Pablo de Lara > , Thomas Monjalon > Cc: Ankur Dwivedi , Jerin Jacob > , Murthy NSSR > , Narayana Prasad > , Nithin Dabilpuram > , Ragothaman Jayaraman > , Srisivasubramanian Srinivasa

Re: [dpdk-dev] [PATCH 03/16] crypto/cpt/base: add hardware initialization API for CPT

2018-06-13 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Jun 2018 22:15:12 +0530 > From: Anoob Joseph > To: Akhil Goyal , Pablo de Lara > , Thomas Monjalon > Cc: Nithin Dabilpuram , Ankur Dwivedi > , Jerin Jacob , > Murthy NSSR , Narayana Prasad > , Ragothaman Jayaraman > , Srisivasubramanian Srinivasan >

[dpdk-dev] [PATCH v1] mbuf: fix RTE_ETH_IS_IPV6_HDR comment typo

2018-06-13 Thread Haiyue Wang
It should be IPv6, not IPv4. Cc: sta...@dpdk.org Signed-off-by: Haiyue Wang --- lib/librte_mbuf/rte_mbuf_ptype.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf_ptype.h b/lib/librte_mbuf/rte_mbuf_ptype.h index 79ea314..01acc66 100644 --- a/lib/

Re: [dpdk-dev] [PATCH 02/16] crypto/cpt/base: add hardware definitions Cavium CPT

2018-06-13 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Jun 2018 22:15:11 +0530 > From: Anoob Joseph > To: Akhil Goyal , Pablo de Lara > , Thomas Monjalon > Cc: Nithin Dabilpuram , Ankur Dwivedi > , Jerin Jacob , > Murthy NSSR , Narayana Prasad > , Ragothaman Jayaraman > , Srisivasubramanian Srinivasan >

Re: [dpdk-dev] [PATCH 01/16] config: add Cavium CPT PMD skeleton

2018-06-13 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Jun 2018 22:15:10 +0530 > From: Anoob Joseph > To: Akhil Goyal , Pablo de Lara > , Thomas Monjalon > Cc: Nithin Dabilpuram , Ankur Dwivedi > , Jerin Jacob , > Murthy NSSR , Narayana Prasad > , Ragothaman Jayaraman > , Srisivasubramanian Srinivasan >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR

2018-06-13 Thread Zhao1, Wei
Hi, > -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, June 14, 2018 8:42 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR > > Hi Wei, > > > > -Original Message- > > From: Zhao1, Wei > > Sent

Re: [dpdk-dev] [PATCH] net/ixgbe: fix mask bits register set error for FDIR

2018-06-13 Thread Zhao1, Wei
Hi, wenzhuo > -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, June 14, 2018 8:53 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix mask bits register set error for FDIR > > Hi Wei, > > > -Original Message- > > From: Zhao1, We

Re: [dpdk-dev] [PATCH] net/ixgbe: fix mask bits register set error for FDIR

2018-06-13 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 13, 2018 4:12 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH] net/ixgbe: fix mask bits register set error for FDIR > > MAC address bits in mask registers should be set to z

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR

2018-06-13 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 13, 2018 4:12 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR > > Tunnel type format should be translated to ixgbe required

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel id format error for FDIR

2018-06-13 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 13, 2018 4:11 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH v2] net/ixgbe: fix tunnel id format error for FDIR > > In cloud mode for FDIR, tunnel id should be set as protocol r

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support for VLAN in IP mode FDIR

2018-06-13 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 13, 2018 4:10 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH v2] net/ixgbe: add support for VLAN in IP mode FDIR > > In IP mode FDIR, X550 can support not only 4 tuple parameter

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add query rule stats support for FDIR

2018-06-13 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, June 13, 2018 4:09 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH v2] net/ixgbe: add query rule stats support for FDIR > > There are many registeres in x550 support stats of flow dir

[dpdk-dev] Mlx meson build

2018-06-13 Thread Stephen Hemminger
Is there any chance of getting MLX drivers to build with meson? It seems like it should be possible to always build with meson if rdma-core is present. The meson build language has ways of checking for necessary dependencies. Are you working on it for 18.08? or shall I bodge something together.

[dpdk-dev] DPDK Release Status Meeting 06/07/2018

2018-06-13 Thread Mcnamara, John
DPDK Release Status Meeting 06/07/2018 == Minutes from the weekly DPDK Release Status Meeting. The DPDK Release Status Meeting is intended for DPDK Committers to discuss the status of the master tree and sub-trees, and for project managers to track progress or

[dpdk-dev] [PATCH] mlx5: fix log initialization

2018-06-13 Thread Stephen Hemminger
The mlx5 driver had two init functions, but this could cause log initialization to be done after the other initialization. Also, the name of the function does not match convention (cut/paste error?). Fix by initializing log type first at start of the pmd_init. This also gets rid of having two cons

Re: [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources

2018-06-13 Thread Wiles, Keith
> On Jun 13, 2018, at 11:59 AM, Thomas Monjalon wrote: > > 13/06/2018 18:41, Ferruh Yigit: >> On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote: >>> diff --git a/drivers/net/cxgbe/cxgbe_filter.h >>> b/drivers/net/cxgbe/cxgbe_filter.h >>> new file mode 100644 >>> index 0..d69c79e80 >>> --- /

Re: [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources

2018-06-13 Thread Thomas Monjalon
13/06/2018 18:41, Ferruh Yigit: > On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote: > > diff --git a/drivers/net/cxgbe/cxgbe_filter.h > > b/drivers/net/cxgbe/cxgbe_filter.h > > new file mode 100644 > > index 0..d69c79e80 > > --- /dev/null > > +++ b/drivers/net/cxgbe/cxgbe_filter.h > > @@ -0,0 +

Re: [dpdk-dev] [PATCH 0/7] cxgbe: add support to offload flows via rte_flow

2018-06-13 Thread Ferruh Yigit
On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote: > This series add basic support to offload flows to Chelsio T5/T6 NICs > via rte_flow API. Chelsio NICs can support wildcard (maskfull) filters > and exact (maskless) filters. Filters can be created in two regions > available on Chelsio NICs. The smaller

Re: [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources

2018-06-13 Thread Ferruh Yigit
On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote: > diff --git a/drivers/net/cxgbe/cxgbe_filter.h > b/drivers/net/cxgbe/cxgbe_filter.h > new file mode 100644 > index 0..d69c79e80 > --- /dev/null > +++ b/drivers/net/cxgbe/cxgbe_filter.h > @@ -0,0 +1,97 @@ > +/* SPDX-License-Identifier: BSD-3-Cla

[dpdk-dev] [PATCH] app/testpmd: fix crash when attaching a device

2018-06-13 Thread Adrien Mazarguil
Below commit checks global device information to determine if a port uses the softnic driver once initialized. Problem is that this information is not available at this point when a port is initialized interactively through a "port attach XXX" command, crashing testpmd. This patch systematically i

Re: [dpdk-dev] [PATCH v1] crypto/qat: add support for 8 byte 3DES

2018-06-13 Thread Trahe, Fiona
Hi Marko, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kovacevic, Marko > Sent: Tuesday, June 12, 2018 11:40 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Jain, Deepak K > ; Kovacevic, Marko ; > ma...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] crypto/qa

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-06-13 Thread Ferruh Yigit
On 2/12/2018 6:26 PM, Chas Williams wrote: > It's not clear to me that link_properties_valid() is even correct.  Nothing > prevents an adapter from later negotiating a lower speed and would fail this > test.  If both adapters are set to autoneg, that should be sufficient but > nothing enforces the

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: support TSO (TCP Segment Offload)

2018-06-13 Thread Wiles, Keith
> On Jun 12, 2018, at 11:31 AM, Ophir Munk wrote: > > This commit implements TCP segmentation offload in TAP. > librte_gso library is used to segment large TCP payloads (e.g. packets > of 64K bytes size) into smaller MTU size buffers. > By supporting TSO offload capability in software a TAP de

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-13 Thread Ferruh Yigit
On 6/7/2018 9:15 AM, David Marchand wrote: > Testpmd should not expect the xstats names and values arrays to be > aligned: neither the arrays sizes, nor the order in which the values are. As far as I can see this assumption is everywhere in API implementation: xstats names and values are aligned w

[dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-06-13 Thread Dariusz Stojaczyk
Although the alignment mechanism works as intended, the `no_align` bool flag was set incorrectly. We were aligning buffers that didn't need extra alignment, and weren't aligning ones that really needed it. Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory") Cc: anatoly.bura

Re: [dpdk-dev] [PATCH] ethdev: force RSS offload rules again

2018-06-13 Thread Thomas Monjalon
04/06/2018 09:56, Shahaf Shuler: > Sunday, June 3, 2018 5:15 PM, Ferruh Yigit: > > Subject: Re: [PATCH] ethdev: force RSS offload rules again > > > > On 6/3/2018 11:41 AM, Shahaf Shuler wrote: > > > Thursday, May 31, 2018 4:23 PM, Ferruh Yigit: > > >> Subject: [PATCH] ethdev: force RSS offload rul

Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules

2018-06-13 Thread Thomas Monjalon
08/06/2018 22:01, Thomas Monjalon: > 08/06/2018 21:51, Ferruh Yigit: > > On 5/31/2018 1:44 PM, Ferruh Yigit wrote: > > > The error path was disabled in previous release to let apps to be more > > > flexible. > > > > > > But this release they are enabled, applications have to obey offload API > > >

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix pmd crash in device probe

2018-06-13 Thread Adrien Mazarguil
On Tue, Jun 12, 2018 at 07:38:11PM +0800, Xueming Li wrote: > This patch initializes counter descriptor struct before invoking Verbs > api to avoid segment fault. > > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") > Cc: or...@mellanox.com > Cc: sta...@dpdk.org > > Signed-off-by: Xueming L

Re: [dpdk-dev] 16.11.7 (LTS) patches review and test

2018-06-13 Thread Luca Boccassi
On Fri, 2018-06-08 at 10:17 +0100, Luca Boccassi wrote: > On Thu, 2018-05-31 at 11:25 +0100, Luca Boccassi wrote: > > Hi all, > > > > Here is a list of patches targeted for LTS release 16.11.7. Please > > help review and test. The planned date for the final release is > > Monday, > > June the 11th

Re: [dpdk-dev] [PATCH 01/22] eal: introduce one device scan

2018-06-13 Thread Zhang, Qi Z
Hi Shreyansh: Thanks for your review. Will fix base on your comments in v2. Regards Qi > -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Friday, June 8, 2018 7:12 PM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; Burakov, Anatoly ; > Ananyev

Re: [dpdk-dev] [PATCH 02/22] bus/vdev: enable one device scan

2018-06-13 Thread Zhang, Qi Z
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Friday, June 8, 2018 8:08 PM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; Burakov, Anatoly ; > Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati,

Re: [dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port representors

2018-06-13 Thread Adrien Mazarguil
On Tue, Jun 12, 2018 at 02:44:12PM +, Xueming(Steven) Li wrote: > > + if (dpdk_dev->devargs) { > > + ret = rte_eth_devargs_parse(dpdk_dev->devargs->args, ð_da); > > + if (ret) > > + goto error; > > + } else { > > + memset(ð_da, 0, sizeof(eth_

[dpdk-dev] [PATCH v3 38/38] crypto/qat: remove configurable max number of sessions

2018-06-13 Thread Tomasz Jozwiak
This patch removes CONFIG_RTE_QAT_PMD_MAX_NB_SESSIONS from common_base, config/rte_config.h files and defines QAT_SYM_PMD_MAX_NB_SESSIONS inside qat_sym_pmd.h file instead. Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe --- config/common_base | 5 - config/rte_config.h

[dpdk-dev] [PATCH v3 35/38] crypto/qat: make response process function inline

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Optimize the dequeue function by inlining the response processing function, assuming only symmetric operations are supported. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 4 +- drivers/crypto/qat/qat_qp.h | 5 -- dr

[dpdk-dev] [PATCH v3 37/38] doc/qat: specify QAT driver and device name formats

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Document the driver and device naming formats. Changed the underscores alignment. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- doc/guides/cryptodevs/qat.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/

[dpdk-dev] [PATCH v3 36/38] crypto/qat: check for service type

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Other services, apart from symmetric crypto, such as compression, will be added in future patches. Therefore, the assumption that only symmetric crypto operations are processed will not be valid anymore, and service type needs to be checked. Signed-off-by: Tomasz Jozwiak Signe

[dpdk-dev] [PATCH v3 34/38] crypto/qat: remove unused arguments

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Process response function is only implemented for crypto symmetric operations, which do not require some of the arguments. Therefore, these arguments can be removed from the function prototype. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/crypto/qat/q

[dpdk-dev] [PATCH v3 33/38] crypto/qat: optimize adf modulo function

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 19 --- drivers/crypto/qat/qat_qp.h | 2 +- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/qat/qat_qp.c b/drivers/crypto/qat/qat_qp.c in

[dpdk-dev] [PATCH v3 32/38] crypto/qat: add max PCI devices to config file

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Added CONFIG_RTE_PMD_QAT_MAX_PCI_DEVICES to build config files. Signed-off-by: Tomasz Jozwiak --- config/common_base | 5 - config/rte_config.h | 2 ++ drivers/crypto/qat/qat_device.c | 8 drivers/crypto/qat/qat_device.h | 2 -- 4 files c

[dpdk-dev] [PATCH v3 30/38] crypto/qat: move macro to common file

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe QAT_64_BTYE_ALIGN_MASK macro is not specific to symmetric crypto, but it is common for other future services. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/crypto/qat/qat_common.h | 2 ++ drivers/crypto/qat/qat_sym.h| 2 -- 2 files changed, 2 inser

[dpdk-dev] [PATCH v3 31/38] crypto/qat: register appropriately named device

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe For every QAT PCI device probed, populate a local rte_device containing an rte_driver. The rte_driver was created in a previous patch to provide a crypto-specific driver name: "crypto_qat". This was previously only used for driver registration, now it's also used in device creat

[dpdk-dev] [PATCH v3 29/38] crypto/qat: remove unused macro

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/crypto/qat/qat_sym.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h index d887dc126..e46448bd2 100644 --- a/drivers/crypto/qat/qat_sym.h

[dpdk-dev] [PATCH v3 28/38] crypto/qat: free cookie pool on queue creation error

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/crypto/qat/qat_qp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/qat/qat_qp.c b/drivers/crypto/qat/qat_qp.c index 9938c1493..569eace57 100644 --- a/drivers/crypto/qat/qat_qp.c +++ b/

[dpdk-dev] [PATCH v3 27/38] crypto/qat: modify debug message

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Removed crypto reference in common debug message. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/crypto/qat/qat_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_common.c b/drivers/crypto/qat/qat_common.

[dpdk-dev] [PATCH v3 25/38] crypto/qat: remove incorrect usage of bundle number

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe As bundle_num is included in qat_gen1_qps static array there shouldn't be a multiplier used in qat_qps_per_service() Then removed ADF_NUM_BUNDLES_PER_DEV as no longer used. Also renamed ADF_MAX_QPS_PER_BUNDLE to ADF_MAX_QPS_ON_ANY_SERVICE and reduced from 4 to 2 which is enough

[dpdk-dev] [PATCH v3 26/38] crypto/qat: rename variables

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Renamed sgl_cookie to cookie and qp_gen_config to qat_gen_config, as it is intended to hold more than just queue pair data. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/crypto/qat/qat_device.c | 2 +- drivers/crypto/qat/qat_device.h | 2 +- driver

[dpdk-dev] [PATCH v3 23/38] crypto/qat: move code into appropriate files

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Move all code into appropriate files, no actual code changes. Specifically: - Rename rte_qat_cryptodev.c to qat_sym_pmd.c - Create qat_sym_pmd.h and populate with fn prototypes for qat_sym_pmd.c - Create qat_comp_pmd.c/.h and populate with placeholder functions - Create qat_

[dpdk-dev] [PATCH v3 22/38] crypto/qat: rename functions which depend on cryptodev

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Rename all device functions which depend on cryptodev structs. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_device.c| 8 drivers/crypto/qat/qat_device.h| 8 drivers/crypto/qat/rte_qat_cryptodev.c | 8 3 files changed, 12 ins

[dpdk-dev] [PATCH v3 18/38] crypto/qat: add QAT PCI device struct

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe - Added struct qat_pci_device to use internally in QAT PMD to avoid dependencies on rte_cryptodev or rte_compressdev - Added a global array of these - Restructured probe/release to separate QAT common init/clear from crypto pmd create/destroy. - In QAT common part alloc

[dpdk-dev] [PATCH v3 24/38] crypto/qat: add lock around csr access and change logic

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Add lock around accesses to the arbiter CSR and use & instead of ^ as ^ not safe if arb_disable called when already disabled. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --g

[dpdk-dev] [PATCH v3 20/38] crypto/qat: move to using new device structure

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Struct qat_pmd_private held the data needed by cryptodev, common code now gets most data from struct qat_pci_device instead. qat_pmd_private is trimmed to hold only sym crypto data and renamed qat_sym_private to reflect its usage. Specifically - remove max_nb_queue_pairs from q

[dpdk-dev] [PATCH v3 21/38] crypto/qat: use common stats structures

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Split qat_sym_stats_get/reset into 2 functions, a wrapper function calling a new qat_stats_get/reset function which can be called per service. Remove cryptodev stats struct from qat_qp, replace with qat_common_stats. Add links for qat_qp into qat_pci_device using an array per se

[dpdk-dev] [PATCH v3 14/38] crypto/qat: move defines from sym to qp header file

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Move defines related to coalescing from sym header file to qp header file as these will be common for all services. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.h | 7 +++ drivers/crypto/qat/qat_sym.h | 7 --- 2 files changed, 7 insertions(+), 7 deletions

[dpdk-dev] [PATCH v3 19/38] crypto/qat: use generic driver name for PCI registration

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe The QAT PMD used to register with PCI using the name "crypto_qat". Keep this name for the driver registered with cryptodev and use a more generic name "qat" for the PCI registration. This paves the way for the PCI device to host other services. Signed-off-by: Fiona Trahe ---

[dpdk-dev] [PATCH v3 16/38] crypto/qat: rename sgl related objects

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Change SGL (Scatter-Gather List) related structs and member names Signed-off-by: ArkadiuszX Kusztal --- drivers/crypto/qat/qat_common.h | 10 +- drivers/crypto/qat/qat_sym.c| 28 ++-- 2 files changed, 19 insertions(+), 19 deletions(-) diff

[dpdk-dev] [PATCH v3 17/38] crypto/qat: move sgl related element to appropriate files

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Move SGL (Scatter-Gather List) related functions to common file Move qat_sym_op_cookie struct to sym header file Signed-off-by: ArkadiuszX Kusztal Signed-off-by: Fiona Trahe --- drivers/crypto/qat/Makefile | 1 + drivers/crypto/qat/meson.build | 1 + drivers/crypto/qa

[dpdk-dev] [PATCH v3 15/38] crypto/qat: create structures to support various generations

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Create data structures to support different generations of qat hardware supplying services through different queue pairs. - Add two new structs qat_gen_hw_data and qat_qp_hw_dat - Add a qat_service_type enum An array of qat_qp_hw_data elements is initialised with constants, th

[dpdk-dev] [PATCH v3 11/38] crypto/qat: separate sym-specific from generic qp setup

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Extracted all sym-specific code from qp setup fns, leaving generic qat_qp_setup fn and helper fns. Created a new meta-data struct qat_qp_config to hold all the data needed to create a qp, filled this out in the sym-specific code and passed to the generic qp_setup fn. No need now

[dpdk-dev] [PATCH v3 12/38] crypto/qat: move sym-specific qp code to sym file

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Move sym qp setup code from qat_qp.c to qat_sym.c Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 78 ++-- drivers/crypto/qat/qat_qp.h | 6 +++ drivers/crypto/qat/qat_sym.c | 75 ++ 3 files change

[dpdk-dev] [PATCH v3 08/38] crypto/qat: make enqueue function generic

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Queue-handling code in enqueue is made generic, so it can be used by other services in future. This is done by - Removing all sym-specific refs in input params - replace with void ptrs. - Wrapping this generic enqueue with the sym-specific enqueue called through the API. -

[dpdk-dev] [PATCH v3 13/38] crypto/qat: remove dependencies on cryptodev from common

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Remove dependence on rte_cryptodev from common qp code to facilitate being used by other device types in future. Transferred required data into qat-specific structures. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_device.h| 11 - drivers/crypto/qat/qat_qp

[dpdk-dev] [PATCH v3 09/38] crypto/qat: make dequeue function generic

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Queue-handling code in dequeue is made generic, so it can be used by other services in future. This is done by - Removing all sym-specific refs in input params - replace with void ptrs. - Wrapping this generic dequeue with the sym-specific dequeue called through the API. -

[dpdk-dev] [PATCH v3 10/38] crypto/qat: move generic qp fn to qp file

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Move the generic enqueue and dequeue fns from the qat_sym.c file to the qat_qp.c file Move generic qp structs to a new qat_qp.h file Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_qp.c | 152 +++ drivers/crypto/qat/qat_qp.h | 63 +

[dpdk-dev] [PATCH v3 04/38] crypto/qat: add symmetric session file

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe This commit adds qat_sym_session.c/h files and moves objects from qat_algs_build_desc and qat_algs.h Following objects were moved: qat_adf/qat_algs_build_desc.c => qat_sym_session.c - all objects - qat_adf/qat_algs.h => qat_sym_session.h - enum qat_crypto_proto_flag - struct qa

[dpdk-dev] [PATCH v3 05/38] crypto/qat: change filename crypto to sym

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe This commit renames qat_crypto.c/h to qat_sym.c/h And makes a few whitespace changes to resolve line-length issues. Signed-off-by: ArkadiuszX Kusztal Signed-off-by: Fiona Trahe --- drivers/crypto/qat/Makefile | 2 +- drivers/crypto/qat/meson.build

[dpdk-dev] [PATCH v3 06/38] crypto/qat: rename fns for consistency

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe Rename fn names to shorten them, i.e. qat_crypto_sym_xxx to qat_sym_xxx _content_desc_ to _cd_ Renaming symmetric crypto specific with consistent names: qat_crypto_set_session_parameters->qat_sym_set_session_parameters qat_write_hw_desc_entry()->qat_sym_build_request()

[dpdk-dev] [PATCH v3 07/38] crypto/qat: renamed sym-specific structs

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe qat_session -> qat_sym_session qat_crypto_proto_flag -> qat_sym_proto_flag qat_alg_cd-> qat_sym_cd qat_crypto_op_cookie -> qat_sym_op_cookie qat_gen1_capabilities -> qat_gen1_sym_capabilities qat_gen2_capabilities -> qat_gen2_sym_capabilities Signed-off-b

[dpdk-dev] [PATCH v3 01/38] crypto/qat: add qat common header

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe This commit adds qat_common.h header file. Following objects were moved to it: qat_algs.h =>. qat_common.h - struct qat_alg_buf - struct qat_alg_buf_list - struct qat_crypto_op_cookie - QAT_SGL_MAX_NUMBER qat_crypto.h => qat_common.h - CRYPTODEV_NAME_QAT_SYM_PMD Signed-off-by:

[dpdk-dev] [PATCH v3 03/38] crypto/qat: remove unused includes

2018-06-13 Thread Tomasz Jozwiak
This commit removes unused includes from qat_crypto.c Signed-off-by: ArkadiuszX Kusztal Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/crypto/qat/qat_crypto.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/crypto/qat/qat_crypto.c b/driv

[dpdk-dev] [PATCH v3 00/38] crypto/qat: refactor to support multiple services

2018-06-13 Thread Tomasz Jozwiak
From: Pablo de Lara The QAT crypto PMD was peppered with references to rte_cryptodev artefacts. Also the pci device it presented to the API layer was entirely owned by the one cryptodev device instance created by the probe. This patchset refactors the PMD so one pci device can present out multipl

[dpdk-dev] [PATCH v3 02/38] crypto/qat: add qat device files

2018-06-13 Thread Tomasz Jozwiak
From: Fiona Trahe This commit adds new qat_device file. Following objects were moved: qat_crypto.h => qat_device.h - struct qat_pmd_private - uint8_t cryptodev_qat_driver_id - int qat_crypto_sym_qp_release (EXTERN) - int qat_dev_config() - int qat_dev_start() - void qat_dev_stop() - int qat_dev_

[dpdk-dev] [PATCH] Use SPDX license tag

2018-06-13 Thread Chao Zhu
Signed-off-by: Chao Zhu --- drivers/net/i40e/i40e_rxtx_vec_altivec.c | 35 ++ lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 34 ++--- lib/librte_eal/common/arch/ppc_64/rte_cycles.c | 4 +++ .../common/include/arch/ppc_64/rte_atomic.h

[dpdk-dev] [PATCH] vhost: introduce new function helper

2018-06-13 Thread xiangxia . m . yue
From: Tonghao Zhang Introduce an new common helper to avoid redundancy. Signed-off-by: Tonghao Zhang --- lib/librte_vhost/vhost.c | 27 +-- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 23 ++- 3 files changed, 20 inserti

[dpdk-dev] [PATCH 2/2] net/ifc: add to meson build

2018-06-13 Thread Xiao Wang
Signed-off-by: Bruce Richardson Signed-off-by: Xiao Wang --- drivers/net/ifc/meson.build | 7 +++ drivers/net/meson.build | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ifc/meson.build diff --git a/drivers/net/ifc/meson.build b/drivers/net/ifc/me

[dpdk-dev] [PATCH 1/2] net/ifc: make driver name consistent

2018-06-13 Thread Xiao Wang
Make the compiler switch name and document name consistent as ``ifc`` to avoid confusion. Also rename the map file to standard name for meson build in the process. Signed-off-by: Xiao Wang Signed-off-by: Bruce Richardson --- MAINTAINERS | 4

[dpdk-dev] [PATCH 0/2] add ifc driver to meson build

2018-06-13 Thread Xiao Wang
The first patch unifies the driver name in compiler flag, document. The second patch adds ifc driver to meson build. Xiao Wang (2): net/ifc: make driver name consistent net/ifc: add to meson build MAINTAINERS | 4 ++-- config/common_base

Re: [dpdk-dev] [PATCH v2] net/pcap: rx_iface_in stream type support

2018-06-13 Thread Ferruh Yigit
On 6/5/2018 6:10 PM, Ido Goshen wrote: > The problem is if a dpdk app uses the same iface(s) both as rx_iface and > tx_iface then it will receive back the packets it sends. > If my app sends a packet to portid=X with rte_eth_tx_burst() then I wouldn't > expect to receive it back by rte_eth_rx_bur

Re: [dpdk-dev] [PATCH 0/7] Make unit tests great again

2018-06-13 Thread Bruce Richardson
On Wed, Jun 13, 2018 at 09:38:32AM +0100, Burakov, Anatoly wrote: > On 12-Jun-18 2:07 PM, Thomas Monjalon wrote: > > +Cc Jananee > > > > 07/06/2018 23:01, Anatoly Burakov: > > > Previously, unit tests were running in groups. There were > > > technical reasons why that was the case (mostly having t

Re: [dpdk-dev] [PATCH v2 08/15] net/ifc: rename to ifcvf

2018-06-13 Thread Bruce Richardson
On Wed, Jun 13, 2018 at 03:46:05AM +0100, Wang, Xiao W wrote: > Hi Bruce, > > > -Original Message- > > From: Richardson, Bruce > > Sent: Saturday, June 9, 2018 5:21 AM > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; Wang, Xiao W > > > > Subject: [PATCH v2 08/15] net/ifc: rename to ifcvf

Re: [dpdk-dev] [PATCH 3/6] cryptodev: remove max number of sessions

2018-06-13 Thread Tomasz Duszynski
On Wed, Jun 13, 2018 at 08:23:36AM +, De Lara Guarch, Pablo wrote: > Hi Tomasz, > > > -Original Message- > > From: Tomasz Duszynski [mailto:t...@semihalf.com] > > Sent: Wednesday, June 13, 2018 7:12 AM > > To: De Lara Guarch, Pablo > > Cc: Tomasz Duszynski ; Doherty, Declan > > ; akhil

Re: [dpdk-dev] [PATCH 2/2] maintainers: add Vhost and Virtio co-maintainers

2018-06-13 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Tuesday, June 12, 2018 4:01 PM > To: mtetsu...@gmail.com; Bie, Tiwei ; Wang, Zhihong > ; dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; Maxime > Coquelin > Subject: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH] cryptodev: fix ABI breakage

2018-06-13 Thread Gujjar, Abhinandan S
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, June 13, 2018 3:07 PM > To: Doherty, Declan ; Gujjar, Abhinandan S > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] cryptodev: fix ABI breakage > > In 17.08, the crypto operation was

[dpdk-dev] missing vq->log_cache_nb_elem ++ ?

2018-06-13 Thread HePeng
Hi, In the latest dpdk master branch, in the function *vhost_log_cache_page*: static __rte_always_inline void vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq, uint64_t page) { uint32_t bit_nr = page % (sizeof(unsigned long) << 3);

Re: [dpdk-dev] [PATCH] cryptodev: fix ABI breakage

2018-06-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, June 13, 2018 10:37 AM > To: Doherty, Declan ; Gujjar, Abhinandan S > > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] cryptodev: fix

Re: [dpdk-dev] [RFC v3 0/7] vhost2: new librte_vhost2 proposal

2018-06-13 Thread Dariusz Stojaczyk
Hi Stefan, I'm sorry for the late response. My email client filtered out this mail. I fixed it just now. pt., 8 cze 2018 o 15:29 Stefan Hajnoczi napisał(a): > > On Thu, Jun 07, 2018 at 05:12:20PM +0200, Dariusz Stojaczyk wrote: > > The proposed structure for the new library is described below. >

[dpdk-dev] [PATCH] cryptodev: fix ABI breakage

2018-06-13 Thread Pablo de Lara
In 17.08, the crypto operation was restructured, and some reserved bytes (5) were added to have the mempool pointer aligned to 64 bits, since the structure is expected to be aligned to 64 bits, allowing future additions with no ABI breakage needed. In 18.05, a new 2-byte field was added, so the r

Re: [dpdk-dev] [dpdk-stable] 18.02.2 patches review and test

2018-06-13 Thread Luca Boccassi
On Wed, 2018-06-13 at 08:56 +0200, Marco Varlese wrote: > Luca, > > I ran some smoke tests on 18.02.2 / 17.11.3 and 16.11.7 using > test_pmd and found > no issues with these snapshots.  > > Further, I ran some tests via OvS-DPDK and VPP (DPDK accelerated) > using the > aforementioned snapshots an

Re: [dpdk-dev] [PATCH 2/2] maintainers: add Vhost and Virtio co-maintainers

2018-06-13 Thread Wang, Zhihong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, June 12, 2018 4:01 PM > To: mtetsu...@gmail.com; Bie, Tiwei ; Wang, Zhihong > ; dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; Maxime > Coquelin > Subject: [PATCH 2/2] maintainers:

Re: [dpdk-dev] [PATCH 2/2] maintainers: add Vhost and Virtio co-maintainers

2018-06-13 Thread Tiwei Bie
On Tue, Jun 12, 2018 at 10:01:27AM +0200, Maxime Coquelin wrote: > Add Tiwei and Zhihong as co-maintainers for the Vhost and > Virtio components. They have done great contributions recently, > and been very helpfull in helping to review Vhost and Virtio > series. > > Also, add Tiwei as backup for

Re: [dpdk-dev] [PATCH 0/7] Make unit tests great again

2018-06-13 Thread Burakov, Anatoly
On 12-Jun-18 2:07 PM, Thomas Monjalon wrote: +Cc Jananee 07/06/2018 23:01, Anatoly Burakov: Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script.

[dpdk-dev] [PATCH] net/ixgbe: fix mask bits register set error for FDIR

2018-06-13 Thread Wei Zhao
MAC address bits in mask registers should be set to zero when the is mac mask is 0xFF, otherwise if it is 0x0 these bits should be to 0x3F. Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_fdir.c | 12 +--- 1 fil

[dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR

2018-06-13 Thread Wei Zhao
Tunnel type format should be translated to ixgbe required format before register set in FDIR cloud mode, Ans also some register not useful in cloud mode but only useful in IP mode should be set to zero as datasheet request. Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550") Fi

[dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel id format error for FDIR

2018-06-13 Thread Wei Zhao
In cloud mode for FDIR, tunnel id should be set as protocol request, the lower 8 bits should be set as reserved. Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550") Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Signed-off-by: Wei Zhao --- v2: -fix tni bit for

[dpdk-dev] [PATCH v2] net/ixgbe: add support for VLAN in IP mode FDIR

2018-06-13 Thread Wei Zhao
In IP mode FDIR, X550 can support not only 4 tuple parameters but also vlan tci in protocol, so add this feature to flow parser. Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Signed-off-by: Wei Zhao --- v2: -fix item check error in v1. --- drivers/net/ixgbe/ixgbe_flow.c | 3 ++

[dpdk-dev] [PATCH v2] net/ixgbe: add query rule stats support for FDIR

2018-06-13 Thread Wei Zhao
There are many registeres in x550 support stats of flow director filters, for example the number of added or removed rules and the number match or miss match packet count for this for port, all these important information can be read form registeres in x550 and display with command xstats. Signed-

  1   2   >