Hi Ferruh, On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote: > diff --git a/drivers/net/cxgbe/cxgbe_filter.h > b/drivers/net/cxgbe/cxgbe_filter.h > new file mode 100644 > index 000000000..d69c79e80 > --- /dev/null > +++ b/drivers/net/cxgbe/cxgbe_filter.h > @@ -0,0 +1,97 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2014-2018 Chelsio Communications. > + * All rights reserved. > + */ > +
Hi Rahul, This is a new file and copyright starts from 2014, is this intentional? And @Thomas, @Hemant, are we allowed to have copyright start date in the past for new files? [Hemant] It is good to ask the submitter to re-check on the copyright year. But they can decide which copyright year they want to put on the files. Typically copyright start can be when the part of the code originated/written first time irrespective of submission to DPDK. Some companies also requires that you keep on updating the copyright year when you are changing the code. While others think that git history is sufficient to keep that track, you need not to update the copyright year. Regards, Hemant
