On Tue, Apr 17, 2018 at 11:14:34PM +0800, Xueming Li wrote:
> Signed-off-by: Xueming Li
Acked-by: Nelio Laranjeiro
> ---
> drivers/net/mlx5/mlx5_flow.c | 99
> +++-
> drivers/net/mlx5/mlx5_rxtx.c | 3 +-
> 2 files changed, 99 insertions(+), 3 deletions
On Tue, Apr 17, 2018 at 11:14:33PM +0800, Xueming Li wrote:
> Dump verb flow detail including flow spec type and size for debugging
> purpose.
>
> Signed-off-by: Xueming Li
> ---
> drivers/net/mlx5/mlx5_flow.c | 68
> ---
> drivers/net/mlx5/mlx5_rxq.c
On Tue, Apr 17, 2018 at 11:14:32PM +0800, Xueming Li wrote:
> Tunnel RSS level of flow RSS action offers user a choice to do RSS hash
> calculation on inner or outer RSS fields. Testpmd flow command examples:
>
> GRE flow inner RSS:
> flow create 0 ingress pattern eth / ipv4 proto is 47 / gre /
On Tue, Apr 17, 2018 at 11:14:29PM +0800, Xueming Li wrote:
> This patch introduced tunnel type identification based on flow rules.
> If flows of multiple tunnel types built on same queue,
> RTE_PTYPE_TUNNEL_MASK will be returned, user application could use bits
> in flow mark as tunnel type identi
Hi Ferruh,
On 4/17/2018 7:26 PM, Ferruh Yigit wrote:
On 4/17/2018 5:54 AM, Tiwei Bie wrote:
On Mon, Apr 16, 2018 at 05:10:24PM +0100, Ferruh Yigit wrote:
On 4/14/2018 11:55 AM, Tiwei Bie wrote:
On Fri, Apr 13, 2018 at 10:53:55PM +0100, Ferruh Yigit wrote:
On 4/10/2018 4:41 PM, Tiwei Bie wro
On Tue, Apr 17, 2018 at 11:14:28PM +0800, Xueming Li wrote:
> This patch support L3 VXLAN, no inner L2 header comparing to standard
> VXLAN protocol. L3 VXLAN using specific overlay UDP destination port to
> discriminate against standard VXLAN, FW has to be configured to support
> it:
> sudo mlxc
On Tue, Apr 17, 2018 at 10:18:22PM +0200, Thomas Monjalon wrote:
> 16/04/2018 18:22, Adrien Mazarguil:
> > This patch replaces C99-style flexible arrays in struct rte_flow_action_rss
> > and struct rte_flow_item_raw with standard pointers to the same data.
> >
> > They proved difficult to use in t
On Tue, Apr 17, 2018 at 11:39:13AM -0700, Yongseok Koh wrote:
> The memory region is [start, end), so if the memseg of 'end' isn't
> allocated yet, the returned memseg will have zero entries and this will
> make 'end' zero (nil).
>
> Fixes: 718e35999c96 ("net/mlx5: use virt2memseg instead of itera
Hi Akhil,
Please find the comments inline.
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Tuesday, April 17, 2018 7:48 PM
> To: Gujjar, Abhinandan S ;
> jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Dohert
Enable the VFIO based accelerator support in vhost-user.
When a vDPA device is attached, vhost user will try to
ask QEMU to do further setup to allow the notifications
to be delivered between the driver in the guest and the
vDPA device in the host directly.
Signed-off-by: Tiwei Bie
---
This patch
-Original Message-
> Date: Mon, 16 Apr 2018 10:44:47 +
> From: Nitin Saxena
> To: Jerin Jacob
> Cc: Nitin Saxena , Narayana Prasad
> , dev@dpdk.org
> Subject: [PATCH] net/thunderx: fix MTU configuration for jumbo pkts
> X-Mailer: git-send-email 2.7.4
>
> thunderx pmd driver passes d
Hello Ferruh,
> On 4/17/2018 1:53 PM, Juhamatti Kuusisaari wrote:
> > Support for PCAP MAC address using physical interface MAC.
> > Support for getting proper link status, speed and duplex.
> >
> > Signed-off-by: Juhamatti Kuusisaari
> > ---
> > config/common_base | 1 +
> > drive
The hugedir returned by get_hugepage_dir is allocated by strdup
but not released. Replace snprintf with a more suitable strlcpy.
Coverity issue: 272585
Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary")
Signed-off-by: Yangchao Zhou
Acked-by: Anatoly Burakov
---
lib/librte_
Thanks to point this out. I agree for the title change.
Do you want me to send v2 patch? Or you can handle it when committing?
> > > Sometimes gcc does not inline the function despite keyword *inline*,
> > > we obeserve rte_movX is not inline when doing performance profiling,
> > > so use *alway
Hi, Adrien Mazarguil,
Thanks for your reply very much.
It means in our tests, when ‘ifconfig eth7 down’, the expect result is the
bond primary netdevice will switch to eth8.
However, we find the bond primary is not changed to eth8 in 19 times of 20
time tests., and it means the dpdk bond d
JUMBO_FRAME offload should be set as default,
missing it will lead to start failing for I40e.
Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu
---
v2:
add fix commit
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
On Tue, Apr 17, 2018 at 7:00 PM, Ferruh Yigit wrote:
> On 3/22/2018 1:01 PM, xiangxia.m@gmail.com wrote:
>> From: Tonghao Zhang
>>
>> Set EITR interval as default. This patch can improve the
>> performance when we enable the rx-intrrupt to process the
>> packets because we hope rx-intrrupt re
A local variable was used without initialization and triggered a
coverity issue.
Is is fixed here, but there is no ill effect of not initializing
the variable in this case. 'rxq_interrupt_offset' is irrelevant
if 'rxq_interrupt_enable' is not set (the condition caught by
coverity).
Fixes: fc2c8c0
A local variable was used without initialization and triggered a coverity
issue.
Is is fixed here, but there is no ill effect of not initializing the
variable in this case. 'rxq_interupt_offset' is irrelevant if
'rxq_interrupt_enable' is not set (the condition caught by coverity).
Fixes: fc2c8c06
> > The original code replies on the private channel for primary and secondary
> > communication. Change to use the generic multi-process channel.
> >
> > Note with this change, dpdk-pdump will be not compatible with old version
> > DPDK applications.
> >
> > Cc: reshma.pat...@intel.com
> >
> >
15/04/2018 17:06, Jianfeng Tan:
> Previously, vfio uses its own private channel for the secondary
> process to get container fd and group fd from the primary process.
>
> This patch changes to use the generic mp channel.
>
> Test:
> 1. Bind two NICs to vfio-pci.
>
> 2. Start the primary and
03/04/2018 15:04, Olivier Matz:
> To avoid code duplication, add a parameter to rte_ctrl_thread_create()
> to specify the name of the thread.
There are some "stats thread" in following examples which could
benefit from this new API:
examples/tep_termination/
examples/vhost/
05/04/2018 17:33, Thomas Monjalon:
> Some DPDK applications wrongly assume these requirements:
> - no hotplug, i.e. ports are never detached
> - all allocated ports are available to the application
>
> Such application iterates over ports by its own mean.
> The most common pattern is to reques
> > > > > > > > > > The initial objective of
> > > > > > > > > > commit d9f0d3a1ffd4 ("ring: remove split cacheline build
> > > > > > > > > > setting")
> > > > > > > > > > was to add an empty cache line betwee, the producer and
> > > > > > > > > > consumer
> > > > > > > > > > data (on platform wi
18/04/2018 00:11, Scott Branden:
> On 18-04-17 03:06 PM, Thomas Monjalon wrote:
> > 17/04/2018 23:49, Stephen Hemminger:
> >> IMHO would have been better to use the kernel SPDX style and
> >> keep the check but that appears to be a minority opinion.
> >
> > I think it is better to work on checkpat
On 18-04-17 03:06 PM, Thomas Monjalon wrote:
17/04/2018 23:49, Stephen Hemminger:
IMHO would have been better to use the kernel SPDX style and
keep the check but that appears to be a minority opinion.
I think it is better to work on checkpatch itself.
When defining our SPDX style, Linux one w
17/04/2018 23:49, Stephen Hemminger:
> IMHO would have been better to use the kernel SPDX style and
> keep the check but that appears to be a minority opinion.
I think it is better to work on checkpatch itself.
When defining our SPDX style, Linux one was not definitive.
Do you think we can ask the
17/04/2018 16:24, Xueming Li:
> + /* Check that device supports requested rss hash functions. */
> + if ((dev_info.flow_type_rss_offloads |
> + dev_conf->rx_adv_conf.rss_conf.rss_hf) !=
> + dev_info.flow_type_rss_offloads) {
> + RTE_PMD_DEBUG_TRACE("ethdev port_
From: Stephen Hemminger
The driver supports Hyper-V networking directly like
virtio for KVM or vmxnet3 for VMware.
This code is based off of the FreeBSD driver. The file and variable
names are kept the same to help with understanding (with most of the
BSD style warts removed).
Signed-off-by: St
Update meson build files for new netvsc and vmbus drivers.
Signed-off-by: Stephen Hemminger
---
config/meson.build | 7 +++
drivers/bus/meson.build| 2 +-
drivers/bus/vmbus/meson.build | 17 +
drivers/net/meson.build| 2 +-
drivers/net/netvsc/m
Matching documentation for new netvsc device.
Signed-off-by: Stephen Hemminger
---
doc/guides/nics/index.rst | 1 +
doc/guides/nics/netvsc.rst | 97 ++
doc/guides/rel_notes/release_18_05.rst | 6 ++
3 files changed, 104 insertions(+)
create mod
From: Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS
(VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016
and Azure. Most of this code was extracted from FreeBSD and some of
this is from earlier code donated by Brocade.
Only Linux is supported
This is a revised version of the Hyper-V native bus (VMBus)
and network device (netvsc) drivers. This virtual device
is used in Microsoft Hyper-V in Windows 10, Windows Server 2016
and Azure. Most of this code was extracted from FreeBSD and some of
this is from earlier code donated by Brocade.
Onl
Since DPDK developers have decided to use a different tag format
than the kernel developers, ignore warnings about SPDX tags.
Signed-off-by: Stephen Hemminger
---
IMHO would have been better to use the kernel SPDX style and
keep the check but that appears to be a minority opinion.
devtools/chec
17/04/2018 16:47, Xueming Li:
> This patch introduce new TX offload flags for device that supports
> IP or UDP tunneled packet L3/L4 checksum and TSO offload.
>
> The support from the device is for inner and outer checksums on
> IPV4/TCP/UDP and TSO for *any packet with the following format*:
>
>
On 4/17/18 4:46 PM, Stephen Hemminger wrote:
On Tue, 17 Apr 2018 13:01:14 -0700
Jim Murphy wrote:
Still used in certain memory constrained environments.
On Tue, Apr 17, 2018 at 11:39 AM, David Harton (dharton)
wrote:
It is used and tested in production and non-production environments.
Re
17/04/2018 17:04, Xueming Li:
> +struct rte_flow_item_vxlan_gpe {
> + uint8_t flags; /**< Normally 0x0c (I and P flags). */
> + uint8_t rsvd0[2]; /**< Reserved, normally 0x. */
> + uint8_t protocol; /**< Protocol type. */
> + uint8_t vni[3]; /**< VXLAN identifier. */
> + uin
On Tue, 17 Apr 2018 13:01:14 -0700
Jim Murphy wrote:
> Still used in certain memory constrained environments.
>
>
> On Tue, Apr 17, 2018 at 11:39 AM, David Harton (dharton)
> wrote:
>
> > It is used and tested in production and non-production environments.
> >
> > Regards,
> > Dave
> >
> >
On Tue, Apr 17, 2018 at 06:31:07PM +, Stephen Hemminger wrote:
> I wonder if x86 32 bit is still useful?
> Many distributions no longer support it, and not sure if it is tested
> througly by anyone.
>
> Maybe time to deprecate it (gradually)?
Distributions no longer support it for the kernel,
17/04/2018 21:25, Ferruh Yigit:
> On 4/5/2018 4:01 PM, Chas Williams wrote:
> > On Thu, Apr 5, 2018 at 6:03 AM, Thomas Monjalon wrote:
> >> 20/03/2018 15:12, Ferruh Yigit:
> >>> On 3/18/2018 1:45 AM, Chas Williams wrote:
> From: Chas Williams
>
> The vmxnet3 never attempts link spe
16/04/2018 18:22, Adrien Mazarguil:
> This patch replaces C99-style flexible arrays in struct rte_flow_action_rss
> and struct rte_flow_item_raw with standard pointers to the same data.
>
> They proved difficult to use in the field (e.g. no possibility of static
> initialization) and unsuitable fo
Due to missing cacheline_aligned definition compiler treats it as a
global variable replace it with proper cache alignment macro.
Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup")
Signed-off-by: Pavan Nikhilesh
---
drivers/net/axgbe/axgbe_rxtx.h | 2 +-
1 file changed, 1 insertion(+), 1 de
Still used in certain memory constrained environments.
On Tue, Apr 17, 2018 at 11:39 AM, David Harton (dharton)
wrote:
> It is used and tested in production and non-production environments.
>
> Regards,
> Dave
>
> > -Original Message-
> > From: dev On Behalf Of Stephen Hemminger
> > Se
On 4/16/2018 5:22 PM, Adrien Mazarguil wrote:
> These enable more precise reporting of objects responsible for errors.
>
> This breaks ABI compatibility for the following public functions:
>
> - rte_flow_create()
> - rte_flow_destroy()
> - rte_flow_error_set()
> - rte_flow_flush()
> - rte_flow_is
On 3/28/2018 4:43 PM, Didier Pallard wrote:
> skip_ip6_ext function can be exported as a helper, it may be used
> by some PMD to skip IPv6 header extensions.
>
> Signed-off-by: Didier Pallard
> ---
> lib/librte_net/Makefile| 1 +
> lib/librte_net/rte_net.c | 21 +++
On 4/5/2018 4:01 PM, Chas Williams wrote:
> On Thu, Apr 5, 2018 at 6:03 AM, Thomas Monjalon wrote:
>> 20/03/2018 15:12, Ferruh Yigit:
>>> On 3/18/2018 1:45 AM, Chas Williams wrote:
From: Chas Williams
The vmxnet3 never attempts link speed negotiation. As a virtual device
the
Alejandro Lucero writes:
> I was just wondering, if device device PCI sysfs resource files or VFIO group
> /dev files require to change
> permissions for non-root users, does it not make sense to adjust also
> /var/lock in the system?
For the /dev, we use udev rules - so the correct individual
On 4/17/2018 5:01 AM, Yangchao Zhou wrote:
> rx_q fifo can only be released by kernel thread. There may be
> mbuf leaks in rx_q because kernel threads are randomly stopped.
>
> When the kni is released and netdev is unregisterd, convert the
> physical address mbufs in rx_q to the virtual address
17/04/2018 18:24, Alejandro Lucero:
> On Tue, Apr 17, 2018 at 4:54 PM, Thomas Monjalon
> wrote:
>
> > 17/04/2018 17:44, Alejandro Lucero:
> > > Adding stable@ and Thomas for discussing how can this be added to stable
> > > DPDK versions even if this is not going to be a patch for current DPDK
> >
17/04/2018 18:09, Burakov, Anatoly:
> On 17-Apr-18 4:56 PM, Thomas Monjalon wrote:
> > 17/04/2018 17:50, Anatoly Burakov:
> >> This patchset fixes a host of coverity issues in memory subsystem
> >> introduced with recent DPDK memory hotplug patchset.
> >>
> >> Coverity issues fixed:
> >> - 272601 -
The memory region is [start, end), so if the memseg of 'end' isn't
allocated yet, the returned memseg will have zero entries and this will
make 'end' zero (nil).
Fixes: c2fe5823224a ("net/mlx4: use virt2memseg instead of iteration")
Cc: Anatoly Burakov
Signed-off-by: Yongseok Koh
---
drivers/n
The memory region is [start, end), so if the memseg of 'end' isn't
allocated yet, the returned memseg will have zero entries and this will
make 'end' zero (nil).
Fixes: 718e35999c96 ("net/mlx5: use virt2memseg instead of iteration")
Cc: Anatoly Burakov
Signed-off-by: Yongseok Koh
---
drivers/n
It is used and tested in production and non-production environments.
Regards,
Dave
> -Original Message-
> From: dev On Behalf Of Stephen Hemminger
> Sent: Tuesday, April 17, 2018 2:31 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] Retire x86 32 bit?
>
> I wonder if x86 32 bit is still usef
I wonder if x86 32 bit is still useful?
Many distributions no longer support it, and not sure if it is tested
througly by anyone.
Maybe time to deprecate it (gradually)?
On 4/17/2018 7:25 PM, Ajit Khaparde wrote:
> No Ferruh. It is not a new product family.
> Just adding a device ID (for a VF) for a skew of already existing product.
> So a documentation update is not required.
OK, thanks for clarification.
>
> Thanks
> Ajit
>
> On Tue, Apr 17, 2018 at 11:20 A
No Ferruh. It is not a new product family.
Just adding a device ID (for a VF) for a skew of already existing product.
So a documentation update is not required.
Thanks
Ajit
On Tue, Apr 17, 2018 at 11:20 AM, Ferruh Yigit
wrote:
> On 4/17/2018 2:11 AM, Ajit Khaparde wrote:
> > From: Somnath Kot
On 4/17/2018 2:11 AM, Ajit Khaparde wrote:
> From: Somnath Kotur
>
This is adding new device id to driver.
Does it require any change in documentation?
Do you want to announce new hw support in release notes?
> Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device")
> Cc: ajit.khapa...@broa
On 4/17/2018 2:11 AM, Ajit Khaparde wrote:
> patchset against dpdk-next-net.
> Please apply.
>
> Thanks
>
> Ajit Khaparde (13):
> net/bnxt: set default log level to informational
> net/bnxt: set padding flags in Rx descriptor
> net/bnxt: fix bnxt_hwrm_vnic_alloc
> net/bnxt: fix incorrect
> On Apr 17, 2018, at 12:20 AM, Thomas Monjalon wrote:
>
> 17/04/2018 04:06, Yongseok Koh:
>> There's a bug in the old RedHat release:
>> Bug 1476120 - glibc headers don't include linux/falloc.h, and therefore
>> doesn't include fallocate() flags [1]
>>
>> How about adding "#include " ahead o
> On Apr 17, 2018, at 2:03 AM, Burakov, Anatoly
> wrote:
>
> On 17-Apr-18 3:48 AM, Yongseok Koh wrote:
>>> On Apr 11, 2018, at 5:30 AM, Anatoly Burakov
>>> wrote:
>>>
>>> Reduce dependency on internal details of EAL memory subsystem, and
>>> simplify code.
>>>
>>> Signed-off-by: Anatoly Bur
On 4/17/2018 6:52 PM, Ajit Khaparde wrote:
> From: Scott Branden
>
> Starting from Linux v3.16 pci_is_bridge() is in linux/pci.h,
> in previous versions it is in drivers/pci/pci.h which is private header.
>
> Fix build error when calling pci_is_bridge by not calling/supporting
> pci_is_bridge w
On 4/16/2018 10:49 PM, John Daley wrote:
> From: Hyong Youb Kim
>
> Recent NIC models support overlay offload. The overlay offload
> feature enables the following on the NIC.
> - Rx/Tx checksum offloads for both inner and outer packets.
> - Rx inner packet type classification.
> - TSO.
> - Inner
On 4/5/2018 9:31 AM, Vipin Varghese wrote:
> Add TUN PMD validation for create, port setup, tx, rx and stats functions.
>
> Signed-off-by: Vipin Varghese
> ---
> test/test/Makefile | 4 +
> test/test/autotest_data.py | 13 ++
> test/test/meson.build | 4 +
> test/test/test_tun.
From: Scott Branden
Starting from Linux v3.16 pci_is_bridge() is in linux/pci.h,
in previous versions it is in drivers/pci/pci.h which is private header.
Fix build error when calling pci_is_bridge by not calling/supporting
pci_is_bridge with kernel versions before 3.16.
Fixes: 6f0841b7701b ("i
On 4/17/2018 6:45 PM, Ferruh Yigit wrote:
> On 4/13/2018 6:58 AM, Vipin Varghese wrote:
>> When non IP packets are sent on TUN interface, the logic put Ipv6 as
>> protocol field in header. With the current patch, the check is modified
>> for ipv4, ipv6 and non ip.
>>
>> Fixes: 5a3efcfffd06 ("net/ta
On 4/13/2018 6:58 AM, Vipin Varghese wrote:
> When non IP packets are sent on TUN interface, the logic put Ipv6 as
> protocol field in header. With the current patch, the check is modified
> for ipv4, ipv6 and non ip.
>
> Fixes: 5a3efcfffd06 ("net/tap: add tun support")
> Cc: vipin.vargh...@intel.
On 4/12/2018 10:39 PM, Yong Wang wrote:
> On 4/9/18, 2:00 AM, "dev on behalf of Hemant Agrawal" on behalf of hemant.agra...@nxp.com> wrote:
>
> Cc: skh...@vmware.com
>
> Signed-off-by: Hemant Agrawal
> ---
> Acked-by: Yong Wang
Applied to dpdk-next-net/master, thanks.
On 4/17/2018 4:18 PM, Andrew Rybchenko wrote:
> From: Ivan Malov
>
> Fixes: 4ec1fc3ba881 ("net/sfc: add basic stubs for RSS support on driver
> attach")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ivan Malov
> Signed-off-by: Andrew Rybchenko
Applied to dpdk-next-net/master, thanks.
On 4/17/2018 6:12 AM, Hyong Youb Kim wrote:
> On Mon, Apr 16, 2018 at 11:40:17AM +0200, David Marchand wrote:
>> Modified enic_del_mac_address() to get a return value from the vnic layer.
>> Reused the .mac_addr_add and .mac_addr_del callbacks code to implement
>> primary mac address handler.
>>
>>
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Tuesday 17 April 2018 15:44
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [PATCH v2] baseband/turbo_sw: update Turbo Software driver
>
> Update Turbo Software driver for Wireless Baseband Device:
> - support
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Wednesday 4 April 2018 15:06
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [PATCH] app/bbdev: dynamic lib support
>
> From: "Chalupnik, KamilX"
>
> Support for linking with dynamic library added in
> Baseba
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Tuesday 17 April 2018 15:34
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [PATCH v2] baseband/turbo_sw: optimization of turbo software
> driver
>
> Optimization of Turbo Software driver:
> - resource-hungry p
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Tuesday 17 April 2018 15:40
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [PATCH v2] baseband/turbo_sw: splitting Queue Groups
>
> Splitting Queue Groups into UL/DL Groups in Turbo Software
> Driver. The are
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Tuesday 17 April 2018 15:27
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; Chalupnik, KamilX
>
> Subject: [PATCH v2] baseband/turbo_sw: offload cost measurement test
>
> New test created to measure offload cost.
> Changes were introduced in
The destination string may not have a null termination if
the source string's length is equal to the sizeof(pipeline->name).
Fix by replacing strncpy with strlcpy that guarantees NULL-termination.
Coverty issue: 272606
Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")
Signed-off-
> -Original Message-
> From: Richardson, Bruce
> Sent: Tuesday, April 17, 2018 4:01 PM
> To: Singh, Jasvinder
> Cc: dev@dpdk.org; Dumitrescu, Cristian
> Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null
> terminated
>
> On Tue, Apr 17, 2018 at 02:28:25PM +0100, Ja
On Tue, Apr 17, 2018 at 4:54 PM, Thomas Monjalon
wrote:
> 17/04/2018 17:44, Alejandro Lucero:
> > Adding stable@ and Thomas for discussing how can this be added to stable
> > DPDK versions even if this is not going to be a patch for current DPDK
> > version.
>
> I don't understand.
> This patch w
On Tue, 17 Apr 2018 09:02:45 +
Raslan Darawsheh wrote:
> Hi Stephan,
>
> I've just tried to apply your patches on top of current master branch and I
> have the following two issues:
> 1- compilation is failing with the following error when compiling with
> RTE_TARGET=x86_64-native-linuxapp
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Tuesday, April 17, 2018 9:49 PM
> To: Dai, Wei; Lu, Wenzhuo; Ananyev, Konstantin; Lin, Xueqin
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix segfault in co
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin
> Sent: Tuesday, April 17, 2018 5:43 PM
> To: Dai, Wei; Lu, Wenzhuo; Yao, Lei A
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-se
> -Original Message-
> From: Zhang, Qi Z
> Sent: Sunday, April 15, 2018 9:33 PM
> To: Shweta Choudaha; dev@dpdk.org
> Cc: Lu, Wenzhuo; Ananyev, Konstantin; Zhang, Helin; Yigit, Ferruh;
> shweta.choud...@att.com
> Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: add access and locking APIs fo
On 17-Apr-18 4:56 PM, Thomas Monjalon wrote:
17/04/2018 17:50, Anatoly Burakov:
This patchset fixes a host of coverity issues in memory subsystem
introduced with recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272601 - leaking fd
- 272560 - double close fd
- 272568 - leaking fd
-
Hi Li,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li
> Sent: Tuesday, April 17, 2018 4:04 PM
> To: Lu, Wenzhuo ; Wu, Jingjing
> ; Thomas Monjalon ; Adrien
> Mazarguil
> Cc: Xueming Li ; Nelio Laranjeiro
> ; Shahaf Shuler ;
> dev@dpdk.org; Olivier M
On 17-Apr-18 4:21 PM, Adrien Mazarguil wrote:
Disclaimer: this patch must not be confused with the CLI library [1]
(work in progress) that will eventually supersede librte_cmdline itself
with a different API.
Rather, it modifies librte_cmdline to delegate all the heavy lifting
(terminal and hist
17/04/2018 17:50, Anatoly Burakov:
> This patchset fixes a host of coverity issues in memory subsystem
> introduced with recent DPDK memory hotplug patchset.
>
> Coverity issues fixed:
> - 272601 - leaking fd
> - 272560 - double close fd
> - 272568 - leaking fd
> - 272570 - leaking fd
> - 272589 -
17/04/2018 17:44, Alejandro Lucero:
> Adding stable@ and Thomas for discussing how can this be added to stable
> DPDK versions even if this is not going to be a patch for current DPDK
> version.
I don't understand.
This patch won't enter in 18.05?
Why do you think this patch is candidate for stabl
I was just wondering, if device device PCI sysfs resource files or VFIO
group /dev files require to change permissions for non-root users, does it
not make sense to adjust also /var/lock in the system?
On Tue, Apr 17, 2018 at 4:44 PM, Alejandro Lucero <
alejandro.luc...@netronome.com> wrote:
>
Previously, if mmap failed to map page address at requested
address, we were attempting to unmap the wrong address. Fix it
by unmapping our actual mapped address, and jump further to
avoid unmapping memory that is not allocated.
Coverity issue: 272602
Fixes: 582bed1e1d1d ("mem: support mapping hu
We close fd if we managed to find it in the list of allocated
segment lists (which should always be the case under normal
conditions), but if we didn't, the fd was leaking. Close it if
we couldn't find it in the segment list. This is not an issue
as if the segment is zero length, we're getting rid
Although unlikely during normal operation, rte_socket_id_by_idx()
may return a negative value, which would've caused an out-of-bounds
read. Fix it by making socket ID signed, and check for negative
return.
Coverity issue: 272577
Coverity issue: 272578
Fixes: 66cc45e293ed ("mem: replace memseg wit
Previous code had an old rebase leftover from the time when
oldpolicy was an actual int, instead of a pointer. Fix it to
do comparison with dereferencing the pointer.
Coverity issue: 272589
Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
Cc: anatoly.bura...@intel.com
Signed-off
We were closing descriptor before checking if mapping has
failed, but if it did, we did a second close afterwards. Fix
it by moving closing descriptor to after we check if mmap has
succeeded.
Coverity issue: 272560
Fixes: 2a04139f66b4 ("eal: add single file segments option")
Cc: anatoly.bura...@i
Signed-off-by: Anatoly Burakov
---
Notes:
One other instance of using snprintf is left alone as
it is expected to be addressed by another patch [1].
[1] http://dpdk.org/dev/patchwork/patch/38301/
lib/librte_eal/bsdapp/eal/eal_hugepage_info.c | 2 +-
lib/librte_eal/common/eal_co
If user has specified a flag to unmap the area right after mapping it,
we were passing an already-unmapped pointer to RTE_LOG. This is not an
issue since RTE_LOG doesn't actually dereference the pointer, but fix
it anyway by moving call to RTE_LOG to before unmap.
Coverity issue: 272584
Fixes: b7
Coverity reports these lines as having no effect. Technically, we do
want for those lines to have no effect, however they would've likely
been optimized out. Add volatile qualifiers to ensure the code has
effects.
Coverity issue: 272608
Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runt
Coverity issue: 272601
Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c
b/lib/libr
Normally, tailq entry should have a valid fd by the time we attempt
to map the segment. However, in case it doesn't, we're leaking fd,
so fix it.
Coverity issue: 272570
Fixes: 2a04139f66b4 ("eal: add single file segments option")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
This patchset fixes a host of coverity issues in memory subsystem
introduced with recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272601 - leaking fd
- 272560 - double close fd
- 272568 - leaking fd
- 272570 - leaking fd
- 272589 - dereference before null check
- 272602 - freeing wro
This patchset fixes a few Coverity issues in malloc
introduced by recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272571 - negative return not handled
- 272597 - negative return not handled
- 272574 - use value before verification
- 272590 - negative return not handled
- 272566 - pos
Previous code checked for both first/last elements being NULL,
but if they weren't, the expectation was that they're both
non-NULL, which will be the case under normal conditions, but
may not be the case due to heap structure corruption.
Coverity issue: 272566
Fixes: bb372060dad4 ("malloc: make h
1 - 100 of 295 matches
Mail list logo
