On 17-Apr-18 4:56 PM, Thomas Monjalon wrote:
17/04/2018 17:50, Anatoly Burakov:
This patchset fixes a host of coverity issues in memory subsystem
introduced with recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272601 - leaking fd
- 272560 - double close fd
- 272568 - leaking fd
- 272570 - leaking fd
- 272589 - dereference before null check
- 272602 - freeing wrong pointer
- 272608 - expression does nothing
- 272577 - negative return not handled
- 272578 - negative return not handled
- 272584 - use after free
Looks like you should buy a Coverity license
to run it locally before submitting ;)
Well, in fairness, most of these issues (and similar issues submitted in
another patchset) will not ever manifest themselves under normal
circumstances, so it's not as bad as it perhaps might present itself.
--
Thanks,
Anatoly
