Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-20 Thread Shreyansh Jain
On Tue, Mar 20, 2018 at 8:24 PM, Ferruh Yigit wrote: > On 3/16/2018 1:54 PM, Shreyansh Jain wrote: >> On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: [...] >>> Hi Remy, Shreyansh, >>> >>> What do you think about using a variable name consistent with existing >>> "default_[rt]xconf" in dev_

Re: [dpdk-dev] [PATCH 1/4] vhost: move fdset functions from fd_man.c to fd_man.h

2018-03-20 Thread Yang, Zhiyong
Hi Thomas, Maxime, Jianfeng, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Zhiyong > Sent: Friday, March 16, 2018 4:44 PM > To: Thomas Monjalon > Cc: Tan, Jianfeng ; Maxime Coquelin > ; dev@dpdk.org; y...@fridaylinux.org; Bie, > Tiwei ; Wang, Zhihong ;

Re: [dpdk-dev] [RESEND v2 3/7] net/dpaa2: change into dynamic logging

2018-03-20 Thread Hemant Agrawal
Hi Shreyansh, On 3/13/2018 11:14 AM, Shreyansh Jain wrote: Signed-off-by: Shreyansh Jain --- config/common_base| 5 - config/defconfig_arm64-dpaa2-linuxapp-gcc | 9 - doc/guides/nics/dpaa2.rst | 44 ++--- drivers/net/dpaa2/Makefile

Re: [dpdk-dev] [RESEND v2 2/7] mempool/dpaa2: change to dynamic logging

2018-03-20 Thread Hemant Agrawal
Hi Shreyansh, On 3/13/2018 11:14 AM, Shreyansh Jain wrote: Signed-off-by: Shreyansh Jain --- drivers/mempool/dpaa2/Makefile| 6 --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 60 +-- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 38 +++

Re: [dpdk-dev] [RESEND v2 1/7] bus/fslmc: change to dynamic logging

2018-03-20 Thread Hemant Agrawal
On 3/13/2018 11:14 AM, Shreyansh Jain wrote: Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/Makefile | 5 - drivers/bus/fslmc/fslmc_bus.c| 64 + drivers/bus/fslmc/fslmc_logs.h | 31 +++ drivers/bus/fslmc/fslmc_vfio.c | 1

Re: [dpdk-dev] [RESEND v2 7/7] crypto/dpaa2_sec: change to dynamic logging

2018-03-20 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] net/mlx5: fix ICC compilation

2018-03-20 Thread Shahaf Shuler
Wednesday, March 21, 2018 1:16 AM, Yongseok Koh: > > On Mar 19, 2018, at 3:42 AM, Nelio Laranjeiro > wrote: > > > > Remove the second declaration of device_attr [1] inside the loop as > > well as the query_device_ex() which has already been done outside of the > loop. > > > > Fixes: 9a761de8ea14 (

Re: [dpdk-dev] [RESEND v2 5/7] bus/fslmc: remove unused debug macros

2018-03-20 Thread Hemant Agrawal
On 3/13/2018 11:14 AM, Shreyansh Jain wrote: Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_logs.h | 40 1 file changed, 40 deletions(-) Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH V15 2/2] pci: add driver auto bind for hot insertion

2018-03-20 Thread Jeff Guo
Normally we use drivectl or dpdk-devbind.py to bind kernel driver before application running, so if we want to automatically driver binding after application run, need to implement a auto bind function, that would benefit for hot insertion case, when detect hot insertion uevent of device, user coul

Re: [dpdk-dev] [RESEND v2 6/7] crypto/dpaa2_sec: fix incorrect debugging prints

2018-03-20 Thread Hemant Agrawal
On 3/13/2018 11:14 AM, Shreyansh Jain wrote: Digest and IV length variable declarations have changed. These were escaping builds as the debugging macro was disabled. During dynamic logging change, they were discoverd. Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to session") Fixes: 7f0034

[dpdk-dev] [PATCH V15 1/2] pci_uio: add uevent hotplug failure handler in uio

2018-03-20 Thread Jeff Guo
when detect hot removal uevent of device, the device resource become invalid, in order to avoid unexpected usage of this resource, remap the device resource to be a fake memory, that would lead the application keep running well but not encounter system core dump. Signed-off-by: Jeff Guo --- v15->

[dpdk-dev] [PATCH] net/i40e: fix flow RSS configuration error

2018-03-20 Thread Wei Zhao
I40e need a protection for rss rule flow configuration after one rule is set for a port. Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao Tested-by: Peng Yuan --- drivers/net/i40e/i40e_flow.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --g

Re: [dpdk-dev] [PATCH v3 01/10] devargs: introduce iterator

2018-03-20 Thread Tan, Jianfeng
Hi Gaetan, On 3/21/2018 7:20 AM, Gaetan Rivet wrote: In preparation to making devargs_list private. Bus drivers generally need to access rte_devargs pertaining to their operations. This match is a common operation for bus drivers. Add a new accessor for the rte_devargs list. Signed-off-by: G

Re: [dpdk-dev] [PATCH v3 03/10] bus/vdev: do not reference devargs list

2018-03-20 Thread Tan, Jianfeng
On 3/21/2018 7:20 AM, Gaetan Rivet wrote: This list should not be operated upon by drivers. Use the public API to achieve the same functionalities. Signed-off-by: Gaetan Rivet Acked-by: Jianfeng Tan Thanks, Jianfeng --- drivers/bus/vdev/Makefile | 1 + drivers/bus/vdev/vdev.c | 11

[dpdk-dev] [PATCH V15 1/5] eal: add uevent monitor api and callback func

2018-03-20 Thread Jeff Guo
This patch aim to add a general uevent mechanism in eal device layer, to enable all linux kernel object uevent monitoring, user could call these APIs to monitor and read out the device status info that sent from the kernel side, then corresponding to handle it, such as when detect hotplug uevent ty

[dpdk-dev] [PATCH V15 3/5] app/testpmd: use uevent to monitor hotplug

2018-03-20 Thread Jeff Guo
use testpmd for example, to show app how to request and use uevent monitoring to handle the hot removal event and the hot insertion event. Signed-off-by: Jeff Guo --- v15->v14: add "--hot-plug" configure parameter in testpmd to switch the hotplug feature --- app/test-pmd/parameters.c | 5 +- a

[dpdk-dev] [PATCH V15 2/5] eal: add uevent pass and process function

2018-03-20 Thread Jeff Guo
In order to handle the uevent which have been detected from the kernel side, add uevent process function, let hot plug event to be example to show uevent mechanism how to pass the uevent and process the uevent. About uevent passing and processing, add below functions in linux eal dev layer. FreeBS

Re: [dpdk-dev] [PATCH v2 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-03-20 Thread Anoob Joseph
Hi Akhil, If you are fine with the existing code, I'll send a revised patchset incorporating the comment change you had suggested for 3rd patch. Shall I proceed? Thanks, Anoob On 14/03/18 11:36, Anoob Joseph wrote: Hi Akhil, Please see inline. Thanks, Anoob On 13/03/18 17:54, Akhil Goyal

Re: [dpdk-dev] [PATCH 18.05 v4] eal: add function to return number of detected sockets

2018-03-20 Thread gowrishankar muthukrishnan
On Wednesday 07 February 2018 03:28 PM, Anatoly Burakov wrote: During lcore scan, find maximum socket ID and store it. This will break the ABI, so bump ABI version. Signed-off-by: Anatoly Burakov --- Notes: v4: - Remove backwards ABI compatibility, bump ABI instead v3:

Re: [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices

2018-03-20 Thread Zhoujian (jay)
Hi Fan, Really thank for your response and testing! > -Original Message- > From: Zhang, Roy Fan [mailto:roy.fan.zh...@intel.com] > Sent: Wednesday, March 21, 2018 12:09 PM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > tho...@monjalon.net; Gonglei (Arei) ; Zeng, Xin >

[dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver

2018-03-20 Thread Xiao Wang
ifcvf driver uses vdev as a control domain to manage ifc VFs that belong to it. It registers vDPA device ops to vhost lib to enable these VFs to be used as vhost data path accelerator. Live migration feature is supported by ifc VF and this driver enables it based on vhost lib. Because vDPA driver

[dpdk-dev] [PATCH v2 2/3] bus/pci: expose sysfs parsing API

2018-03-20 Thread Xiao Wang
Some existing sysfs parsing functions are helpful for the later vDPA driver, this patch make them global and expose them to shared lib. Signed-off-by: Xiao Wang --- v2: - Rename function pci_get_kernel_driver_by_path to rte_pci_device_kdriver_name to make the API generic cross Linux and BSD, ma

[dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple container

2018-03-20 Thread Xiao Wang
From: Junjie Chen Currently eal vfio framework binds vfio group fd to the default container fd, while in some cases, e.g. vDPA (vhost data path acceleration), we want to set vfio group to a new container and program DMA mapping via this new container, so this patch adds APIs to support multiple c

[dpdk-dev] [PATCH v2 0/3] add ifcvf driver

2018-03-20 Thread Xiao Wang
This patch set has dependency on http://dpdk.org/dev/patchwork/patch/36241/ (vhost: support selective datapath); ifc VF is virtio vring compatible device, it can be used to accelerate vhost data path. This patch implements vDPA driver ops which configures ifc VF to be a vhost data path accelerator

Re: [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices

2018-03-20 Thread Zhang, Roy Fan
Hi Jay, Excellent work! The patch, although need some minor rework, has improved the performance. Some comments: 1. you need to set up capabilities for virtio_crypto PMD. As in Qemu vhost crypto proxy backend only AESCBC and SHA1 are supported (in cryptodev_vhost_user_init() definition), I bel

[dpdk-dev] [RFC] testpmd: use RFC2544 reserved IP addresses

2018-03-20 Thread Stephen Hemminger
Change the transmit only side of testpmd to use the IP addresses that are marked as reserved for benchmarking by RFC2544 192.18.0.0/27; rather than the commonly used subnet 192.168.0.0/24 which is likely to used for administrative interface. Signed-off-by: Stephen Hemminger --- app/test-pmd/txon

[dpdk-dev] [PATCH v3 2/4] net/virtio: add checking for cvq

2018-03-20 Thread zhiyong . yang
Add checking for cvq to judge if virtio_ack_link_announce should be called. The existing code doesn't cause issue, and add the checking just to look more reasonable. Signed-off-by: Zhiyong Yang --- drivers/net/virtio/virtio_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH v3 3/4] net/virtio-user: add support for server mode

2018-03-20 Thread zhiyong . yang
virtio-user adds support for server mode in this patch. Virtio-user with server mode creates socket file and then starts to wait for the first connection from vhost user with client mode in blocking mode. Server mode virtio-user supports many times' vhost reconnections with the same configuration

[dpdk-dev] [PATCH v3 4/4] net/vhost: add NULL pointer checking

2018-03-20 Thread zhiyong . yang
When vhost user PMD works in client mode to connect/reconnect virtio-user with server mode, new thread sometimes may run to new_device before queue_setup has been done, So have to wait until memory allocation is done. Release note is updated in the patch. Signed-off-by: Zhiyong Yang --- doc/gui

[dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking

2018-03-20 Thread zhiyong . yang
It is necessary to add pointer checking because in some case the code will cause crash. For example, the code goes here before memory allocation of rxvq is finished. Fixes: 7365504f77e3("net/virtio: support guest announce") Cc: sta...@dpdk.org Signed-off-by: Zhiyong Yang --- drivers/net/virtio/v

[dpdk-dev] [PATCH v3 0/4] add support for virtio-user server mode

2018-03-20 Thread zhiyong . yang
In a container environment if the vhost-user backend restarts, there's no way for it to reconnect to virtio-user currently. To address this, support for server mode is added. In this mode the socket file is created by virtio-user, which the backend then connects to. This means that if the backend r

Re: [dpdk-dev] [PATCH] pdump: change to use generic multi-process channel

2018-03-20 Thread Tan, Jianfeng
Thank you for the comments! > -Original Message- > From: Pattan, Reshma > Sent: Wednesday, March 21, 2018 12:38 AM > To: Tan, Jianfeng; dev@dpdk.org > Subject: RE: [PATCH] pdump: change to use generic multi-process channel > > Hi, > > > -Original Message- > > From: Tan, Jianfeng

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-20 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 20, 2018 9:19 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue > setup > > > > > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH v2 0/7] crypto: add virtio poll mode driver

2018-03-20 Thread Zhoujian (jay)
Gentle ping... > -Original Message- > From: Zhoujian (jay) > Sent: Saturday, February 24, 2018 9:14 PM > To: dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; roy.fan.zh...@intel.com; > tho...@monjalon.net; Gonglei (Arei) ; > xin.z...@intel.com; Huangweidong (C) ; wangxin (U) > ; longpeng

Re: [dpdk-dev] [PATCH v3 1/7] ethdev: introduce Tx generic tunnel L3/L4 offload

2018-03-20 Thread Yongseok Koh
On Mon, Mar 05, 2018 at 10:51:15PM +0800, Xueming Li wrote: > This patch introduce new TX offload flags for device that supports > tunnel agnostic L3/L4 checksum and TSO offload. > > The support from the device is for inner and outer checksums on > IPV4/TCP/UDP and TSO for *any packet with the fol

[dpdk-dev] [PATCH v3 10/10] devargs: rename legacy API

2018-03-20 Thread Gaetan Rivet
This previous symbols were deprecated for two releases. They are now marked as such and cannot be used anymore. They are replaced by ones respecting the new namespace that are marked experimental. As a result, eth_dev attach and detach is slightly reworked to follow the changes. Signed-off-by: G

[dpdk-dev] [PATCH v3 09/10] devargs: use proper namespace prefix

2018-03-20 Thread Gaetan Rivet
rte_eal_devargs is useless, rte_devargs is sufficient. Only experimental functions are changed for now. Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev.c | 6 +++--- drivers/net/failsafe/failsafe_args.c| 2 +- drivers/net/failsafe/failsafe_eal.c | 2

[dpdk-dev] [PATCH v3 08/10] devargs: make parsing variadic

2018-03-20 Thread Gaetan Rivet
rte_eal_devargs_parse can be used by EAL subsystems, drivers, applications alike. Device parameters may be presented with different structure each time; as a single declaration string or several strings each describing different parts of the declaration. To simplify the use of this parsing facili

[dpdk-dev] [PATCH v3 06/10] test: remove devargs unit tests

2018-03-20 Thread Gaetan Rivet
The current test will not be compatible anymore with a private devargs list. Moreover, the new functions should have new tests, while the existing API will be removed. The current unit tests are thus obsolete and hereby removed. Signed-off-by: Gaetan Rivet --- MAINTAINERS | 1 -

[dpdk-dev] [PATCH v3 07/10] devargs: make devargs list private

2018-03-20 Thread Gaetan Rivet
Initially, rte_devargs was meant to be populated once and sometimes accessed, then never emptied. With the new hotplug functionality having better standing, new usage appeared with repeated addition of devices and their subsequent removal. Exposing devargs_list pushed bus drivers and libraries to

[dpdk-dev] [PATCH v3 05/10] net/vdev_netvsc: do not reference devargs list

2018-03-20 Thread Gaetan Rivet
This list should not be used by drivers. Use the public API instead. Signed-off-by: Gaetan Rivet --- drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index cbf4

[dpdk-dev] [PATCH v3 04/10] bus/pci: do not reference devargs list

2018-03-20 Thread Gaetan Rivet
This list should not be used by drivers. Use the public API instead. Signed-off-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 1 + drivers/bus/pci/pci_common.c | 6 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile ind

[dpdk-dev] [PATCH v3 03/10] bus/vdev: do not reference devargs list

2018-03-20 Thread Gaetan Rivet
This list should not be operated upon by drivers. Use the public API to achieve the same functionalities. Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/Makefile | 1 + drivers/bus/vdev/vdev.c | 11 +++ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/bus/vdev/

[dpdk-dev] [PATCH v3 02/10] devargs: introduce foreach macro

2018-03-20 Thread Gaetan Rivet
Introduce new rte_devargs accessor allowing to iterate over all rte_devargs pertaining to a bus. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_devargs.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/c

[dpdk-dev] [PATCH v3 00/10] devargs cleanup

2018-03-20 Thread Gaetan Rivet
Cleanup the rte_devargs API. This is a continuous process. The previous version of this patchset was dependent on changes on the PCI bus and the rte_bus library. Not all these changes were integrated. This patchset has thus been limited to elements that are available right now, without dependencie

[dpdk-dev] [PATCH v3 01/10] devargs: introduce iterator

2018-03-20 Thread Gaetan Rivet
In preparation to making devargs_list private. Bus drivers generally need to access rte_devargs pertaining to their operations. This match is a common operation for bus drivers. Add a new accessor for the rte_devargs list. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devarg

Re: [dpdk-dev] [PATCH] net/mlx5: fix ICC compilation

2018-03-20 Thread Yongseok Koh
> On Mar 19, 2018, at 3:42 AM, Nelio Laranjeiro > wrote: > > Remove the second declaration of device_attr [1] inside the loop as well as > the query_device_ex() which has already been done outside of the loop. > > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") > Cc: or...@mellanox.com

Re: [dpdk-dev] [PATCH] net/mlx5: setup RSS regardless of queue count

2018-03-20 Thread Yongseok Koh
On Tue, Mar 20, 2018 at 01:26:08PM +0100, Nélio Laranjeiro wrote: > On Mon, Mar 19, 2018 at 11:30:07AM -0500, Allain Legacy wrote: > > From: Dahir Osman > > > > In some environments it is desirable to have the NIC perform RSS > > normally on the packet regardless of the number of queues configure

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Arnon Warshavsky
> > You are talking about API, and I agree the old applications can keep > considering the functions as void. > But I was talking about ABI, meaning: can we use an old application > without recompiling and update only the DPDK (in .so file)? > > > You are right of course. Once again I mixed the two

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Thomas Monjalon
20/03/2018 23:42, Arnon Warshavsky: > > Thanks for working on this important topic. > > With pleasure :) > > > My feeling is that we could replace most of them by a log + return. > > I did not think you would add a new macro. Why you chose this way? > > This was meant to keep the code shorter, a

Re: [dpdk-dev] [PATCH 18.05 v4] eal: add function to return number of detected sockets

2018-03-20 Thread Thomas Monjalon
08/03/2018 15:38, Burakov, Anatoly: > On 08-Mar-18 12:12 PM, Bruce Richardson wrote: > > Question: we are ok assuming that the socket numbers are sequential, or > > nearly so, and knowing the maximum socket number seen is a good > > approximation of the actual physical sockets? I know in terms of c

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Arnon Warshavsky
> Thanks for working on this important topic. > With pleasure :) > ... > My feeling is that we could replace most of them by a log + return. > I did not think you would add a new macro. Why you chose this way? > This was meant to keep the code shorter, and imply to the reader that this > return i

Re: [dpdk-dev] Pull request for dpdk-next-build

2018-03-20 Thread Thomas Monjalon
15/03/2018 18:19, Bruce Richardson: > http://dpdk.org/git/draft/dpdk-next-build Fixed MAINTAINERS file (proc-info), and pulled, thanks

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Thomas Monjalon
Hi, 20/03/2018 22:28, Arnon Warshavsky: > The purpose of this patch is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. Thanks for w

[dpdk-dev] [PATCH v3] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Arnon Warshavsky
The purpose of this patch is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly tear-down or other mitigation of the event. This patch modifies the majority of rte_panic calls under li

[dpdk-dev] [PATCH v2] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Arnon Warshavsky
The purpose of this patch is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly tear-down or other mitigation of the event. This patch modifies the majority of rte_panic calls under li

[dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Arnon Warshavsky
The purpose of this patch is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly teardown or other mitigation of the event. This patch modifies the majority of rte_panic calls under lib

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Trahe, Fiona
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, March 20, 2018 5:28 PM > To: Richardson, Bruce > Cc: Pavan Nikhilesh ; > jerin.ja...@caviumnetworks.com; > santosh.shu...@caviumnetworks.com; Burakov, Anatoly > ; > lir...@marvell.com; Trahe, Fio

[dpdk-dev] [PATCH v2 9/9] doc: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. Signed-off-by: Shahaf Shuler --- doc/guides/linux_gsg/linux_drivers.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/linux_gsg/linux_drivers.rst b/doc/guides/linux_gsg/linux_drivers.rst index 14381eed8..371a

[dpdk-dev] [PATCH v2 6/9] eal: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. Cc: vikto...@rehivetech.com Cc: jianbo@arm.com Cc: chao...@linux.vnet.ibm.com Cc: bruce.richard...@intel.com Signed-off-by: Shahaf Shuler --- lib/librte_eal/common/arch/arm/rte_hypervisor.c| 2 +- lib/librte_eal/common/arch/ppc_64/rt

[dpdk-dev] [PATCH v2 5/9] net/vdev_netvsc: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. Cc: ma...@mellanox.com Signed-off-by: Shahaf Shuler --- doc/guides/nics/vdev_netvsc.rst | 2 +- drivers/net/vdev_netvsc/Makefile | 2 +- drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-

[dpdk-dev] [PATCH v2 7/9] ethdev: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. Cc: tho...@monjalon.net Cc: adrien.mazarg...@6wind.com Signed-off-by: Shahaf Shuler --- lib/librte_ether/rte_flow.c| 2 +- lib/librte_ether/rte_flow.h| 2 +- lib/librte_ether/rte_flow_driver.h | 2 +- 3 files changed, 3 inser

[dpdk-dev] [PATCH v2 8/9] net: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. Cc: olivier.m...@6wind.com Signed-off-by: Shahaf Shuler --- lib/librte_net/rte_esp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index 0fc99ac69..f77ec2eb2 100644 --

[dpdk-dev] [PATCH v2 4/9] net/failsafe: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. Cc: gaetan.ri...@6wind.com Signed-off-by: Shahaf Shuler --- drivers/net/failsafe/failsafe.c | 2 +- drivers/net/failsafe/failsafe_args.c| 2 +- drivers/net/failsafe/failsafe_eal.c | 2 +- drivers/net/failsafe/failsafe_ether.c

[dpdk-dev] [PATCH v2 1/9] net/mlx: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. In addition replace to SPDX licence files which were missed. Cc: adrien.mazarg...@6wind.com Cc: nelio.laranje...@6wind.com Cc: ys...@mellanox.com Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx4.rst | 30 ++-

[dpdk-dev] [PATCH v2 2/9] net/tap: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. Cc: pascal.ma...@6wind.com Signed-off-by: Shahaf Shuler --- drivers/net/tap/rte_eth_tap.h | 2 +- drivers/net/tap/tap_bpf.h | 2 +- drivers/net/tap/tap_bpf_api.c | 2 +- drivers/net/tap/tap_bpf_insns.h | 2 +- drivers/net/t

[dpdk-dev] [PATCH v2 3/9] app/testpmd: align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. Cc: wenzhuo...@intel.com Cc: jingjing...@intel.com Signed-off-by: Shahaf Shuler --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c ind

[dpdk-dev] [PATCH v2 0/9] align SPDX Mellanox copyrights

2018-03-20 Thread Shahaf Shuler
This series is to align the format of the copyright in Mellanox related files. On v2: - remove completely the BSD licence from mlx PMD docs - add more patches to align files not under drivers/net/mlx* Shahaf Shuler (9): net/mlx: align SPDX Mellanox copyrights net/tap: align SPDX Mellanox c

Re: [dpdk-dev] [PATCH v1 00/18] Device querying

2018-03-20 Thread Gaëtan Rivet
On Thu, Mar 15, 2018 at 06:49:30PM +0100, Gaetan Rivet wrote: > This patchset introduces a new EAL API for querying devices, > filtered by arbitrary properties. > > The following elements are introduced to this end: > > * A new object, "rte_class", is used to describe >the device class abstr

Re: [dpdk-dev] [PATCH] net/mrvl: use proper constant for Rx descriptors number

2018-03-20 Thread Ferruh Yigit
On 3/15/2018 12:12 PM, Tomasz Duszynski wrote: > Since filling hardware buffer pool (bpool) is Rx related > constant describing maximum number of rx descriptors > instead of maximum number of Tx descriptors should be used. > > Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") > Cc: sta...@dpd

Re: [dpdk-dev] [PATCH] net/mlx: align to SPDX format

2018-03-20 Thread Shahaf Shuler
Tuesday, March 20, 2018 7:26 PM, Ferruh Yigit: > > Subject: Re: [dpdk-dev] [PATCH] net/mlx: align to SPDX format > > On 3/20/2018 5:17 PM, Shahaf Shuler wrote: > > diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst index > > afeff276e..7ed46021d 100644 > > --- a/doc/guides/nics/mlx4.

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Thomas Monjalon
20/03/2018 18:01, Bruce Richardson: > On Tue, Mar 20, 2018 at 09:36:25PM +0530, Pavan Nikhilesh wrote: > > Hi Thomas, > > > > On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > > > 20/03/2018 15:40, Pavan Nikhilesh: > > > > Add driver/common folder and skeleton makefile for adding

Re: [dpdk-dev] [PATCH] net/mlx: align to SPDX format

2018-03-20 Thread Ferruh Yigit
On 3/20/2018 5:17 PM, Shahaf Shuler wrote: > diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst > index afeff276e..7ed46021d 100644 > --- a/doc/guides/nics/mlx4.rst > +++ b/doc/guides/nics/mlx4.rst > @@ -1,6 +1,6 @@ > -.. BSD LICENSE > +.. SPDX-License-Identifier: BSD-3-Clause >

Re: [dpdk-dev] [PATCH] doc: announce ethdev CRC strip flag deprecation

2018-03-20 Thread Ferruh Yigit
On 3/20/2018 11:35 AM, Thomas Monjalon wrote: > 20/03/2018 12:26, Ferruh Yigit: >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> +* ethdev: Make CRC stript default behavior without any flag required and >> add a > > s/stript/stripping/ > >> + new of

[dpdk-dev] [PATCH] net/mlx: align to SPDX format

2018-03-20 Thread Shahaf Shuler
Aligning Mellanox SPDX copyrights to a single format. In addition replace to SPDX licence files which were missed. Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx4.rst | 4 ++-- doc/guides/nics/mlx5.rst | 4 ++-- drivers/net/mlx4/Makefile | 31 ++-

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Bruce Richardson
On Tue, Mar 20, 2018 at 09:36:25PM +0530, Pavan Nikhilesh wrote: > Hi Thomas, > > On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > > 20/03/2018 15:40, Pavan Nikhilesh: > > > Add driver/common folder and skeleton makefile for adding commonly > > > used functions across mempool, ev

Re: [dpdk-dev] [PATCH v1 8/9] mempool: ensure the mempool is initialized before populating

2018-03-20 Thread Olivier Matz
On Tue, Mar 20, 2018 at 04:32:04PM +0300, Andrew Rybchenko wrote: > On 03/19/2018 08:06 PM, Olivier Matz wrote: > > On Sat, Mar 10, 2018 at 03:39:41PM +, Andrew Rybchenko wrote: > > > From: "Artem V. Andreev" > > > > > > Callback to calculate required memory area size may require mempool > >

Re: [dpdk-dev] [PATCH] pdump: change to use generic multi-process channel

2018-03-20 Thread Pattan, Reshma
Hi, > -Original Message- > From: Tan, Jianfeng > Sent: Sunday, March 4, 2018 3:04 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Pattan, Reshma > > Subject: [PATCH] pdump: change to use generic multi-process channel > > The original code replies on the private channel for primary and second

[dpdk-dev] [PATCH v5] ethdev: return named opaque type instead of void pointer

2018-03-20 Thread Ferruh Yigit
"struct rte_eth_rxtx_callback" is defined as internal data structure and used as named opaque type. So the functions that are adding callbacks can return objects in this type instead of void pointer. Also const qualifier added to "struct rte_eth_rxtx_callback *" to protect it better from applicat

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Pavan Nikhilesh
Hi Thomas, On Tue, Mar 20, 2018 at 04:45:47PM +0100, Thomas Monjalon wrote: > 20/03/2018 15:40, Pavan Nikhilesh: > > Add driver/common folder and skeleton makefile for adding commonly used > > functions across mempool, event and net devices. > > I am not sure there is a real benefit of introducing

Re: [dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to common folder

2018-03-20 Thread Pavan Nikhilesh
Hi Hemant, On Tue, Mar 20, 2018 at 08:31:42PM +0530, Hemant Agrawal wrote: > > HI Pavan, >     One quick comment > > On 3/20/2018 8:10 PM, Pavan Nikhilesh wrote: > > -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx > > -lrte_pmd_octeontx > > +LDLIBS += -lrte_eal -lrte_eventdev -lrte_oct

Re: [dpdk-dev] [PATCH v4] ethdev: return named opaque type instead of void pointer

2018-03-20 Thread Ferruh Yigit
On 3/9/2018 7:06 PM, Neil Horman wrote: > On Fri, Mar 09, 2018 at 03:45:49PM +, Ferruh Yigit wrote: >> On 3/9/2018 3:16 PM, Neil Horman wrote: >>> On Fri, Mar 09, 2018 at 01:00:35PM +, Ferruh Yigit wrote: On 3/9/2018 12:36 PM, Neil Horman wrote: > On Fri, Mar 09, 2018 at 11:25:31AM

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Thomas Monjalon
20/03/2018 15:40, Pavan Nikhilesh: > Add driver/common folder and skeleton makefile for adding commonly used > functions across mempool, event and net devices. I am not sure there is a real benefit of introducing such new directory. Is it only solving the choice of where you add files used by seve

Re: [dpdk-dev] kni: continuous memory restriction ?

2018-03-20 Thread Ferruh Yigit
> > 在2018年03月13 22时57分, "Ferruh Yigit"写道: > > > On 3/9/2018 12:14 PM, cys wrote: > > Commit 8451269e6d7ba7501723fe2efd0 said "remove continuous memory > restriction"; > > > > http://dpdk.org/browse/dpdk/commit/lib/librte_eal/linuxapp/kni/kni_net.c?id=8451269e6d7ba7501723fe2

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-03-20 Thread Ferruh Yigit
On 3/14/2018 8:14 AM, Nélio Laranjeiro wrote: > On Tue, Mar 13, 2018 at 06:05:34PM +, Ferruh Yigit wrote: >> Update link status related feature document items and minor updates in >> some link status related functions. >> >> Signed-off-by: Ferruh Yigit <...> >> @@ -536,7 +536,7 @@ mlx5_link_

Re: [dpdk-dev] [PATCH] net/bonding: switch to new offloading flags

2018-03-20 Thread Ferruh Yigit
On 3/14/2018 12:50 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit, Sent: Tuesday, March 13, 2018 2:25 PM >> Switch from using deprecated bitfields in rxmode to offloads variable. >> >> Signed-off-by: Ferruh Yigit >> --- >> drivers/net/bonding/rte_eth_bond_api.c | 3 ++- >> drivers/net/

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-20 Thread Ferruh Yigit
On 3/16/2018 3:36 PM, Remy Horton wrote: > > On 16/03/2018 13:54, Shreyansh Jain wrote: >> On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: >>> On 3/15/2018 2:39 PM, Bruce Richardson wrote: On Thu, Mar 15, 2018 at 01:57:13PM +, Ferruh Yigit wrote: > [..] >>> Hi Remy, Shreyansh, >>> >

Re: [dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to common folder

2018-03-20 Thread Hemant Agrawal
HI Pavan,     One quick comment On 3/20/2018 8:10 PM, Pavan Nikhilesh wrote: -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx -lrte_pmd_octeontx +LDLIBS += -lrte_eal -lrte_eventdev -lrte_octeontx_common -lrte_pmd_octeontx Typically the naming convention for driver based libraries is

Re: [dpdk-dev] [PATCH V1 0/5] Introduce Intel FPGA BUS

2018-03-20 Thread Gaëtan Rivet
Hi Rosen, Unless I'm mistaken, this is the v1? Did you mean to send the v2 instead and got mixed up or did I miss something? I would have the same remarks regarding PCI parsing of devices etc. Can you send the v2 as a response to this cover-letter? You have to take the Message-ID of the previous

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-20 Thread Ferruh Yigit
On 3/16/2018 1:54 PM, Shreyansh Jain wrote: > On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: >> On 3/15/2018 2:39 PM, Bruce Richardson wrote: >>> On Thu, Mar 15, 2018 at 01:57:13PM +, Ferruh Yigit wrote: On 3/14/2018 9:36 PM, Bruce Richardson wrote: > On Wed, Mar 14, 2018 at 09:

Re: [dpdk-dev] [PATCH 00/41] Memory Hotplug for DPDK

2018-03-20 Thread Burakov, Anatoly
On 20-Mar-18 2:18 PM, Olivier Matz wrote: Hi, On Tue, Mar 20, 2018 at 01:51:31PM +, Burakov, Anatoly wrote: On 20-Mar-18 12:42 PM, Olivier Matz wrote: On Tue, Mar 20, 2018 at 10:27:55AM +, Burakov, Anatoly wrote: On 19-Mar-18 5:30 PM, Olivier Matz wrote: Hi Anatoly, On Sat, Mar 03,

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent

2018-03-20 Thread Chas Williams
On Tue, Mar 20, 2018 at 10:12 AM, Ferruh Yigit wrote: > On 3/18/2018 1:45 AM, Chas Williams wrote: > > From: Chas Williams > > > > The vmxnet3 never attempts link speed negotiation. As a virtual device > > the link speed is vague at best. However, it is important for certain > > applications,

[dpdk-dev] [PATCH v2 1/2] drivers: add common folder

2018-03-20 Thread Pavan Nikhilesh
Add driver/common folder and skeleton makefile for adding commonly used functions across mempool, event and net devices. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Removed dependency on bus. drivers/Makefile | 13 +++-- drivers/common/Makefile| 7 +++ drivers

Re: [dpdk-dev] [PATCH v1 1/9] mempool: add op to calculate memory size to be allocated

2018-03-20 Thread Bruce Richardson
On Mon, Mar 19, 2018 at 06:03:52PM +0100, Olivier Matz wrote: > On Sat, Mar 10, 2018 at 03:39:34PM +, Andrew Rybchenko wrote: > > Size of memory chunk required to populate mempool objects depends > > on how objects are stored in the memory. Different mempool drivers > > may have different requi

[dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to common folder

2018-03-20 Thread Pavan Nikhilesh
Move commonly used functions across mempool, event and net devices to a common folder in drivers. Signed-off-by: Pavan Nikhilesh --- drivers/common/Makefile| 4 ++ drivers/common/meson.build | 1 + drivers/common/octeontx/Makefile

Re: [dpdk-dev] [PATCH 1/2] drivers: add common folder

2018-03-20 Thread Pavan Nikhilesh
Hi Shreyansh, On Mon, Mar 19, 2018 at 04:05:13PM +0530, Shreyansh Jain wrote: > Hi Pavan, > > On Mon, Mar 19, 2018 at 2:57 PM, Pavan Nikhilesh > wrote: > > Add driver/common folder and skeleton makefile for adding commonly used > > functions across mempool, event and net devices. > > > > Signed-o

Re: [dpdk-dev] Question on AESNI PMD

2018-03-20 Thread Luse, Paul E
Any thoughts on this? -Original Message- From: Luse, Paul E Sent: Wednesday, March 14, 2018 5:43 PM To: De Lara Guarch, Pablo ; 'Thomas Monjalon' Cc: 'dev@dpdk.org' ; Doherty, Declan ; Harris, James R ; Verkamp, Daniel Subject: RE: [dpdk-dev] Question on AESNI PMD So what do you thi

Re: [dpdk-dev] [PATCH 00/41] Memory Hotplug for DPDK

2018-03-20 Thread Olivier Matz
Hi, On Tue, Mar 20, 2018 at 01:51:31PM +, Burakov, Anatoly wrote: > On 20-Mar-18 12:42 PM, Olivier Matz wrote: > > On Tue, Mar 20, 2018 at 10:27:55AM +, Burakov, Anatoly wrote: > > > On 19-Mar-18 5:30 PM, Olivier Matz wrote: > > > > Hi Anatoly, > > > > > > > > On Sat, Mar 03, 2018 at 01:4

[dpdk-dev] [PATCH v4 2/2] event/sw: support device stop flush callback

2018-03-20 Thread Gage Eads
This commit also adds a flush callback test to the sw eventdev's selftest suite. Signed-off-by: Gage Eads --- drivers/event/sw/sw_evdev.c | 25 ++- drivers/event/sw/sw_evdev_selftest.c | 80 +++- 2 files changed, 102 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH v4 1/2] eventdev: add device stop flush callback

2018-03-20 Thread Gage Eads
When an event device is stopped, it drains all event queues. These events may contain pointers, so to prevent memory leaks eventdev now supports a user-provided flush callback that is called during the queue drain process. This callback is stored in process memory, so the callback must be registere

  1   2   >