Hi Shreyansh, On Mon, Mar 19, 2018 at 04:05:13PM +0530, Shreyansh Jain wrote: > Hi Pavan, > > On Mon, Mar 19, 2018 at 2:57 PM, Pavan Nikhilesh > <pbhagavat...@caviumnetworks.com> wrote: > > Add driver/common folder and skeleton makefile for adding commonly used > > functions across mempool, event and net devices. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > > --- > > drivers/Makefile | 14 ++++++++------ > > drivers/common/Makefile | 7 +++++++ > > drivers/common/meson.build | 6 ++++++ > > drivers/meson.build | 9 +++++---- > > 4 files changed, 26 insertions(+), 10 deletions(-) > > create mode 100644 drivers/common/Makefile > > create mode 100644 drivers/common/meson.build > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index ee65c87b0..bd83ad9f3 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -4,17 +4,19 @@ > > include $(RTE_SDK)/mk/rte.vars.mk > > > > DIRS-y += bus > > +DIRS-y += common > > +DEPDIRS-common := bus > > Why should common be dependent on bus? Shouldn't common be independent > in itself?
Yup will send out v2 soon. > > > DIRS-y += mempool > > -DEPDIRS-mempool := bus > > +DEPDIRS-mempool := bus common > > DIRS-y += net > > -DEPDIRS-net := bus mempool > > +DEPDIRS-net := bus common mempool > > DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += bbdev > > -DEPDIRS-bbdev := bus mempool > > +DEPDIRS-bbdev := bus common mempool > > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto > > -DEPDIRS-crypto := bus mempool > > +DEPDIRS-crypto := bus common mempool > > DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event > > -DEPDIRS-event := bus mempool net > > +DEPDIRS-event := bus common mempool net > > DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw > > -DEPDIRS-raw := bus mempool net event > > +DEPDIRS-raw := bus common mempool net event > > [...] > > - > Shreyansh Thanks, Pavan.
