Hi, > -----Original Message----- > From: Tan, Jianfeng > Sent: Sunday, March 4, 2018 3:04 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng <jianfeng....@intel.com>; Pattan, Reshma > <reshma.pat...@intel.com> > Subject: [PATCH] pdump: change to use generic multi-process channel > > The original code replies on the private channel for primary and secondary > communication. Change to use the generic multi-process channel. > > Note with this change, dpdk-pdump will be not compatible with old version > DPDK applications. >
Is this the correct time to make this change? As I see the rte_mp APIs are still in experimental stage? If you wish to change them, 1) I feel ABI breakage has to be addressed first for change in rte_pdump_init() . 2)ABI notice for removal of the rte_pdump_set_socket_dir() and then remove it completely . 3)Need to do cleanup of the code app/dpdk-pdump. 4)After all the changes we need to make sure dpdk-pdump works fine without breaking the functionality, validation team should be able to help. 5)Replace strcpy with snprintf. Thanks, Reshma
