Re: [dpdk-dev] [PATCH v4 09/15] net/sfc: use new rte_eth_linkstatus functions

2018-01-11 Thread Andrew Rybchenko
On 01/11/2018 08:06 PM, Ferruh Yigit wrote: From: Stephen Hemminger Use the new API (_rte_eth_linkstatus_set) to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_ethdev.c | 27 +++ drivers/net/sfc/sfc_ev.c | 23

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-11 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Friday, January 12, 2018 2:02 AM > Hi Matan, > > > > > Hi Konstantin > > > > From: Ananyev, Konstantin, Thursday, January 11, 2018 2:40 PM > > > Hi Matan, > > > > > > > > > > > Hi Konstantin > > > > > > > > From: Ananyev, Konstantin, Wednesday, January 10

[dpdk-dev] [PATCH v4] net/i40e: fix port segmentation fault when restart

2018-01-11 Thread Wei Zhao
This patch will go into the process of clear all queue region related configuration when dev stop even if there is no queue region command before, so this is a bug, it may cause error. So add code to check if there is queue configuration exist when flush queue region config and remove this process

[dpdk-dev] [PATCH] net/i40e: fix issue of pctype does't take effect in X722

2018-01-11 Thread Rosen Xu
Fixes: a286ebeb0714 ("net/i40e: add dynamic mapping of SW flow types to HW pctypes") Cc: sta...@dpdk.org Signed-off-by: Rosen Xu --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev

Re: [dpdk-dev] [PATCH] net/i40e: add break case in flow API

2018-01-11 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, January 12, 2018 2:14 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yigit, Ferruh > ; Zhao1, Wei > Subject: [PATCH] net/i40e: add break case in flow API > > This bug may cause build error when there is no break case code, so add it. >

[dpdk-dev] [PATCH] net/i40e: fix issue of pctype does't take effert in X722

2018-01-11 Thread Rosen Xu
Fixes: a286ebeb0714 ("net/i40e: add dynamic mapping of SW flow types to HW pctypes") Cc: sta...@dpdk.org Signed-off-by: Rosen Xu --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev

Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API

2018-01-11 Thread Zhao1, Wei
Hi,Ferruh A fix patch has been commit. https://dpdk.org/dev/patchwork/patch/33640/ > -Original Message- > From: Zhao1, Wei > Sent: Friday, January 12, 2018 1:50 PM > To: Yigit, Ferruh ; dev@dpdk.org > Cc: Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API > >

[dpdk-dev] [PATCH] net/i40e: add break case in flow API

2018-01-11 Thread Wei Zhao
This bug may cause build error when there is no break case code, so add it. Fixes: accf70b2ae64e ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_f

Re: [dpdk-dev] [PATCH v4 0/2] app/testpmd: fix invalid rxq and txq nubmer settings

2018-01-11 Thread Dai, Wei
Hi, Yuan I can build dpdk with my patches successfully in my Fedora 24 with gcc 6.3.1 20161221 (Red Hat 6.3.1-1) Anyway, I will make v5 patch to address the problem you report and correct typos reported by Konstantin. Thanks > -Original Message- > From: Peng, Yuan > Sent: Friday, Januar

Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API

2018-01-11 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 10, 2018 9:29 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API > > On 1/10/2018 2:10 AM, Wei Zhao wrote: > > Rte_flow actually defined

Re: [dpdk-dev] [PATCH] test/memzone: Fix test_memzone_basic & test_memzone_free issues.

2018-01-11 Thread Jianbo Liu
The 01/11/2018 17:41, Phil Yang wrote: > 1. test_memzone_basic: No need to free a NULL memzone. It will cause test > termination. > 2. test_memzone_free: Out of mz[RTE_MAX_MEMZONE] memory bound while > reserving memzone for mz. It will flush variable i. Fix by extend to > mz[RTE_MAX_MEMZONE + 1]. >

Re: [dpdk-dev] [PATCH v4 0/2] app/testpmd: fix invalid rxq and txq nubmer settings

2018-01-11 Thread Peng, Yuan
Hi Wei, There is a build error applied your patches to the latest DPDK version. /root/dpdk/app/test-pmd/testpmd.c: In function 'check_nb_rxq': /root/dpdk/app/test-pmd/testpmd.c:579:3: error: 'pid' may be used uninitialized in this function [-Werror=maybe-uninitialized] printf("Fail: input rxq

Re: [dpdk-dev] [PATCH v2] bus/pci: forbid VA as IOVA mode if IOMMU address width too small

2018-01-11 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Tuesday, January 9, 2018 9:18 PM > To: dev@dpdk.org; sta...@dpdk.org; Tan, Jianfeng ; > santosh.shu...@caviumnetworks.com; Burakov, Anatoly > ; tho...@monjalon.net; > step...@networkplumber

Re: [dpdk-dev] [PATCH] eal: add option to force IOVA as PA mode

2018-01-11 Thread Chas Williams
Thanks, and yes I already saw that. That seems like a much better solution. I will give it a spin in my box with this problem. On Thu, Jan 11, 2018 at 7:12 PM, Thomas Monjalon wrote: > 03/12/2017 01:23, Chas Williams: > > The particular machine in my case is a Dell Optiplex 790 which is fairly

Re: [dpdk-dev] [PATCH v2] bus/pci: forbid VA as IOVA mode if IOMMU address width too small

2018-01-11 Thread Zhang, Qi Z
> -Original Message- > From: Tan, Jianfeng > Sent: Friday, January 12, 2018 11:01 AM > To: 'Maxime Coquelin' ; dev@dpdk.org; > sta...@dpdk.org; santosh.shu...@caviumnetworks.com; Burakov, Anatoly > ; tho...@monjalon.net; > step...@networkplumber.org > Cc: pet...@redhat.com; Zhang, Qi Z >

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF

2018-01-11 Thread Dai, Wei
> -Original Message- > From: Wu, Yanglong > Sent: Friday, January 12, 2018 10:38 AM > To: Dai, Wei ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF > > Hi > After confirm with Daiwei and according to the data sheet, > RTE_ETH_DEV_SRIOV(dev).nb_q_p

Re: [dpdk-dev] [PATCH v2] bus/pci: forbid VA as IOVA mode if IOMMU address width too small

2018-01-11 Thread Tan, Jianfeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, January 9, 2018 9:18 PM > To: dev@dpdk.org; sta...@dpdk.org; Tan, Jianfeng; > santosh.shu...@caviumnetworks.com; Burakov, Anatoly; > tho...@monjalon.net; step...@networkplumber.org > Cc: pet.

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF

2018-01-11 Thread Wu, Yanglong
Hi After confirm with Daiwei and according to the data sheet, RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool is the Max number of queue can be used in VF, that would be assigned as IXGBE_MAX_RX_QUEUE_NUM / RTE_ETH_DEV_SRIOV(dev).active, so that assigning nb_q_per_pool as 1 when PF is in ETH_MQ_RX_NONE,

Re: [dpdk-dev] [PATCH 2/2] net/e1000: fix mailbox interrupt handler

2018-01-11 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 28, 2017 4:23 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; Wang, Liang-min > ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH 2/2] net/e1000: fix mailbox interrupt handler > > Mailbox interrupt handler only take

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2018-01-11 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, December 28, 2017 4:22 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Dai, Wei ; Wang, Liang-min > ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler > > Mailbox interrupt handler only take

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2018-01-11 Thread Dai, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 11, 2018 4:08 PM > To: Dai, Wei ; Lu, Wenzhuo > Cc: dev@dpdk.org; Wang, Liang-min ; > sta...@dpdk.org > Subject: RE: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler > > > > > -Original Message- > > From: Dai

Re: [dpdk-dev] [PATCH v2] net/i40e: fix flag sent to mac_address_write

2018-01-11 Thread Xing, Beilei
> -Original Message- > From: Igor Ryzhov [mailto:iryz...@nfware.com] > Sent: Thursday, January 11, 2018 6:07 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix flag sent to mac_address_write > > Use the same value as in Linux driver. Sorry for

Re: [dpdk-dev] [PATCH v3] net/i40e: fix VF reset stats crash

2018-01-11 Thread Zhao1, Wei
Hi, > -Original Message- > From: David C Harton [mailto:dhar...@cisco.com] > Sent: Thursday, January 11, 2018 11:14 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; David C Harton ; Zhao1, Wei > > Subject: [PATCH v3] net/i40e: fix VF reset stats crash > > Calling i40evf_dev_xsta

Re: [dpdk-dev] [PATCH v2] bus/pci: forbid VA as IOVA mode if IOMMU address width too small

2018-01-11 Thread Tan, Jianfeng
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, January 12, 2018 4:20 AM > To: Tan, Jianfeng > Cc: dev@dpdk.org; sta...@dpdk.org; santosh.shu...@caviumnetworks.com; > Burakov, Anatoly; tho...@monjalon.net; step...@networkplumber.o

Re: [dpdk-dev] [PATCH] eal: add option to force IOVA as PA mode

2018-01-11 Thread Thomas Monjalon
03/12/2017 01:23, Chas Williams: > The particular machine in my case is a Dell Optiplex 790 which is fairly > similar to another system that has basically the same problem. The IOMMU > advertises that is can only handle 39 bits of addressing. The DMAR address > tables have a width of 36 bits, so

Re: [dpdk-dev] [PATCH v3] bus/pci: fix wrong intr_handle.type with uio_pci_generic

2018-01-11 Thread Thomas Monjalon
10/01/2018 03:32, Zhiyong Yang: > For virtio legacy device, testpmd startup fails when using uio_pci_generic. > > The issue is caused by invoking the function pci_ioport_map. The correct > value of intr_handle.type is already set before calling it, we should avoid > overwriting the default value "

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-11 Thread Ananyev, Konstantin
Hi Matan, > > Hi Konstantin > > From: Ananyev, Konstantin, Thursday, January 11, 2018 2:40 PM > > Hi Matan, > > > > > > > > Hi Konstantin > > > > > > From: Ananyev, Konstantin, Wednesday, January 10, 2018 3:36 PM > > > > Hi Matan, > > > > > > > > Few comments from me below. > > > > BTW, do you p

Re: [dpdk-dev] [PATCH v3] bus/vdev: add custom scan hook

2018-01-11 Thread Thomas Monjalon
09/01/2018 00:25, Thomas Monjalon: > The scan callback allows to spawn a vdev automatically > given some custom scan rules. > It is especially useful to create a TAP device automatically > connected to a netdevice as remote. > > Signed-off-by: Thomas Monjalon > Acked-by: Jianfeng Tan Applied

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-11 Thread Thomas Monjalon
07/11/2017 10:50, Jonas Pfefferle1: > Thomas Monjalon wrote on 11/07/2017 10:40:15 AM: > > > From: Thomas Monjalon > > To: Jonas Pfefferle1 , anatoly.bura...@intel.com > > Cc: dev@dpdk.org > > Date: 11/07/2017 10:40 AM > > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling > >

Re: [dpdk-dev] [PATCH v3] eal/x86: get hypervisor name

2018-01-11 Thread Thomas Monjalon
07/01/2018 23:20, Thomas Monjalon: > The CPUID instruction is caught by hypervisor which can return > a flag indicating one is running, and its name. > > Suggested-by: Stephen Hemminger > Signed-off-by: Thomas Monjalon > Acked-by: Jerin Jacob Applied

Re: [dpdk-dev] [PATCH] mem: warn if address hint is not respected

2018-01-11 Thread Thomas Monjalon
07/11/2017 14:54, Burakov, Anatoly: > On 06-Nov-17 8:26 PM, Thomas Monjalon wrote: > > 31/10/2017 10:08, Jonas Pfefferle: > >> Print a warning if the --base-virtaddr hint is not respected > >> since this might lead to problems when mapping memory in > >> the secondary process. > >> > >> Signed-off-

Re: [dpdk-dev] [PATCH v2] mbuf: check sanity of data_len and pkt_len as well

2018-01-11 Thread Thomas Monjalon
14/12/2017 10:31, Olivier MATZ: > On Thu, Dec 14, 2017 at 09:50:25AM +0100, Olivier MATZ wrote: > > On Sun, Dec 10, 2017 at 12:39:18AM +0300, Ilya V. Matveychikov wrote: > > > Update rte_mbuf_sanity_check() to check sanity of data_len and pkt_len > > > fields. For segmented packets it is supposed t

Re: [dpdk-dev] [PATCH v2] mbuf: cleanup rte_pktmbuf_lastseg function

2018-01-11 Thread Thomas Monjalon
14/12/2017 10:30, Olivier MATZ: > On Thu, Dec 14, 2017 at 09:48:29AM +0100, Olivier MATZ wrote: > > On Sun, Dec 10, 2017 at 12:08:22AM +0300, Ilya V. Matveychikov wrote: > > > There is no reason to have local variable m2. > > > > > > Fixes: af75078fece3 ("first public release") > > > Signed-off-by

Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function

2018-01-11 Thread Thomas Monjalon
12/01/2018 00:09, Carrillo, Erik G: > Hi Aaron, > > From: Aaron Conole [mailto:acon...@redhat.com] > > > > Hi Erik, > > > > Erik Gabriel Carrillo writes: > > > > > Update rte_lcore_has_role() so that it returns true/false instead of > > > success/failure. > > > > > > Fixes: 78666372fa2b ("eal:

Re: [dpdk-dev] [PATCH v3 1/4] power: changed unsigned to unsigned int

2018-01-11 Thread Thomas Monjalon
12/12/2017 15:03, Marko Kovacevic: > Since this patch-set attempts to clean up the power library, > and there are many instances of "unsigned" caught by checkpatch, > it was decided to clean these up first rather than have them included > in the later patches in the patch set. And would also minimi

Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function

2018-01-11 Thread Carrillo, Erik G
Hi Aaron, > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Tuesday, January 9, 2018 10:45 AM > To: Carrillo, Erik G > Cc: pbhagavat...@caviumnetworks.com; Van Haaren, Harry > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from l

Re: [dpdk-dev] [PATCH v1] eal: remove use of 'register' keyword

2018-01-11 Thread Thomas Monjalon
09/01/2018 17:11, Avi Kivity: > The 'register' keyword does nothing, and has been removed in C++17. > > Remove it for compatibility. > > Signed-off-by: Avi Kivity Applied, thanks

Re: [dpdk-dev] [PATCH 0/3] service: add attribute get and reset

2018-01-11 Thread Thomas Monjalon
04/10/2017 12:54, Harry van Haaren: > This patchset adds two new functions to the service cores API, allowing > the service library to expose generic attributes about the services, > and to reset them. These attributes can be the cycle counts that cores > have spent in the service-function. The 3rd

Re: [dpdk-dev] [PATCH v4 1/2] service: fix lcore role after delete

2018-01-11 Thread Thomas Monjalon
10/01/2018 11:23, Pavan Nikhilesh: > On Tue, Jan 09, 2018 at 01:37:40PM +, Harry van Haaren wrote: > > This patch fixes the reset of the service core, > > that when rte_service_lcore_del() is called, the > > lcore_role is restored to RTE. > > > > This issue was reported as when running the unit

Re: [dpdk-dev] [dpdk-stable] [PATCH] service: fix number mapped cores count

2018-01-11 Thread Thomas Monjalon
> > When adding service the number of mapped cores should only be incremented > > when the core is not already a service core or vice versa. > > > > Fixes: 21698354c832 ("service: introduce service cores concept") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Pavan Nikhilesh > > Just a note; >

Re: [dpdk-dev] [PATCH v2] eal: add function to return number of detected sockets

2018-01-11 Thread Thomas Monjalon
22/12/2017 13:41, Anatoly Burakov: > During lcore scan, find maximum socket ID and store it. > > Signed-off-by: Anatoly Burakov > --- > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -83,6 +83,7 @@ enum rte_proc_type_t { > struct rte_config { >

Re: [dpdk-dev] [PATCH v5 0/3] Support VxLAN GRO

2018-01-11 Thread Thomas Monjalon
10/01/2018 15:03, Jiayu Hu: > Jiayu Hu (3): > gro: codes cleanup > gro: comply RFC 6864 to process IPv4 ID > gro: support VxLAN GRO Applied, thanks

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-11 Thread John Daley (johndale)
Hi Declan and Shahaf, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Doherty, Declan > Sent: Tuesday, January 09, 2018 9:31 AM > To: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement > > On 24/12/2017 5:30

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-11 Thread John Daley (johndale)
Hi, One comment on DECAP action and a "feature request". I'll also reply to the top of thread discussion separately. Thanks for the RFC Declan! Feature request associated with ENCAP action: VPP (and probably other apps) would like the ability to simply specify an independent tunnel ID as part

Re: [dpdk-dev] [PATCHv4 5/5] doc: Add ABI __experimental tag documentation

2018-01-11 Thread Neil Horman
On Thu, Jan 11, 2018 at 08:06:48PM +, Ferruh Yigit wrote: > On 12/13/2017 3:17 PM, Neil Horman wrote: > > Document the need to add the __experimental tag to appropriate functions > > > > Signed-off-by: Neil Horman > > CC: Thomas Monjalon > > CC: "Mcnamara, John" > > CC: Bruce Richardson >

Re: [dpdk-dev] [PATCHv4 4/5] dpdk: add __experimental tag to appropriate api calls

2018-01-11 Thread Neil Horman
On Thu, Jan 11, 2018 at 08:06:33PM +, Ferruh Yigit wrote: > On 12/13/2017 3:17 PM, Neil Horman wrote: > > Append the __experimental tag to api calls appearing in the EXPERIMENTAL > > section of their libraries version map > > > > Signed-off-by: Neil Horman > > CC: Thomas Monjalon > > CC: "Mc

Re: [dpdk-dev] [PATCHv4 3/5] Makefiles: Add experimental tag check and warnings to trigger on use

2018-01-11 Thread Neil Horman
On Thu, Jan 11, 2018 at 08:06:43PM +, Ferruh Yigit wrote: > On 12/13/2017 3:17 PM, Neil Horman wrote: > > Add checks during build to ensure that all symbols in the EXPERIMENTAL > > version map section have __experimental tags on their definitions, and > > enable the warnings needed to announce

Re: [dpdk-dev] [PATCH v2] bus/pci: forbid VA as IOVA mode if IOMMU address width too small

2018-01-11 Thread Maxime Coquelin
Hi Jianfeng, On 01/09/2018 02:18 PM, Maxime Coquelin wrote: Intel VT-d supports different address widths for the IOVAs, from 39 bits to 56 bits. While recent processors support at least 48 bits, VT-d emulation currently only supports 39 bits. It makes DMA mapping to fail in this case when using

Re: [dpdk-dev] [PATCH] net/bonding: add ethdev ops function for MTU set

2018-01-11 Thread Ferruh Yigit
On 1/11/2018 7:12 PM, Sharmila Podury wrote: > From: Sharmila Podury > > Set the MTU for bonding device by calling .mtu_set for all > the slaves. Set the MTU only if all slaves support .mtu_set, > and there is no error returned from any slave. > > Signed-off-by: Sharmila Podury > Acked-by: Decl

Re: [dpdk-dev] [PATCHv4 5/5] doc: Add ABI __experimental tag documentation

2018-01-11 Thread Ferruh Yigit
On 12/13/2017 3:17 PM, Neil Horman wrote: > Document the need to add the __experimental tag to appropriate functions > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: "Mcnamara, John" > CC: Bruce Richardson > --- > doc/guides/contributing/versioning.rst | 9 + > 1 file change

Re: [dpdk-dev] [PATCHv4 3/5] Makefiles: Add experimental tag check and warnings to trigger on use

2018-01-11 Thread Ferruh Yigit
On 12/13/2017 3:17 PM, Neil Horman wrote: > Add checks during build to ensure that all symbols in the EXPERIMENTAL > version map section have __experimental tags on their definitions, and > enable the warnings needed to announce their use. Also add an > ALLOW_EXPERIMENTAL_APIS define to allow indi

Re: [dpdk-dev] [PATCHv4 4/5] dpdk: add __experimental tag to appropriate api calls

2018-01-11 Thread Ferruh Yigit
On 12/13/2017 3:17 PM, Neil Horman wrote: > Append the __experimental tag to api calls appearing in the EXPERIMENTAL > section of their libraries version map > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: "Mcnamara, John" > CC: Bruce Richardson > --- > lib/librte_eal/common/eal_co

[dpdk-dev] [PATCH v2] app/procinfo: Fix memory leak by rte_service_init

2018-01-11 Thread Vipin Varghese
When procinfo is run multiple times against primary application, it consumes huge page memory by rte_service_init. Which is not released at exit of application. Invoking rte_service_finalize to real memory and prevent memory leak. Signed-off-by: Vipin Varghese --- app/proc_info/main.c | 3 +++

[dpdk-dev] [PATCH v5 0/5] Introducing Wirless Base Band Device (bbdev) abstraction library

2018-01-11 Thread Amr Mokhtar
Hello, Latest update for Wireless Device abstraction library. v5: * Fixed patch titles * Fixed build error in bbdev test app * Few editorials v4: * Organized patch set * Enhanced bbdev sample app * Turbo operation application interface is better documented http://dpdk.org/dev/patchwork/patch/326

[dpdk-dev] [PATCH v5 5/5] bbdev: sample app

2018-01-11 Thread Amr Mokhtar
- sample application performing a loop-back over ethernet using a bbbdev device - 'turbo_sw' PMD must be enabled for the app to be functional - a packet is received on an ethdev port -> enqueued for baseband encode operation -> dequeued -> enqueued for baseband decode operation-> dequeued -> com

[dpdk-dev] [PATCH v5 3/5] bbdev: software turbo driver

2018-01-11 Thread Amr Mokhtar
- bbdev 'turbo_sw' is the software accelerated version of 3GPP L1 Turbo coding operation using the optimized Intel FlexRAN SDK libraries. - 'turbo_sw' pmd is disabled by default Signed-off-by: Amr Mokhtar Acked-by: Ferruh Yigit --- config/common_base |5 + d

[dpdk-dev] [PATCH v5 2/5] bbdev: null device driver

2018-01-11 Thread Amr Mokhtar
- 'bbdev_null' is a basic pmd that performs a minimalistic bbdev operation - useful for bbdev smoke testing and in measuring the overhead introduced by the bbdev library - 'bbdev_null' pmd is enabled by default Signed-off-by: Amr Mokhtar Acked-by: Ferruh Yigit --- MAINTAINERS

[dpdk-dev] [PATCH v5 1/5] bbdev: introducing wireless base band device abstraction lib

2018-01-11 Thread Amr Mokhtar
- wireless baseband device (bbdev) library files - bbdev is tagged as EXPERIMENTAL - Makefiles and configuration macros definition - bbdev library is enabled by default - release notes of the initial version Signed-off-by: Amr Mokhtar Acked-by: Ferruh Yigit --- MAINTAINERS

[dpdk-dev] [PATCH] net/bonding: add ethdev ops function for MTU set

2018-01-11 Thread Sharmila Podury
From: Sharmila Podury Set the MTU for bonding device by calling .mtu_set for all the slaves. Set the MTU only if all slaves support .mtu_set, and there is no error returned from any slave. Signed-off-by: Sharmila Podury Acked-by: Declan Doherty --- drivers/net/bonding/rte_eth_bond_pmd.c | 31

Re: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch option

2018-01-11 Thread Mody, Rasesh
Hi Ferruh, > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, January 11, 2018 9:50 AM > > On 11/8/2017 12:41 AM, Thomas Monjalon wrote: > > The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH > > has been added just before the 17.11 release. > > Such ne

Re: [dpdk-dev] [RFC v3] Compression API in DPDK :SW ZLIB PMD

2018-01-11 Thread Trahe, Fiona
Hi Shally, From: Verma, Shally [mailto:shally.ve...@cavium.com] Sent: Wednesday, January 10, 2018 8:33 AM To: Trahe, Fiona ; dev@dpdk.org Cc: Gupta, Ashish ; Sahu, Sunila ; Challa, Mahipal ; Athreya, Narayana Prasad ; De Lara Guarch, Pablo ; Jain, Deepak K ; Roy Pledge ; Youri Querry ; Hemant

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-01-11 Thread Trahe, Fiona
Hi Shally, Ahmed, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Wednesday, January 10, 2018 12:55 PM > To: Ahmed Mansour ; Trahe, Fiona > ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; Gupta, > Ashish > ; Sahu, Sunila ; De Lara > Guarch, Pablo > ;

Re: [dpdk-dev] [PATCH 4/6] ethdev: introduce TX common tunnel offloads

2018-01-11 Thread Ferruh Yigit
On 1/9/2018 2:11 PM, Xueming Li wrote: > This patch introduce new DEV_TX_OFFLOAD_GENERIC_TNL_CKSUM_TSO flag for > devices that support tunnel agnostic TX checksum and tso offloading. > > Checksum offset and TSO header length are calculated based on mbuf > inner length l*_len, outer_l*_len and tx o

Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table

2018-01-11 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Thursday, January 11, 2018 1:49 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Tomasz Duszynski > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table > > S

Re: [dpdk-dev] [PATCH] net/bnxt: fix check for on-chip resources

2018-01-11 Thread Ferruh Yigit
On 1/10/2018 10:12 PM, Ajit Khaparde wrote: > In some cases tx_nr_rings/rx_nr_rings may not be initialized. > In those scenarios, we may wrongly fail device initialization. > This patch fixes it. Use max_tx_rings/max_rx_rings instead. > > Fixes: 2da0426e7cf8 ("net/bnxt: check on-chip resources") >

Re: [dpdk-dev] [Bug 9] qays

2018-01-11 Thread Thomas Monjalon
11/01/2018 19:07, bugzi...@dpdk.org: > https://dpdk.org/tracker/show_bug.cgi?id=9 > > Bug ID: 9 >Summary: qays >Product: DPDK >Version: 16.04 > Hardware: x86 > OS: Other > Status: CONFIRMED > Severity:

[dpdk-dev] [PATCH v2] service: fix memory leak by rte_service_init

2018-01-11 Thread Vipin Varghese
This patch fixes the memory leak created by rte_service_init. When secondary application which shares the huge page from primary, is executed multiple times memory is initialized but not freed on exit The rte_service_finalize checks if the service is initialized. If yes, it frees up rte_services &

Re: [dpdk-dev] [PATCH v4 1/4] lib/librte_flow_classify: remove table id parameter from apis

2018-01-11 Thread Thomas Monjalon
19/12/2017 15:29, Jasvinder Singh: > This patch removes table id parameter from all the flow > classify apis to reduce the complexity alongwith some code > cleanup. > > The validate api is exposed as public api to allow user > to validate the flow before adding it to the classifier. > > Signed-of

Re: [dpdk-dev] [PATCH v1] [net/pcap] fix the NUMA id display in logs.

2018-01-11 Thread Ferruh Yigit
On 1/11/2018 6:06 PM, Ferruh Yigit wrote: > On 12/22/2017 4:38 AM, Vipin Varghese wrote: >> On single NUMA device the log information shows as boundary value >> instead of -1. The change brings in unsinged to signed. >> >> Signed-off-by: Vipin Varghese > > Acked-by: Ferruh Yigit Applied to dpdk

[dpdk-dev] [Bug 9] qays

2018-01-11 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=9 Bug ID: 9 Summary: qays Product: DPDK Version: 16.04 Hardware: x86 OS: Other Status: CONFIRMED Severity: major Priority: Normal Component: othe

Re: [dpdk-dev] [PATCH v2] igb_uio: convert license headers to SPDX tags

2018-01-11 Thread Thomas Monjalon
19/12/2017 01:03, Ferruh Yigit: > Signed-off-by: Ferruh Yigit Applied (Makefile was already updated), thanks

Re: [dpdk-dev] [PATCH v1] [net/pcap] fix the NUMA id display in logs.

2018-01-11 Thread Ferruh Yigit
On 12/22/2017 4:38 AM, Vipin Varghese wrote: > On single NUMA device the log information shows as boundary value > instead of -1. The change brings in unsinged to signed. > > Signed-off-by: Vipin Varghese Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 3/3] test: update cryptodev tests with skipped value

2018-01-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, January 11, 2018 5:51 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Richardson, > Bruce ; Van Haaren, Harry > > Subject: [PATCH v2 3/3] test: update cryptodev tests with skipped value > > The cryptodev tests are upda

Re: [dpdk-dev] [PATCH v2 2/3] test: add skipped return result

2018-01-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, January 11, 2018 5:51 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Richardson, > Bruce ; Van Haaren, Harry > > Subject: [PATCH v2 2/3] test: add skipped return result > > This commit allows a test to return "skipped

Re: [dpdk-dev] [PATCH v3 0/3] improve failsafe performance

2018-01-11 Thread Ferruh Yigit
On 12/19/2017 5:14 PM, Matan Azrad wrote: > This fail-safe series should improve some cycles in failsafe data path. > It is obvious that we cannot improve a lot because the most of data path > functionality are done by the sub devices data path. > So the expectation from this series is just to imp

Re: [dpdk-dev] [PATCH] net/e1000: add minimum support for Broadcom 54616 PHY

2018-01-11 Thread Chas Williams
I derived that value by observing what the ixgbe finds when loading on my platform. The docs for the platform say that the attached PHY is a Broadcom 54616. I couldn't find any documentation on this PHY to determine what this value is (i.e. is it really some sort of ID string for that PHY).I

Re: [dpdk-dev] [PATCH v2] net/pcap: convert license headers to SPDX tags

2018-01-11 Thread Thomas Monjalon
10/01/2018 07:28, Hemant Agrawal: > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright(c) 2010-2014 Intel Corporation. > > +# Copyright(c) 2014 6WIND S.A. > > +# All rights reserved. > > This patch should get an explicit ACK from 6 wind. Cc some 6WIND guys.

Re: [dpdk-dev] [PATCH v3] kni: convert license headers to SPDX tags

2018-01-11 Thread Thomas Monjalon
10/01/2018 07:46, Hemant Agrawal: > On 1/9/2018 9:00 PM, Ferruh Yigit wrote: > > On 1/9/2018 3:24 PM, Thomas Monjalon wrote: > >> 09/01/2018 16:12, Ferruh Yigit: > >>> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > >>> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kn

[dpdk-dev] [PATCH v2 3/3] test: update cryptodev tests with skipped value

2018-01-11 Thread Harry van Haaren
The cryptodev tests are updated to return SKIPPED instead of failing if the PMD is not enabled, allowing test infrastructure to identify that the test was not able to run. Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- v2: - Split cryptodev test changes into own patch (Pab

[dpdk-dev] [PATCH v2 2/3] test: add skipped return result

2018-01-11 Thread Harry van Haaren
This commit allows a test to return "skipped", indicating that it cannot be run. This is useful for PMDs which have not been compiled due to the unavailability of dependencies, or their explicit disabling in the build configuration. The result printing is updated to correctly indicate if a test ha

[dpdk-dev] [PATCH v2 1/3] test: use env variable to run tests

2018-01-11 Thread Harry van Haaren
With this patch the test binary checks the DPDK_TEST environment variable and if set, the contents of the var are inserted on the test app command line, and run. Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren Reviewed-by: Pablo de Lara --- v2: - Added Pablo's reviewed-by Not

Re: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch option

2018-01-11 Thread Ferruh Yigit
On 11/8/2017 12:41 AM, Thomas Monjalon wrote: > The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH > has been added just before the 17.11 release. > Such new options are forbidden and must be replaced by a run-time option. > If it is not replaced in 18.02-rc1, this removal will be applied.

[dpdk-dev] [PATCH v4 4/5] net/tap: add eBPF API

2018-01-11 Thread Ophir Munk
This commit include BPF API to be used by TAP. tap_flow_bpf_cls_q() - download to kernel BPF program that classifies packets to their matching queues tap_flow_bpf_calc_l3_l4_hash() - download to kernel BPF program that calculates per packet layer 3 and layer 4 RSS hash tap_flow_bpf_rss_map_create(

[dpdk-dev] [PATCH v4 5/5] net/tap: implement TAP RSS using eBPF

2018-01-11 Thread Ophir Munk
TAP PMD is required to support RSS queue mapping based on rte_flow API. An example usage for this requirement is failsafe transparent switching from a PCI device to TAP device while keep redirecting packets to the same RSS queues on both devices. TAP RSS implementation is based on eBPF programs se

[dpdk-dev] [PATCH v4 3/5] net/tap: add eBPF program file

2018-01-11 Thread Ophir Munk
File tap_bpf_program.c was added with two ELF sections corresponding to two BPF programs and one BPF map. It is the C source file used to generate the eBPF bytes code (see "net/tap: add eBPF bytes code"). Section cls_q - BPF classifier to classify packets to their corresponding queue after an RSS

[dpdk-dev] [PATCH v4 1/5] net/tap: support actions for different classifiers

2018-01-11 Thread Ophir Munk
Add a generic TC actions handling for TC actions: "mirred", "gact", "skbedit". This will be useful when introducing BPF actions, as it uses TCA_BPF_ACT instead of TCA_FLOWER_ACT Signed-off-by: Ophir Munk --- drivers/net/tap/Makefile | 8 ++ drivers/net/tap/rte_eth_tap.h | 4 +- drivers/

[dpdk-dev] [PATCH v4 0/5] TAP RSS eBPF cover letter

2018-01-11 Thread Ophir Munk
The patches of TAP RSS eBPF follow the RFC on this issue https://dpdk.org/dev/patchwork/patch/31781/ v4 changes with respect to v3 = * Code updates based on review comments * New commits organization (2-->5) based on review comments 1. net/tap: support actions for dif

Re: [dpdk-dev] [PATCH] kni: fix build dependency

2018-01-11 Thread Thomas Monjalon
> > kni library has a dependency to new PCI library, adding that dependency. > > > > build error: > > CC rte_kni.o > > In file included from dpdk/lib/librte_kni/rte_kni.c:48:0: > > dpdk/build/include/rte_kni.h:49:21: > > fatal error: rte_pci.h: No such file or directory > > #include > >

[dpdk-dev] [PATCH v4 2/5] net/tap: add eBPF bytes code

2018-01-11 Thread Ophir Munk
File tap_bpf_insns.h was added with eBPF bytes code. The bytes code is in the format of C array of struct bpf_insn It was generated from C source file by external tools. 1. The C file was compiled via LLVM into an object file in ELF format as: clang -O2 -emit-llvm -c tap_bpf_program.c -o - | llc -

Re: [dpdk-dev] [PATCH] net/sfc/base: change license to BSD-3-Clause

2018-01-11 Thread Ferruh Yigit
On 1/11/2018 1:42 PM, Andrew Rybchenko wrote: > Change license from BSD-2-Clause-FreeBSD to BSD-3-Clause. > Bump copyright year. > > Fixes: 0b6f6260ac6c ("net/sfc/base: change license to BSD-3-Clause") > Cc: Ferruh Yigit > > Signed-off-by: Andrew Rybchenko > --- > Could you squash the patch int

Re: [dpdk-dev] [PATCH 2/2] doc: Fix typo

2018-01-11 Thread Thomas Monjalon
11/12/2017 16:20, Mcnamara, John: > > Fix trivial typo (an -> and) in description of service core masks. > > > > Signed-off-by: Roy Franz > > Thanks. For future reference the subject line should be lowercase like: > > doc: fix typo > > Or better > > doc: fix typo in service cores doc

Re: [dpdk-dev] [PATCH v3] net/i40e: fix VF reset stats crash

2018-01-11 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David C Harton > Sent: Thursday, January 11, 2018 3:14 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; David C Harton ; Zhao1, Wei > > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix VF reset stats crash > > Calling i40evf_dev_xstats

Re: [dpdk-dev] [PATCH v6 01/23] eventtimer: add event timer adapter API

2018-01-11 Thread Pavan Nikhilesh
On Thu, Jan 11, 2018 at 04:56:40PM +, Carrillo, Erik G wrote: > > > -Original Message- > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Thursday, January 11, 2018 5:11 AM > > To: Carrillo, Erik G ; > > jerin.ja...@caviumnetworks.com; nipun.gu...@nxp.com; > >

Re: [dpdk-dev] [PATCH v6 08/23] eventtimer: add adapter start/stop definitions

2018-01-11 Thread Pavan Nikhilesh
On Wed, Jan 10, 2018 at 06:20:59PM -0600, Erik Gabriel Carrillo wrote: > Add definitions to the default software implementation for the functions > that start and stop adapter instances. > > Signed-off-by: Erik Gabriel Carrillo > --- > lib/librte_eventdev/rte_event_timer_adapter.c | 19 ++

[dpdk-dev] [PATCH 3/3] test: increase rx and tx default ring sizes

2018-01-11 Thread Kevin Laatz
Increase the default RX/TX ring sizes to 1024/1024 to accomodate for NICs with higher throughput (25G, 40G etc) Signed-off-by: Kevin Laatz --- Cc: ferruh.yi...@intel.com Cc: declan.dohe...@intel.com --- test/test/test_kni.c| 4 ++-- test/test/test_link_bonding.c | 4 ++--

[dpdk-dev] [PATCH 2/3] app/testpmd: increase rx and tx default ring size

2018-01-11 Thread Kevin Laatz
Signed-off-by: Kevin Laatz --- Cc: wenzhou...@intel.com Cc: jingjing...@intel.com --- app/test-pmd/testpmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 47e145c..597c703 100644 --- a/app/test-pmd/testpmd.c +++ b/ap

[dpdk-dev] [PATCH 2/3] app/testpmd: increase rx and tx default ring sizes

2018-01-11 Thread Kevin Laatz
Increase the default RX/TX ring sizes to 1024/1024 to accomodate for NICs with higher throughput (25G, 40G etc) Signed-off-by: Kevin Laatz --- Cc: wenzhou...@intel.com Cc: jingjing...@intel.com --- app/test-pmd/testpmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ap

[dpdk-dev] [PATCH 0/3] Increase default RX/TX ring sizes

2018-01-11 Thread Kevin Laatz
Increasing the RX/TX default ring size to 1024/1024 to accommodate for faster NICs. With the increase of number of PPS, a larger RX buffer is required in order to avoid packet loss. While a ring size of 128 may be large enough for 1G and possibly 10G NICs, this is not going to scale to small packet

[dpdk-dev] [PATCH 1/3] examples: increase rx and tx default ring sizes

2018-01-11 Thread Kevin Laatz
Increase the default RX/TX ring sizes to 1024/1024 to accomodate for NICs with higher throughput (25G, 40G etc) Signed-off-by: Kevin Laatz --- Cc: ferruh.yi...@intel.com Cc: declan.dohe...@intel.com Cc: bruce.richard...@intel.com Cc: remy.hor...@intel.com Cc: bernard.iremon...@intel.com Cc: kons

Re: [dpdk-dev] [PATCH v3 2/2] net/tap: implement RSS with eBPF classifier and action

2018-01-11 Thread Ophir Munk
Hi Pascal, Please see inline > -Original Message- > From: Pascal Mazon [mailto:pascal.ma...@6wind.com] > Sent: Wednesday, January 10, 2018 12:20 PM > To: Ophir Munk ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > > Subject: Re: [PATCH v3 2/2] net/tap: implement RSS with eBPF classifie

  1   2   3   >