[dpdk-dev] [PATCH] net/virtio: fix memory leak

2017-10-25 Thread Pengzhen Liu
In function eth_virtio_dev_init(), dynamic memory stored in "eth_dev->data->mac_addrs" variable and it is not freed whe function return, this is a possible memory leak. Fixes: 6b9ed026a870 ("net/virtio: eth_dev->data->mac_addrs is not freed") Cc: sta...@dpdk.org Signed-off-by: Pengzhen Liu --- d

[dpdk-dev] [PATCH] cfgfile: fix NULL pointer dereference

2017-10-25 Thread Jacek Piasecki
Function memchr() could return NULL and assign it to split[1] pointer. Additional check and error handing is made after memchr() call. Coverity issue: 195004 Fixes: a6a47ac9c2c9 ("cfgfile: rework load function") Cc: jacekx.piase...@intel.com Cc: sta...@dpdk.org Signed-off-by: Jacek Piasecki ---

Re: [dpdk-dev] [PATCH] test: provide performance difference ratio and test time

2017-10-25 Thread Jianbo Liu
The 10/25/2017 15:13, Herbert Guan wrote: > The printed time values presented in TSC is not straight forward > showing the performance difference. And if the high resolution > counter is not enabled, time value is too small to show the actual > performance (e.g. "1 - 1" seems the same but in fact

[dpdk-dev] [PATCH] cfgfile: fix resource leak

2017-10-25 Thread Jacek Piasecki
Unsuccesfull memory allocation for elements inside cfgfile structure could result in resource leak. Fixed by pointer verification after each malloc, if malloc fail - error branch is proceeded with freeing memory. Coverity issue: 195032 Fixes: d4cb8197589d ("cfgfile: support runtime modification")

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix TSO inline size calculation

2017-10-25 Thread Shahaf Shuler
Thursday, October 26, 2017 2:31 AM, Yongseok Koh: > When "net/mlx5: replace network to host macros" is rebased for v4, changes > of "net/mlx5: fix calculating TSO inline size" have been reverted. > > Fixes: 6b30a6a8552a ("net/mlx5: replace network to host macros") > Cc: sta...@dpdk.org > Cc: Shach

[dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

2017-10-25 Thread wangzhike
The max_mtu is kept as zero in case no CRTL channel, which leads to failure when calling virtio_mtu_set(). Signed-off-by: wangzhike --- drivers/net/virtio/virtio_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-25 Thread Jia He
Hi Jerin On 10/25/2017 9:26 PM, Jerin Jacob Wrote: -Original Message- Date: Tue, 24 Oct 2017 10:04:26 +0800 From: Jia He To: Jerin Jacob Cc: "Ananyev, Konstantin" , "Zhao, Bing" , Olivier MATZ , "dev@dpdk.org" , "jia...@hxt-semitech.com" , "jie2@hxt-semitech.com" , "bing.

Re: [dpdk-dev] [PATCH] net/liquidio: add support for 10GBase-T cards

2017-10-25 Thread Srisivasubramanian Srinivasan
On Wed, 2017-10-25 at 11:23 -0700, Ferruh Yigit wrote: > On 10/25/2017 11:06 AM, Srisivasubramanian Srinivasan wrote: > > On Tue, 2017-10-24 at 10:49 -0700, Ferruh Yigit wrote: > >> On 10/23/2017 9:42 PM, Srisivasubramanian S wrote: > >>> Signed-off-by: Srisivasubramanian S > >>> Signed-off-by: Sh

Re: [dpdk-dev] [PATCH v6 00/10] introduce security offload library

2017-10-25 Thread Thomas Monjalon
25/10/2017 17:07, Akhil Goyal: > This patchset introduce the rte_security library in DPDK. > This also includes the sample implementation of drivers and > changes in ipsec gateway application to demonstrate its usage. [...] > Akhil Goyal (5): > cryptodev: support security APIs > security: intro

Re: [dpdk-dev] [pull-request] next-crypto 17.11 rc2

2017-10-25 Thread Thomas Monjalon
25/10/2017 18:18, Pablo de Lara: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-10-25 Thread Mody, Rasesh
Hi Ferruh, > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, October 20, 2017 9:58 AM > > On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > Remove device reset during application start, the reset for > > application exit still there. > > > > Reset in open removed be

[dpdk-dev] [PATCH] net/mlx5: fix TSO inline size calculation

2017-10-25 Thread Yongseok Koh
When "net/mlx5: replace network to host macros" is rebased for v4, changes of "net/mlx5: fix calculating TSO inline size" have been reverted. Fixes: 6b30a6a8552a ("net/mlx5: replace network to host macros") Cc: sta...@dpdk.org Cc: Shachar Beiser Signed-off-by: Yongseok Koh --- drivers/net/mlx5

Re: [dpdk-dev] [PATCH v8 3/4] bus/vdev: move to vdev bus to drivers/bus

2017-10-25 Thread Gaëtan Rivet
Hello Jianfeng, On Wed, Oct 25, 2017 at 05:10:45PM +, Jianfeng Tan wrote: > Move the vdev bus from lib/librte_eal to drivers/bus. > > As the crypto vdev helper function refers to data structure > in rte_vdev.h, so we move those helper function into drivers/bus > too. > > Signed-off-by: Jianf

Re: [dpdk-dev] [PATCH] doc: update failsafe feature list

2017-10-25 Thread Gaëtan Rivet
On Wed, Oct 25, 2017 at 11:44:39AM -0700, Ferruh Yigit wrote: > On 9/23/2017 10:55 PM, Matan Azrad wrote: > > Hi Ferruh > > > >> -Original Message- > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Friday, September 22, 2017 1:32 PM > >> To: Matan Azrad ; Gaetan Rivet > >>

[dpdk-dev] [PATCH v7 25/25] maintainers: claim maintainership of PCI lib

2017-10-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c072d03..0fd6cab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -870,6 +870,10 @@ Latency statistics M: Reshma Pattan F: lib/librte_latencystats/ +PCI +M: Gaetan

[dpdk-dev] [PATCH v7 22/25] net/bonding: use local prefix for local function

2017-10-25 Thread Gaetan Rivet
The current name conflicts with the librte_pci naming convention. Additionally, it is easier to use gdb when having prefixed even private functions. Signed-off-by: Gaetan Rivet --- drivers/net/bonding/rte_eth_bond_args.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH v7 24/25] doc: add notes on EAL PCI API update

2017-10-25 Thread Gaetan Rivet
Add a section related to EAL API changes to 17.11 release notes. Signed-off-by: Gaetan Rivet Acked-by: John McNamara --- doc/guides/rel_notes/release_17_11.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/

[dpdk-dev] [PATCH v7 21/25] pci: use EAL exposed configuration

2017-10-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/eal_pci.c| 2 +- lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 2 +- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 18 +++--- 4 files changed, 14 insertions(+), 10 del

[dpdk-dev] [PATCH v7 20/25] pci: do not expose IOVA mode getter

2017-10-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_private.h | 10 ++ lib/librte_eal/common/include/rte_pci.h | 10 -- lib/librte_eal/rte_eal_version.map | 1 - 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/lib/librte_eal/common/eal_private.h b

[dpdk-dev] [PATCH v7 18/25] pci: do not expose private functions

2017-10-25 Thread Gaetan Rivet
make the functions + rte_pci_detach + rte_pci_probe + rte_pci_probe_one + rte_pci_scan private as there is no point in using them outside of the rte_bus framework. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_private.h | 49 + lib/li

[dpdk-dev] [PATCH v7 19/25] pci: do not expose PCI match function

2017-10-25 Thread Gaetan Rivet
This function is private to the PCI bus. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_private.h | 15 +++ lib/librte_eal/common/include/rte_pci.h | 16 lib/librte_eal/rte_eal_version.map | 1 - 3 files changed, 15 insertions(+), 17 deletions(-)

[dpdk-dev] [PATCH v7 16/25] pci: use new PCI addr comparison function

2017-10-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/eal_pci.c| 2 +- lib/librte_eal/common/eal_common_pci.c | 8 lib/librte_eal/common/eal_common_pci_uio.c | 4 ++-- lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 4 ++--

[dpdk-dev] [PATCH v7 17/25] pci: use new PCI addr parsing function

2017-10-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index bf8a96c..0a51dd8 100644 --- a/lib/librte_eal/common/eal_common_pci.c

[dpdk-dev] [PATCH v7 15/25] pci: make specialized parsing functions private

2017-10-25 Thread Gaetan Rivet
Do not expose the minute implementations of PCI parsing. This leaves only the all-purpose rte_pci_addr_parse, which is simpler to use. Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/deprecation.rst| 6 ++ lib/librte_eal/common/eal_common_pci.c | 4 ++-- lib/librte_eal/common/inc

[dpdk-dev] [PATCH v7 11/25] pci: avoid inlining functions

2017-10-25 Thread Gaetan Rivet
Parsing operations should not happen in performance critical sections. Headers should not propose implementations unless duly required. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 68 lib/librte_eal/common/include/rte_pci.h | 69 +++-

[dpdk-dev] [PATCH v7 14/25] pci: introduce PCI address parsing function

2017-10-25 Thread Gaetan Rivet
A new single function that is able to parse all currently supported format: * Domain-Bus-Device-Function *Bus-Device-Function Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 9 + lib/librte_eal/common/include/rte_pci.h | 14 ++ lib/li

[dpdk-dev] [PATCH v7 12/25] pci: avoid over-complicated macro

2017-10-25 Thread Gaetan Rivet
Using a macro helps writing the code to the detriment of the reader in this case. This is backward. Write once, read many. The few LOCs gained is not worth the opacity of the implementation. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 67 +++-

[dpdk-dev] [PATCH v7 13/25] pci: deprecate misnamed functions

2017-10-25 Thread Gaetan Rivet
Rename misnamed functions and describe the change in a deprecation notice. Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/deprecation.rst| 9 +++ lib/librte_eal/common/eal_common_pci.c | 27 --- lib/librte_eal/common/include/rte_pci.h | 47

[dpdk-dev] [PATCH v7 06/25] eal: expose internal config elements

2017-10-25 Thread Gaetan Rivet
Some internal configuration elements set by the user on the command line are necessary outside the EAL, when the PCI bus is detached. Expose: + rte_eal_create_uio_dev + rte_eal_has_pci + rte_eal_vfio_intr_mode Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/eal.c | 16 ++

[dpdk-dev] [PATCH v7 10/25] vfio: move PCI-related functions out of vfio header

2017-10-25 Thread Gaetan Rivet
These two declarations are only relevant to PCI operations and should be in a related header. Signed-off-by: Gaetan Rivet --- lib/librte_eal/linuxapp/eal/eal_pci_init.h | 2 ++ lib/librte_eal/linuxapp/eal/eal_vfio.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/l

[dpdk-dev] [PATCH v7 09/25] vfio: check PCI dependency from within PCI code

2017-10-25 Thread Gaetan Rivet
PCI sometimes requires vfio to be enabled. Move the check from EAL init to PCI bus scan. Signed-off-by: Gaetan Rivet --- lib/librte_eal/linuxapp/eal/eal.c | 5 - lib/librte_eal/linuxapp/eal/eal_pci.c | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v7 07/25] eal: expose vfio symbols

2017-10-25 Thread Gaetan Rivet
The following symbols are used by vfio implementations within the PCI bus. They need to be publicly available for the PCI bus to be outside the EAL. + vfio_enable; + vfio_is_enabled; + vfio_noiommu_is_enabled; + vfio_release_device; + vfio_setup_device; PCI-related files (either source

[dpdk-dev] [PATCH v7 08/25] vfio: remove useless PCI headers and add vfio one

2017-10-25 Thread Gaetan Rivet
PCI headers are not necessary and are making this module dependent on the PCI subsystem. The internal eal_vfio.h header was necessary however for shared build. Signed-off-by: Gaetan Rivet --- lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[dpdk-dev] [PATCH v7 04/25] eal: include common header

2017-10-25 Thread Gaetan Rivet
The macro RTE_SET_USED is defined in rte_common.h This header is included through eal_private.h, which includes in turn rte_pci.h Once the PCI subsystem is out of the EAL, this will break the compilation (seen on FreeBSD). Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/arch/x86/rte_cycl

[dpdk-dev] [PATCH v7 05/25] eal: expose rte_eal_using_phys_addrs

2017-10-25 Thread Gaetan Rivet
This function was previously private to the EAL layer. Other subsystems requires it, such as the PCI bus. In order not to force other components to include stdbool, which is incompatible with several NIC drivers, the return type has been changed from bool to int. Signed-off-by: Gaetan Rivet ---

[dpdk-dev] [PATCH v7 00/25] Move PCI away from the EAL

2017-10-25 Thread Gaetan Rivet
Hi all, Here is a new version of the PCI bus move out of the EAL. The EAL PCI implementation is divided in two parts: - librte_pci: library offering helpers to handle PCI objects - librte_bus_pci: bus driver for PCI devices This allows other libraries / tools to use PCI elements (location,

[dpdk-dev] [PATCH v7 01/25] ethdev: remove useless PCI dependency

2017-10-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 0b1e928..e91c963 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -47,7 +47,6 @@ #

[dpdk-dev] [PATCH v7 02/25] eal: include debug header in bus source

2017-10-25 Thread Gaetan Rivet
This header is included through rte_pci.h, which will be removed once the PCI bus is moved out of the EAL. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/ea

[dpdk-dev] [PATCH v7 03/25] eal: include stdint in private header

2017-10-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_private.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 6e0f85d..9340b6e 100644 --- a/lib/librte_eal/common/eal_private.h +++ b/lib/librte_eal/common/ea

Re: [dpdk-dev] [PATCH] test: fix build without flow classify

2017-10-25 Thread Thomas Monjalon
> > The unit test for flow classify should be disabled if the library is > > disabled in > > the configuration. > > > > Fixes: 9c9befea4f57 ("test: add flow classify unit tests") > > Cc: bernard.iremon...@intel.com > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Bernard Iremonger Appli

Re: [dpdk-dev] [PATCH] doc: remove trailing commas in API index

2017-10-25 Thread Thomas Monjalon
> > Signed-off-by: Thomas Monjalon > > Acked-by: John McNamara Applied

[dpdk-dev] [pull-request] next-net 17.11 RC2

2017-10-25 Thread Ferruh Yigit
The following changes since commit b17b952ec3c60030ab5e93c6734d62922de9c8f7: service: allow to disable core check (2017-10-25 17:05:38 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 5a6cb88cd1d13e033216b38f161580671e5382

Re: [dpdk-dev] [PATCH v5] ethdev: allow returning error on VLAN offload ops

2017-10-25 Thread Ferruh Yigit
On 10/24/2017 8:01 PM, Ferruh Yigit wrote: > From: David Harton > > Some devices may not support or fail setting VLAN offload > configuration based on dynamic circumstances so the > vlan_offload_set_t vector is modified to return an int so > the caller can determine success or not. > > rte_eth_d

Re: [dpdk-dev] [PATCH] net/bonding: fix check slaves link properties

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 3:01 PM, Ferruh Yigit wrote: > On 10/20/2017 8:49 AM, Tomasz Kulasek wrote: >> Result of slaves link properties validation is not used when new slave >> is added. >> >> This patch uses the value of link_properties_valid() to determinate if >> slave can be used in the bonding. If funct

Re: [dpdk-dev] [PATCH] net/bonding: fix check slaves link properties

2017-10-25 Thread Ferruh Yigit
On 10/20/2017 8:49 AM, Tomasz Kulasek wrote: > Result of slaves link properties validation is not used when new slave > is added. > > This patch uses the value of link_properties_valid() to determinate if > slave can be used in the bonding. If function fails, error is returned > preventing to add

Re: [dpdk-dev] [PATCH] net/mlx5: fix device stop with multiple regions

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 7:04 AM, Nelio Laranjeiro wrote: > LIST macro are not safe when inside a LIST_FOREACH() a LIST_REMOVE() is > called to remove an entry, this behavior is undefined causing some entries > to disappear from the list. > > Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx q

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix adjust priority for drop queue

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 9:41 AM, Yongseok Koh wrote: > >> On Oct 25, 2017, at 1:25 AM, Nelio Laranjeiro >> wrote: >> >> Drop queue should also adjust their priority according the most specific >> layer in the pattern they are matching to avoid dropping all the traffic. >> >> Fixes: 8086cf08b2f0 ("net/mlx5

Re: [dpdk-dev] [PATCH v2 2/7] net/mlx4: inline more Tx functions

2017-10-25 Thread Ophir Munk
Hi Adrien, On Wednesday, October 25, 2017 7:50 PM, Adrien Mazarguil wrote: > > Hi Ophir, > > On Mon, Oct 23, 2017 at 02:21:55PM +, Ophir Munk wrote: > > Change functions to inline on Tx fast path to improve performance > > > > Inside the inline function call other functions to handle "unlike

Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets

2017-10-25 Thread Ferruh Yigit
On 10/15/2017 5:43 PM, Lu, Wenzhuo wrote: > Hi, > >> -Original Message- >> From: Roger B Melton [mailto:rmel...@cisco.com] >> Sent: Friday, October 13, 2017 1:25 AM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org; Roger B Melton >> Subject: [PATCH v2] net/e1000: correct VLAN tag byte order for i3

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix Tx doorbell memory barrier

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 2:19 AM, Nélio Laranjeiro wrote: > On Tue, Oct 24, 2017 at 05:27:25PM -0700, Yongseok Koh wrote: >> Configuring UAR as IO-mapped makes maximum throughput decline by noticeable >> amount. If UAR is configured as write-combining register, a write memory >> barrier is needed on ringing a

Re: [dpdk-dev] [PATCH v8 3/4] bus/vdev: move to vdev bus to drivers/bus

2017-10-25 Thread De Lara Guarch, Pablo
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, October 25, 2017 6:11 PM > To: dev@dpdk.org > Cc: jblu...@infradead.org; Richardson, Bruce > ; Ananyev, Konstantin > ; De Lara Guarch, Pablo > ; tho...@monjalon.net; > y...@fridaylinux.org; maxime.coque...@redhat.co

Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 1:48 PM, Richardson, Bruce wrote: > > >> -Original Message- >> From: Roger B. Melton [mailto:rmel...@cisco.com] >> Sent: Wednesday, October 25, 2017 9:45 PM >> To: Yigit, Ferruh ; Richardson, Bruce >> >> Cc: Lu, Wenzhuo ; dev@dpdk.org; Ananyev, Konstantin >> >> Subject: Re

Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets

2017-10-25 Thread Richardson, Bruce
> -Original Message- > From: Roger B. Melton [mailto:rmel...@cisco.com] > Sent: Wednesday, October 25, 2017 9:45 PM > To: Yigit, Ferruh ; Richardson, Bruce > > Cc: Lu, Wenzhuo ; dev@dpdk.org; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte ord

Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets

2017-10-25 Thread Roger B. Melton
On 10/25/17 4:22 PM, Ferruh Yigit wrote: On 10/25/2017 1:16 PM, Bruce Richardson wrote: On Wed, Oct 25, 2017 at 11:11:08AM -0700, Ferruh Yigit wrote: On 10/23/2017 10:42 AM, Roger B. Melton wrote: On 10/20/17 3:04 PM, Ferruh Yigit wrote: On 10/12/2017 10:24 AM, Roger B Melton wrote: When cop

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test-pmd: fix compiler error with drivers disabled

2017-10-25 Thread Bruce Richardson
On Wed, Oct 25, 2017 at 01:20:30PM -0700, Ferruh Yigit wrote: > On 10/25/2017 1:09 PM, Bruce Richardson wrote: > > When both ixgbe and bnxt drivers are disabled at build time, testpmd has > > a compiler errors due to unused parameters, and unused variables. > > > > Fixes: 36735a932ca7 ("net/bnxt:

Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 1:16 PM, Bruce Richardson wrote: > On Wed, Oct 25, 2017 at 11:11:08AM -0700, Ferruh Yigit wrote: >> On 10/23/2017 10:42 AM, Roger B. Melton wrote: >>> On 10/20/17 3:04 PM, Ferruh Yigit wrote: On 10/12/2017 10:24 AM, Roger B Melton wrote: > When copying VLAN tags from the RX d

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test-pmd: fix compiler error with drivers disabled

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 1:09 PM, Bruce Richardson wrote: > When both ixgbe and bnxt drivers are disabled at build time, testpmd has > a compiler errors due to unused parameters, and unused variables. > > Fixes: 36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof") > CC: sta...@dpdk.org > > Signe

Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets

2017-10-25 Thread Bruce Richardson
On Wed, Oct 25, 2017 at 11:11:08AM -0700, Ferruh Yigit wrote: > On 10/23/2017 10:42 AM, Roger B. Melton wrote: > > On 10/20/17 3:04 PM, Ferruh Yigit wrote: > >> On 10/12/2017 10:24 AM, Roger B Melton wrote: > >>> When copying VLAN tags from the RX descriptor to the vlan_tci field > >>> in the mbuf

[dpdk-dev] [PATCH] app/test-pmd: fix compiler error with drivers disabled

2017-10-25 Thread Bruce Richardson
When both ixgbe and bnxt drivers are disabled at build time, testpmd has a compiler errors due to unused parameters, and unused variables. Fixes: 36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof") CC: sta...@dpdk.org Signed-off-by: Bruce Richardson --- app/test-pmd/cmdline.c | 5 +

Re: [dpdk-dev] [PATCH] doc: update failsafe feature list

2017-10-25 Thread Ferruh Yigit
On 9/23/2017 10:55 PM, Matan Azrad wrote: > Hi Ferruh > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Friday, September 22, 2017 1:32 PM >> To: Matan Azrad ; Gaetan Rivet >> >> Cc: dev@dpdk.org; john.mcnam...@intel.com >> Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v2] net/octeontx: fix build for gcc < 4.6

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 10:17 AM, Ferruh Yigit wrote: > -Ofast option supported starting from gcc4.6 [1], for older versions > using "-O3 -ffast-math" instead. > > [1] build error: > CC octeontx_rxtx.o > cc1: error: invalid option argument ‘-Ofast’ > > Fixes: 9e747589bd4c ("net/octeontx: add packet tra

Re: [dpdk-dev] [PATCH] net/liquidio: add support for 10GBase-T cards

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 11:06 AM, Srisivasubramanian Srinivasan wrote: > On Tue, 2017-10-24 at 10:49 -0700, Ferruh Yigit wrote: >> On 10/23/2017 9:42 PM, Srisivasubramanian S wrote: >>> Signed-off-by: Srisivasubramanian S >>> Signed-off-by: Shijith Thotton >>> --- >>> doc/guides/nics/liquidio.rst

Re: [dpdk-dev] [PATCH v2] mbuf: rename deprecated VLAN flags

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 10:42 AM, Ferruh Yigit wrote: > On 10/25/2017 8:12 AM, Olivier Matz wrote: >> PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. >> As explained in [1], these flags were kept to let the applications and >> PMDs move to the new flag. There is also a need to support Rx vlan

Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets

2017-10-25 Thread Ferruh Yigit
On 10/23/2017 10:42 AM, Roger B. Melton wrote: > On 10/20/17 3:04 PM, Ferruh Yigit wrote: >> On 10/12/2017 10:24 AM, Roger B Melton wrote: >>> When copying VLAN tags from the RX descriptor to the vlan_tci field >>> in the mbuf header, igb_rxtx.c:eth_igb_recv_pkts() and >>> eth_igb_recv_scattered_p

Re: [dpdk-dev] [PATCH] net/liquidio: add support for 10GBase-T cards

2017-10-25 Thread Srisivasubramanian Srinivasan
On Tue, 2017-10-24 at 10:49 -0700, Ferruh Yigit wrote: > On 10/23/2017 9:42 PM, Srisivasubramanian S wrote: > > Signed-off-by: Srisivasubramanian S > > Signed-off-by: Shijith Thotton > > --- > > doc/guides/nics/liquidio.rst| 2 ++ > > drivers/net/liquidio/base/lio_hw_defs.h | 12 +++

[dpdk-dev] [PATCH v2] examples/flow_filtering: demo of simple rte flow

2017-10-25 Thread Ori Kam
This application shows a simple usage of the rte_flow API for hardware filtering offloading. In this demo we are filtering specific IP to specific target queue, while sending all the rest of the packets to other queue. Signed-off-by: Ori Kam --- v2: * Merge patches into one patch. * Add flow

Re: [dpdk-dev] [PATCH v2] mbuf: rename deprecated VLAN flags

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 8:12 AM, Olivier Matz wrote: > PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. > As explained in [1], these flags were kept to let the applications and > PMDs move to the new flag. There is also a need to support Rx vlan > offload without vlan strip (at least for the i

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-25 Thread Ferruh Yigit
On 10/24/2017 5:35 AM, Thomas Monjalon wrote: > 24/10/2017 12:35, Gaetan Rivet: >> Gaetan Rivet (6): >> ethdev: do not rely on detachable flag in detach >> ethdev: remove detachable device flag >> pci: propagate PMD removal error value for unplug >> doc: follow detachable flag disappearance

[dpdk-dev] [PATCH v2] net/octeontx: fix build for gcc < 4.6

2017-10-25 Thread Ferruh Yigit
-Ofast option supported starting from gcc4.6 [1], for older versions using "-O3 -ffast-math" instead. [1] build error: CC octeontx_rxtx.o cc1: error: invalid option argument ‘-Ofast’ Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function") Signed-off-by: Ferruh Yigit Acked-b

[dpdk-dev] [PATCH v8 3/4] bus/vdev: move to vdev bus to drivers/bus

2017-10-25 Thread Jianfeng Tan
Move the vdev bus from lib/librte_eal to drivers/bus. As the crypto vdev helper function refers to data structure in rte_vdev.h, so we move those helper function into drivers/bus too. Signed-off-by: Jianfeng Tan --- config/common_base| 5 + doc/guides/rel_notes/release

[dpdk-dev] [PATCH v8 1/4] cryptodev: remove crypto vdev init API

2017-10-25 Thread Jianfeng Tan
Remove rte_cryptodev_create_vdev() for duplication. Signed-off-by: Jianfeng Tan Acked-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_17_11.rst | 4 +++- lib/librte_cryptodev/Makefile | 2 +- lib/librte_cry

[dpdk-dev] [PATCH v8 2/4] eal: remove dependency on vdev

2017-10-25 Thread Jianfeng Tan
We can call bus->plug() to avoid calling rte_vdev_init() explicitly. Signed-off-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_dev.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/

[dpdk-dev] [PATCH v8 4/4] bus/vdev: change log type

2017-10-25 Thread Jianfeng Tan
Use specialized dynamic log type for vdev bus logging. Suggested-by: Gaetan Rivet Suggested-by: Shreyansh Jain Signed-off-by: Jianfeng Tan --- drivers/bus/vdev/vdev.c | 20 drivers/bus/vdev/vdev_logs.h | 45 2 files changed

[dpdk-dev] [PATCH v8 0/4] move vdev into drivers/bus

2017-10-25 Thread Jianfeng Tan
v8: (Suggested by Pablo) - As we bump the library version and add new library (bus_vdev), we need to update those in release note. - Fix compiling issue in test as of missing rte_vdev.h. - Move vdev API symbols from eal to bus_vdev; update in release note. v7: - Add notice in release n

Re: [dpdk-dev] [PATCH v2 7/7] net/mlx4: separate Tx for multi-segments

2017-10-25 Thread Adrien Mazarguil
Hi Ophir, On Mon, Oct 23, 2017 at 02:22:00PM +, Ophir Munk wrote: > This commit optimizes handling of one segment and calls a > dedicated function for handling multi segments > > Signed-off-by: Ophir Munk While it indeed moves the code to a separate function I'm not sure by how much it impr

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx4: improve performance of one Tx segment

2017-10-25 Thread Adrien Mazarguil
On Mon, Oct 23, 2017 at 02:21:59PM +, Ophir Munk wrote: > From: Matan Azrad > > Since one segment shouldn't use additional memory to save segments > byte_count for writing them in different order we can prevent > additional memory unnecessary usage in this case. > By the way, prevent loop man

Re: [dpdk-dev] [PATCH v2 5/7] net/mlx4: remove unnecessary variables in Tx burst

2017-10-25 Thread Adrien Mazarguil
Hi Ophir/Matan, On Mon, Oct 23, 2017 at 02:21:58PM +, Ophir Munk wrote: > From: Matan Azrad > > Remove usage of variables which doesn't add new information for > performance improvement. > > Signed-off-by: Matan Azrad I'm almost 100% sure this commit wasn't validated for performance on it

Re: [dpdk-dev] [PATCH v2 2/7] net/mlx4: inline more Tx functions

2017-10-25 Thread Adrien Mazarguil
Hi Ophir, On Mon, Oct 23, 2017 at 02:21:55PM +, Ophir Munk wrote: > Change functions to inline on Tx fast path to improve performance > > Inside the inline function call other functions to handle "unlikely" > cases such that the inline function code footprint is small. > > Signed-off-by: Oph

Re: [dpdk-dev] [PATCH v2 1/7] net/mlx4: remove error flows from Tx fast path

2017-10-25 Thread Adrien Mazarguil
Hi Ophir, Matan, On Mon, Oct 23, 2017 at 02:21:54PM +, Ophir Munk wrote: > From: Matan Azrad > > Move unnecessary error flows to DEBUG mode for > performance improvements. > > Signed-off-by: Matan Azrad One comment before going on with the review of the remaining patches in this series, i

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix adjust priority for drop queue

2017-10-25 Thread Yongseok Koh
> On Oct 25, 2017, at 1:25 AM, Nelio Laranjeiro > wrote: > > Drop queue should also adjust their priority according the most specific > layer in the pattern they are matching to avoid dropping all the traffic. > > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") > >

Re: [dpdk-dev] [PATCH] test: fix build without flow classify

2017-10-25 Thread Iremonger, Bernard
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 25, 2017 4:18 PM > To: dev@dpdk.org > Cc: Iremonger, Bernard > Subject: [PATCH] test: fix build without flow classify > > The unit test for flow classify should be disabled if the library

[dpdk-dev] [pull-request] next-crypto 17.11 rc2

2017-10-25 Thread Pablo de Lara
The following changes since commit 1e02d735c1446705592ca8d89b4b500f9492a8ef: examples/kni: check PCI info not NULL before reading (2017-10-25 00:03:20 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 1f076245bc41cdeb42

Re: [dpdk-dev] [PATCH] comment: Describe how rte_cryptodev_info_get returns capabilities

2017-10-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Trahe, Fiona > Sent: Wednesday, October 25, 2017 5:02 PM > To: O Mahony, Billy ; Doherty, Declan > > Cc: dev@dpdk.org; O Mahony, Billy > Subject: Re: [dpdk-dev] [PATCH] comment: Describe how > rte_cryptodev_info

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-25 Thread Ferruh Yigit
On 10/24/2017 4:56 PM, Ferruh Yigit wrote: > On 10/24/2017 3:35 AM, Gaetan Rivet wrote: >> This flag was deprecated in the previous release, and this is its removal. > > This change was in wait list, but it would be much more better if not received > just before rc2, but in early stages in the rel

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: document error codes of reset

2017-10-25 Thread Ferruh Yigit
On 10/25/2017 5:01 AM, Luca Boccassi wrote: > On Tue, 2017-10-24 at 13:41 -0700, Ferruh Yigit wrote: >> On 10/24/2017 6:19 AM, luca.bocca...@gmail.com wrote: >>> From: Luca Boccassi >>> >>> This new function returns 0 on success and various error codes on >>> different failures. Attempt to documen

Re: [dpdk-dev] [PATCH v2 0/3] Break cryptodev dependency on bus infrastructure

2017-10-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty > Sent: Wednesday, October 25, 2017 1:01 PM > To: dev@dpdk.org > Cc: Doherty, Declan > Subject: [dpdk-dev] [PATCH v2 0/3] Break cryptodev dependency on bus > infrastructure > > This patch set brea

Re: [dpdk-dev] [PATCH] crypto/qat: fix HMAC supported digest sizes

2017-10-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, October 25, 2017 12:41 PM > To: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jain, Deepak K ; > Griffin, John > Cc: dev@dpdk.org; De Lara Guarch, Pablo > ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/qat: fix HM

Re: [dpdk-dev] [PATCH v3 0/4] cryptodev vdev changes for 17.11-rc1

2017-10-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, October 25, 2017 3:33 PM > To: Jan Blunck ; dev@dpdk.org > Cc: Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v3 0/4] cryptodev vdev changes for 17.11- > rc1 > > >

Re: [dpdk-dev] [PATCH] comment: Describe how rte_cryptodev_info_get returns capabilities

2017-10-25 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Billy O'Mahony > Sent: Tuesday, October 24, 2017 3:53 PM > To: Doherty, Declan > Cc: dev@dpdk.org; O Mahony, Billy > Subject: [dpdk-dev] [PATCH] comment: Describe how rte_cryptodev_info_get > returns capabiliti

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add new APIs to assist PMD initialisation

2017-10-25 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty > Sent: Wednesday, October 25, 2017 1:01 PM > To: dev@dpdk.org > Cc: Doherty, Declan > Subject: [dpdk-dev] [PATCH v2 1/3] cryptodev: add new APIs to assist PMD > initialisation > > Adds new PMD a

[dpdk-dev] [PATCH v10 2/2] doc: add new introduction to sample app guides

2017-10-25 Thread Marko Kovacevic
Add new Introduction Section into the sample app guides. Signed-off-by: Marko Kovacevic Acked-by: John McNamara --- doc/guides/sample_app_ug/intro.rst | 153 +++-- 1 file changed, 113 insertions(+), 40 deletions(-) diff --git a/doc/guides/sample_app_ug/intro.rst

[dpdk-dev] [PATCH v10 1/2] doc: add generic compilation doc for all sample apps

2017-10-25 Thread Marko Kovacevic
From: Herakliusz Lipiec Moved duplicated, and occasionally outdated, doc sections from each of the sample app guides chapters to a common chapter at the start. This reduces the duplication in the docs and provides a single point of reference for compiling the sample apps. Signed-off-by: Herakli

Re: [dpdk-dev] [PATCH v2 3/3] cryptodev: break dependency on PCI device bus

2017-10-25 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty > Sent: Wednesday, October 25, 2017 1:01 PM > To: dev@dpdk.org > Cc: Doherty, Declan > Subject: [dpdk-dev] [PATCH v2 3/3] cryptodev: break dependency on PCI device > bus > > Removes any dependenc

[dpdk-dev] [PATCH v4 1/2] net/mlx4: introducing consumer index mask

2017-10-25 Thread Moti Haimovsky
This commit defines MLX4_CQ_DB_CI_MASK which is used when updating the consumer index of the completion queue instead of the hardcoded 0xff used until now. Signed-off-by: Moti Haimovsky --- drivers/net/mlx4/mlx4_prm.h | 3 +++ drivers/net/mlx4/mlx4_rxtx.c | 5 +++-- 2 files changed, 6 inser

Re: [dpdk-dev] [PATCH] doc: remove trailing commas in API index

2017-10-25 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, October 25, 2017 4:20 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: remove trailing commas in API index > > Fixes: c711ccb30987 ("ivshmem: remove library and its EAL

[dpdk-dev] [PATCH v4 2/2] net/mlx4: fix no Rx interrupts

2017-10-25 Thread Moti Haimovsky
This commit addresses the issue of Rx interrupts support with the new Rx datapath introduced in DPDK version 17.11. In order to generate an Rx interrupt an event queue is armed with the consumer index of the Rx completion queue. Since version 17.11 this index is handled by the PMD so it is now the

Re: [dpdk-dev] [PATCH v2] doc: add basic howto for flow API

2017-10-25 Thread Mcnamara, John
> -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Wednesday, October 25, 2017 3:51 PM > To: adrien.mazarg...@6wind.com; Mcnamara, John > Cc: dev@dpdk.org; or...@mellanox.com > Subject: [PATCH v2] doc: add basic howto for flow API > > As the rte flow is a new compl

[dpdk-dev] [PATCH] doc: remove trailing commas in API index

2017-10-25 Thread Thomas Monjalon
Fixes: c711ccb30987 ("ivshmem: remove library and its EAL integration") Fixes: e8009a077d17 ("doc: group classification libraries in doxygen index") Signed-off-by: Thomas Monjalon --- doc/api/doxy-api-index.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/api/doxy

[dpdk-dev] [PATCH] test: fix build without flow classify

2017-10-25 Thread Thomas Monjalon
The unit test for flow classify should be disabled if the library is disabled in the configuration. Fixes: 9c9befea4f57 ("test: add flow classify unit tests") Cc: bernard.iremon...@intel.com Signed-off-by: Thomas Monjalon --- test/test/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[dpdk-dev] [PATCH v2] mbuf: rename deprecated VLAN flags

2017-10-25 Thread Olivier Matz
PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. As explained in [1], these flags were kept to let the applications and PMDs move to the new flag. There is also a need to support Rx vlan offload without vlan strip (at least for the ixgbe driver). This patch renames the old flags for

  1   2   3   >