[dpdk-dev] [PATCH] net/virtio: fix memory leak

[Pengzhen Liu]

In function eth_virtio_dev_init(), dynamic memory stored
in "eth_dev->data->mac_addrs" variable and it is not freed whe function return,
this is a possible memory leak.

Fixes: 6b9ed026a870 ("net/virtio: eth_dev->data->mac_addrs is not freed")
Cc: sta...@dpdk.org
Signed-off-by: Pengzhen Liu <liupengzh...@huawei.com>
---
 drivers/net/virtio/virtio_ethdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_ethdev.c 
b/drivers/net/virtio/virtio_ethdev.c
index 0ec54a9..d9f186f 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1586,13 +1586,13 @@ static int virtio_dev_xstats_get_names(struct 
rte_eth_dev *dev,
        if (!hw->virtio_user_dev) {
                ret = vtpci_init(RTE_ETH_DEV_TO_PCI(eth_dev), hw);
                if (ret)
-                       return ret;
+            goto out;
        }
 
        /* reset device and negotiate default features */
        ret = virtio_init_device(eth_dev, VIRTIO_PMD_DEFAULT_GUEST_FEATURES);
        if (ret < 0)
-               return ret;
+        goto out;
 
        /* Setup interrupt callback  */
        if (eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
@@ -1600,6 +1600,10 @@ static int virtio_dev_xstats_get_names(struct 
rte_eth_dev *dev,
                        virtio_interrupt_handler, eth_dev);
 
        return 0;
+
+out:
+    rte_free(eth_dev->data->mac_addrs);
+    return ret;
 }
 
 static int
-- 
1.7.12.4