Hi Ophir, Matan, On Mon, Oct 23, 2017 at 02:21:54PM +0000, Ophir Munk wrote: > From: Matan Azrad <ma...@mellanox.com> > > Move unnecessary error flows to DEBUG mode for > performance improvements. > > Signed-off-by: Matan Azrad <ma...@mellanox.com>
One comment before going on with the review of the remaining patches in this series, ideally, even obvious patches such as this one (ifdef'ing some code away) should come with a couple of sentences describing their performance impact. If it's negligible or just a gut feeling, then say so. If it's significant, then by all means you should provide hard numbers and a test scenario (no need to go in details though). Performance being the main purpose of DPDK and all, it's *that* important since such commits may be considered for back-ports later (the lack of performance can be consirered a bug). Some patches labelled as performance improvements are actually code clean up not worth validating on their own, but possibly leading to subsequent patches with actual improvements. I think it's the case here, just avoid mentioning "performance improvement" without proof. Other than that: Acked-by: Adrien Mazarguil <adrien.mazarg...@6wind.com> -- Adrien Mazarguil 6WIND
