Re: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value

2017-10-10 Thread Kozak, KubaX
Thanks Zhiyong, Should I correct this patch and resend to dpdk or is it just a suggestion for future? Regards, Kuba >-Original Message- >From: Yang, Zhiyong >Sent: Tuesday, October 10, 2017 08:56 >To: Kozak, KubaX ; Ananyev, Konstantin > >Cc: dev@dpdk.org; Kozak, KubaX ; sta...@dpdk.or

[dpdk-dev] [PATCH v3] eal: enable vfio independent of PCI bus

2017-10-10 Thread Hemant Agrawal
VFIO may be used by buses other than PCI. This patch enables the VFIO on the basis of vfio root presence. Since vfio_enable should be called only once, pci_vfio_enable is also removed. A debug print is added in case vfio_pci module is not present. Signed-off-by: Hemant Agrawal --- v3: changed t

Re: [dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers

2017-10-10 Thread Shreyansh Jain
Hello Jianfeng, On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote: Introduce a new log type, RTE_LOGTYPE_BUS, for bus drivers. And change fslmc to use this type for logging. Suggested-by: Gaetan Rivet Signed-off-by: Jianfeng Tan --- drivers/bus/fslmc/fslmc_bus.c | 9 +++

Re: [dpdk-dev] [PATCH 04/10] net/i40e: fix compilation with -Og

2017-10-10 Thread Wu, Jingjing
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, October 6, 2017 7:25 AM > To: Olivier Matz ; dev@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: Re: [dpdk-dev] [PATCH 04/10] net/i40e: fix compilation with -Og > > On 9/11/2017 4:13 PM, Olivier Matz wrote: > > The compilatio

Re: [dpdk-dev] [PATCH v10 3/9] linuxapp/eal_pci: get iommu class

2017-10-10 Thread santosh
On Wednesday 11 October 2017 11:01 AM, Tan, Jianfeng wrote: > > > On 10/11/2017 12:43 PM, santosh wrote: >> On Wednesday 11 October 2017 07:17 AM, Tan, Jianfeng wrote: >>> Hi, >>> >>> Nice patch series. But I still have a small question about below flag. >>> >>> >>> On 10/6/2017 7:03 PM, Santosh S

Re: [dpdk-dev] [PATCH v10 3/9] linuxapp/eal_pci: get iommu class

2017-10-10 Thread Tan, Jianfeng
On 10/11/2017 12:43 PM, santosh wrote: On Wednesday 11 October 2017 07:17 AM, Tan, Jianfeng wrote: Hi, Nice patch series. But I still have a small question about below flag. On 10/6/2017 7:03 PM, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapp

Re: [dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan

2017-10-10 Thread santosh
On Wednesday 11 October 2017 10:47 AM, Shreyansh Jain wrote: > On Tuesday 10 October 2017 10:25 PM, santosh wrote: >> >> On Tuesday 10 October 2017 09:47 PM, Thomas Monjalon wrote: >>> 10/10/2017 16:05, santosh: Hi Thomas, On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote:

Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping

2017-10-10 Thread Wu, Jingjing
NACK it. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Saturday, September 9, 2017 11:22 AM > To: Zang MingJie ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping > > > > > -Original Message- > > Fr

Re: [dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan

2017-10-10 Thread Shreyansh Jain
On Tuesday 10 October 2017 10:25 PM, santosh wrote: On Tuesday 10 October 2017 09:47 PM, Thomas Monjalon wrote: 10/10/2017 16:05, santosh: Hi Thomas, On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote: 10/10/2017 09:01, Shreyansh Jain: Fixes: 5b22cf744689 ("bus/dpaa: introducing FMa

Re: [dpdk-dev] [PATCH v10 3/9] linuxapp/eal_pci: get iommu class

2017-10-10 Thread santosh
On Wednesday 11 October 2017 07:17 AM, Tan, Jianfeng wrote: > Hi, > > Nice patch series. But I still have a small question about below flag. > > > On 10/6/2017 7:03 PM, Santosh Shukla wrote: >> Get iommu class of PCI device on the bus and returns preferred iova >> mapping mode for that bus. >> >>

[dpdk-dev] [PATCH] net/virtio: fix wrong TX pkt length stats

2017-10-10 Thread Zhiyong Yang
In the function virtqueue_enqueue_xmit(), when can_push == 1 is true, vtnet_hdr_size is added to pkt_len by calling rte_pktmbuf_prepend. So, virtio header len should be subtracted before calling stats function. Fixes: 58169a9c8153 ("net/virtio: support Tx checksum offload") Signed-off-by: Zhiyong

Re: [dpdk-dev] [PATCH 3/4] event/dpaa2: support event eth adapter

2017-10-10 Thread Rao, Nikhil
On 10/10/2017 11:21 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/event/Makefile | 4 +- drivers/event/dpaa2/Makefile | 2 + drivers/event/dpaa2/dpaa2_eventdev.c | 96 +++- drivers/event/dpaa2/dpaa2_eventdev.h | 8 +++

Re: [dpdk-dev] [PATCH 3/4] event/dpaa2: support event eth adapter

2017-10-10 Thread Rao, Nikhil
On 10/10/2017 11:21 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/event/Makefile | 4 +- drivers/event/dpaa2/Makefile | 2 + drivers/event/dpaa2/dpaa2_eventdev.c | 96 +++- drivers/event/dpaa2/dpaa2_eventdev.h | 8 +++

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF

2017-10-10 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Dai, Wei > Sent: Thursday, September 28, 2017 10:29 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Liang, Cunming > ; Ma, Jianwei > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF > > When a V

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Rx queue interrupt mapping in VF

2017-10-10 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Dai, Wei > Sent: Wednesday, September 20, 2017 6:18 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix Rx queue interrupt mapping in VF > > When a VF port is bound to VFIO-PCI, mis

Re: [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable

2017-10-10 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Yong Wang [mailto:wang.yon...@zte.com.cn] > Sent: Tuesday, September 19, 2017 11:17 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH] net/ixgbe: fix uninitialized variable > > In func ixgbe_dev_link_update(), "link.link_autoneg" is us

Re: [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps function to SW PMD

2017-10-10 Thread Jerin Jacob
-Original Message- > Date: Wed, 11 Oct 2017 01:16:25 +0200 > From: Thomas Monjalon > To: Nikhil Rao > Cc: dev@dpdk.org, jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > Subject: Re: [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps > function to SW PMD > > Hi, > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect var assignment

2017-10-10 Thread Ferruh Yigit
On 9/18/2017 7:53 PM, Jingjing Wu wrote: > rx/tx_queue_setup functions are shared between PF and VF > drivers. So the var 'pf' should not be assigned at the beginning. > This patch fixes the issue, and also corrects the return err code. > > Cc: sta...@dpdk.org > Fixes: b6583ee40265 ("i40e: full VM

Re: [dpdk-dev] [PATCH] doc: update the SDK version for DPAA2

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 3:13 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] doc: minor corrections in DPAA NIC guide

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 3:13 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for configuration of queue region

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 4:01 AM, Zhao1, Wei wrote: > Hi,Ferruh > >> -Original Message- >> From: Zhao1, Wei >> Sent: Tuesday, October 10, 2017 10:56 AM >> To: Yigit, Ferruh ; dev@dpdk.org >> Subject: RE: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for >> configuration of queue region >> >> Hi, >>

Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-10 Thread Ferruh Yigit
On 10/11/2017 3:01 AM, Ferruh Yigit wrote: > On 10/10/2017 9:20 PM, Matan Azrad wrote: >> The stats_get dev op API doesn't include return value, so PMD cannot >> return an error in case of failure at stats getting process time. >> >> Since PCI devices can be removed and there is a time between the

Re: [dpdk-dev] [PATCH 0/4] patches for bnxt

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 3:22 PM, Ajit Khaparde wrote: > Patches against dpdk-next-net. > Please apply. > > Ajit Khaparde (4): > net/bnxt: fix cleanup if a filter allocation fails > net/bnxt: prevent programming a duplicate flow > net/bnxt: include fdir support > net/bnxt: fix the association of a MA

Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 9:20 PM, Matan Azrad wrote: > The stats_get dev op API doesn't include return value, so PMD cannot > return an error in case of failure at stats getting process time. > > Since PCI devices can be removed and there is a time between the > physical removal to the RMV interrupt, the use

Re: [dpdk-dev] [PATCH v10 3/9] linuxapp/eal_pci: get iommu class

2017-10-10 Thread Tan, Jianfeng
Hi, Nice patch series. But I still have a small question about below flag. On 10/6/2017 7:03 PM, Santosh Shukla wrote: Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Patch also introduces RTE_PCI_DRV_IOVA_AS_VA drv flag. Flag used when driver ne

Re: [dpdk-dev] [PATCH v2] net/mlx5: flow counter support

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 5:10 PM, Yongseok Koh wrote: >> On Oct 10, 2017, at 7:22 AM, Nelio Laranjeiro >> wrote: >> >> From: Ori Kam >> >> Example for setting rule for counting packets with dest >> ip = 192.168.3.1 in testpmd: >> >> testpmd: flow create 0 ingress pattern eth / ipv4 dst is 192.168.3.1 >> /

Re: [dpdk-dev] [PATCH] net/e1000: i350 VLAN tags in loopback packets are big endian

2017-10-10 Thread Lu, Wenzhuo
Hi Roger, > -Original Message- > From: Roger B Melton [mailto:rmel...@cisco.com] > Sent: Saturday, October 7, 2017 7:34 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Roger B Melton > Subject: [PATCH] net/e1000: i350 VLAN tags in loopback packets are big > endian > > When copying VLAN tags fr

Re: [dpdk-dev] [PATCH v9 1/3] ethdev: add Rx HW timestamp capability

2017-10-10 Thread Ferruh Yigit
On 10/11/2017 2:22 AM, Yongseok Koh wrote: > >> On Oct 10, 2017, at 6:14 PM, Ferruh Yigit wrote: >> >> On 10/10/2017 3:37 PM, Raslan Darawsheh wrote: >>> Add a new offload capability flag for Rx HW >>> timestamp and enabling/disabling this via rte_eth_rxmode. >>> >>> Signed-off-by: Raslan Darawsh

Re: [dpdk-dev] [PATCH v9 1/3] ethdev: add Rx HW timestamp capability

2017-10-10 Thread Yongseok Koh
> On Oct 10, 2017, at 6:14 PM, Ferruh Yigit wrote: > > On 10/10/2017 3:37 PM, Raslan Darawsheh wrote: >> Add a new offload capability flag for Rx HW >> timestamp and enabling/disabling this via rte_eth_rxmode. >> >> Signed-off-by: Raslan Darawsheh >> Reviewed-by: Shahaf Shuler >> Acked-by: Yo

Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 8:33 PM, Ferruh Yigit wrote: > On 10/10/2017 3:56 PM, Pavan Nikhilesh wrote: >> Use the event device get attribute function to fetch the event >> port and queue count >> >> Signed-off-by: Pavan Nikhilesh > > Reviewed-by: Ferruh Yigit Squashed into relevant commit in next-net, than

Re: [dpdk-dev] [PATCH v9 1/3] ethdev: add Rx HW timestamp capability

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 3:37 PM, Raslan Darawsheh wrote: > Add a new offload capability flag for Rx HW > timestamp and enabling/disabling this via rte_eth_rxmode. > > Signed-off-by: Raslan Darawsheh > Reviewed-by: Shahaf Shuler > Acked-by: Yongseok Koh Series applied to dpdk-next-net/master, thanks. (f

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx5: fix deadlock due to buffered slots in Rx SW ring

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 3:04 PM, Yongseok Koh wrote: > When replenishing Rx ring, there're always buffered slots reserved between > consumed entries and HW owned entries. These have to be filled with fake > mbufs to protect from possible overflow rather than optimistically > expecting successful replenishmen

Re: [dpdk-dev] How to update the sequence number in TCP packets using DPDK-pktgen?

2017-10-10 Thread Wiles, Keith
> On Oct 10, 2017, at 6:00 PM, Stephen Hemminger > wrote: > > On Mon, 9 Oct 2017 19:12:49 +0530 > Shailja Pandey wrote: > >> pktgen_tcp_hdr_ctor(pkt_seq_t *pkt, tcpip_t *tip, int type __rte_unused) >> { >> uint16_t tlen; >> >> /* Zero out the header space */ >> memse

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

2017-10-10 Thread Don Provan
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Monday, October 09, 2017 10:01 PM > To: Don Provan ; Jan Blunck ; > Thomas Monjalon > Cc: dev ; Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail > > ... > > > From the

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix uninitialized variable

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 2:24 PM, Wu, Jingjing wrote: > > >> -Original Message- >> From: Yong Wang [mailto:wang.yon...@zte.com.cn] >> Sent: Tuesday, October 10, 2017 7:24 PM >> To: Wu, Jingjing >> Cc: dev@dpdk.org; Yong Wang ; sta...@dpdk.org >> Subject: [PATCH v2] net/i40e: fix uninitialized varia

Re: [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps function to SW PMD

2017-10-10 Thread Thomas Monjalon
Hi, 11/10/2017 00:21, Nikhil Rao: > --- a/lib/librte_eventdev/rte_eventdev_pmd.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd.h > @@ -83,6 +83,14 @@ extern "C" { > } \ > } while (0) > > +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \ > + ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_

Re: [dpdk-dev] [pull-request] next-eventdev 17.11 RC1

2017-10-10 Thread Thomas Monjalon
10/10/2017 18:52, Jerin Jacob: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [RFC 0/4] misc enic fixes

2017-10-10 Thread Ferruh Yigit
On 9/26/2017 7:53 PM, Aaron Conole wrote: > These still need some testing, and I will cc to stable > with the official patch. > > I'm especially interested in the comments on base. > > Aaron Conole (4): > enic: update format string to match arg types > enic: fix assignment > enic: remove un

Re: [dpdk-dev] How to update the sequence number in TCP packets using DPDK-pktgen?

2017-10-10 Thread Stephen Hemminger
On Mon, 9 Oct 2017 19:12:49 +0530 Shailja Pandey wrote: > pktgen_tcp_hdr_ctor(pkt_seq_t *pkt, tcpip_t *tip, int type __rte_unused) > { >     uint16_t tlen; > >     /* Zero out the header space */ >     memset((char *)tip, 0, sizeof(tcpip_t)); > >     /* Create the TCP header

Re: [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-10-10 Thread Stephen Hemminger
On Mon, 9 Oct 2017 00:13:47 +0800 "Tan, Jianfeng" wrote: > Hi, > > > On 10/8/2017 12:54 PM, Bill Bonaparte wrote: > > Thanks Jianfeng for taking time to reply. > > > > please allow me to briefly explain why I want to run dpdk on xen. > > our system is based on dpdk, which means we use dpdk as p

Re: [dpdk-dev] [PATCH v3 2/4] net/mrvl: add mrvl net pmd driver

2017-10-10 Thread Thomas Monjalon
05/10/2017 10:43, Tomasz Duszynski: > On Wed, Oct 04, 2017 at 05:59:11PM +0100, Ferruh Yigit wrote: > > On 10/4/2017 9:59 AM, Tomasz Duszynski wrote: > > > On Wed, Oct 04, 2017 at 01:24:27AM +0100, Ferruh Yigit wrote: > > >> On 10/3/2017 12:51 PM, Tomasz Duszynski wrote: > > >>> Add support for the

Re: [dpdk-dev] [git pull] virtio/vhost changes for 17.11-rc1

2017-10-10 Thread Thomas Monjalon
10/10/2017 16:00, Yuanhan Liu: > Hi Thomas, > > Please consider pulling following virtio/vhost changes for 17.11-rc1 at > git://dpdk.org/next/dpdk-next-virtiomaster Pulled, thanks

[dpdk-dev] [PATCH v5 4/4] doc: add description of raw mode in flow director in testpmd

2017-10-10 Thread Kirill Rybalchenko
v3: Add description of raw flow type mode for flow_director_filter command in testpmd. v4: Fix documentation of flow_director_filter command in testpmd according to modified parameters. Signed-off-by: Kirill Rybalchenko --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 18 +- 1

[dpdk-dev] [PATCH v5 1/4] ethdev: add support for raw flow type for flow director

2017-10-10 Thread Kirill Rybalchenko
Add new structure rte_eth_raw_flow to the union rte_eth_fdir_flow to support filter for raw flow type. Signed-off-by: Kirill Rybalchenko --- lib/librte_ether/rte_eth_ctrl.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_

[dpdk-dev] [PATCH v5 0/4] add support for raw flow type for flow director

2017-10-10 Thread Kirill Rybalchenko
For complex packets use raw flow type with pre-constructed packet buffer instead of creating a packet internally in PMD. v2: Fix code style, add comments v3: Merge with dunamic pctype to flow type mapping patch. Add raw flow type mode to flow_director_filter command in testpmd. v4: Remove unnece

[dpdk-dev] [PATCH v5 3/4] app/testpmd: add raw flow type to flow director

2017-10-10 Thread Kirill Rybalchenko
v3: Add raw flow type support to flow_director_filter command v4: Remove unnecessary flexbytes parameter for raw flow type flow director. Add possibility for arbitrary flow type for set_fdir_input_set and set_hash_global_config commands. Signed-off-by: Kirill Rybalchenko --- app/test-pmd/cmdlin

[dpdk-dev] [PATCH v5 2/4] net/i40e: add support for raw flow type for flow director

2017-10-10 Thread Kirill Rybalchenko
When addidng flow director filter for raw flow type, instead of constructing packet use buffer with pre-constructed packet. v3: Merge with dynamic pctype to flow type mapping patch. v5: Fix code style warning. Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/i40e_fdir.c | 26

[dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op

2017-10-10 Thread Matan Azrad
The stats_get dev op API doesn't include return value, so PMD cannot return an error in case of failure at stats getting process time. Since PCI devices can be removed and there is a time between the physical removal to the RMV interrupt, the user may get invalid stats without any indication. Thi

[dpdk-dev] [PATCH v4 1/4] ethdev: add support for raw flow type for flow director

2017-10-10 Thread Kirill Rybalchenko
Add new structure rte_eth_raw_flow to the union rte_eth_fdir_flow to support filter for raw flow type. Signed-off-by: Kirill Rybalchenko --- lib/librte_ether/rte_eth_ctrl.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_

[dpdk-dev] [PATCH v4 4/4] doc: add description of raw mode in flow director in testpmd

2017-10-10 Thread Kirill Rybalchenko
v3: Add description of raw flow type mode for flow_director_filter command in testpmd. v4: Fix documentation of flow_director_filter command in testpmd according to modified parameters. Signed-off-by: Kirill Rybalchenko --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 18 +- 1

[dpdk-dev] [PATCH v4 3/4] app/testpmd: add raw flow type to flow director

2017-10-10 Thread Kirill Rybalchenko
v3: Add raw flow type support to flow_director_filter command v4: Remove unnecessary flexbytes parameter for raw flow type flow director. Add possibility for arbitrary flow type for set_fdir_input_set and set_hash_global_config commands. Signed-off-by: Kirill Rybalchenko --- app/test-pmd/cmdlin

[dpdk-dev] [PATCH v4 2/4] net/i40e: add support for raw flow type for flow director

2017-10-10 Thread Kirill Rybalchenko
When addidng flow director filter for raw flow type, instead of constructing packet use buffer with pre-constructed packet. v3: Merge with dynamic pctype to flow type mapping patch. Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/i40e_fdir.c | 25 - 1 file changed

[dpdk-dev] [PATCH v4 0/4] add support for raw flow type for flow director

2017-10-10 Thread Kirill Rybalchenko
For complex packets use raw flow type with pre-constructed packet buffer instead of creating a packet internally in PMD. v2: Fix code style, add comments v3: Merge with dunamic pctype to flow type mapping patch. Add raw flow type mode to flow_director_filter command in testpmd. v4: Remove unnece

Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets

2017-10-10 Thread Ferruh Yigit
On 9/4/2017 2:19 PM, Radu Nicolau wrote: > > On 8/30/2017 4:46 AM, ZengGanghui wrote: >> When the nic does not support vlan rx offload may be wrong, resulting in >> lacp packets will not be processed. >> >> Signed-off-by: ZengGanghui > Reviewed-by: Radu Nicolau Acked-by: Declan Doherty Appl

Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 7:16 PM, Ferruh Yigit wrote: > On 10/10/2017 7:04 PM, Jerin Jacob wrote: >> -Original Message- >>> Date: Tue, 10 Oct 2017 20:26:15 +0530 >>> From: Pavan Nikhilesh >>> To: ferruh.yi...@intel.com >>> CC: dev@dpdk.org, Pavan Nikhilesh >>> Subject: [dpdk-dev] [PATCH] net/octeont

Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 3:56 PM, Pavan Nikhilesh wrote: > Use the event device get attribute function to fetch the event > port and queue count > > Signed-off-by: Pavan Nikhilesh Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] doc: add description of traffic management functions in testpmd

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 8:18 PM, Jasvinder Singh wrote: > Add description of the traffic management functions in the testpmd. > > Signed-off-by: Jasvinder Singh Squashed into relevant commit in next-net, thanks. Commit: 8cbcdd8861cf ("app/testpmd: add traffic management forwarding mode")

Re: [dpdk-dev] [PATCH] net/octeontx/base: fix icc build

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 2:33 PM, santosh wrote: > > On Tuesday 10 October 2017 10:07 AM, Pablo de Lara wrote: >> drivers/net/octeontx/base/octeontx_pkovf.c(527): >> error #592: variable "i" is used before its value is set >> RTE_SET_USED(i); >> >> Fixes: ab4f789560c4 ("net/octeontx/base: probe PKI a

Re: [dpdk-dev] [PATCH v8 0/5] net/softnic: sw fall-back pmd for traffic mgmt and others

2017-10-10 Thread Singh, Jasvinder
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, October 10, 2017 7:31 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Dumitrescu, Cristian ; > tho...@monjalon.net; Lu, Wenzhuo > Subject: Re: [PATCH v8 0/5] net/softnic: sw fall-back pmd for traffic mgmt > and others > > On 10/

[dpdk-dev] [PATCH] doc: add description of traffic management functions in testpmd

2017-10-10 Thread Jasvinder Singh
Add description of the traffic management functions in the testpmd. Signed-off-by: Jasvinder Singh --- doc/guides/testpmd_app_ug/run_app.rst | 1 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 262 2 files changed, 263 insertions(+) diff --git a/doc/guides

Re: [dpdk-dev] [PATCH v8 0/5] net/softnic: sw fall-back pmd for traffic mgmt and others

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 11:18 AM, Jasvinder Singh wrote: > The SoftNIC PMD is intended to provide SW fall-back options for specific > ethdev APIs in a generic way to the NICs not supporting those features. > > Currently, the only implemented ethdev API is Traffic Management (TM), > but other ethdev APIs suc

Re: [dpdk-dev] [PATCH v8 5/5] app/testpmd: add traffic management forwarding mode

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 11:18 AM, Jasvinder Singh wrote: > This commit extends the testpmd application with new forwarding engine > that demonstrates the use of ethdev traffic management APIs and softnic > PMD for QoS traffic management. > > In this mode, 5-level hierarchical tree of the QoS scheduler is bu

Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 7:04 PM, Jerin Jacob wrote: > -Original Message- >> Date: Tue, 10 Oct 2017 20:26:15 +0530 >> From: Pavan Nikhilesh >> To: ferruh.yi...@intel.com >> CC: dev@dpdk.org, Pavan Nikhilesh >> Subject: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get >> count >> X-Ma

Re: [dpdk-dev] [pull-request] next-eventdev 17.11 RC1

2017-10-10 Thread Jerin Jacob
-Original Message- > Date: Tue, 10 Oct 2017 19:11:09 +0200 > From: Thomas Monjalon > To: Jerin Jacob > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [pull-request] next-eventdev 17.11 RC1 > > 10/10/2017 18:52, Jerin Jacob: > > The following changes since commit 33604c31354abc9c55405d5a4b99e

Re: [dpdk-dev] [PATCH v1 0/7] Flow API helpers enhancements

2017-10-10 Thread Ferruh Yigit
On 10/6/2017 9:05 AM, Adrien Mazarguil wrote: > On Fri, Oct 06, 2017 at 02:13:14AM +0100, Ferruh Yigit wrote: >> On 10/5/2017 10:49 AM, Adrien Mazarguil wrote: >>> This series brings enhancements to various rte_flow helpers: >>> >>> - Allow applications to use rte_flow_error_set() by making it part

Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count

2017-10-10 Thread Jerin Jacob
-Original Message- > Date: Tue, 10 Oct 2017 20:26:15 +0530 > From: Pavan Nikhilesh > To: ferruh.yi...@intel.com > CC: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get > count > X-Mailer: git-send-email 2.7.4 > > Use the event devic

Re: [dpdk-dev] [PATCH v2] net/i40e: improve i40evf buffer cleanup in Tx vector mode

2017-10-10 Thread Ferruh Yigit
On 10/6/2017 3:08 PM, Roger B Melton wrote: > Signed-off-by: Roger B Melton > --- > v2 - Same content as v1, but properly signed-off. This patch marked as Superseded in patchwork by patch: http://dpdk.org/dev/patchwork/patch/30023/

Re: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment

2017-10-10 Thread John Daley (johndale)
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole > Sent: Tuesday, September 26, 2017 11:53 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment > > The assignment at initialization is overwritten immediately. Dr

Re: [dpdk-dev] [RFC 3/4] enic: remove unused code

2017-10-10 Thread John Daley (johndale)
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole > Sent: Tuesday, September 26, 2017 11:53 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC 3/4] enic: remove unused code > > The functions here aren't called anywhere in code, at least according to b

Re: [dpdk-dev] [RFC 2/4] enic: fix assignment

2017-10-10 Thread John Daley (johndale)
Aaron, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole > Sent: Tuesday, September 26, 2017 11:53 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC 2/4] enic: fix assignment > > As it stands, the existing assingment to mbuf has no effect outside of t

Re: [dpdk-dev] [RFC 1/4] enic: update format string to match arg types

2017-10-10 Thread John Daley (johndale)
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole > Sent: Tuesday, September 26, 2017 11:53 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC 1/4] enic: update format string to match arg types > > The argument `index` (and unique_id) is unsigned, but

Re: [dpdk-dev] [pull-request] next-eventdev 17.11 RC1

2017-10-10 Thread Thomas Monjalon
10/10/2017 18:52, Jerin Jacob: > The following changes since commit 33604c31354abc9c55405d5a4b99eb42a55a495f: > > vfio: refactor PCI BAR mapping (2017-10-10 15:37:58 +0200) > > are available in the git repository at: > > http://dpdk.org/git/next/dpdk-next-eventdev Thanks Jerin. Please upd

Re: [dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan

2017-10-10 Thread santosh
On Tuesday 10 October 2017 09:47 PM, Thomas Monjalon wrote: > 10/10/2017 16:05, santosh: >> Hi Thomas, >> >> On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote: >>> 10/10/2017 09:01, Shreyansh Jain: Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") Fixes: 37f9b54b

[dpdk-dev] [pull-request] next-eventdev 17.11 RC1

2017-10-10 Thread Jerin Jacob
The following changes since commit 33604c31354abc9c55405d5a4b99eb42a55a495f: vfio: refactor PCI BAR mapping (2017-10-10 15:37:58 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 457f7a1876b56fa254eec1c36f429d62b92734b

Re: [dpdk-dev] [PATCH v6 0/7] eventdev: cover letter: eth Rx adapter

2017-10-10 Thread Jerin Jacob
-Original Message- > Date: Wed, 11 Oct 2017 03:51:30 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > CC: dev@dpdk.org > Subject: [PATCH v6 0/7] eventdev: cover letter: eth Rx adapter > X-Mailer: git-send-email 2.7.4 > > Eventdev-based networking

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 8:40 AM, Kavanagh, Mark B wrote: >> From: Yigit, Ferruh >> Sent: Monday, October 9, 2017 6:34 PM >> To: Kavanagh, Mark B ; dev@dpdk.org >> Cc: ajit.khapa...@broadcom.com >> Subject: Re: [PATCH] net/bnxt: fix compilation >> >> On 10/9/2017 2:59 PM, Mark Kavanagh wrote: >>> As of 5ef3b7

Re: [dpdk-dev] [PATCH v2] eal: enable vfio independent of no PCI flag

2017-10-10 Thread Thomas Monjalon
10/10/2017 15:46, Hemant Agrawal: > Hi Thomas, Anatoly, > > On 10/7/2017 5:07 PM, Thomas Monjalon wrote: > > 07/10/2017 13:20, Hemant Agrawal: > >> In case no_pci is configured, other buses e.g. fslmc bus will > >> still need the the vfio to be enabled. > >> > >> Signed-off-by: Hemant Agrawal > >

Re: [dpdk-dev] [PATCH v6 0/7] eventdev: cover letter: eth Rx adapter

2017-10-10 Thread Jerin Jacob
-Original Message- > Date: Wed, 11 Oct 2017 03:51:30 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > CC: dev@dpdk.org > Subject: [PATCH v6 0/7] eventdev: cover letter: eth Rx adapter > X-Mailer: git-send-email 2.7.4 > > Eventdev-based networking

Re: [dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan

2017-10-10 Thread Thomas Monjalon
10/10/2017 16:05, santosh: > Hi Thomas, > > On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote: > > 10/10/2017 09:01, Shreyansh Jain: > >> Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") > >> Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") > > These lines

Re: [dpdk-dev] [PATCH v2] net/mlx5: flow counter support

2017-10-10 Thread Yongseok Koh
> On Oct 10, 2017, at 7:22 AM, Nelio Laranjeiro > wrote: > > From: Ori Kam > > Example for setting rule for counting packets with dest > ip = 192.168.3.1 in testpmd: > > testpmd: flow create 0 ingress pattern eth / ipv4 dst is 192.168.3.1 > / end actions queue index 0 / count / end > > Readi

Re: [dpdk-dev] [PATCH v2 10/12] net/ixgbe: enable inline ipsec

2017-10-10 Thread Radu Nicolau
Hi, Next iteration will have the macro removed and the register write then polling macro reworked and moved to ixgbe_osdep.h Regards, Radu On 10/6/2017 7:33 PM, Ananyev, Konstantin wrote: -Original Message- From: Nicolau, Radu Sent: Friday, October 6, 2017 10:18 AM To: Ananyev, K

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

2017-10-10 Thread Aaron Conole
Shreyansh Jain writes: > Hello Don, > > On Monday 09 October 2017 11:51 PM, Don Provan wrote: >>> -Original Message- >>> From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] >>> Sent: Monday, October 09, 2017 4:10 AM >>> To: Jan Blunck ; Thomas Monjalon >>> >>> Cc: dev ; Hemant Agrawal

Re: [dpdk-dev] [PATCH] drivers: update DPAA2 libs ABIVER and build reproducibility

2017-10-10 Thread Thomas Monjalon
10/10/2017 16:15, Hemant Agrawal: > Signed-off-by: Hemant Agrawal > --- > drivers/bus/fslmc/Makefile| 3 ++- > drivers/crypto/dpaa2_sec/Makefile | 3 ++- > drivers/event/dpaa2/Makefile | 3 ++- > drivers/mempool/dpaa2/Makefile| 3 ++- > drivers/net/dpaa2/Makefile| 3 ++- >

[dpdk-dev] [PATCH] event/sw: fix get of single xstat value

2017-10-10 Thread Harry van Haaren
This commit allows the xstats_get() API to return just a single value based on its ID. Previously, the "ret_n_lt_stats" value set to 1 ensured a check to take place that the array was larger than the available xstats. The xstats_get() API allows retriving of individual stats - hence this check sho

[dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count

2017-10-10 Thread Pavan Nikhilesh
Use the event device get attribute function to fetch the event port and queue count Signed-off-by: Pavan Nikhilesh --- drivers/net/octeontx/octeontx_ethdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/o

[dpdk-dev] [PATCH v6 7/7] eventdev: add tests for eth Rx adapter APIs

2017-10-10 Thread Nikhil Rao
Add unit tests for rte_event_eth_rx_adapter_xxx() APIs Signed-off-by: Nikhil Rao --- test/test/test_event_eth_rx_adapter.c | 453 ++ MAINTAINERS | 1 + test/test/Makefile| 1 + 3 files changed, 455 insertions(+) c

Re: [dpdk-dev] [PATCH v9 3/3] net/mlx5: add Rx HW timestamp

2017-10-10 Thread Yongseok Koh
> On Oct 10, 2017, at 7:37 AM, Raslan Darawsheh wrote: > > Expose Rx HW timestamp to packet mbufs. > > Signed-off-by: Raslan Darawsheh > --- Acked-by: Yongseok Koh Thanks

[dpdk-dev] [PATCH v9 3/3] net/mlx5: add Rx HW timestamp

2017-10-10 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by: Raslan Darawsheh --- Changes in v9: - Fix indentation issue in mlx5_rxtx_vec_neon.h Changes in v8: - Rebasing the work on top of next-net Changes in v7: - Rebasing the work on top ot c814b93b ("net/mlx5: add vectorized Rx/Tx burst for ARM"

[dpdk-dev] [PATCH v9 2/3] app/testpmd: add Rx HW timestamp

2017-10-10 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2 ++ ap

[dpdk-dev] [PATCH v9 1/3] ethdev: add Rx HW timestamp capability

2017-10-10 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Reviewed-by: Shahaf Shuler Acked-by: Yongseok Koh --- Changes in v7: - Updated features.rst to use both rx_offload_capa,rx_queue_offload_capa - Updated default.i

Re: [dpdk-dev] Mellanox ConnectX-5 crashes and mbuf leak

2017-10-10 Thread Yongseok Koh
Glad to hear that helped! Then the patch will get merged soon. Thanks, Yongseok > On Oct 10, 2017, at 1:10 AM, Martin Weiser > wrote: > > Hi Yongseok, > > I can confirm that this patch fixes the crashes and freezing in my tests > so far. > > We still see an issue that once the mbufs run low

Re: [dpdk-dev] [PATCH] mempool: remove get capability debug print

2017-10-10 Thread santosh
On Tuesday 10 October 2017 07:47 PM, Hemant Agrawal wrote: > This is not required to be printed for every mempool call. > > Signed-off-by: Hemant Agrawal > --- Will print only in debug mode though, But ok with patch. Reviewed-by: Santosh Shukla Thanks.

[dpdk-dev] [PATCH v2] net/mlx5: flow counter support

2017-10-10 Thread Nelio Laranjeiro
From: Ori Kam Example for setting rule for counting packets with dest ip = 192.168.3.1 in testpmd: testpmd: flow create 0 ingress pattern eth / ipv4 dst is 192.168.3.1 / end actions queue index 0 / count / end Reading the number of packets and bytes for the rule: testpmd: flow query 0 0 count

[dpdk-dev] [PATCH 4/4] net/bnxt: fix the association of a MACVLAN per VNIC

2017-10-10 Thread Ajit Khaparde
We were not associating a MAC+VLAN per VNIC filter correctly. This patch fixes that. Also set the VLAN type appropriately. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 22 ++ drivers/net/bnxt/bnxt_rxq.c | 2 +- 2 files changed, 23 insertions(+), 1 deletio

[dpdk-dev] [PATCH 2/4] net/bnxt: prevent programming a duplicate flow

2017-10-10 Thread Ajit Khaparde
Match a flow against existing flows programmed in the HW and prevent overlapping entries. Also change log level of some logs to DEBUG. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 72 +++--- 1 file changed, 67 insertions(+), 5 deletions(-)

[dpdk-dev] [PATCH 3/4] net/bnxt: include fdir support

2017-10-10 Thread Ajit Khaparde
This patch brings support for Flow Director. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 384 - drivers/net/bnxt/bnxt_filter.h | 2 + 2 files changed, 384 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/

[dpdk-dev] [PATCH 1/4] net/bnxt: fix cleanup if a filter allocation fails

2017-10-10 Thread Ajit Khaparde
We are not checking if a filter allocation succeeded. And we end up accessing a null pointer after that. Also invalidate the fw_l2_filter_id to prevent unnecessary HW access and hence HWRM command failures during exit. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 14

[dpdk-dev] [PATCH 0/4] patches for bnxt

2017-10-10 Thread Ajit Khaparde
Patches against dpdk-next-net. Please apply. Ajit Khaparde (4): net/bnxt: fix cleanup if a filter allocation fails net/bnxt: prevent programming a duplicate flow net/bnxt: include fdir support net/bnxt: fix the association of a MACVLAN per VNIC drivers/net/bnxt/bnxt_ethdev.c | 384 ++

Re: [dpdk-dev] [PATCH 0/2] Multiple Pktmbuf mempool support

2017-10-10 Thread Hemant Agrawal
On 10/10/2017 7:45 PM, Thomas Monjalon wrote: 25/09/2017 12:24, Olivier MATZ: Hi Hemant, On Fri, Sep 22, 2017 at 12:43:36PM +0530, Hemant Agrawal wrote: On 7/4/2017 5:52 PM, Hemant Agrawal wrote: This patch is in addition to the patch series[1] submitted by Santosh to allow application to set

[dpdk-dev] [PATCH] mempool: remove get capability debug print

2017-10-10 Thread Hemant Agrawal
This is not required to be printed for every mempool call. Signed-off-by: Hemant Agrawal --- lib/librte_mempool/rte_mempool.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 57a4f81..6357fd4 100644

  1   2   >