Glad to hear that helped! Then the patch will get merged soon. Thanks, Yongseok
> On Oct 10, 2017, at 1:10 AM, Martin Weiser > <martin.wei...@allegro-packets.com> wrote: > > Hi Yongseok, > > I can confirm that this patch fixes the crashes and freezing in my tests > so far. > > We still see an issue that once the mbufs run low and reference counts > are used as well as freeing of mbufs in processing lcores happens we > suddenly lose a large amount of mbufs that will never return to the > pool. But I can also reproduce this with ixgbe so this is not specific > to the mlx5 driver but rather an issue of the current dpdk-net-next > state. I will write up a separate mail with details how to reproduce this. > > Thank you for your support! > > Best regards, > Martin > > > On 08.10.17 00:19, Yongseok Koh wrote: >>> On Oct 6, 2017, at 3:30 PM, Yongseok Koh <ys...@mellanox.com> wrote: >>> >>> Hi, Martin >>> >>> Even though I had done quite serious tests before sending out the patch, >>> I figured out deadlock could happen if the Rx queue size is smaller. It is >>> 128 >>> by default in testpmd while I usually use 256. >>> >>> I've fixed the bug and submitted a new patch [1], which actually reverts the >>> previous patch. So, you can apply the attached with disregarding the old >>> one. >>> >>> And I have also done extensive tests for this new patch but please let me >>> know >>> your test results. >>> >>> [1] >>> "net/mlx5: fix deadlock due to buffered slots in Rx SW ring" >>> at >>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fdev%2Fpatchwork%2Fpatch%2F29847&data=02%7C01%7Cyskoh%40mellanox.com%7Cd026493e00eb429cb6b608d50fb673ed%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636432198675778556&sdata=YOZQFrSeIM%2BFw42CvqazNDYSv98jKB%2F2bMRSqrYo2a8%3D&reserved=0 >> Hi Martin >> >> I've submitted v2 of the patch [1]. I just replaced vector insns with regular >> statements. This is just for ease of maintenance because I'm about to add >> vectorized PMD for ARM NEON. In terms of functionality and performance it is >> identical. >> >> Please proceed your testing with this and let me know the result. >> >> [1] >> [dpdk-dev,v2] net/mlx5: fix deadlock due to buffered slots in Rx SW ring >> , which is at >> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fdev%2Fpatchwork%2Fpatch%2F29879%2F&data=02%7C01%7Cyskoh%40mellanox.com%7Cd026493e00eb429cb6b608d50fb673ed%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636432198675778556&sdata=IrrEKKLWYRarrbE2McSzytYaQ4zdh1nAnsWErgijd%2Fg%3D&reserved=0 >> >> Thanks, >> Yongseok
