-----Original Message----- > Date: Wed, 11 Oct 2017 01:16:25 +0200 > From: Thomas Monjalon <tho...@monjalon.net> > To: Nikhil Rao <nikhil....@intel.com> > Cc: dev@dpdk.org, jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > Subject: Re: [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps > function to SW PMD > > Hi, > > 11/10/2017 00:21, Nikhil Rao: > > --- a/lib/librte_eventdev/rte_eventdev_pmd.h > > +++ b/lib/librte_eventdev/rte_eventdev_pmd.h > > @@ -83,6 +83,14 @@ extern "C" { > > } \ > > } while (0) > > > > +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \ > > + ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | \ > > + (RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ)) > > + > > +/**< Ethernet Rx adapter cap to return If the packet transfers from > > + * the ethdev to eventdev use a SW service function > > + */ > > It is a value specific to the SW driver. > I think it should not be defined in librte_eventdev.
It should be defined in librte_eventdev as HW drivers use this flag if HW adapter needs to use SW for fallback. Already discussed this at http://dpdk.org/ml/archives/dev/2017-September/075302.html See HW driver usage as example for dpaa2. http://dpdk.org/ml/archives/dev/2017-October/078391.html function: dpaa2_eventdev_eth_caps_get > > Do you mind to move it for RC2?