Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Shahaf Shuler
September 12, 2017 9:43 AM, Andrew Rybchenko: I think port level is the right place for these flags. These flags define which transmit and transmit cleanup callbacks could be used. These functions are specified on port level now. However, I see no good reasons to change it. The Tx queue flags are

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Andrew Rybchenko
On 09/12/2017 09:35 AM, Shahaf Shuler wrote: Tuesday, September 12, 2017 8:52 AM, Jerin Jacob: - The application can express it wants such optimization. - It is global Currently it does not seems there is high demand for such flags from other PMDs. If such demand will raise, we can discuss aga

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items

2017-09-11 Thread Xing, Beilei
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, September 7, 2017 8:20 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items > >

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Andrew Rybchenko
On 09/12/2017 08:51 AM, Jerin Jacob wrote: Tuesday, September 12, 2017 7:01 AM, Jerin Jacob: Yes, only when ETH_TXQ_FLAGS_NOMULTMEMP and ETH_TXQ_FLAGS_NOREFCOUNT selected at tx queue configuration. So literally, yes it is not a TX HW offload, though I understand your intention to have such pos

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Shahaf Shuler
Tuesday, September 12, 2017 8:52 AM, Jerin Jacob: > > I understand the use case, and the fact those flags improve the > performance on low-end ARM CPUs. > > IMO those flags cannot be on queue/port level. They must be global. > > Where should we have it as global(in terms of API)? > And why it can

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Tue, 12 Sep 2017 05:25:42 + > From: Shahaf Shuler > To: Jerin Jacob , "Ananyev, Konstantin" > > CC: Stephen Hemminger , Thomas Monjalon > , "dev@dpdk.org" , "Zhang, Helin" > , "Wu, Jingjing" > Subject: RE: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx q

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Shahaf Shuler
Tuesday, September 12, 2017 7:01 AM, Jerin Jacob: > Yes, only when ETH_TXQ_FLAGS_NOMULTMEMP and > ETH_TXQ_FLAGS_NOREFCOUNT selected at tx queue configuration. > > > > > So literally, yes it is not a TX HW offload, though I understand your > > intention to have such possibility - it might help to s

Re: [dpdk-dev] [PATCH v3 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Tue, 12 Sep 2017 17:59:28 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > narend

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Mon, 11 Sep 2017 11:02:07 + > From: "Ananyev, Konstantin" > To: Jerin Jacob , Shahaf Shuler > > CC: Stephen Hemminger , Thomas Monjalon > , "dev@dpdk.org" , "Zhang, Helin" > , "Wu, Jingjing" > Subject: RE: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx q

[dpdk-dev] [PATCH v3 4/4] eventdev: Add tests for event eth Rx adapter APIs

2017-09-11 Thread Nikhil Rao
Add unit tests for rte_event_eth_rx_adapter_xxx() APIs Signed-off-by: Nikhil Rao --- test/test/test_event_eth_rx_adapter.c | 385 ++ test/test/Makefile| 1 + 2 files changed, 386 insertions(+) create mode 100644 test/test/test_event_eth_rx_a

[dpdk-dev] [PATCH v3 0/4] eventdev: cover letter: ethernet Rx queue event adapter

2017-09-11 Thread Nikhil Rao
Eventdev-based networking applications require a component to dequeue packets from NIC Rx queues and inject them into eventdev queues[1]. While some platforms (e.g. Cavium Octeontx) do this operation in hardware, other platforms use software. This patchset introduces an ethernet Rx event adapter t

[dpdk-dev] [PATCH v3 1/4] eventdev: Add caps API and PMD callbacks for rte_event_eth_rx_adapter

2017-09-11 Thread Nikhil Rao
The caps API allows application to get information needed to configure the ethernet receive adapter for the eventdev and ethdev pair. The PMD callbacks are used by the rte_event_eth_rx_xxx() APIs to configure and control the ethernet receive adapter if packet transfers from the ethdev to eventdev

[dpdk-dev] [PATCH v3 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-11 Thread Nikhil Rao
Add common APIs for configuring packet transfer from ethernet Rx queues to event devices across HW & SW packet transfer mechanisms. A detailed description of the adapter is contained in the header's comments. The adapter implementation uses eventdev PMDs to configure the packet transfer if HW supp

[dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev

2017-09-11 Thread Nikhil Rao
The SW event device always uses a EAL service function for packet transfer from the eth device to the event device, this function is capable of generating a event flow ID which is the IPv4/6 RSS hash. The caps function returns RTE_EVENT_ETH_RX_ADAPTER_SW_CAP which is currently set to RTE_EVENT_ETH

[dpdk-dev] ?????? About the shared flock for hugepage files

2017-09-11 Thread ??????
Hi Jim, Thank you for reply, i understand it, but i still have two doubts. 1) if i have > 1 DPDK application on a machine, i can use the parameter "--file-prefix" to distinguish, it can work even if have not flock. 2) If I understand correctly, in the "map_all_hugepages()", after making the s

Re: [dpdk-dev] About the shared flock for hugepage files

2017-09-11 Thread Jim Thompson
Bakari, This is so you can have > 1 DPDK application on a machine and they won't use each other's hugepages. See, for example the comments in clear_hugedir() http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c#n198 Jim > On Sep 11, 2017, at 9:16 PM, 白长敏 <912873..

Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-09-11 Thread Xing, Beilei
> -Original Message- > From: David Harton (dharton) [mailto:dhar...@cisco.com] > Sent: Tuesday, September 12, 2017 1:23 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast > addresses > > Hi Beilei, > > > ---

[dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support

2017-09-11 Thread Jiayu Hu
This patch adds GSO support for TCP/IPv4 packets. Supported packets may include a single VLAN tag. TCP/IPv4 GSO assumes that all input packets have correct checksums, and doesn't update checksums for output packets (the responsibility for this lies with the application). Additionally, TCP/IPv4 GSO

Re: [dpdk-dev] [PATCH] net/virtio-user: send kick to tx queue to notify backend on initialization

2017-09-11 Thread Yuanhan Liu
On Tue, Aug 01, 2017 at 09:17:36AM -0700, Steven wrote: > Acccording to the spec, > https://fossies.org/linux/qemu/docs/specs/vhost-user.txt > > client must start ring upon receiving a kick (that is, detecting that file > descriptor is reachable) on the descriptor specified by > VHOST_USER_SET_VR

[dpdk-dev] [PATCH v3 4/5] gso: add GRE GSO support

2017-09-11 Thread Jiayu Hu
From: Mark Kavanagh This patch adds GSO support for GRE-tunneled packets. Supported GRE packets must contain an outer IPv4 header, and inner TCP/IPv4 headers. They may also contain a single VLAN tag. GRE GSO assumes that all input packets have correct checksums and doesn't update checksums for ou

[dpdk-dev] [PATCH v3 5/5] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO

2017-09-11 Thread Jiayu Hu
This patch adds GSO support to the csum forwarding engine. Oversized packets transmitted over a GSO-enabled port will undergo segmentation (with the exception of packet-types unsupported by the GSO library). GSO support is disabled by default. GSO support may be toggled on a per-port basis, using

[dpdk-dev] [PATCH v3 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK

2017-09-11 Thread Jiayu Hu
Generic Segmentation Offload (GSO) is a SW technique to split large packets into small ones. Akin to TSO, GSO enables applications to operate on large packets, thus reducing per-packet processing overhead. To enable more flexibility to applications, DPDK GSO is implemented as a standalone library.

[dpdk-dev] [PATCH v3 1/5] gso: add Generic Segmentation Offload API framework

2017-09-11 Thread Jiayu Hu
Generic Segmentation Offload (GSO) is a SW technique to split large packets into small ones. Akin to TSO, GSO enables applications to operate on large packets, thus reducing per-packet processing overhead. To enable more flexibility to applications, DPDK GSO is implemented as a standalone library.

[dpdk-dev] [PATCH v3 3/5] gso: add VxLAN GSO support

2017-09-11 Thread Jiayu Hu
From: Mark Kavanagh This patch adds GSO support for VxLAN-encapsulated packets. Supported VxLAN packets must have an outer IPv4 header (prepended by an optional VLAN tag), and contain an inner TCP/IPv4 packet (with an optional inner VLAN tag). VxLAN GSO assumes that all input packets have correc

Re: [dpdk-dev] [PATCH v2 00/10] virtio fixes

2017-09-11 Thread Yuanhan Liu
On Thu, Sep 07, 2017 at 02:13:37PM +0200, Olivier Matz wrote: > This patchset addresses several issues related to offload and > Rx/Tx handler selection in virtio PMD. Thanks a lot for working on it. Seires applied to dpdk-next-virtio. --yliu > > v1 -> v2: > - add one patch to remove unee

Re: [dpdk-dev] [PATCH v2 1/3] eal/x86: run-time dispatch over memcpy

2017-09-11 Thread Li, Xiaoyun
Hi ALL After investigating, most DPDK codes are already run-time dispatching. Only rte_memcpy chooses the ISA at build-time. To modify memcpy, there are two ways. The first one is function pointers and another is function multi-versioning in GCC. But memcpy has been greatly optimized and gets

[dpdk-dev] About the shared flock for hugepage files

2017-09-11 Thread ??????
Hi, everyone, I'm a developer from china, now i have a problem is about the shared flock for hugepage files in the function of "map_all_hugepages()". as follows: --- /* set shared flock on the f

Re: [dpdk-dev] [RFC PATCH 1/1] net/mlx5: add vectorized Rx/Tx burst for ARM

2017-09-11 Thread Yongseok Koh
Hi Nelio, Sorry for delayed reply. I was on vacation for a week. On Mon, Sep 04, 2017 at 02:37:05PM +0200, Nélio Laranjeiro wrote: > Hi Yongseok, > > Some questions/comments below, > > On Fri, Aug 25, 2017 at 11:40:23AM -0700, Yongseok Koh wrote: > > New Rx/Tx burst functions are added using NE

Re: [dpdk-dev] [PATCH] net/mlx5: fix calculating TSO inline size

2017-09-11 Thread Yongseok Koh
On Mon, Sep 04, 2017 at 04:01:08PM +0200, Nélio Laranjeiro wrote: > Hi Yongseok, > > Please see some comments below, > > On Thu, Aug 31, 2017 at 09:27:06AM -0700, Yongseok Koh wrote: > > Tx descriptor for TSO embeds packet header to be replicated. If Tx inline > > is enabled, there could be addit

Re: [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function

2017-09-11 Thread Stephen Hemminger
I wonder if it is time to move the bar forward to oldest LTS which is 3.2.92 On Sep 11, 2017 10:56 AM, "Ferruh Yigit" wrote: > On 9/5/2017 1:04 PM, Markus Theil wrote: > > The patch which introduced the usage of pci_alloc_irq_vectors > > came after the patch which switched to non-threaded ISR (

[dpdk-dev] git trees organization

2017-09-11 Thread Thomas Monjalon
Hi all, As you know I am currently the only maintainer of the master tree. It is very convenient because I need to synchronize with others only when pulling "next-*" trees. But the drawback is that I should be available very often to avoid stalled patches waiting in patchwork backlog. I feel it i

[dpdk-dev] [PATCH] net/enic: fix multi-process operation

2017-09-11 Thread John Daley
- Use rte_malloc() instead of malloc() for the per device 'vdev' structure so that it can be shared across processes. - Only initialize the device if the process type is RTE_PROC_PRIMARY - Only allow the primary process to do queue setup, start/stop, promisc allmulticast, mac add/del, mtu. Fix

Re: [dpdk-dev] [PATCH 06/26] net/octeontx/base: probe PKI and PKO PCIe VF devices

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Tue, 5 Sep 2017 18:44:22 +0100 > From: Ferruh Yigit > To: Jerin Jacob , dev@dpdk.org > CC: santosh.shu...@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH 06/26] net/octeontx/base: probe PKI and PKO > PCIe VF devices > User-Agent: Mozilla/5.0 (Windows NT 10.0

Re: [dpdk-dev] [PATCH 02/10] net/qede: fix compilation with -Og

2017-09-11 Thread Patil, Harish
-Original Message- From: dev on behalf of Olivier Matz Date: Monday, September 11, 2017 at 8:13 AM To: "dev@dpdk.org" Subject: [dpdk-dev] [PATCH 02/10] net/qede: fix compilation with -Og >The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following >error: > > CC qede_rxtx.o

Re: [dpdk-dev] [PATCH 00/26] DPDK PMD for OCTEONTX NW device

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Tue, 5 Sep 2017 18:43:37 +0100 > From: Ferruh Yigit > To: Jerin Jacob , dev@dpdk.org > CC: santosh.shu...@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH 00/26] DPDK PMD for OCTEONTX NW device > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/

Re: [dpdk-dev] [RFC PATCH 0/1] IPSec Inline and look aside crypto offload

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Sep 2017 16:42:56 +0530 > From: Akhil Goyal > To: Jerin Jacob , Radu Nicolau > > CC: Thomas Monjalon , dev@dpdk.org, > bor...@mellanox.com, declan.dohe...@intel.com, avia...@mellanox.com, > sandeep.ma...@nxp.com, hemant.agra...@nxp.com, > pablo.de.lar

Re: [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function

2017-09-11 Thread Ferruh Yigit
On 9/5/2017 1:04 PM, Markus Theil wrote: > The patch which introduced the usage of pci_alloc_irq_vectors > came after the patch which switched to non-threaded ISR (f0d1896fa1), > but did not use non-threaded ISR, if pci_alloc_irq_vectors > is used. > > Fixes: 99bb58f3adc7 ("igb_uio: switch to new

Re: [dpdk-dev] [PATCH v3 4/4] eventdev: add device started attribute

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Sep 2017 16:36:55 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH v3 4/4] eventdev: add device started attribute > X-Mailer: git-send-email 2.7.4 > > This commit adds an attrib

Re: [dpdk-dev] [PATCH v7 1/6] igb_uio: refactor irq enable/disable into own functions

2017-09-11 Thread Ferruh Yigit
On 9/5/2017 1:04 PM, Markus Theil wrote: > Interrupt setup code in igb_uio has to deal with multiple > types of interrupts and kernel versions. This patch moves > the setup and teardown code into own functions, to make > it more readable. > > Signed-off-by: Markus Theil Series Acked-by: Ferruh Y

Re: [dpdk-dev] [PATCH v3 3/4] eventdev: add queue attribute function

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Sep 2017 16:36:54 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH v3 3/4] eventdev: add queue attribute function > X-Mailer: git-send-email 2.7.4 > > This commit adds a generic

Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-09-11 Thread David Harton (dharton)
Hi Beilei, > -Original Message- > From: Xing, Beilei [mailto:beilei.x...@intel.com] > > Hi, > > > -Original Message- > > From: David Harton [mailto:dhar...@cisco.com] > > > > The i40e maintains a single MAC filter table for both unicast and > > multicast addresses. The i40e_vali

Re: [dpdk-dev] [PATCH v3 2/4] eventdev: add dev attribute get function

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Sep 2017 16:36:53 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH v3 2/4] eventdev: add dev attribute get function > X-Mailer: git-send-email 2.7.4 > > This commit adds a devic

Re: [dpdk-dev] [PATCH 2/2] doc: add API documentation for bnxt PMD

2017-09-11 Thread Ferruh Yigit
On 9/11/2017 5:33 PM, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > doc/api/doxy-api-index.md | 1 + > doc/api/doxy-api.conf | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md > index 19e0d4f3d..1e8068d7c 100644 > ---

Re: [dpdk-dev] [PATCH v3 1/4] eventdev: add port attribute function

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Sep 2017 16:36:52 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH v3 1/4] eventdev: add port attribute function > X-Mailer: git-send-email 2.7.4 > > This commit reworks the por

[dpdk-dev] [PATCH 2/2] doc: add API documentation for bnxt PMD

2017-09-11 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index 19e0d4f3d..1e8068d7c 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md

[dpdk-dev] [PATCH 1/2] doc: add shared library versions for missing PMDs

2017-09-11 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/rel_notes/release_17_11.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 8773b086d..925612eea 100644 --- a/doc/guides/rel_notes/release_17_11.rst +++ b/doc/g

Re: [dpdk-dev] [PATCH v2] net/failsafe: stat support enhancement

2017-09-11 Thread Ferruh Yigit
On 9/7/2017 1:19 PM, Gaëtan Rivet wrote: > Hi Matan, > > You should send your v[N] In-Reply-To the Message-Id of your v[N-1] > to help people reading. > > On Thu, Sep 07, 2017 at 02:31:13PM +0300, Matan Azrad wrote: >> The previous stats code returned only the current TX sub >> device stats. >> >

Re: [dpdk-dev] [PATCH v3 0/4] eventdev: add attribute based get APIs

2017-09-11 Thread Jerin Jacob
-Original Message- > Date: Fri, 8 Sep 2017 16:36:51 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH v3 0/4] eventdev: add attribute based get APIs > X-Mailer: git-send-email 2.7.4 > > This patchset refactors th

Re: [dpdk-dev] [PATCH v5] net/mlx5: support device removal event

2017-09-11 Thread Ferruh Yigit
On 9/8/2017 11:47 AM, Matan Azrad wrote: > Extend the LSC event handling to support the device removal as well. > > The mlx5 event handling has been made capable of receiving and > signaling several event types at once. > > This support includes next: > 1. Removal event detection according to the

Re: [dpdk-dev] [PATCH v4 1/2] net/mlx5: link status update separation

2017-09-11 Thread Ferruh Yigit
On 9/6/2017 4:14 PM, Adrien Mazarguil wrote: > On Wed, Sep 06, 2017 at 06:03:57PM +0300, Matan Azrad wrote: >> Link status is sometimes inconsistent during a LSC event. >> When it occurs, the PMD refrains from immediately notifying >> the application; instead, an alarm is scheduled to check >> link

Re: [dpdk-dev] [PATCH] sched: make RED scaling configurable

2017-09-11 Thread Kantecki, Tomasz
Hi Alan, This looks like a very good idea but I think the patch must also cover adequate changes of test/test/test_red.c file. What range of fraction/max_threshold values did you find to work correctly with no further code mods? Thanks, Tomasz -Original Message- From: alangordonde...@g

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: get information about protocols defined in ddp profile

2017-09-11 Thread Ferruh Yigit
On 9/1/2017 5:01 PM, Kirill Rybalchenko wrote: > This patch adds new package info types to get list of protocols, > pctypes and ptypes defined in a profile > > Signed-off-by: Kirill Rybalchenko <...> > +/* Get number of tvl records in the section */ > +static unsigned > +i40e_get_tlv_section_si

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: get information about protocols defined in ddp profile

2017-09-11 Thread Ferruh Yigit
On 9/1/2017 5:01 PM, Kirill Rybalchenko wrote: > Update 'ddp get info' command to display protocols defined in a profile > > Signed-off-by: Kirill Rybalchenko > --- > app/test-pmd/cmdline.c | 98 > +- > 1 file changed, 97 insertions(+), 1 deletio

Re: [dpdk-dev] [PATCH 00/10] fix compilation with -Og

2017-09-11 Thread Bruce Richardson
On Mon, Sep 11, 2017 at 05:13:23PM +0200, Olivier Matz wrote: > In developer mode (RTE_DEVEL_BUILD=y) where -Werror is passed in the > CFLAGS, the compilation fails with gcc-6.3.0 and EXTRA_CFLAGS=-Og. Some > errors are real bugs (but not critical), while some are false positives > (gcc bugs?). >

[dpdk-dev] [PATCH v4 0/2] Dynamically configure mempool handle

2017-09-11 Thread Santosh Shukla
v4: - Includes v3 review coment changes. Patches rebased on 06791a4bce: ethdev: get the supported pools for a port v3: - Rebased on top of v17.11-rc0 - Updated version.map entry to v17.11. v2: DPDK has support for hw and sw mempool. Those mempool can work optimal for specific PMD's. Exampl

[dpdk-dev] [PATCH v4 2/2] ethdev: get the supported pools for a port

2017-09-11 Thread Santosh Shukla
Now that dpdk supports more than one mempool drivers and each mempool driver works best for specific PMD, example: - sw ring based mempool for Intel PMD drivers. - dpaa2 HW mempool manager for dpaa2 PMD driver. - fpa HW mempool manager for Octeontx PMD driver. Application would like to know the be

[dpdk-dev] [PATCH v4 1/2] eal: allow user to override default pool handle

2017-09-11 Thread Santosh Shukla
DPDK has support for both sw and hw mempool and currently user is limited to use ring_mp_mc pool. In case user want to use other pool handle, need to update config RTE_MEMPOOL_OPS_DEFAULT, then build and run with desired pool handle. Introducing eal option to override default pool handle. Now use

[dpdk-dev] [PATCH 10/10] app/test-crypto-perf: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC cperf_test_verify.o cperf_test_verify.c: In function ‘cperf_verify_op’: cperf_test_verify.c:382:5: error: ‘auth’ may be used uninitialized in this function [-We

[dpdk-dev] [PATCH 09/10] app/test-crypto-perf: fix memory leak

2017-09-11 Thread Olivier Matz
data is allocated but never freed. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Olivier Matz --- app/test-crypto-perf/cperf_test_verify.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-cr

[dpdk-dev] [PATCH 05/10] uio: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC eal_pci_uio.o eal_pci_uio.c: In function ‘pci_get_uio_de ’: eal_pci_uio.c:221:9: error: ‘uio_num’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return uio_num

[dpdk-dev] [PATCH 07/10] metrics: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC rte_metrics.o rte_metrics.c: In function ‘rte_metrics_reg_names’: rte_metrics.c:153:22: error: ‘entry’ may be used uninitialized in this function [-Werror=m

[dpdk-dev] [PATCH 08/10] lpm6: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC rte_lpm6.o rte_lpm6.c: In function ‘rte_lpm6_add_v1705’: rte_lpm6.c:442:11: error: ‘tbl_next’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (!tbl[

[dpdk-dev] [PATCH 06/10] cmdline: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC cmdline_parse.o cmdline_parse.c: In function ‘match_inst’: cmdline_parse.c:227:5: error: ‘token_p’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (token

[dpdk-dev] [PATCH 01/10] net/bnxt: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC rte_pmd_bnxt.o rte_pmd_bnxt.c: In function ‘rte_pmd_bnxt_set_all_queues_drop_en’: rte_pmd_bnxt.c:116:6: error: ‘rc’ may be used uninitialized in this function [-Werror=maybe-uninitialize

[dpdk-dev] [PATCH 02/10] net/qede: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC qede_rxtx.o qede_rxtx.c: In function ‘qede_start_queues’: qede_rxtx.c:797:9: error: ‘rc’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return rc;

[dpdk-dev] [PATCH 04/10] net/i40e: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC i40e_adminq.o i40e_adminq.c: In function ‘i40e_clean_arq_element’: i40e_adminq.c:1145:56: error: ‘ntu’ may be used uninitialized in this function [-Werror=maybe-uninitialized] *pen

[dpdk-dev] [PATCH 00/10] fix compilation with -Og

2017-09-11 Thread Olivier Matz
In developer mode (RTE_DEVEL_BUILD=y) where -Werror is passed in the CFLAGS, the compilation fails with gcc-6.3.0 and EXTRA_CFLAGS=-Og. Some errors are real bugs (but not critical), while some are false positives (gcc bugs?). The solution often consists in initializing a local variable to ensure t

[dpdk-dev] [PATCH 03/10] net/virtio: fix compilation with -Og

2017-09-11 Thread Olivier Matz
The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC virtio_rxtx.o virtio_rxtx.c: In function ‘virtio_rx_offload’: virtio_rxtx.c:680:10: error: ‘csum’ may be used uninitialized in this function [-Werror=maybe-uninitialized] csum = ~

[dpdk-dev] [PATCH] net: fix inner L2 length in software ptype parser

2017-09-11 Thread Olivier Matz
The inner L2 length returned by rte_net_get_ptype() is not properly initialized. If the caller does not zero the header lengths structure, the inner_l2 field will be undefined. Fix it by initializing inner_l2 to 0 when parsing a inner layer. Fixes: 2c15c5377da2 ("net: support NVGRE in software pa

Re: [dpdk-dev] [PATCH] net/virtio-user: send kick to tx queue to notify backend on initialization

2017-09-11 Thread Steven Luong (sluong)
Dear Maxime and Yuanhan, Do you have any more question on this patch? According to the text in the spec, the vring/queue is supposed to be disable until a kick is received. This is to ensure that the kickfd is working properly prior to the operation and I think it makes sense. The only exceptio

Re: [dpdk-dev] [PATCH v2 0/6] NXP DPAA2: Refactor bus scan/probe code

2017-09-11 Thread Shreyansh Jain
On Monday 11 September 2017 07:36 PM, Ferruh Yigit wrote: On 8/25/2017 11:19 AM, Shreyansh Jain wrote: Change Log: ~~~ v2: - Minor updates for logging (removed some logs and changed others to make it cleaner when application starts) Brief: ~~ -- v1 is at [3] -- In [1

Re: [dpdk-dev] [PATCH v2 0/6] NXP DPAA2: Refactor bus scan/probe code

2017-09-11 Thread Ferruh Yigit
On 8/25/2017 11:19 AM, Shreyansh Jain wrote: > Change Log: > ~~~ > v2: >- Minor updates for logging (removed some logs and changed others > to make it cleaner when application starts) > > Brief: > ~~ > > -- v1 is at [3] -- > > In [1], during the IOVA Mapping patch set [2]

Re: [dpdk-dev] [PATCH 6/6] app/crypto-perf: use single mempool

2017-09-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Monday, September 11, 2017 2:11 PM > To: De Lara Guarch, Pablo ; Akhil Goyal > > Cc: Doherty, Declan ; Trahe, Fiona > ; Jain, Deepak K ; > Griffin, John ; jerin.ja...@caviumnetworks.com; > hemant.agra...@

[dpdk-dev] [PATCH] net/nfp: remove firmware ABI check

2017-09-11 Thread Alejandro Lucero
Link speed is not advertised in old firmwares. However, it is safe to remove the check because reading NFP_NET_CFG_STS returns 0 in those cases. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/driver

Re: [dpdk-dev] [PATCH v2] net/thunderx: add device speed capability info

2017-09-11 Thread Ferruh Yigit
On 9/4/2017 4:10 PM, Jerin Jacob wrote: > updated nicvf feature file to mark support. > > Signed-off-by: Jerin Jacob Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] doc: announce ABI change for ring structure

2017-09-11 Thread Olivier Matz
As discussed on the mailing list, the alignment constraint of the ring structure can be relaxed. Link: http://dpdk.org/dev/patchwork/patch/25039 Link: http://dpdk.org/dev/patchwork/patch/26103 Signed-off-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 ins

Re: [dpdk-dev] [PATCH 0/6] remove unncessary void cast

2017-09-11 Thread Ferruh Yigit
On 9/11/2017 1:44 PM, Ferruh Yigit wrote: > On 8/23/2017 4:44 PM, Stephen Hemminger wrote: >> There are many places that cast away the return value from >> rte_memcpy(). This was a common practice in the Unix BSD days because >> lint would complain about unused return values, but it is not done >>

Re: [dpdk-dev] [PATCH] vmxnet3: mac address set fixes

2017-09-11 Thread Ferruh Yigit
On 9/10/2017 6:40 PM, Shrikrishna Khare wrote: > > > On Fri, 25 Aug 2017, David Harton wrote: > >> Updated vmxnet3_mac_addr_set() to store the newly set MAC address. >> Modified vmxnet3_write_mac() so the h/w is updated in an endian >> neutral manner. >> >> Signed-off-by: David Harton > > Acke

[dpdk-dev] [PATCH] net/nfp: add info about RSS capabilities

2017-09-11 Thread Alejandro Lucero
NFP supports RSS but it is not being advertised. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 5d35ce1..2c288c2 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/driver

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix invalid session error

2017-09-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, September 11, 2017 1:22 PM > To: Gonzalez Monroy, Sergio ; > dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/aesni_mb: fix invalid session error > > > > > -Original Mes

Re: [dpdk-dev] [PATCH] vmxnet3: replenish ring buffers in rx processing

2017-09-11 Thread Ferruh Yigit
On 9/10/2017 5:47 PM, Shrikrishna Khare wrote: > > > On Fri, 25 Aug 2017, David Harton wrote: > >> vmxnet3 rx processing should replenish ring buffers after new buffers >> are available to prevent the interface from getting stuck in a state >> that no new work is processed. >> >> Signed-off-by:

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Andrew Rybchenko
On 09/11/2017 03:27 PM, Shahaf Shuler wrote: September 11, 2017 11:03 AM, Andrew Rybchenko: +/** + * A conversion function from txq_flags API. + */ +static void +rte_eth_convert_txq_flags(const uint32_t txq_flags, uint64_t *tx_offloads) Maybe tx_offlaods should be simp

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-09-11 Thread Ananyev, Konstantin
Hi Jiayu, > > > Linux supports two kinds of IP identifier: fixed identifier and > > > incremental > > identifier, and > > > which one to use depends on upper protocol modules. Specifically, if the > > protocol module > > > wants fixed identifiers, it will set SKB_GSO_TCP_FIXEDID to skb->gso_type,

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: allow pmd to advertise pool handle

2017-09-11 Thread Olivier MATZ
On Mon, Sep 11, 2017 at 06:10:36PM +0530, santosh wrote: > Hi Olivier, > > > On Monday 11 September 2017 03:03 PM, Olivier MATZ wrote: > > On Thu, Sep 07, 2017 at 04:38:39PM +0530, Hemant Agrawal wrote: > >> On 9/7/2017 3:41 PM, santosh wrote: > >>> Sorry for the font, resending proposed API: > >

Re: [dpdk-dev] [PATCH 0/6] remove unncessary void cast

2017-09-11 Thread Ferruh Yigit
On 8/23/2017 4:44 PM, Stephen Hemminger wrote: > There are many places that cast away the return value from > rte_memcpy(). This was a common practice in the Unix BSD days because > lint would complain about unused return values, but it is not done > in modern Linux style because it clutters the c

Re: [dpdk-dev] [PATCH 6/6] app/crypto-perf: use single mempool

2017-09-11 Thread Shreyansh Jain
Hello Pablo, I have a comment inline: On Monday 11 September 2017 04:38 PM, De Lara Guarch, Pablo wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal Sent: Wednesday, August 30, 2017 9:31 AM To: De Lara Guarch, Pablo ; Doherty, Declan ; Trahe, Fion

[dpdk-dev] [PATCH v3 3/3] net/mlx5: enforce Tx num of segments limitation

2017-09-11 Thread Shahaf Shuler
Mellanox NICs has a limitation on the number of mbuf segments a multi segment mbuf can have. The max number depends on the Tx offloads requested. The current code not enforce such limitation, which might cause malformed work requests to be written to the device. This commit adds verification for

[dpdk-dev] [PATCH v3 2/3] net/mlx5: fix Tx stats error counter

2017-09-11 Thread Shahaf Shuler
The current Tx error counter counts, according to its description, the total number of packets not sent when TX ring full. It is reported to application as part of oerrors field. Putting aside the fact there is no logic which increment this counter, the behaviour of the PMD is wrong. The drop due

[dpdk-dev] [PATCH v3 1/3] net/mlx5: fix num seg assumption on vPMD

2017-09-11 Thread Shahaf Shuler
vPMD Tx function assumes that after the scatter of the multi-segment packets the next packet will be a single segment packet. This is not current as the function can return due to lack of resources without sending all of the multi-segment mbufs sequence. Fixes: 6cb559d67b83 ("net/mlx5: add vector

Re: [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts

2017-09-11 Thread Ferruh Yigit
On 8/23/2017 4:44 PM, Stephen Hemminger wrote: > The testpmd was doing old BSD lint style casts of rte_memcpy > to (void). This is unnecessary. > > Signed-off-by: Stephen Hemminger <...> > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2173,7 +2173,7 @@ init_port_dcb_config(p

Re: [dpdk-dev] [PATCH 0/6] remove unncessary void cast

2017-09-11 Thread Ferruh Yigit
On 8/23/2017 4:44 PM, Stephen Hemminger wrote: > There are many places that cast away the return value from > rte_memcpy(). This was a common practice in the Unix BSD days because > lint would complain about unused return values, but it is not done > in modern Linux style because it clutters the c

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: allow pmd to advertise pool handle

2017-09-11 Thread santosh
Hi Olivier, On Monday 11 September 2017 03:03 PM, Olivier MATZ wrote: > On Thu, Sep 07, 2017 at 04:38:39PM +0530, Hemant Agrawal wrote: >> On 9/7/2017 3:41 PM, santosh wrote: >>> Sorry for the font, resending proposed API: >>> >>> /** >>> * Get list of supported pools for a port >>> * @param po

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Shahaf Shuler
September 11, 2017 11:03 AM, Andrew Rybchenko: +/** + * A conversion function from txq_flags API. + */ +static void +rte_eth_convert_txq_flags(const uint32_t txq_flags, uint64_t *tx_offloads) Maybe tx_offlaods should be simply return value of the function instead of void. Similar comm

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix invalid session error

2017-09-11 Thread Zhang, Roy Fan
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Thursday, September 7, 2017 12:51 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto/aesni_mb: fix invalid

Re: [dpdk-dev] [PATCH v2] vhost: adaptively batch small guest memory copies

2017-09-11 Thread Yuanhan Liu
On Sat, Sep 09, 2017 at 08:28:57PM +0530, santosh wrote: > On Friday 08 September 2017 06:20 PM, Tiwei Bie wrote: > > This patch adaptively batches the small guest memory copies. > > By batching the small copies, the efficiency of executing the > > memory LOAD instructions can be improved greatly,

Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range

2017-09-11 Thread Yang, Zhiyong
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 11, 2017 6:23 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Hunt, David > > Subject: Re: [PATCH v3 0/4] increase port_id range > > On 9/9/2017 3:47 PM, Zhiyong Yang wrote: > >

Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range

2017-09-11 Thread Ferruh Yigit
On 9/11/2017 11:55 AM, Yang, Zhiyong wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Monday, September 11, 2017 6:27 PM >> To: Yang, Zhiyong ; dev@dpdk.org >> Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Hunt, David >> >> Subject: Re: [PATCH v3 0/4] increas

Re: [dpdk-dev] [PATCH 6/6] app/crypto-perf: use single mempool

2017-09-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Wednesday, August 30, 2017 9:31 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan ; Trahe, Fiona > ; Jain, Deepak K ; > Griffin, John ; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com >

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads API

2017-09-11 Thread Ananyev, Konstantin
> > > > > > > > I don't understand. > > > > From the exact link above, you explicitly say that *you* will move this > > > > flags > > > once the series is integrated. Quoting: > > > > > > > > " > > > > > Please Jerin, could you work on moving these settings in a new API? > > > > > > > > Sure. Onc

Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range

2017-09-11 Thread Yang, Zhiyong
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, September 11, 2017 6:27 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Hunt, David > > Subject: Re: [PATCH v3 0/4] increase port_id range > > > 3. add 17.11 release note. > Th

  1   2   >