On Mon, Sep 11, 2017 at 05:13:23PM +0200, Olivier Matz wrote: > In developer mode (RTE_DEVEL_BUILD=y) where -Werror is passed in the > CFLAGS, the compilation fails with gcc-6.3.0 and EXTRA_CFLAGS=-Og. Some > errors are real bugs (but not critical), while some are false positives > (gcc bugs?). > > The solution often consists in initializing a local variable to > ensure the compiler won't complain. > > The patchset contains all the fixes needed to properly compile with -Og. > Feedback is welcome to decide if: > 1/ we include all of them, even if some are workarounds for > gcc bugs > 2/ we only include the real fixes, without fixing the compilation with > -Og. > Unless it's in a performance critical code path, where additional tests may be needed to ensure it's not affecting the performance via extra writes to the variable, I'd say apply them all! No point in leaving known errors/warnings around when the fixes are generally trivial.
/Bruce
