September 11, 2017 11:03 AM, Andrew Rybchenko:



 +/**

 + * A conversion function from txq_flags API.

 + */

 +static void

 +rte_eth_convert_txq_flags(const uint32_t txq_flags, uint64_t *tx_offloads)

Maybe tx_offlaods should be simply return value of the function instead of void.
Similar comment is applicable to rte_eth_convert_txq_offloads().


Can you elaborate why it would be better?

Reply via email to