Re: [dpdk-dev] [PATCH] igbvf: fix MAC address set problem

2017-04-27 Thread Yang, Qiming
Hi, Wenzhuo > -Original Message- > From: Lu, Wenzhuo > Sent: Friday, April 28, 2017 8:39 AM > To: Yang, Qiming ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] igbvf: fix MAC address set problem > > Hi Qiming, > > > -Original Message- > > From: Yang, Qiming > > Sent: T

[dpdk-dev] [PATCH] net/avp: fix interrupt migration check

2017-04-27 Thread Ferruh Yigit
Bitwise OR within if statement is always true, fix bitwise operator. Coverity issue: 1423906 Fixes: 82e140b84995 ("net/avp: handle interrupt migration") Signed-off-by: Ferruh Yigit --- drivers/net/avp/avp_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/a

[dpdk-dev] [PATCH] ixgbe: check scatter_enable in set_mtu

2017-04-27 Thread Jia Yu
There exists case that software sets mtu (i.e jumbo frame) of ixgbe device when it's stopped. Before the fix, scattered_rx is cleared during device stop, and setting jumbo frame mtu after device stop will always fail as scattered_rx is 0. Signed-off-by: Jia Yu --- drivers/net/ixgbe/ixgbe_ethdev.

[dpdk-dev] [PATCH v2] sched: add neon optimizations

2017-04-27 Thread Ashwin Sekhar T K
* Removed setting CONFIG_RTE_SCHED_VECTOR=n from armv8a config so that the setting from common_base is taken as the default setting for armv8a * Verified the changes with sched_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Removed line CONFIG_RTE_SCHED_VECTOR=n from conf

Re: [dpdk-dev] [PATCH] sched: enable neon optimizations

2017-04-27 Thread Sekhar, Ashwin
On Friday 28 April 2017 11:07 AM, Jianbo Liu wrote: > On 28 April 2017 at 13:27, Sekhar, Ashwin wrote: >> On Friday 28 April 2017 09:20 AM, Jianbo Liu wrote: >>> On 27 April 2017 at 21:00, Ashwin Sekhar T K >>> wrote: * Enabled CONFIG_RTE_SCHED_VECTOR for arm64 * Verified the changes wi

Re: [dpdk-dev] [PATCH] net/i40e: consider QinQ when setting MTU

2017-04-27 Thread Ferruh Yigit
On 4/28/2017 2:55 AM, Wenzhuo Lu wrote: > When counting max packet length from MTU, count > VLAN tag length twice for QinQ packets. > > Signed-off-by: Wenzhuo Lu > --- > drivers/net/i40e/i40e_ethdev.c| 2 +- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > 2 files changed, 2 insertions(+), 2 de

Re: [dpdk-dev] [PATCH] sched: enable neon optimizations

2017-04-27 Thread Jianbo Liu
On 28 April 2017 at 13:27, Sekhar, Ashwin wrote: > On Friday 28 April 2017 09:20 AM, Jianbo Liu wrote: >> On 27 April 2017 at 21:00, Ashwin Sekhar T K >> wrote: >>> * Enabled CONFIG_RTE_SCHED_VECTOR for arm64 >>> * Verified the changes with sched_autotest unit test case >>> >>> Signed-off-by: Ash

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix ntuple filter support for sctp

2017-04-27 Thread Ferruh Yigit
On 4/28/2017 4:37 AM, Wei Zhao wrote: > Add the support of RTE_FLOW_ITEM_TYPE_SCTP type packet for > ixgbe ntuple filter. > > Fixes: 672be56d76a ("net/ixgbe: parse n-tuple filter") > > Signed-off-by: Wei Zhao Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] sched: enable neon optimizations

2017-04-27 Thread Sekhar, Ashwin
On Friday 28 April 2017 09:20 AM, Jianbo Liu wrote: > On 27 April 2017 at 21:00, Ashwin Sekhar T K > wrote: >> * Enabled CONFIG_RTE_SCHED_VECTOR for arm64 >> * Verified the changes with sched_autotest unit test case >> >> Signed-off-by: Ashwin Sekhar T K >> --- >> config/defconfig_arm64-armv8a-l

Re: [dpdk-dev] [PATCH v4] net/ixgbe: ensure link status is updated

2017-04-27 Thread Ferruh Yigit
On 4/28/2017 1:43 AM, Dai, Wei wrote: >> -Original Message- >> From: Laurent Hardy [mailto:laurent.ha...@6wind.com] >> Sent: Thursday, April 27, 2017 11:04 PM >> To: dev@dpdk.org; Dai, Wei >> Cc: Yigit, Ferruh ; Zhang, Helin >> ; Ananyev, Konstantin >> ; olivier.m...@6wind.com >> Subject:

Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix updating the slave link status

2017-04-27 Thread Ferruh Yigit
On 4/27/2017 3:28 PM, Declan Doherty wrote: > On 25/04/2017 7:30 AM, wang wei wrote: >> we need to update dev->data->dev_link before handling lsc event. >> Otherwise it will still have the initial value after the startup of >> the program before interrupt callback was executed. >> >> Signed-off-by:

Re: [dpdk-dev] [PATCH v2] config: make AVX and AVX512 configurable

2017-04-27 Thread Yuanhan Liu
On Thu, Apr 27, 2017 at 07:00:14PM -0400, Zhihong Wang wrote: > Making AVX and AVX512 configurable is useful for performance and power > testing. > > The similar kernel patch at https://patchwork.kernel.org/patch/9618883/. > > AVX512 support like in rte_memcpy has been in DPDK since 16.04, but it

Re: [dpdk-dev] [PATCH] config: set cache line as 128B in the generic arm64 config

2017-04-27 Thread Jerin Jacob
-Original Message- > Date: Fri, 28 Apr 2017 10:14:11 +0800 > From: Jianbo Liu > To: Jerin Jacob > Cc: dev@dpdk.org, tho...@monjalon.net, Hemant Agrawal > , christian.ehrha...@canonical.com > Subject: Re: [dpdk-dev] [PATCH] config: set cache line as 128B in the > generic arm64 config >

Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix dev detachable flag

2017-04-27 Thread Yuanhan Liu
On Wed, Feb 22, 2017 at 10:34:23AM +0800, Yuanhan Liu wrote: > On Mon, Feb 20, 2017 at 10:04:45PM +0800, hanxue...@126.com wrote: > > From: Huanle Han > > > > The dev detachable flag was removed by > > commit f229eb4 ("net/virtio: fix rewriting LSC flag"). > > > > Signed-off-by: Huanle Han > >

Re: [dpdk-dev] [PATCH 2/3] net/virtio: fix crash when close virtio dev twice

2017-04-27 Thread Yuanhan Liu
On Wed, Feb 22, 2017 at 10:24:13AM +0800, Yuanhan Liu wrote: > On Mon, Feb 20, 2017 at 10:04:46PM +0800, hanxue...@126.com wrote: > > From: Huanle Han > > > > This commit fixs segment fault when rte_eth_dev_close() > > is called on a virtio dev more than once. > > Assigning zero after free to avo

Re: [dpdk-dev] [PATCH] net/virtio-user: fix recognize physical devices

2017-04-27 Thread Yuanhan Liu
On Fri, Apr 21, 2017 at 02:28:09AM +, Jianfeng Tan wrote: > Segfault happens when using virtio-user after commit 7f0a669e7b04 > ("ethdev: add allocation helper for virtual drivers"). > > It's due to we use ethdev->device to recognize physical devices, > but after above commit, this field is al

Re: [dpdk-dev] [PATCH v2 2/4] net/virtio: clean up LSC setting

2017-04-27 Thread Yuanhan Liu
On Thu, Apr 27, 2017 at 07:35:37AM +, Jianfeng Tan wrote: > LSC flag is set in several places, but only the last one takes effect; > so we remove the redundant ones and just keep the last one. Note that I modified this commit log a bit. It actually fixed a bug: the dev_flags is being overwritt

Re: [dpdk-dev] [PATCH v2 0/4] fixes and cleanup on virtio LSC

2017-04-27 Thread Yuanhan Liu
On Thu, Apr 27, 2017 at 07:35:35AM +, Jianfeng Tan wrote: > v2: > - Split 2nd patch into two patches. > > Patch 1: fix wrong MSI-X for modern devices so that LSC is always not > available. > Patch 2: clean up LSC setting. > Patch 3: remove redundant MSI-X detection > Patch 4: fix li

Re: [dpdk-dev] [PATCH v2] vhost: workaround MQ fails to startup

2017-04-27 Thread Yuanhan Liu
On Thu, Apr 27, 2017 at 12:00:52PM +0200, Maxime Coquelin wrote: > > > On 04/27/2017 11:41 AM, Zhiyong Yang wrote: > > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > >new connection when negotiating to set MQ. (one queue pair works > >well). > >Because there exist some b

Re: [dpdk-dev] [PATCH] config: set cache line as 128B in the generic arm64 config

2017-04-27 Thread santosh
Hi Jerin, On Wednesday 26 April 2017 09:59 PM, Jerin Jacob wrote: > armv8 implementations may have 64B or 128B cache line. > Setting to the maximum available cache line size in generic config to > address minimum DMA alignment across all arm64 implementations. > > Increasing the cacheline size ha

Re: [dpdk-dev] [PATCH] sched: enable neon optimizations

2017-04-27 Thread Jianbo Liu
On 27 April 2017 at 21:00, Ashwin Sekhar T K wrote: > * Enabled CONFIG_RTE_SCHED_VECTOR for arm64 > * Verified the changes with sched_autotest unit test case > > Signed-off-by: Ashwin Sekhar T K > --- > config/defconfig_arm64-armv8a-linuxapp-gcc | 2 +- > lib/librte_sched/rte_sched.c

[dpdk-dev] [PATCH v3] net/ixgbe: fix ntuple filter support for sctp

2017-04-27 Thread Wei Zhao
Add the support of RTE_FLOW_ITEM_TYPE_SCTP type packet for ixgbe ntuple filter. Fixes: 672be56d76a ("net/ixgbe: parse n-tuple filter") Signed-off-by: Wei Zhao Acked-by: Wenzhuo Lu --- Changes in v2: add type check of RTE_FLOW_ITEM_TYPE_SCTP for item flow. Changes in v3: change comments for

[dpdk-dev] [PATCH v3] net/ixgbe: fix ntuple filter support for sctp

2017-04-27 Thread Wei Zhao
Add the support of RTE_FLOW_ITEM_TYPE_SCTP type packet for ixgbe ntuple filter. Fixes: 672be56d76a ("net/ixgbe: parse n-tuple filter") Signed-off-by: Wei Zhao --- Changes in v2: add type check of RTE_FLOW_ITEM_TYPE_SCTP for item flow. Changes in v3: change comments for support of SCTP ---

Re: [dpdk-dev] [PATCH v2] hash: add neon support for thash

2017-04-27 Thread Jianbo Liu
On 27 April 2017 at 20:33, Ashwin Sekhar T K wrote: > Verified the changes with thash_autotest unit test case > > Signed-off-by: Ashwin Sekhar T K > --- > v2: > * Slightly modified the content of the commit message body > * Added prefix [dpdk-dev] to the email subject line > > lib/librte_hash/rt

[dpdk-dev] [PATCH] doc: correct the hugepage limitation of 32 bit

2017-04-27 Thread Qi Zhang
The hugepage memory limitation of 32 bit application is "1GB size" but not "1GB per page size". Signed-off-by: Qi Zhang --- doc/guides/faq/faq.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index 40c793c..308a287 1006

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Yuanhan Liu
On Thu, Apr 27, 2017 at 10:52:20AM +0200, Maxime Coquelin wrote: > > > On 04/27/2017 10:20 AM, Yuanhan Liu wrote: > >On Thu, Apr 27, 2017 at 09:56:47AM +0200, Maxime Coquelin wrote: > >>Hi Zhiyong, > >> > >>+Marc-André > >> > >>On 04/27/2017 08:34 AM, Zhiyong Yang wrote: > >>>vhost since dpdk17.0

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ntuple filter support for sctp

2017-04-27 Thread Zhao1, Wei
Hi,Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 27, 2017 5:44 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ntuple filter support for > sctp > > On 4/27/2017 6:39 AM, Wei Zhao wrote: > > Add the support of RTE_FLOW_ITEM

Re: [dpdk-dev] [PATCH] config: set cache line as 128B in the generic arm64 config

2017-04-27 Thread Jianbo Liu
On 27 April 2017 at 00:29, Jerin Jacob wrote: > armv8 implementations may have 64B or 128B cache line. > Setting to the maximum available cache line size in generic config to > address minimum DMA alignment across all arm64 implementations. > > Increasing the cacheline size has no negative impact

Re: [dpdk-dev] [PATCH v2] config: make AVX and AVX512 configurable

2017-04-27 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhihong Wang > Sent: Friday, April 28, 2017 7:00 AM > To: dev@dpdk.org > Cc: yuanhan@linux.intel.com; tho...@monjalon.net; Richardson, Bruce > ; Wang, Zhihong > Subject: [dpdk-dev] [PATCH v2] config: make AVX

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix exit without freeing resources

2017-04-27 Thread Tan, Jianfeng
> -Original Message- > From: Hu, Jiayu > Sent: Friday, April 28, 2017 9:33 AM > To: dev@dpdk.org > Cc: Wu, Jingjing; sta...@dpdk.org; Tan, Jianfeng; Hu, Jiayu > Subject: [PATCH v2] app/testpmd: fix exit without freeing resources > > When testpmd exists, it frees the acquired resources (e

[dpdk-dev] [PATCH] net/i40e: consider QinQ when setting MTU

2017-04-27 Thread Wenzhuo Lu
When counting max packet length from MTU, count VLAN tag length twice for QinQ packets. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 2 +- drivers/net/i40e/i40e_ethdev_vf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v2] app/testpmd: fix exit without freeing resources

2017-04-27 Thread Jiayu Hu
When testpmd exists, it frees the acquired resources (e.g. stop ports). However, when we terminate it by Ctrl-d, testpmd exists directly without releasing the resources. In this patch, we fix this exit issue. Fixes:af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Jiayu Hu

Re: [dpdk-dev] [PATCH] ixgbe: check scatter_enable in set_mtu

2017-04-27 Thread Lu, Wenzhuo
Hi Jia, > -Original Message- > From: Jia Yu [mailto:j...@vmware.com] > Sent: Friday, April 28, 2017 5:13 AM > To: Lu, Wenzhuo; Ananyev, Konstantin > Cc: dev@dpdk.org; Jia Yu > Subject: [PATCH] ixgbe: check scatter_enable in set_mtu > > There exists case that software sets mtu (i.e jumbo f

Re: [dpdk-dev] [PATCH v4] net/ixgbe: ensure link status is updated

2017-04-27 Thread Dai, Wei
> -Original Message- > From: Laurent Hardy [mailto:laurent.ha...@6wind.com] > Sent: Thursday, April 27, 2017 11:04 PM > To: dev@dpdk.org; Dai, Wei > Cc: Yigit, Ferruh ; Zhang, Helin > ; Ananyev, Konstantin > ; olivier.m...@6wind.com > Subject: [PATCH v4] net/ixgbe: ensure link status is up

Re: [dpdk-dev] [PATCH] igbvf: fix MAC address set problem

2017-04-27 Thread Lu, Wenzhuo
Hi Qiming, > -Original Message- > From: Yang, Qiming > Sent: Thursday, April 27, 2017 5:02 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; sta...@dpdk.org; Yang, Qiming > Subject: [PATCH] igbvf: fix MAC address set problem > > We find that VF receive address register is not set if MAC address is

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps

2017-04-27 Thread Wu, Jingjing
> 25/04/2017 16:02, Wu, Jingjing: > > From: Oleg Kuporosov > > > Implemented two methods of control > > > > > > - by --enable-timestamps CL testpmd application we can enable > timestamping > > > for all ports; > > > - in interactive mode port config timestamps on|off is able to > > > configure

[dpdk-dev] [PATCH] ixgbe: check scatter_enable in set_mtu

2017-04-27 Thread Jia Yu
There exists case that software sets mtu (i.e jumbo frame) of ixgbe device when it's stopped. Before the fix, scattered_rx is cleared during device stop, and setting jumbo frame mtu after device stop will always fail as scattered_rx is 0. --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 -- 1 file cha

[dpdk-dev] [PATCH v2] usertools: add status-dev argument to devbind

2017-04-27 Thread Ferruh Yigit
Script displays status for all device types and output is much longer than it used to be. This makes harder to read script output. This patch adds new --status-dev argument to the script to select a device group to display status. Supported device groups: net crypto event mempool Sample usage: .

Re: [dpdk-dev] [PATCH] crypto/qat: fix dequeue count stats retrieval

2017-04-27 Thread Trahe, Fiona
> -Original Message- > From: Eads, Gage > Sent: Thursday, April 27, 2017 4:31 PM > To: dev@dpdk.org > Cc: Griffin, John ; Trahe, Fiona > ; Jain, Deepak K ; > sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix dequeue count stats retrieval > > The QAT device's dequeued_count and dequeue_e

[dpdk-dev] [PATCH] crypto/qat: fix dequeue count stats retrieval

2017-04-27 Thread Gage Eads
The QAT device's dequeued_count and dequeue_err_count stats were incorrectly assigned the enqueued_count and enqueue_err_count values, respectively. Signed-off-by: Gage Eads Fixes: 1703e94a ("qat: add driver for QuickAssist devices") --- drivers/crypto/qat/qat_crypto.c | 4 ++-- 1 file changed,

[dpdk-dev] [PATCH v4] net/ixgbe: ensure link status is updated

2017-04-27 Thread Laurent Hardy
In case of fiber and link speed set to 1Gb at peer side (with autoneg or with defined speed), link status could be not properly updated at time cable is plugged-in. Indeed if cable was not plugged when device has been configured and started then link status will not be updated properly with new spe

[dpdk-dev] [PATCH v1 6/6] net/ixgbe: support xstats by ID

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak To achieve functionality of retrieving only specific statistics given by application there are two new functions added: ixgbe_dev_xstats_get_by_ids() which retrieve values of statistics specified by ids array and ixgbe_dev_xstats_get_names_by_ids() which retrieve names of statist

[dpdk-dev] [PATCH v1 5/6] net/e1000: support xstats by ID

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak To achieve functionality of retrieving only specific statistics given by application there are two new functions added: eth_igb_xstats_get_by_id() which retrieve values of statistics specified by ids array and eth_igb_xstats_get_names_by_id() which retrieve names of statistics sp

[dpdk-dev] [PATCH v1 4/6] app/proc-info: support xstats by ID and by name

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak There are new arguments --xstats-ids and --xstats-name in proc_info command line to retrieve statistics given by ids and by name. E.g. --xstats-ids="1,3,5,7,8" E.g. --xstats-name rx_errors Signed-off-by: Kuba Kozak --- app/proc_info/main.c | 150 +++

[dpdk-dev] [PATCH v1 3/6] ethdev: get xstats ID by name

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak Introduced new function: rte_eth_xstats_get_id_by_name to retrieve xstats ids by its names. doc: added release note Signed-off-by: Kuba Kozak --- doc/guides/rel_notes/release_17_05.rst | 2 ++ lib/librte_ether/rte_ethdev.c | 44 ++ li

[dpdk-dev] [PATCH v1 2/6] ethdev: retrieve xstats by ID

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak Extended xstats API in ethdev library to allow grouping of stats logically so they can be retrieved per logical grouping managed by the application. Added new functions rte_eth_xstats_get_names_by_id and rte_eth_xstats_get_by_id using additional arguments (in compare to rte_eth_

[dpdk-dev] [PATCH v1 1/6] ethdev: revert patches extending xstats API in ethdev

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak Revert patches to provide clear view for upcoming changes. Reverted patches are listed below: commit ea85e7d711b6 ("ethdev: retrieve xstats by ID") commit a954495245c4 ("ethdev: get xstats ID by name") commit 1223608adb9b ("app/proc-info: support xstats by ID") commit 25e38f09af9

[dpdk-dev] [PATCH v1 0/6] Extended xstats API in ethdev library to allow grouping of stats

2017-04-27 Thread Michal Jastrzebski
From: Kuba Kozak This patchset fixes following patches: commit ea85e7d711b6 ("ethdev: retrieve xstats by ID") commit a954495245c4 ("ethdev: get xstats ID by name") commit 1223608adb9b ("app/proc-info: support xstats by ID") commit 25e38f09af9c ("net/e1000: support xstats by ID")

Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix updating the slave link status

2017-04-27 Thread Declan Doherty
On 25/04/2017 7:30 AM, wang wei wrote: we need to update dev->data->dev_link before handling lsc event. Otherwise it will still have the initial value after the startup of the program before interrupt callback was executed. Signed-off-by: wang wei --- drivers/net/bonding/rte_eth_bond_pmd.c | 4

[dpdk-dev] [PATCH 2/2] test: add tests for arm64 CRC neon versions

2017-04-27 Thread Ashwin Sekhar T K
Verified the changes with crc_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- test/test/test_crc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/test/test/test_crc.c b/test/test/test_crc.c index cd5af69..ac0e359 100644 --- a/test/test/test_crc.c +++ b/test/test/test_c

[dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-27 Thread Ashwin Sekhar T K
* Added CRC compute APIs for arm64 utilizing the pmull capability * Added new file net_crc_neon.h to hold the arm64 pmull CRC implementation * Added crypto capability in compilation of generic armv8 and thunderx targets * pmull CRC version is used only after checking the pmull capability at r

[dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-27 Thread Ashwin Sekhar T K
* Added CRC compute APIs for arm64 utilizing the pmull capability * Added new file net_crc_neon.h to hold the arm64 pmull CRC implementation * Added crypto capability in compilation of generic armv8 and thunderx targets * pmull CRC version is used only after checking the pmull capability at r

[dpdk-dev] [PATCH] net/tap: fix support for large Rx queues

2017-04-27 Thread Pascal Mazon
Rx queues configured with more than 1023 descriptors cause readv() calls to fail due to more iovec entries than permitted by the kernel. As a result, no packets can be received. Quietly limit internal Rx queue size to the maximum number of iovec entries to fix this issue. Fixes: 0781f5762cfe ("ne

[dpdk-dev] [PATCH 2/2] table: add neon version for lru strategy 3

2017-04-27 Thread Ashwin Sekhar T K
* Added new file rte_lru_arm64.h for holding arm64 specific definitions * Verified the changes with table_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- MAINTAINERS | 1 + lib/librte_table/Makefile| 2 +- lib/librte_table/rte_lru.h | 2 + lib

[dpdk-dev] [PATCH 1/2] table: separate out arch specific defines from lru header

2017-04-27 Thread Ashwin Sekhar T K
* Moved all x86 related lru defines to rte_lru_x86.h while retaining all common defines in rte_lru.h * Verified the changes with table_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- lib/librte_table/Makefile | 1 + lib/librte_table/rte_lru.h | 106 ++---

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix wrong array index

2017-04-27 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, April 25, 2017 4:33 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix wrong array index > > Fixes: c0f87eb5

[dpdk-dev] Integration of DPDK with a seperate tool

2017-04-27 Thread reshma sarat
Hi , I am integrating DPDK with another tool to increase the performance of the tool. But I am getting the following error. How to overcome this error. EAL: Detected 8 lcore(s) EAL: cannot open /proc/self/numa_maps, consider that all memory is in socket_id 0 EAL: Error - exiting with code: 1 Ca

[dpdk-dev] [PATCH] sched: enable neon optimizations

2017-04-27 Thread Ashwin Sekhar T K
* Enabled CONFIG_RTE_SCHED_VECTOR for arm64 * Verified the changes with sched_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- config/defconfig_arm64-armv8a-linuxapp-gcc | 2 +- lib/librte_sched/rte_sched.c | 22 ++ 2 files changed, 23 insertions(+)

[dpdk-dev] [PATCH v2] efd: support lookup using neon intrinsics

2017-04-27 Thread Ashwin Sekhar T K
* Added file lib/librte_efd/rte_efd_arm64.h to hold arm64 specific definitions * Verified the changes with efd_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Slightly modified the content of the commit message body * Added prefix [dpdk-dev] to the email subject line MAINTA

[dpdk-dev] [PATCH v1 2/2] examples/l2fwd-keepalive: add SHM cleanup on exit

2017-04-27 Thread Remy Horton
This patch adds the unlinking/unmapping of shared host memory on termination of l2fwd-keepalive. Previously it was only cleaned on re-running of the example application. Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application") Signed-off-by: Remy Horton --- examples/l2fwd-keepal

[dpdk-dev] [PATCH v1 1/2] examples/l2fwd-keepalive: add graceful exit

2017-04-27 Thread Remy Horton
The l2fwd-keepalive example has infinite processing loops and as a result the only way to exit it is via SIGINT/SIGTERM (e.g. Control-C). The resulting shutdown is unclean, which is fixed by adding a signal handler that causes the processing loops to break. Fixes: e64833f2273a ("examples/l2fwd-kee

[dpdk-dev] [PATCH v1 0/2] l2fwd-keepalive: Termination cleanup

2017-04-27 Thread Remy Horton
The l2fwd-keepalive example has infinite processing loops and as a result the only way to exit it is via SIGINT/SIGTERM (e.g. Control-C). The resulting shutdown is unclean, in particular leaving stale shared host memory handles. This is fixed by adding a signal handler that causes the processing lo

[dpdk-dev] [PATCH v2] hash: add neon support for thash

2017-04-27 Thread Ashwin Sekhar T K
Verified the changes with thash_autotest unit test case Signed-off-by: Ashwin Sekhar T K --- v2: * Slightly modified the content of the commit message body * Added prefix [dpdk-dev] to the email subject line lib/librte_hash/rte_thash.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

Re: [dpdk-dev] OpenSSL Cryptodev PMD and openssl engine

2017-04-27 Thread Trahe, Fiona
Hi Srivathsan, From: Aravamudan Srivathsan [mailto:srivathsan.aravamu...@technicolor.com] Sent: Thursday, April 27, 2017 2:20 AM To: Trahe, Fiona ; dev@dpdk.org Cc: Doherty, Declan Subject: Re: OpenSSL Cryptodev PMD and openssl engine Hi Fiona, Thank you for the reply. I have a crypto dev

[dpdk-dev] [PATCH] efd: support lookup using neon intrinsics

2017-04-27 Thread Ashwin Sekhar T K
* Added file lib/librte_efd/rte_efd_arm64.h to hold arm64 specific definitions * Tested using efd_autotest Signed-off-by: Ashwin Sekhar T K --- MAINTAINERS| 1 + lib/librte_efd/rte_efd.c | 22 lib/librte_efd/rte_efd_arm64.h | 76 +

[dpdk-dev] [PATCH] net/i40e: add check for ethertype filter

2017-04-27 Thread Beilei Xing
LLDP rule is not supported in ethertype filter. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_flow.c | 1 + lib/librte_net/rte_ether.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 0a0181f..24e1c65 100644 --- a/dr

Re: [dpdk-dev] [PATCH] ethdev: add lock-less txq capability flag

2017-04-27 Thread Jerin Jacob
-Original Message- > Date: Mon, 24 Apr 2017 14:34:59 +0200 > From: Thomas Monjalon > To: Jerin Jacob > Cc: dev@dpdk.org, bruce.richard...@intel.com, harry.van.haa...@intel.com, > hemant.agra...@nxp.com, gage.e...@intel.com, nipun.gu...@nxp.com, > santosh.shu...@caviumnetworks.com > Subj

Re: [dpdk-dev] [PATCH] doc: fix enic NIC guide syntax and copyright

2017-04-27 Thread Ferruh Yigit
On 4/27/2017 11:13 AM, Mcnamara, John wrote: > > >> -Original Message- >> From: John Daley [mailto:johnd...@cisco.com] >> Sent: Thursday, April 27, 2017 1:53 AM >> To: Yigit, Ferruh ; Mcnamara, John >> >> Cc: dev@dpdk.org; John Daley >> Subject: [PATCH] doc: fix enic NIC guide syntax an

Re: [dpdk-dev] [PATCH v2] doc: enic SR-IOV configurations

2017-04-27 Thread Ferruh Yigit
On 4/27/2017 11:12 AM, Mcnamara, John wrote: > > >> -Original Message- >> From: John Daley [mailto:johnd...@cisco.com] >> Sent: Thursday, April 27, 2017 1:52 AM >> To: Yigit, Ferruh ; Mcnamara, John >> >> Cc: dev@dpdk.org; John Daley >> Subject: [PATCH v2] doc: enic SR-IOV configuration

Re: [dpdk-dev] [PATCH v2] doc: enic SR-IOV configurations

2017-04-27 Thread Mcnamara, John
> -Original Message- > From: John Daley [mailto:johnd...@cisco.com] > Sent: Thursday, April 27, 2017 1:52 AM > To: Yigit, Ferruh ; Mcnamara, John > > Cc: dev@dpdk.org; John Daley > Subject: [PATCH v2] doc: enic SR-IOV configurations > > Document SR-IOV passthrough setup and limitations

Re: [dpdk-dev] [PATCH] doc: fix enic NIC guide syntax and copyright

2017-04-27 Thread Mcnamara, John
> -Original Message- > From: John Daley [mailto:johnd...@cisco.com] > Sent: Thursday, April 27, 2017 1:53 AM > To: Yigit, Ferruh ; Mcnamara, John > > Cc: dev@dpdk.org; John Daley > Subject: [PATCH] doc: fix enic NIC guide syntax and copyright > > Fixes: 211f9a9ce2f0 ("enic: add guide")

Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable

2017-04-27 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 27, 2017 5:20 PM > To: Wang, Zhihong > Cc: Richardson, Bruce ; dev@dpdk.org; > yuanhan@linux.intel.com > Subject: Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable > > 27/

[dpdk-dev] [PATCH v2] config: make AVX and AVX512 configurable

2017-04-27 Thread Zhihong Wang
Making AVX and AVX512 configurable is useful for performance and power testing. The similar kernel patch at https://patchwork.kernel.org/patch/9618883/. AVX512 support like in rte_memcpy has been in DPDK since 16.04, but it's still unproven in rich use cases in hardware. Therefore it's marked as

Re: [dpdk-dev] [PATCH v2] vhost: workaround MQ fails to startup

2017-04-27 Thread Maxime Coquelin
On 04/27/2017 11:41 AM, Zhiyong Yang wrote: vhost since dpdk17.02 + qemu2.7 and above will cause failures of new connection when negotiating to set MQ. (one queue pair works well). Because there exist some bugs in qemu code when introducing VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when d

[dpdk-dev] [PATCH v2] vhost: workaround MQ fails to startup

2017-04-27 Thread Zhiyong Yang
vhost since dpdk17.02 + qemu2.7 and above will cause failures of new connection when negotiating to set MQ. (one queue pair works well). Because there exist some bugs in qemu code when introducing VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the vhost message VHOST_USER_SET_MEM_T

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ntuple filter support for sctp

2017-04-27 Thread Ferruh Yigit
On 4/27/2017 6:39 AM, Wei Zhao wrote: > Add the support of RTE_FLOW_ITEM_TYPE_SCTP type packet for > ixgbe ntuple filter. > > v2: > --add type check of RTE_FLOW_ITEM_TYPE_SCTP for item flow. For version information in the commit log, can you put it as: Below signed-off tag, in new line put three

Re: [dpdk-dev] [dpdk-maintainers] Example(Load_balancer) Tx Flush Bug(This bug DPDK each version)

2017-04-27 Thread Andriy Berestovskyy
Hey, Those patches superseded by: http://dpdk.org/ml/archives/dev/2017-April/064858.html Regards, Andriy On Mon, Jan 16, 2017 at 3:18 PM, Thomas Monjalon wrote: > Hi, > > Sorry if you feel your patch is ignored. > It is not in the right format for several reasons we tried > to explain earlier I

[dpdk-dev] [PATCH] examples/load_balancer: fix Tx flush

2017-04-27 Thread Andriy Berestovskyy
Port ID is not an index from 0 to n_nic_ports, but rather a value of nic_ports array. Signed-off-by: Andriy Berestovskyy --- examples/load_balancer/runtime.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/load_balancer/runtime.c b/examples/load_balancer/runtime.c

Re: [dpdk-dev] [PATCH 0/3 v2] disable vector PMD for i686

2017-04-27 Thread Bruce Richardson
On Thu, Apr 27, 2017 at 03:01:04AM -0400, Qi Zhang wrote: > Vector PMD is not designed for i686 orginally, but it still can be active > with i686 compile option. > Below are observed failure when vPMD is invovled on i686 > (but may not limited to) > > 1) memory overwrite when assign 2 mbuf points

Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable

2017-04-27 Thread Thomas Monjalon
27/04/2017 11:18, Wang, Zhihong: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 27/04/2017 18:34, Zhihong Wang: > > > Making AVX and AVX512 configurable is useful for performance and power > > > testing. > > > > > > The similar kernel patch at https://patchwork.kernel.org/patch/9618883/.

Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable

2017-04-27 Thread Wang, Zhihong
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 27, 2017 5:08 PM > To: Wang, Zhihong ; Richardson, Bruce > > Cc: dev@dpdk.org; yuanhan@linux.intel.com > Subject: Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable > > 27/

Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check

2017-04-27 Thread Ferruh Yigit
On 4/27/2017 8:15 AM, Lu, Wenzhuo wrote: > Hi, > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao >> Sent: Thursday, April 27, 2017 2:34 PM >> To: dev@dpdk.org >> Cc: Zhao1, Wei >> Subject: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item

[dpdk-dev] [PATCH] igbvf: fix MAC address set problem

2017-04-27 Thread Qiming Yang
We find that VF receive address register is not set if MAC address is assigned by PF. This patch fixes it. Signed-off-by: Qiming Yang Fixes: 2a3cf07108b4 ("igbvf: fix MAC address if none assigned by PF") --- drivers/net/e1000/igb_ethdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 de

Re: [dpdk-dev] [PATCH] config: make AVX and AVX512 configurable

2017-04-27 Thread Thomas Monjalon
27/04/2017 18:34, Zhihong Wang: > Making AVX and AVX512 configurable is useful for performance and power > testing. > > The similar kernel patch at https://patchwork.kernel.org/patch/9618883/. [...] > +# > +# Recognize/ignore the AVX/AVX512 CPU flags for performance/power testing > +# > +CONFIG_RT

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Maxime Coquelin
On 04/27/2017 10:20 AM, Yuanhan Liu wrote: On Thu, Apr 27, 2017 at 09:56:47AM +0200, Maxime Coquelin wrote: Hi Zhiyong, +Marc-André On 04/27/2017 08:34 AM, Zhiyong Yang wrote: vhost since dpdk17.02 + qemu2.7 and above will cause failures of new connection when negotiating to set MQ. (one qu

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Maxime Coquelin
On 04/27/2017 10:24 AM, Yang, Zhiyong wrote: Hi, Maxime: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, April 27, 2017 4:05 PM To: Yang, Zhiyong ; dev@dpdk.org Cc: yuanhan@linux.intel.com; Loftus, Ciara ; Marc- André Lureau Subject: R

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Yang, Zhiyong
Hi, yuanhan: > -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Thursday, April 27, 2017 4:12 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Loftus, Ciara > > Subject: Re: [PATCH] vhost: fix MQ fails to startup > > On Thu, Apr 2

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Yuanhan Liu
On Thu, Apr 27, 2017 at 09:56:47AM +0200, Maxime Coquelin wrote: > Hi Zhiyong, > > +Marc-André > > On 04/27/2017 08:34 AM, Zhiyong Yang wrote: > >vhost since dpdk17.02 + qemu2.7 and above will cause failures of > >new connection when negotiating to set MQ. (one queue pair works > >well).Because t

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Yang, Zhiyong
Hi, Maxime: > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, April 27, 2017 4:05 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: yuanhan@linux.intel.com; Loftus, Ciara ; Marc- > André Lureau > Subject: Re: [PATCH] vhost: fix MQ fails to st

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Yuanhan Liu
On Thu, Apr 27, 2017 at 02:34:53PM +0800, Zhiyong Yang wrote: > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > new connection when negotiating to set MQ. (one queue pair works > well).Because there exist some bugs in qemu code when introducing > VHOST_USER_PROTOCOL_F_REPLY_ACK t

Re: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup

2017-04-27 Thread Iremonger, Bernard
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Thursday, April 27, 2017 6:28 AM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for > QinQ setup > > > > > >

[dpdk-dev] [PATCH] hash: add neon support for thash

2017-04-27 Thread Ashwin Sekhar T K
Tested using thash_autotest Signed-off-by: Ashwin Sekhar T K --- lib/librte_hash/rte_thash.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h index a4886a8..60d58c6 100644 --- a/lib/librte_hash/rte_thash.h +++ b/l

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Maxime Coquelin
On 04/27/2017 09:56 AM, Maxime Coquelin wrote: Hi Zhiyong, +Marc-André On 04/27/2017 08:34 AM, Zhiyong Yang wrote: vhost since dpdk17.02 + qemu2.7 and above will cause failures of new connection when negotiating to set MQ. (one queue pair works well).Because there exist some bugs in qemu cod

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Maxime Coquelin
Hi Zhiyong, +Marc-André On 04/27/2017 08:34 AM, Zhiyong Yang wrote: vhost since dpdk17.02 + qemu2.7 and above will cause failures of new connection when negotiating to set MQ. (one queue pair works well).Because there exist some bugs in qemu code when introducing VHOST_USER_PROTOCOL_F_REPLY_ACK

Re: [dpdk-dev] [PATCH v2 2/4] net/virtio: clean up LSC setting

2017-04-27 Thread Yuanhan Liu
On Thu, Apr 27, 2017 at 07:35:37AM +, Jianfeng Tan wrote: > LSC flag is set in several places, but only the last one takes effect; > so we remove the redundant ones and just keep the last one. I think this patch would also fix the issue reported by: http://dpdk.org/dev/patchwork/patch/2055

Re: [dpdk-dev] [PATCH] vhost: fix MQ fails to startup

2017-04-27 Thread Loftus, Ciara
> > vhost since dpdk17.02 + qemu2.7 and above will cause failures of > new connection when negotiating to set MQ. (one queue pair works > well).Because there exist some bugs in qemu code when introducing > VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the > vhost > message VHOST_USER_

[dpdk-dev] [PATCH v2 2/4] net/virtio: clean up LSC setting

2017-04-27 Thread Jianfeng Tan
LSC flag is set in several places, but only the last one takes effect; so we remove the redundant ones and just keep the last one. Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_ethdev.c | 7 ++- drivers/net/virtio/virtio_pci.c| 21 ++--- drivers/net/virtio/vi

[dpdk-dev] [PATCH v2 4/4] net/virtio: fix link status always being down

2017-04-27 Thread Jianfeng Tan
The virtio port link status will always be DOWN: The commit aa9f06061765 ("net/virtio: fix link status always being up") introduces a flag to help checking the status. If this flag is not set, status will be always down. However, in dev start, this flag is set after link status update, then we mis

[dpdk-dev] [PATCH v2 3/4] net/virtio: remove redundant MSI-X detection

2017-04-27 Thread Jianfeng Tan
As we already change to use capability list to detect MSI-X, remove the redundant MSI-X detection in legacy devices. Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_pci.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.c b/d

[dpdk-dev] [PATCH v2 0/4] fixes and cleanup on virtio LSC

2017-04-27 Thread Jianfeng Tan
v2: - Split 2nd patch into two patches. Patch 1: fix wrong MSI-X for modern devices so that LSC is always not available. Patch 2: clean up LSC setting. Patch 3: remove redundant MSI-X detection Patch 4: fix link status always being down. Signed-off-by: Jianfeng Tan Jianfeng Tan (4):

  1   2   >