On 28 April 2017 at 13:27, Sekhar, Ashwin <ashwin.sek...@cavium.com> wrote: > On Friday 28 April 2017 09:20 AM, Jianbo Liu wrote: >> On 27 April 2017 at 21:00, Ashwin Sekhar T K >> <ashwin.sek...@caviumnetworks.com> wrote: >>> * Enabled CONFIG_RTE_SCHED_VECTOR for arm64 >>> * Verified the changes with sched_autotest unit test case >>> >>> Signed-off-by: Ashwin Sekhar T K <ashwin.sek...@caviumnetworks.com> >>> --- >>> config/defconfig_arm64-armv8a-linuxapp-gcc | 2 +- >>> lib/librte_sched/rte_sched.c | 22 ++++++++++++++++++++++ >>> 2 files changed, 23 insertions(+), 1 deletion(-) >>> >>> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc >>> b/config/defconfig_arm64-armv8a-linuxapp-gcc >>> index 65888ce..021044a 100644 >>> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc >>> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc >>> @@ -48,4 +48,4 @@ CONFIG_RTE_LIBRTE_FM10K_PMD=n >>> CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n >>> CONFIG_RTE_LIBRTE_AVP_PMD=n >>> >>> -CONFIG_RTE_SCHED_VECTOR=n >>> +CONFIG_RTE_SCHED_VECTOR=y >> >> It's enough to remove this line only, I don't think you must enable it >> explicitly in the armv8a common config. >> > Tried removing this line from armv8a config. But in that case > RTE_SCHED_VECTOR doesn't get defined. > ./config/common_base has "CONFIG_RTE_SCHED_VECTOR=n" as the default > setting. So enabling explicitly is required. >
I know it must be enabled to use your enhancement. But I meant to keep the same as common_base (or other default configs) if there is no other strange reason to enable it. Thanks! Jianbo