Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, April 27, 2017 6:28 AM > To: Iremonger, Bernard <bernard.iremon...@intel.com>; dev@dpdk.org > Cc: Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi <qi.zh...@intel.com>; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for > QinQ setup > > > > > > The command vlan set qinq on <port_id> is an common command, but > not > > > only For i40e. I think it's better to doc it somewhere instead of > > > changing the default Behavior of this command. > > > > There is a doc patch in flight: > > http://dpdk.org/dev/patchwork/patch/23704/ > > > > Is this enough or should I send a v3 of this patch for the i40e PMD only? > > > Yes. I think doc it is enough. > We don't need this patch. > > Thanks > Jingjing
I will NAK this patch. Self NAK Regards, Bernard.