[dpdk-dev] [PATCH v6 3/3] app/testpmd: add port reset command into testpmd

2017-04-05 Thread Wei Zhao
Add port reset command into testpmd project, it is the interface for user to reset port. And also it is not limit to be used only in vf reset, but also for pf port reset.But this patch set only realted to vf reset feature. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdli

[dpdk-dev] [PATCH v6 2/3] net/i40e: implement device reset on port

2017-04-05 Thread Wei Zhao
This patch implement the device reset function on vf port. This restart function will detach device then attach device, reconfigure dev, re-setup the Rx/Tx queues. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 2 +- drivers/net/i40e/i40e_ethdev.h

[dpdk-dev] [PATCH v6 1/3] lib/librte_ether: add support for port reset

2017-04-05 Thread Wei Zhao
Add support for port reset in rte layer.This reset feature can not only used in vf port reset in later code develop, but alsopf port.But in this patch set, we only limit the discussion scope to vf reset. This patch Add an API to restart the device. It's for VF device in this scenario, kernel PF + D

[dpdk-dev] [PATCH v6 0/3] net/i40e: vf port reset

2017-04-05 Thread Wei Zhao
The patches mainly finish following functions: 1) get pf reset vf comamand falg from interrupt server function. 2) reset vf port from testpmd app using a command. 3) sore and restore vf related parameters. v2: -change the order of patch in the set. -add more details in patch comment to clarify tha

[dpdk-dev] [PATCH v2 2/2] test/mempool_perf: support default mempool autotest

2017-04-05 Thread Santosh Shukla
Mempool_perf autotest currently does perf regression for: * nochache * cache Introducing default_pool, mainly targeted for ext-mempool regression test. Ext-mempool don't need 'cache' modes so only adding test-case support for 'nocache' mode. So to run ext-mempool perf regression, user has to se

[dpdk-dev] [PATCH v2 1/2] test/mempool_perf: Free mempool on exit

2017-04-05 Thread Santosh Shukla
Mempool_perf test not freeing pool memory. Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla Acked-by: Shreyansh Jain --- v1 --> v2: * Fixed patch context test/test/test_mempool_perf.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/test/t

[dpdk-dev] [PATCH v5 3/3] app/testpmd: add port reset command into testpmd

2017-04-05 Thread Wei Zhao
Add port reset command into testpmd project, it is the interface for user to reset port. And also it is not limit to be used only in vf reset, but also for pf port reset.But this patch set only realted to vf reset feature. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdli

[dpdk-dev] [PATCH v5 1/3] lib/librte_ether: add support for port reset

2017-04-05 Thread Wei Zhao
Add support for port reset in rte layer.This reset feature can not only used in vf port reset in later code develop, but alsopf port.But in this patch set, we only limit the discussion scope to vf reset. This patch Add an API to restart the device. It's for VF device in this scenario, kernel PF + D

[dpdk-dev] [PATCH v5 2/3] net/i40e: implement device reset on port

2017-04-05 Thread Wei Zhao
This patch implement the device reset function on vf port. This restart function will detach device then attach device, reconfigure dev, re-setup the Rx/Tx queues. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 2 +- drivers/net/i40e/i40e_ethdev.h

[dpdk-dev] [PATCH v5 0/3] net/i40e: vf port reset

2017-04-05 Thread Wei Zhao
The patches mainly finish following functions: 1) get pf reset vf comamand falg from interrupt server function. 2) reset vf port from testpmd app using a command. 3) sore and restore vf related parameters. v2: -change the order of patch in the set. -add more details in patch comment to clarify tha

[dpdk-dev] [PATCH v2] devtools: make commits with stable tag outstanding

2017-04-05 Thread Yuanhan Liu
So that, as a stable maintainer while picking commits to a stable release, I could pay less attention to those have it and pay more attention to those don't have it. Signed-off-by: Yuanhan Liu --- v2: - introduce a function stable_tag for that - fix regexp --- devtools/git-log-fixes.sh | 13

Re: [dpdk-dev] [PATCH v3] net/i40e: fix return value check issue

2017-04-05 Thread Zhang, Helin
> -Original Message- > From: caihe [mailto:ca...@huawei.com] > Sent: Thursday, April 6, 2017 9:06 AM > To: Zhang, Helin > Cc: dev@dpdk.org; Wu, Jingjing; Zhoujingbin > Subject: 答复: [PATCH v3] net/i40e: fix return value check issue > > Do you have any idea to fix the patch check warning,

Re: [dpdk-dev] [PATCH] devtools: make commits with stable tag outstanding

2017-04-05 Thread Yuanhan Liu
On Fri, Mar 10, 2017 at 12:13:28PM +0100, Thomas Monjalon wrote: > 2017-02-23 10:49, Yuanhan Liu: > > So that, as a stable maintainer while picking commits to a stable release, > > I could pay less attention to those have it and pay more attention to those > > don't have it. > > Good idea > > >

[dpdk-dev] [PATCH 3/3] net/i40e: add missing 25G link speed

2017-04-05 Thread Qi Zhang
Add missing 25G link speed decode in i40evf_dev_link_update. Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index d3659c9..caafa2d 100

[dpdk-dev] [PATCH 2/3] net/i40e: fix wrong VF link speed

2017-04-05 Thread Qi Zhang
When PF notify link speed to VF, encode of link speed need to be converted from ETH_SPEED_XXX to I40E_LINK_SPEED_XXX. Fixes: bb6722fb5c0e ("net/i40e: fix VF bonded device link down") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_pf.c | 29 +++-- 1

[dpdk-dev] [PATCH 1/3] net/i40e: remove duplicate code

2017-04-05 Thread Qi Zhang
Make i40e_notify_all_vfs_link_status as a wrapper of i40e_notify_vf_link_status so duplicate code can be removed. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/

[dpdk-dev] [PATCH 0/3] net/i40e: fix wrong VF link speed

2017-04-05 Thread Qi Zhang
VF link speed is not correct due to encode mismatch between VF and PF, the patch set fix this issue. Qi Zhang (3): net/i40e: remove duplicate code net/i40e: fix wrong VF link speed net/i40e: add missing 25G link speed drivers/net/i40e/i40e_ethdev.c| 10 +- drivers/net/i40e/i40

Re: [dpdk-dev] [PATCH 0/2] reduce writes in i40e driver

2017-04-05 Thread Jianbo Liu
On 3 April 2017 at 22:39, Bruce Richardson wrote: > this set is based upon Olivier's mbuf rework patchset, and makes some > improvement to the i40e driver taking account of the rework. It also > removes a build-time option that seems unnecessary. > > Bruce Richardson (2): > net/i40e: eliminate m

Re: [dpdk-dev] [PATCH] net/vhost: move device stop call in close function

2017-04-05 Thread Yuanhan Liu
On Fri, Mar 31, 2017 at 03:47:10PM -0700, Sagar Abhang wrote: > Moved the call to "eth_dev_stop" inside "eth_dev_close" because > "rte_eth_dev_close" calls 'close' operation of device, and in existing > code the close was happening without 'stop' operation for vhost device. > Moved code to free rx

Re: [dpdk-dev] [PATCH 0/2] reduce writes in i40e driver

2017-04-05 Thread Jianbo Liu
On 3 April 2017 at 22:39, Bruce Richardson wrote: > this set is based upon Olivier's mbuf rework patchset, and makes some > improvement to the i40e driver taking account of the rework. It also > removes a build-time option that seems unnecessary. > > Bruce Richardson (2): > net/i40e: eliminate m

Re: [dpdk-dev] [PATCH 0/2] ppc:Fix the memory initialization for IBM POWER

2017-04-05 Thread gowrishankar muthukrishnan
Could this patch be reviewed and added ? This is required in ppc64le for multiprocess support. Regards, Gowrishankar On Thursday 02 March 2017 11:46 AM, Chao Zhu wrote: Due to mmap implementation on IBM POWER, the secondary process memory initialization may fail (mmap will not respect the requ

Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb segments

2017-04-05 Thread Yuanhan Liu
Hi Olivier, On Tue, Apr 04, 2017 at 06:28:05PM +0200, Olivier Matz wrote: > Change the size of m->port and m->nb_segs to 16 bits. But all the ethdev APIs are still using 8 bits. 16 bits won't really take effect without updating those APIs. Any plans? --yliu

Re: [dpdk-dev] [PATCH v2] net/i40e: fix QinQ eth pattern parsing

2017-04-05 Thread Xing, Beilei
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, April 5, 2017 10:04 PM > To: dev@dpdk.org; Xing, Beilei > Cc: Lu, Wenzhuo ; Iremonger, Bernard > > Subject: [PATCH v2] net/i40e: fix QinQ eth pattern parsing > > The eth keyword only should be accepted. > > Fixes: d46e8

[dpdk-dev] [PATCH v7 2/2] eal: clean up interrupt handle

2017-04-05 Thread Qi Zhang
The patch change the prototype of callback function (rte_intr_callback_fn) by removing the unnecessary parameter. Signed-off-by: Qi Zhang --- v7: - Update for avp and tap driver which are new added. - Merge test code changes. v5: - Update mlx4 driver which is missed in previous version. v4:

[dpdk-dev] [PATCH v7 0/2] clean up interrupt handle

2017-04-05 Thread Qi Zhang
It seems its not necessary to register an intr_handle for interrupt callback function. "void* cb_arg" shows enough when be used to pass the object that contain the information be required to handle the interrupt event( A typical way which is implemented by almost all driver is by passing a rte_ethd

[dpdk-dev] [PATCH v7 1/2] vfio: keep interrupt source read only

2017-04-05 Thread Qi Zhang
Remove the inappropriate modification on get_max_intr field that keep the intr_source read only. Signed-off-by: Qi Zhang --- v4: - Add back this patch to make patch set complete though it already be applied. v2: - Seperate patch 1 of v1 into 2 patches.(part 1) lib/librte_eal/linuxapp/eal/ea

Re: [dpdk-dev] [PATCH 0/2] net/virtio: support to turn on/off the traffic flow

2017-04-05 Thread Yuanhan Liu
On Fri, Mar 31, 2017 at 07:40:17PM +0800, Zhiyong Yang wrote: > Current dpdk code virtio_dev_stop only disables interrupt and marks link down, > When it is invoked, tx/rx traffic flows still work. This is a strange > behavior. > The patchset supports the switch of flow by calling virtio_dev_start/

Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset

2017-04-05 Thread Zhao1, Wei
Hi, Thomas > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, March 31, 2017 3:55 AM > To: Zhao1, Wei ; Mcnamara, John > > Cc: dev@dpdk.org; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port > reset >

[dpdk-dev] net/i40e: fix hash input set issue on X722

2017-04-05 Thread Jeff Guo
Since there are some new pctypes on X722, but recently they have not been announced on the RTE lib, so if it can not correspondently set hash input set for these packet type, the hash function won’t work. So we need to handle them base on the translation of the new PCTYPE and the original PCTYPE.

[dpdk-dev] 答复: [PATCH v3] net/i40e: fix return value check issue

2017-04-05 Thread caihe
Do you have any idea to fix the patch check warning, this is already the perfect way? -邮件原件- 发件人: Zhang, Helin [mailto:helin.zh...@intel.com] 发送时间: 2017年4月5日 23:34 收件人: caihe 抄送: dev@dpdk.org; Wu, Jingjing; Zhoujingbin 主题: RE: [PATCH v3] net/i40e: fix return value check issue > -O

Re: [dpdk-dev] [PATCH v11 0/2] librte_net: add crc computation support

2017-04-05 Thread Thomas Monjalon
2017-04-05 21:49, Jasvinder Singh: > In some applications, CRC (Cyclic Redundancy Check) needs to be computed > or updated during packet processing operations. This patchset adds > software implementation of some common standard CRCs (32-bit Ethernet > CRC as per Ethernet/[ISO/IEC 8802-3] and 16-bi

Re: [dpdk-dev] [PATCH v11 2/2] test/test: add unit test for CRC computation

2017-04-05 Thread Thomas Monjalon
2017-04-05 21:49, Jasvinder Singh: > This patch provides a set of tests for verifying the functional > correctness of 16-bit and 32-bit CRC APIs. > > Signed-off-by: Jasvinder Singh > Acked-by: Pablo de Lara Now first patch is fine but this one has an issue: test_crc.c:88:2: fatal error: implic

Re: [dpdk-dev] [PATCH v2 0/3] clarify eth_dev state management

2017-04-05 Thread Thomas Monjalon
2017-03-31 14:04, Gaetan Rivet: > 1. The hotplug API currently available in DPDK introduces the notion of >device states (DEV_DETACHED, DEV_ATTACHED). These states are implicit >and internal to the ethdev layer. > > 2. Device enumeration and access is done directly, without regard to the >

Re: [dpdk-dev] [PATCH v2 2/3] ethdev: add device iterator

2017-04-05 Thread Thomas Monjalon
2017-03-31 14:04, Gaetan Rivet: > /** > + * Iterates over valid ethdev ports. > + * > + * @param: port_id warning: expected whitespace after : command Will fix it when applying > + * The id of the next possible valid port. > + * @return > + * Next valid port id, RTE_MAX_ETHPORTS if there is

[dpdk-dev] [PATCH v11 2/2] test/test: add unit test for CRC computation

2017-04-05 Thread Jasvinder Singh
This patch provides a set of tests for verifying the functional correctness of 16-bit and 32-bit CRC APIs. Signed-off-by: Jasvinder Singh Acked-by: Pablo de Lara --- MAINTAINERS | 1 + test/test/Makefile | 2 + test/test/test_crc.c | 183 ++

[dpdk-dev] [PATCH v11 1/2] librte_net: add crc compute APIs

2017-04-05 Thread Jasvinder Singh
APIs for selecting the architecure specific implementation and computing the crc (16-bit and 32-bit CRCs) are added. For CRCs calculation, scalar as well as x86 intrinsic(sse4.2) versions are implemented. The scalar version is based on generic Look-Up Table(LUT) algorithm, while x86 intrinsic vers

[dpdk-dev] [PATCH v11 0/2] librte_net: add crc computation support

2017-04-05 Thread Jasvinder Singh
In some applications, CRC (Cyclic Redundancy Check) needs to be computed or updated during packet processing operations. This patchset adds software implementation of some common standard CRCs (32-bit Ethernet CRC as per Ethernet/[ISO/IEC 8802-3] and 16-bit CCITT-CRC [ITU-T X.25]). Two versions of

[dpdk-dev] mlx5 vxlan match filter vni endianness

2017-04-05 Thread Legacy, Allain
Hi, None of the comments in the rte_flow.h file (or the programmers guide) specify what endianness should be applied to spec/mask fields. Based on the testing I have done so far using a CX4 device (mlx5 driver) fields like VLAN ID and UDP ports are expected in network byte order. There seems t

Re: [dpdk-dev] [PATCH v10 1/2] librte_net: add crc compute APIs

2017-04-05 Thread Singh, Jasvinder
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, April 5, 2017 6:50 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; olivier.m...@6wind.com; Doherty, Declan > ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH v10 1/2] lib

Re: [dpdk-dev] [PATCH] crypto/scheduler: add mode set get API

2017-04-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, April 05, 2017 7:26 PM > To: Zhang, Roy Fan; dev@dpdk.org > Cc: Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: add mode set get API > > > > >

Re: [dpdk-dev] [PATCH] crypto/scheduler: add mode set get API

2017-04-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, April 05, 2017 5:03 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Doherty, Declan > Subject: [PATCH] crypto/scheduler: add mode set get API > > This patch adds two APIs, "rte_cryptodev_scheduler_mode_set" and > "rte_cryp

Re: [dpdk-dev] [PATCH v10 1/2] librte_net: add crc compute APIs

2017-04-05 Thread Thomas Monjalon
2017-04-05 15:58, Jasvinder Singh: > APIs for selecting the architecure specific implementation and computing > the crc (16-bit and 32-bit CRCs) are added. For CRCs calculation, scalar > as well as x86 intrinsic(sse4.2) versions are implemented. > > The scalar version is based on generic Look-Up T

Re: [dpdk-dev] [PATCH v6 0/3] clean up interrupt handle

2017-04-05 Thread Thomas Monjalon
2017-04-05 07:09, Qi Zhang: > It seems its not necessary to register an intr_handle for interrupt callback > function. "void* cb_arg" shows enough when be used to pass the object that > contain the information be required to handle the interrupt event( A typical > way which is implemented by almost

Re: [dpdk-dev] [PATCH 2/2] event/sw: fix build with icc

2017-04-05 Thread Thomas Monjalon
2017-04-05 16:32, Ferruh Yigit: > build error: > .../drivers/event/sw/sw_evdev_scheduler.c(379): > error #300: const variable "dummy_rob" requires an initializer > static const struct reorder_buffer_entry dummy_rob; > ^ > > Variable

Re: [dpdk-dev] [PATCH] ring: fix build with icc

2017-04-05 Thread Thomas Monjalon
2017-04-05 17:13, Bruce Richardson: > On Wed, Apr 05, 2017 at 04:03:12PM +0100, Ferruh Yigit wrote: > > build error: > > In file included from .../lib/librte_ring/rte_ring.c(90): > > .../lib/librte_ring/rte_ring.h(162): > > error #1366: a reduction in alignment without the "packed" attribute > > is

Re: [dpdk-dev] [PATCH] ring: fix build with icc

2017-04-05 Thread Bruce Richardson
On Wed, Apr 05, 2017 at 04:03:12PM +0100, Ferruh Yigit wrote: > build error: > In file included from .../lib/librte_ring/rte_ring.c(90): > .../lib/librte_ring/rte_ring.h(162): > error #1366: a reduction in alignment without the "packed" attribute > is ignored > } __rte_cache_aligned; > ^ >

[dpdk-dev] [PATCH] drivers/net: remove unused DEPDIRS from makefiles

2017-04-05 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- drivers/net/Makefile | 2 +- drivers/net/kni/Makefile | 8 drivers/net/liquidio/Makefile | 4 drivers/net/mlx4/Makefile | 7 --- drivers/net/tap/Makefile | 9 - 5 files changed, 1 insertion(+), 29 deletions(-) diff

[dpdk-dev] [PATCH v5] crypto/scheduler: add mode specific option support

2017-04-05 Thread Fan Zhang
Some scheduling modes may need extra options to be configured, this patch adds the function prototype for setting/getting options. Signed-off-by: Fan Zhang Acked-by: Declan Doherty --- v5: - Fixed a whitespace error v4: - Added documentation v3: - Fixed the order of APIs in the version map fi

Re: [dpdk-dev] [PATCH v14 0/6] Expanded statistics reporting

2017-04-05 Thread Thomas Monjalon
2017-03-30 22:00, Remy Horton: > This patchset consists of three libraries: A Metrics library for > distributing device information, a library that calculates bit-rate > statistics, and a library that calculates latency statistics. The > latter two libraries make use of the first library. I have f

[dpdk-dev] [PATCH] crypto/scheduler: add mode set get API

2017-04-05 Thread Fan Zhang
This patch adds two APIs, "rte_cryptodev_scheduler_mode_set" and "rte_cryptodev_scheduler_mode_get", to crypto scheduler PMD. These two API provides same functionalities as "rte_crpytodev_scheduler_mode_get" and "rte_crpytodev_scheduler_mode_set" and they are proposed to deprecated in 17.08. Signe

Re: [dpdk-dev] [PATCH] ring: fix build with icc

2017-04-05 Thread Bruce Richardson
On Wed, Apr 05, 2017 at 05:29:48PM +0200, Thomas Monjalon wrote: > 2017-04-05 16:03, Ferruh Yigit: > > build error: > > In file included from .../lib/librte_ring/rte_ring.c(90): > > .../lib/librte_ring/rte_ring.h(162): > > error #1366: a reduction in alignment without the "packed" attribute > > is

[dpdk-dev] [PATCH v4] crypto/scheduler: add mode specific option support

2017-04-05 Thread Fan Zhang
Some scheduling modes may need extra options to be configured, this patch adds the function prototype for setting/getting options. Signed-off-by: Fan Zhang Acked-by: Declan Doherty --- v4: - Added documentation v3: - Fixed the order of APIs in the version map file v2: - Updated for option sup

Re: [dpdk-dev] [PATCH v3] net/i40e: fix return value check issue

2017-04-05 Thread Zhang, Helin
> -Original Message- > From: henry [mailto:ca...@huawei.com] > Sent: Wednesday, April 5, 2017 9:20 PM > To: Zhang, Helin > Cc: dev@dpdk.org; Wu, Jingjing; zhoujing...@huawei.com; henry cai > Subject: [PATCH v3] net/i40e: fix return value check issue > > From: henry cai > > function i40

[dpdk-dev] [PATCH 2/2] event/sw: fix build with icc

2017-04-05 Thread Ferruh Yigit
build error: .../drivers/event/sw/sw_evdev_scheduler.c(379): error #300: const variable "dummy_rob" requires an initializer static const struct reorder_buffer_entry dummy_rob; ^ Variable "dummy_rob" defined as const but already cast

[dpdk-dev] [PATCH 1/2] event/octeontx: fix build with icc

2017-04-05 Thread Ferruh Yigit
build error: .../drivers/event/octeontx/ssovf_worker.c(212): error #592: variable "get_work0" is used before its value is set RTE_SET_USED(get_work0); ^ .../drivers/event/octeontx/ssovf_worker.c(213): error #592: variable "get_work1" is used before its value is set RTE_SET_

Re: [dpdk-dev] [PATCH] ring: fix build with icc

2017-04-05 Thread Thomas Monjalon
2017-04-05 16:03, Ferruh Yigit: > build error: > In file included from .../lib/librte_ring/rte_ring.c(90): > .../lib/librte_ring/rte_ring.h(162): > error #1366: a reduction in alignment without the "packed" attribute > is ignored > } __rte_cache_aligned; > ^ > > Alignment attribute moved t

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Thomas Monjalon
2017-04-05 16:16, Remy Horton: > > On 05/04/2017 16:06, Thomas Monjalon wrote: > [..] > > Do you mean DEPDIRS-$(CONFIG_RTE_LIBRTE_METRICS) et al? > > I can remove them if you confirm. > > The ones in lib/librte_*/Makefile - yes those ones. I think they can be > removed as feb9f680cd2c ("mk: opti

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Remy Horton
On 05/04/2017 16:06, Thomas Monjalon wrote: [..] Do you mean DEPDIRS-$(CONFIG_RTE_LIBRTE_METRICS) et al? I can remove them if you confirm. The ones in lib/librte_*/Makefile - yes those ones. I think they can be removed as feb9f680cd2c ("mk: optimize directory dependencies") changed the syste

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Thomas Monjalon
2017-04-05 15:46, Remy Horton: > > On 05/04/2017 14:39, Thomas Monjalon wrote: > > 2017-03-30 22:00, Remy Horton: > >> --- a/mk/rte.app.mk > >> +++ b/mk/rte.app.mk > [..] > >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS)+= -lrte_metrics > > > > It should not be added here in --whole-archive as it

[dpdk-dev] [PATCH] ring: fix build with icc

2017-04-05 Thread Ferruh Yigit
build error: In file included from .../lib/librte_ring/rte_ring.c(90): .../lib/librte_ring/rte_ring.h(162): error #1366: a reduction in alignment without the "packed" attribute is ignored } __rte_cache_aligned; ^ Alignment attribute moved to first element of the struct Fixes: a6619414e0a9

Re: [dpdk-dev] [PATCH v3 7/9] net/virtio: Add MTU feature support

2017-04-05 Thread Tan, Jianfeng
On 4/5/2017 9:54 PM, Maxime Coquelin wrote: On 04/05/2017 11:42 AM, Tan, Jianfeng wrote: Hi Maxime, Thank you for replying. On 4/5/2017 3:11 PM, Maxime Coquelin wrote: Hi Jianfeng, On 04/05/2017 06:52 AM, Tan, Jianfeng wrote: Hi Maxime, Have some confusion about this feature. Please he

[dpdk-dev] [PATCH v10 1/2] librte_net: add crc compute APIs

2017-04-05 Thread Jasvinder Singh
APIs for selecting the architecure specific implementation and computing the crc (16-bit and 32-bit CRCs) are added. For CRCs calculation, scalar as well as x86 intrinsic(sse4.2) versions are implemented. The scalar version is based on generic Look-Up Table(LUT) algorithm, while x86 intrinsic vers

[dpdk-dev] [PATCH v10 2/2] test/test: add unit test for CRC computation

2017-04-05 Thread Jasvinder Singh
This patch provides a set of tests for verifying the functional correctness of 16-bit and 32-bit CRC APIs. Signed-off-by: Jasvinder Singh Acked-by: Pablo de Lara --- MAINTAINERS | 1 + test/test/Makefile | 2 + test/test/test_crc.c | 183 ++

[dpdk-dev] [PATCH v10 0/2] librte_net: add crc computation support

2017-04-05 Thread Jasvinder Singh
In some applications, CRC (Cyclic Redundancy Check) needs to be computed or updated during packet processing operations. This patchset adds software implementation of some common standard CRCs (32-bit Ethernet CRC as per Ethernet/[ISO/IEC 8802-3] and 16-bit CCITT-CRC [ITU-T X.25]). Two versions of

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Remy Horton
On 05/04/2017 14:39, Thomas Monjalon wrote: 2017-03-30 22:00, Remy Horton: --- a/mk/rte.app.mk +++ b/mk/rte.app.mk [..] +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS)+= -lrte_metrics It should not be added here in --whole-archive as it is not going to be used by plugins (drivers). I suggest

Re: [dpdk-dev] [PATCH v14 5/6] lib: added new library for latency stats

2017-04-05 Thread Remy Horton
On 05/04/2017 15:24, Thomas Monjalon wrote: 2017-03-30 22:01, Remy Horton: [..] lib/librte_latencystats/rte_latencystats.c:204:27: fatal error: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value] glob_stats->jitter += (abs(pre

Re: [dpdk-dev] [PATCH v14 5/6] lib: added new library for latency stats

2017-04-05 Thread Thomas Monjalon
2017-03-30 22:01, Remy Horton: > + /* > +* The jitter is calculated as statistical mean of interpacket > +* delay variation. The "jitter estimate" is computed by > taking > +* the absolute values of the ipdv sequence and applying an > +

Re: [dpdk-dev] dpdk-next-eventdev git pull request for RC1

2017-04-05 Thread Ferruh Yigit
On 4/5/2017 2:15 PM, Jerin Jacob wrote: > -Original Message- >> Date: Wed, 5 Apr 2017 12:46:09 +0100 >> From: Ferruh Yigit >> To: Thomas Monjalon , Jerin Jacob >> >> CC: bruce.richard...@intel.com, dev@dpdk.org >> Subject: Re: [dpdk-dev] dpdk-next-eventdev git pull request for RC1 >> Use

[dpdk-dev] vlan id from ixgbevf

2017-04-05 Thread Yaron Illouz
Hi I am using the dpdk igb_uio in vm instead of ixgbevf To get the mac address from code I call function rte_eth_macaddr_get How do I get the vlan id assigned to the vf I am using, is there a similar function?

[dpdk-dev] [PATCH v2] net/i40e: fix QinQ eth pattern parsing

2017-04-05 Thread Bernard Iremonger
The eth keyword only should be accepted. Fixes: d46e85af6b5c ("net/i40e: parse QinQ pattern") Signed-off-by: Bernard Iremonger --- Changes in v2: rebased to latest dpdk-next-net Document the i40e_flow_parse_qinq_pattern function. Parse the eth keyword in similar way to mpls parsing function. d

Re: [dpdk-dev] [PATCH v3 7/9] net/virtio: Add MTU feature support

2017-04-05 Thread Maxime Coquelin
On 04/05/2017 11:42 AM, Tan, Jianfeng wrote: Hi Maxime, Thank you for replying. On 4/5/2017 3:11 PM, Maxime Coquelin wrote: Hi Jianfeng, On 04/05/2017 06:52 AM, Tan, Jianfeng wrote: Hi Maxime, Have some confusion about this feature. Please help confirm. (1) With this feature, we only sup

Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library

2017-04-05 Thread Thomas Monjalon
2017-03-30 22:00, Remy Horton: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -98,6 +98,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL)+= -lrte_eal > _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE)+= -lrte_cmdline > _LDLIBS-$(CONFIG_RT

Re: [dpdk-dev] [PATCH] doc: add missing step in PVP reference benchmark howto

2017-04-05 Thread Thomas Monjalon
2017-04-05 13:09, Mcnamara, John: > From: Jens Freimann [mailto:jfrei...@redhat.com] > > > > After we configure QEMU we also need to call 'make' to build the binary. > > This step is currently missing in the description and this patch fixes it. > > > > Signed-off-by: Jens Freimann > > > Thanks

Re: [dpdk-dev] [PATCH] doc: remove old deprecation notices

2017-04-05 Thread Thomas Monjalon
2017-04-05 13:57, Bruce Richardson: > On Wed, Apr 05, 2017 at 02:27:26PM +0200, Thomas Monjalon wrote: > > The ring and distributor reworks are done. > > > > Fixes: a6619414e0a9 ("ring: make struct and macros type agnostic") > > Fixes: 775003ad2f96 ("distributor: add new burst-capable library") >

[dpdk-dev] [PATCH v3] net/i40e: fix return value check issue

2017-04-05 Thread henry
From: henry cai function i40evf_add_del_all_mac_addr without check return value of rte_zmalloc Fixes: 97ac72aa71a9 ("i40e: support setting VF MAC address ") Signed-off-by: henry cai --- drivers/net/i40e/i40e_ethdev_vf.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/

Re: [dpdk-dev] dpdk-next-eventdev git pull request for RC1

2017-04-05 Thread Jerin Jacob
-Original Message- > Date: Wed, 5 Apr 2017 12:46:09 +0100 > From: Ferruh Yigit > To: Thomas Monjalon , Jerin Jacob > > CC: bruce.richard...@intel.com, dev@dpdk.org > Subject: Re: [dpdk-dev] dpdk-next-eventdev git pull request for RC1 > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:

Re: [dpdk-dev] [PATCH] doc: add missing step in PVP reference benchmark howto

2017-04-05 Thread Mcnamara, John
> -Original Message- > From: Jens Freimann [mailto:jfrei...@redhat.com] > Sent: Wednesday, April 5, 2017 1:29 PM > To: maxime.coque...@redhat.com > Cc: Mcnamara, John ; dev@dpdk.org > Subject: [PATCH] doc: add missing step in PVP reference benchmark howto > > After we configure QEMU we a

Re: [dpdk-dev] [PATCH] doc: remove old deprecation notices

2017-04-05 Thread Bruce Richardson
On Wed, Apr 05, 2017 at 02:27:26PM +0200, Thomas Monjalon wrote: > The ring and distributor reworks are done. > > Fixes: a6619414e0a9 ("ring: make struct and macros type agnostic") > Fixes: 775003ad2f96 ("distributor: add new burst-capable library") > > Signed-off-by: Thomas Monjalon > --- Acked

Re: [dpdk-dev] [PATCH v9 0/3] librte_net: add crc computation support

2017-04-05 Thread Singh, Jasvinder
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Wednesday, April 5, 2017 10:37 AM > To: Thomas Monjalon ; Singh, Jasvinder > > Cc: dev@dpdk.org; olivier.m...@6wind.com; Doherty, Declan > ; De Lara Guarch, Pablo > > Subject: RE: [dpdk-dev] [PATCH v9 0/3] librte_net: add c

Re: [dpdk-dev] [PATCH 2/2] test/mempool_perf: support default mempool autotest

2017-04-05 Thread santosh
Hi Shreyansh, On Wednesday 05 April 2017 03:32 PM, Shreyansh Jain wrote: > Hi Santosh, > On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: >> Mempool_perf autotest currently does perf regression for: >> * nochache >> * cache >> Introducing default_pool, mainly targeted for ext-mempool

Re: [dpdk-dev] [PATCH 1/2] test/mempool_perf: Free mempool on exit

2017-04-05 Thread santosh
Hi Shreyansh, On Wednesday 05 April 2017 03:27 PM, Shreyansh Jain wrote: > Hello Santosh, > On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: >> Mempool_perf test not freeing pool memory. >> Cc: sta...@dpdk.org >> Signed-off-by: Santosh Shukla >> --- >> test/test/test_mempool_perf.c |

[dpdk-dev] [PATCH] doc: add missing step in PVP reference benchmark howto

2017-04-05 Thread Jens Freimann
After we configure QEMU we also need to call 'make' to build the binary. This step is currently missing in the description and this patch fixes it. Signed-off-by: Jens Freimann --- doc/guides/howto/pvp_reference_benchmark.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/howto/p

[dpdk-dev] [PATCH] doc: remove old deprecation notices

2017-04-05 Thread Thomas Monjalon
The ring and distributor reworks are done. Fixes: a6619414e0a9 ("ring: make struct and macros type agnostic") Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 26 -- 1 file change

Re: [dpdk-dev] [PATCH v2 0/8] mbuf: structure reorganization

2017-04-05 Thread Ferruh Yigit
On 4/5/2017 10:37 AM, Thomas Monjalon wrote: > 2017-04-04 18:27, Olivier Matz: >> Based on discussions done in [1] and in this thread, this patchset >> reorganizes >> the mbuf. >> >> The main changes are: >> - reorder structure to increase vector performance on some non-ia >> platforms. >> - add

Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

2017-04-05 Thread Thomas Monjalon
2017-04-04 18:40, Olivier Matz: > The objective of this patchset is to introduce a framework to > support dynamic log types in EAL. It also provides one example of use > (in i40e). > > Features: > - log types are identified by a string > - at registration, a uniq identifier is associated to a log

Re: [dpdk-dev] dpdk-next-eventdev git pull request for RC1

2017-04-05 Thread Ferruh Yigit
On 4/5/2017 9:04 AM, Thomas Monjalon wrote: > 2017-04-04 15:54, Jerin Jacob: >> On 17-04-04 09:13:38, Thomas Monjalon wrote: >>> Hi, >>> >>> When trying to pull the tree, the compilation failed at the third patch: >>> eventdev: implement the northbound APIs >>> >>> When building for x86_64: >>>

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] crypto/scheduler: add mode specific option support

2017-04-05 Thread Thomas Monjalon
2017-04-05 11:02, Declan Doherty: > On 05/04/2017 10:02 AM, Fan Zhang wrote: > > Some scheduling modes may need extra options to be configured, > > this patch adds the function prototype for setting/getting > > options. > > > > Signed-off-by: Fan Zhang > > --- > ... > > > > Fan, could you send a

Re: [dpdk-dev] [PATCH] mbuf: bump library version

2017-04-05 Thread Thomas Monjalon
2017-04-05 12:00, Olivier Matz: > The reorganization of the mbuf structure induces an ABI breakage. > Bump the library version, and update the documentation accordingly. > > Signed-off-by: Olivier Matz Applied, thanks

Re: [dpdk-dev] [PATCH v2] net/cxgbe: fix a bug in t4_wr_mbox_meat_timeout

2017-04-05 Thread Ferruh Yigit
On 3/30/2017 5:08 PM, Ferruh Yigit wrote: > On 3/28/2017 8:32 AM, henry wrote: >> Check return value of malloc >> >> Signed-off-by: henry > > Hi henry, > > Full name is required for sign-off and author fields. > > Since patch already acked, if you can provide the information, I can > update the

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

2017-04-05 Thread Ferruh Yigit
On 4/5/2017 9:23 AM, Bruce Richardson wrote: > On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote: >> On 4/4/2017 5:36 PM, Allain Legacy wrote: >>> The AVP devices are only supported on Intel 64-bit architectures so >>> adjusting the defconfig attributes accordingly. >>> >>> Fixes: c5ab47

[dpdk-dev] [PATCH] mbuf: bump library version

2017-04-05 Thread Olivier Matz
The reorganization of the mbuf structure induces an ABI breakage. Bump the library version, and update the documentation accordingly. Signed-off-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 7 --- doc/guides/rel_notes/release_17_05.rst | 21 - lib/librte

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: add mode specific option support

2017-04-05 Thread Declan Doherty
On 05/04/2017 10:02 AM, Fan Zhang wrote: Some scheduling modes may need extra options to be configured, this patch adds the function prototype for setting/getting options. Signed-off-by: Fan Zhang --- ... Fan, could you send a documentation patch with a update to the scheduler documentati

Re: [dpdk-dev] [PATCH 2/2] test/mempool_perf: support default mempool autotest

2017-04-05 Thread Shreyansh Jain
Hi Santosh, On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: Mempool_perf autotest currently does perf regression for: * nochache * cache Introducing default_pool, mainly targeted for ext-mempool regression test. Ext-mempool don't need 'cache' modes so only adding test-case support

Re: [dpdk-dev] [PATCH 1/2] test/mempool_perf: Free mempool on exit

2017-04-05 Thread Shreyansh Jain
Hello Santosh, On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: Mempool_perf test not freeing pool memory. Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- test/test/test_mempool_perf.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) d

Re: [dpdk-dev] [PATCH v2 0/8] mbuf: structure reorganization

2017-04-05 Thread Olivier MATZ
On Wed, 05 Apr 2017 11:37:39 +0200, Thomas Monjalon wrote: > 2017-04-04 18:27, Olivier Matz: > > Based on discussions done in [1] and in this thread, this patchset > > reorganizes > > the mbuf. > > > > The main changes are: > > - reorder structure to increase vector performance on some non-ia >

Re: [dpdk-dev] [PATCH v2 0/8] mbuf: structure reorganization

2017-04-05 Thread Richardson, Bruce
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, April 5, 2017 10:38 AM > To: Olivier Matz > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Richardson, Bruce ; m...@smartsharesystems.com; > Chilikin, Andrey ; jblu...@infradead.org; > nelio.lar

Re: [dpdk-dev] ZUC PMD as shared library

2017-04-05 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Tuesday, April 04, 2017 1:16 PM > To: De Lara Guarch, Pablo; dev@dpdk.org > Subject: ZUC PMD as shared library > > Hi, > > Is it possible to build ZUC PMD as a shared library? It is not cu

Re: [dpdk-dev] [PATCH v3 7/9] net/virtio: Add MTU feature support

2017-04-05 Thread Tan, Jianfeng
Hi Maxime, Thank you for replying. On 4/5/2017 3:11 PM, Maxime Coquelin wrote: Hi Jianfeng, On 04/05/2017 06:52 AM, Tan, Jianfeng wrote: Hi Maxime, Have some confusion about this feature. Please help confirm. (1) With this feature, we only support to advertise MTU value which is defined by

Re: [dpdk-dev] [PATCH v2 0/8] mbuf: structure reorganization

2017-04-05 Thread Thomas Monjalon
2017-04-04 18:27, Olivier Matz: > Based on discussions done in [1] and in this thread, this patchset reorganizes > the mbuf. > > The main changes are: > - reorder structure to increase vector performance on some non-ia > platforms. > - add a 64bits timestamp field in the 1st cache line. This tim

Re: [dpdk-dev] [PATCH v9 0/3] librte_net: add crc computation support

2017-04-05 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, April 5, 2017 10:01 AM > To: Singh, Jasvinder > Cc: dev@dpdk.org; olivier.m...@6wind.com; Doherty, Declan > ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH v9 0/3] l

  1   2   >