On Fri, Mar 31, 2017 at 03:47:10PM -0700, Sagar Abhang wrote:
> Moved the call to "eth_dev_stop" inside "eth_dev_close" because
> "rte_eth_dev_close" calls 'close' operation of device, and in existing
> code the close was happening without 'stop' operation for vhost device.
> Moved code to free rx and tx queues inside "eth_dev_close" because the
> "rte_eth_dev_close" function calls the vhost's "eth_dev_close" function
> In that case, the memory allocated for the queues is not freed up
> before we free the pointer of rx and tx queues causing memory leak.
This patch looks Okay to me, expect the log is a bit hard to understand:
you don't have to explain that "rte_eth_dev_xx" calls the vhost "eth_dev_xxx".
Also please use whitespace lines between paragraphs.
Will you try to reword the log a bit, so that I can apply?
Thanks.
--yliu
