Hello Santosh,
On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote:
Mempool_perf test not freeing pool memory.
Cc: sta...@dpdk.org
Signed-off-by: Santosh Shukla <santosh.shu...@caviumnetworks.com>
---
test/test/test_mempool_perf.c | 31 +++++++++++++++++++------------
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
index ebf1721..3c45971 100644
--- a/test/test/test_mempool_perf.c
+++ b/test/test/test_mempool_perf.c
@@ -312,6 +312,8 @@ struct mempool_test_stats {
static int
test_mempool_perf(void)
{
+ int ret = -1;
+
rte_atomic32_init(&synchro);
/* create a mempool (without cache) */
@@ -322,7 +324,7 @@ struct mempool_test_stats {
Can you check why the patch is showing "struct mempool_test_stats" as
the context?
I tried creating this patch and it shows "test_mempool_perf(void)" as
context.
off the topic, does it matter to maintainers if context is not correct?
my_obj_init, NULL,
SOCKET_ID_ANY, 0);
if (mp_nocache == NULL)
- return -1;
+ goto err;
/* create a mempool (with cache) */
if (mp_cache == NULL)
[...]
+err:
+ rte_mempool_free(mp_cache);
+ rte_mempool_free(mp_nocache);
+ return ret;
}
REGISTER_TEST_COMMAND(mempool_perf_autotest, test_mempool_perf);
Other than that:
Acked-by: Shreyansh Jain <shreyansh.j...@nxp.com>
