[dpdk-dev] [PATCH] ip_pipeline:pipeline_firewall: Fix for UDP/TCP port range filtering

2017-03-20 Thread Shyam Kumar Shrivastav
Firewall ACL definition need to use same input index for source and destination ports as these are 16 bits and would fit in one ACL field of 32 bits. This is required as per librte_acl API. Without this UDP/TCP source and destination ports filtering (and for that matter ICMP type/code filtering)

Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver

2017-03-20 Thread Shreyansh Jain
On Tuesday 21 March 2017 11:55 AM, Shreyansh Jain wrote: Hello Keith, On Tuesday 21 March 2017 11:32 AM, Wiles, Keith wrote: On Mar 20, 2017, at 11:55 PM, Shreyansh Jain wrote: Hello David, On Monday 20 March 2017 08:20 PM, Hunt, David wrote: On 20/3/2017 10:03 AM, Shreyansh Jain wrote:

Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver

2017-03-20 Thread Shreyansh Jain
Hello Keith, On Tuesday 21 March 2017 11:32 AM, Wiles, Keith wrote: On Mar 20, 2017, at 11:55 PM, Shreyansh Jain wrote: Hello David, On Monday 20 March 2017 08:20 PM, Hunt, David wrote: On 20/3/2017 10:03 AM, Shreyansh Jain wrote: CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_ba

[dpdk-dev] [PATCH] test: add delay time in test alarm

2017-03-20 Thread Qiming Yang
Because accuracy of timing to the microsecond is not guaranteed in rte_eal_alarm_set, this function will not be called before the requested time, but may be called a period of time afterwards which can not be calculated. In order to ensure test alarm running success, this patch added the delay time

Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver

2017-03-20 Thread Wiles, Keith
> On Mar 20, 2017, at 11:55 PM, Shreyansh Jain wrote: > > Hello David, > > On Monday 20 March 2017 08:20 PM, Hunt, David wrote: >> >> On 20/3/2017 10:03 AM, Shreyansh Jain wrote: >>> CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base. >>> Stack mempool handler moved from lib/librte_me

Re: [dpdk-dev] i40e queues per VF

2017-03-20 Thread Wu, Jingjing
> > This number is used as initialization time to allocate queue number > > for PF/VF for HW's queue pool. Will add more description in i40e.rst. > > The description "Number of queues reserved for each SR-IOV VF" seems > partially wrong. Please explain it is a queue pair. > OK. Sure. [..] >

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add api for attach-detach session with queue pair

2017-03-20 Thread Akhil Goyal
On 3/20/2017 9:56 PM, Trahe, Fiona wrote: Hi Akhil, -Original Message- From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] Sent: Friday, March 17, 2017 8:45 AM To: dev@dpdk.org Cc: Gonzalez Monroy, Sergio ; Doherty, Declan ; De Lara Guarch, Pablo ; Trahe, Fiona ; Akhil Goyal Subject

Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver

2017-03-20 Thread Shreyansh Jain
Hello David, On Monday 20 March 2017 08:20 PM, Hunt, David wrote: On 20/3/2017 10:03 AM, Shreyansh Jain wrote: CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base. Stack mempool handler moved from lib/librte_mempool into drivers/mempool. <...> -} - -static struct rte_mempool_ops o

[dpdk-dev] link speed is not available with Intel x520

2017-03-20 Thread Chillance Zen
Hi,all I can get link speed via rte_eth_link_get() with my nic x520,did anybody even meet this before? Thanks&Regards Linc

Re: [dpdk-dev] [PATCH v4] devtools: add tags and cscope index file generation support

2017-03-20 Thread Jerin Jacob
On Mon, Mar 20, 2017 at 10:15:45AM +, Dumitrescu, Cristian wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Sunday, March 19, 2017 10:52 AM > > To: dev@dpdk.org > > Cc: thomas.monja...@6wind.com; Yigit, Ferruh ; > > Jerin

Re: [dpdk-dev] [PATCH 19/39] event/octeontx: add support worker dequeue function

2017-03-20 Thread Jerin Jacob
On Mon, Mar 20, 2017 at 09:11:35PM +, Eads, Gage wrote: > Hi Jerin, Hi Gage, > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Friday, March 3, 2017 11:28 AM > > To: dev@dpdk.org > > Cc: thomas.monja...@6wind.com; Richardson, Bruce

Re: [dpdk-dev] [PATCH 39/39] doc: add OCTEONTX ssovf details

2017-03-20 Thread Jerin Jacob
On Mon, Mar 20, 2017 at 09:38:53PM +, Eads, Gage wrote: > And one other on line 66: "pre-perquisites" -> "prerequisites" Thanks for the review. Will fix it in v2 > > Thanks, > Gage > > > -Original Message- > > From: Eads, Gage > > Sent: Monday, March 20, 2017 3:20 PM > > To: 'Je

[dpdk-dev] [PATCH] mempool: remove non-EAL thread note from header

2017-03-20 Thread Gage Eads
Commit 4b5062755aa7 ("mempool: allow user-owned cache") added the capability for non-EAL threads to use the mempool library by checking rte_lcore_id() before accessing the per-lcore cache. This commit removes the note indicating that the mempool library cannot be used safely by non-EAL threads. Al

[dpdk-dev] [PATCH] net/mlx5: fix reusing Rx/Tx queues

2017-03-20 Thread Yongseok Koh
When configuring Rx/Tx queue, if queue already exists, it is reused. But if the queue size is changed, it must be resized to not access/overwrite invalid memory. Fixes: 2e22920b85d9 ("mlx5: support non-scattered Tx and Rx") CC: sta...@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/ml

[dpdk-dev] [PATCH v2 3/3] net/mlx5: rebuild flows on updating RETA

2017-03-20 Thread Yongseok Koh
Currently mlx5_dev_rss_reta_update() just updates tables in the host, therefore it isn't immediately effective until restarting the device by calling mlx5_dev_stop()/mlx5_dev_start() to update the changes in the device side. This patch adds rebuilding the device-specific datastructure and applying

[dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size

2017-03-20 Thread Yongseok Koh
In rte_eth_check_reta_mask(), it is required to align the size of the RETA table to RTE_RETA_GROUP_SIZE but as the size can be less than the limit, this should be removed. The change is also applied to a command of testpmd. Signed-off-by: Yongseok Koh --- app/test-pmd/cmdline.c| 4 +++-

[dpdk-dev] [PATCH v2 2/3] net/mlx5: use correct RETA table size

2017-03-20 Thread Yongseok Koh
When querying and updating RSS RETA table, it always uses the max size of the device instead of configured value. This patch fixes it and removed the related comments in the code. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 8 ++-- drivers/net/mlx5/mlx5_rss.c| 13 ++

[dpdk-dev] [PATCH v2 0/3] net/mlx5: fix updating RETA

2017-03-20 Thread Yongseok Koh
Currently rte_eth_dev_rss_reta_update() doesn't work properly for mlx5 PMD. This patchset fixes the issue. This also enables testing the API with testpmd. v2: * Minor code change by review. Yongseok Koh (3): lib/librte_ether: remove requirement of aligned RETA size net/mlx5: use correct RETA

Re: [dpdk-dev] [PATCH v4 00/17] Wind River Systems AVP PMD vs virtio? - ivshmem is back

2017-03-20 Thread Hobywan Kenoby
If AVP was an upstream device of Qemu or Linux kernel that would be very natural to have a DPDK PMD (setting aside my comments on a preferred single virtual device). As far as I know this is not the case. Because of that, one could see the AVP PMD as a way to leverage open source to promote pr

Re: [dpdk-dev] [PATCH v2] net/ark: poll-mode driver for AtomicRules Arkville

2017-03-20 Thread Stephen Hemminger
On Mon, 20 Mar 2017 17:14:51 -0400 Ed Czeck wrote: > +/* * > */ > +int > +ark_ddm_verify(struct ark_ddm_t *ddm) > +{ > + if (sizeof(struct ark_ddm_t) != ARK_DDM_EXPECTED_SIZE) { > + fprintf(stderr, " DDM structure l

Re: [dpdk-dev] [PATCH 39/39] doc: add OCTEONTX ssovf details

2017-03-20 Thread Eads, Gage
And one other on line 66: "pre-perquisites" -> "prerequisites" Thanks, Gage > -Original Message- > From: Eads, Gage > Sent: Monday, March 20, 2017 3:20 PM > To: 'Jerin Jacob' ; dev@dpdk.org > Cc: thomas.monja...@6wind.com; Richardson, Bruce > ; Van Haaren, Harry > ; hemant.agra...@

Re: [dpdk-dev] [PATCH 19/39] event/octeontx: add support worker dequeue function

2017-03-20 Thread Eads, Gage
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Friday, March 3, 2017 11:28 AM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Richardson, Bruce > ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; nipun.gu...@nxp.c

Re: [dpdk-dev] [PATCH 39/39] doc: add OCTEONTX ssovf details

2017-03-20 Thread Eads, Gage
Just a few nitpicks. > + > +Features of the OCTEONTX SSOVF PMD are: > + > +- 64 Event queues > +- 32 Event ports > +- HW event scheduler > +- Supports 1M flows per event queue > +- Flow based event pipeling pipeling -> pipelining > +- Flow pinning support in flow based event pipeling

[dpdk-dev] [PATCH v4 2/2] app/test: add unit test for CRC computation

2017-03-20 Thread Jasvinder Singh
This patch provides a set of tests for verifying the functional correctness of 16-bit and 32-bit CRC APIs. Signed-off-by: Jasvinder Singh --- app/test/Makefile | 2 + app/test/test_crc.c | 223 2 files changed, 225 insertions(+) create mo

[dpdk-dev] [PATCH v4 1/2] librte_net: add crc compute APIs

2017-03-20 Thread Jasvinder Singh
APIs for selecting the architecure specific implementation and computing the crc (16-bit and 32-bit CRCs) are added. For CRCs calculation, scalar as well as x86 intrinsic(sse4.2) versions are implemented. The scalar version is based on generic Look-Up Table(LUT) algorithm, while x86 intrinsic vers

[dpdk-dev] [PATCH v4 0/2] librte_net: add crc computation support

2017-03-20 Thread Jasvinder Singh
In some applications, CRC (Cyclic Redundancy Check) needs to be computed or updated during packet processing operations. This patchset adds software implementation of some common standard CRCs (32-bit Ethernet CRC as per Ethernet/[ISO/IEC 8802-3] and 16-bit CCITT-CRC [ITU-T X.25]). Two versions of

[dpdk-dev] [PATCH v11 14/18] examples/distributor: tweaks for performance

2017-03-20 Thread David Hunt
Approximately 10% performance increase due to these changes. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/examples/distributor/main.c b/examples/dis

Re: [dpdk-dev] [PATCH v2 01/21] net/qede/base: fix incorrect typecasting of flag

2017-03-20 Thread Ferruh Yigit
On 3/18/2017 6:48 AM, Rasesh Mody wrote: > dcbx-update-flag is incorrectly converted to boolean before assigining > it to ramrod data, fix this typecasting. Also, added more debug > messages in the dcbx code paths. > > Fixes: 26ae839d06e9 ("qede: add DCBX support") > > Signed-off-by: Rasesh Mody

[dpdk-dev] [PATCH v11 02/18] lib: create private header file

2017-03-20 Thread David Hunt
We'll be adding internal implementation definitions in here that are common to both burst and legacy APIs. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/rte_distributor_private.h | 136 +++ lib/librte_distributor/rte_distributor_v20.c |

[dpdk-dev] [PATCH v11 18/18] maintainers: add to distributor lib maintainers

2017-03-20 Thread David Hunt
Signed-off-by: David Hunt Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0c78b58..0dee268 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -492,6 +492,7 @@ F: doc/guides/sample_app_ug/ip_reassembly.rst Distributor M

[dpdk-dev] [PATCH v11 17/18] doc: distributor app changes for new burst API

2017-03-20 Thread David Hunt
Changes in the thread layout described, with an updated diagram. Signed-off-by: David Hunt Acked-by: John McNamara --- doc/guides/sample_app_ug/dist_app.rst | 50 +++--- doc/guides/sample_app_ug/img/dist_app.svg | 276 +- 2 files changed, 180 insertions(+), 146

[dpdk-dev] [PATCH v11 16/18] doc: distributor library changes for new burst API

2017-03-20 Thread David Hunt
Signed-off-by: David Hunt Acked-by: John McNamara Acked-by: Bruce Richardson --- doc/guides/prog_guide/packet_distrib_lib.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/prog_guide/packet_distrib_lib.rst b/doc/guides/prog_guide/packet_distrib_lib.rst index b5bdabb..e0adca

[dpdk-dev] [PATCH v11 15/18] examples/distributor: give Rx thread a core

2017-03-20 Thread David Hunt
Now that we're printing out a page of stats every second to the console, we should give the stats it's own core so that we don't interfere with the performance of the Rx core. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 24 1 f

[dpdk-dev] [PATCH v11 13/18] examples/distributor: add dedicated core for dist

2017-03-20 Thread David Hunt
Give the distribution functionality it's own core for performance, otherwise it's limited by the Rx core. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 181 ++-- 1 file changed, 123 insertions(+), 58 deletions(-)

[dpdk-dev] [PATCH v11 12/18] examples/distributor: wait for ports to come up

2017-03-20 Thread David Hunt
On some machines, ports take several seconds to come up. This patch causes the app to wait. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/distributor/main.c b/examples/dist

[dpdk-dev] [PATCH v11 09/18] test: test single and burst distributor API

2017-03-20 Thread David Hunt
Signed-off-by: David Hunt Acked-by: Bruce Richardson --- test/test/test_distributor.c | 116 ++- 1 file changed, 82 insertions(+), 34 deletions(-) diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c index 7a30513..890a852 100644 --- a

[dpdk-dev] [PATCH v11 11/18] examples/distributor: allow for extra stats

2017-03-20 Thread David Hunt
This will allow us to see what's going on at various stages throughout the sample app, with per-second visibility Signed-off-by: David Hunt Acked-by: Bruce Richardson --- examples/distributor/main.c | 140 +++- 1 file changed, 124 insertions(+), 16 deleti

[dpdk-dev] [PATCH v11 08/18] lib: add symbol versioning to distributor

2017-03-20 Thread David Hunt
Also bumped up the ABI version number in the Makefile Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/Makefile| 2 +- lib/librte_distributor/rte_distributor.c | 57 +++--- lib/librte_distributor/rte_distributor_v1705.h |

[dpdk-dev] [PATCH v11 10/18] test: add perf test for distributor burst mode

2017-03-20 Thread David Hunt
Signed-off-by: David Hunt Acked-by: Bruce Richardson --- test/test/test_distributor_perf.c | 75 ++- 1 file changed, 51 insertions(+), 24 deletions(-) diff --git a/test/test/test_distributor_perf.c b/test/test/test_distributor_perf.c index 1dd326b..732d86d 1

[dpdk-dev] [PATCH v11 07/18] lib: make v20 header file private

2017-03-20 Thread David Hunt
Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile index a812fe4..2b28eff 100644 --- a/lib/librte_distributor/Makefile +++ b/lib/librte_distr

[dpdk-dev] [PATCH v11 06/18] lib: switch distributor over to new API

2017-03-20 Thread David Hunt
This is the main switch over between the legacy API and the new burst API. We rename all the functions in rte_distributor.c to remove the _v1705, and we add in _v20 in the rte_distributor_v20.c We also rename the rte_distributor_next.h as rte_distributor.h, as this is now the public header. At th

[dpdk-dev] [PATCH v11 03/18] lib: add new distributor code

2017-03-20 Thread David Hunt
This patch includes the code for new burst-capable distributor library. It also includes the rte_distributor_next.h file which will be used as the public header once we add in the symbol versioning for v20 and v1705 APIs, at which stage we will rename it to rte_distributor.h. The new distributor

[dpdk-dev] [PATCH v11 04/18] lib: add SIMD flow matching to distributor

2017-03-20 Thread David Hunt
Add an optimised version of the in-flight flow matching algorithm using SIMD instructions. This should give up to 1.5x over the scalar versions performance. Falls back to scalar version if SSE4.2 not available Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/Make

[dpdk-dev] [PATCH v11 05/18] test/distributor: extra params for autotests

2017-03-20 Thread David Hunt
In the next few patches, we'll want to test old and new API, so here we're allowing different parameters to be passed to the tests, instead of just a distributor struct. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- test/test/test_distributor.c | 64 +-

[dpdk-dev] [PATCH v11 01/18] lib: rename legacy distributor lib files

2017-03-20 Thread David Hunt
Move files out of the way so that we can replace with new versions of the distributor libtrary. Files are named in such a way as to match the symbol versioning that we will apply for backward ABI compatibility. Signed-off-by: David Hunt Acked-by: Bruce Richardson --- lib/librte_distributor/Make

[dpdk-dev] [PATCH v11 0/18] distributor lib performance enhancements

2017-03-20 Thread David Hunt
This patch aims to improve the throughput of the distributor library. It uses a similar handshake mechanism to the previous version of the library, in that bits are used to indicate when packets are ready to be sent to a worker and ready to be returned from a worker. One main difference is that in

Re: [dpdk-dev] [PATCH v2 00/61] net/qede/base: qede PMD enhancements

2017-03-20 Thread Ferruh Yigit
On 3/18/2017 7:05 AM, Rasesh Mody wrote: > Hi, > > This patch set adds support for new firmware 8.18.9.0, new features and > bug fixes. > > Please apply to dpdk-net-next for 17.05 release. Note that this patch set > depends on http://dpdk.org/dev/patchwork/patch/21896. > > v1..v2 > - address al

[dpdk-dev] [PATCH] crypto/scheduler: fix header includes

2017-03-20 Thread Fan Zhang
Fixes: 097ab0bac017 ("crypto/scheduler: add API") Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") Fixes: 870babeb53cf ("crypto/scheduler: add internal structures") Fixes: 31439ee72b2c ("crypto/scheduler: add API implementations") This patch fixes the incorrect header includes. S

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add api for attach-detach session with queue pair

2017-03-20 Thread Trahe, Fiona
Hi Akhil, > -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Friday, March 17, 2017 8:45 AM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; Doherty, > Declan ; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Akhil Goyal > Subject: [PATCH 1/2] cryptodev: ad

[dpdk-dev] checkpatch question -- CamelCase versus PRIu32

2017-03-20 Thread Ed Czeck
Hi All, I have a small number checkpatch.sh messages in the pattern below. The message is a conflict between the definition of PRIu32 in the system header files and the DPDK checkpatch setup. CHECK:CAMELCASE: Avoid CamelCase: #866: FILE: drivers/net/ark/ark_debug.h:41: +#define ARK_SU32 "\n\t%-

Re: [dpdk-dev] [PATCH v2 00/13] Improve Solarflare PMD performance

2017-03-20 Thread Ferruh Yigit
On 3/20/2017 10:15 AM, Andrew Rybchenko wrote: > Implement EF10 (SFN7xxx and SFN8xxx) native datapaths which may be > chosen per device using PCI whitelist device arguments. > > libefx-based datapath implementation is bound to API and structure > imposed by the libefx. It has many indirect functio

Re: [dpdk-dev] [PATCH] crypto/scheduler: optimize crypto op ordering

2017-03-20 Thread Declan Doherty
On 02/03/17 14:18, Fan Zhang wrote: This patch optimizes the crypto op ordering by replacing the ordering method from using rte_reorder library to using rte_ring to avoid unnecessary crypto op storing and recovering cost. Signed-off-by: Fan Zhang Signed-off-by: Sergio Gonzalez Monroy --- ...

Re: [dpdk-dev] [PATCH v2 00/13] introduce fail-safe PMD

2017-03-20 Thread Thomas Monjalon
There have been some discussions on this new PMD and it will be discussed today in the techboard meeting. I would like to expose my view and summarize the solutions I have heard. First it is important to remind that everyone agrees on the need for this feature, i.e. masking the hotplug events by m

Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver

2017-03-20 Thread Hunt, David
On 20/3/2017 10:03 AM, Shreyansh Jain wrote: CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base. Stack mempool handler moved from lib/librte_mempool into drivers/mempool. With this patch, the Stack mempool handler registration is optional and toggled via the configuration file. In case

[dpdk-dev] Solarflare DPDK

2017-03-20 Thread Ankit Aggarwal
Hi DPDK Users/devs Can you please tell me the benefits of using DPDK over openonload for solarflare cards? Ankit Aggarwal

Re: [dpdk-dev] Welcome to the "dev" mailing list

2017-03-20 Thread Ankit Aggarwal
Hi DPDK Users/devs Can you please tell me the benefits of using DPDK over openonload for solarflare cards? Ankit Aggarwal On Mon, Mar 20, 2017 at 5:36 PM, Ferruh Yigit wrote: > On 3/20/2017 5:57 AM, Ankit Aggarwal wrote: > > Hi Team, > > > > Is there any way we can get the performance numbers

Re: [dpdk-dev] [PATCH] crypto/scheduler: change enqueue and dequeue functions

2017-03-20 Thread Declan Doherty
On 02/03/17 11:12, Fan Zhang wrote: This patch changes the enqueue and dequeue methods to cryptodev scheduler PMD. Originally a 2-layer function call is carried out upon enqueuing or dequeuing a burst of crypto ops. This patch removes one layer to improve the performance. Signed-off-by: Fan Zhan

Re: [dpdk-dev] [PATCH v3 1/2] net/mlx4: split the definitions to the header file

2017-03-20 Thread Ferruh Yigit
On 3/20/2017 9:19 AM, Nélio Laranjeiro wrote: > On Sun, Mar 05, 2017 at 09:51:31AM +0200, Vasily Philipov wrote: >> Make priv_lock/priv_unlock functions and some other structs/defines visible >> from different source files by placing them into mlx4.h header. >> >> Signed-off-by: Vasily Philipov >

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] net/mlx4: update link status upon probing with lsc

2017-03-20 Thread Ferruh Yigit
On 3/17/2017 10:40 AM, Adrien Mazarguil wrote: > On Fri, Mar 03, 2017 at 04:39:56PM +0100, Gaetan Rivet wrote: >> If LSC interrupts are enabled, the application expects the link_update >> ops to be executed by the PMD itself. >> >> No link status change event is received upon probing, therefore the

[dpdk-dev] [PATCH] net/thunderx: sync mailbox definitions with Linux PF driver

2017-03-20 Thread Jerin Jacob
- bgx_link_status mbox definition was changed in Linux commit 1cc702591bae ("net: thunderx: Add ethtool support") - NIC_MBOX_MSG_RES_BIT related changes were never part of Linux PF driver Signed-off-by: Jerin Jacob --- drivers/net/thunderx/base/nicvf_mbox.c | 7 ++- drivers/net/thunderx/bas

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-20 Thread Adrien Mazarguil
Hi Ferruh, On Mon, Mar 20, 2017 at 01:24:36PM +, Ferruh Yigit wrote: > On 3/16/2017 11:04 AM, Adrien Mazarguil wrote: > > On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote: > >> Most ConnectX-3 adapters expose two physical ports on a single PCI bus > >> address. > >> > >> Add a new

Re: [dpdk-dev] [PATCH 1/1] net/mlx4: add port parameter

2017-03-20 Thread Ferruh Yigit
On 3/16/2017 11:04 AM, Adrien Mazarguil wrote: > On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote: >> Most ConnectX-3 adapters expose two physical ports on a single PCI bus >> address. >> >> Add a new port parameter allowing the user to choose >> either or both physical ports to be used

Re: [dpdk-dev] [PATCH] net/ark: poll-mode driver for AtomicRules Arkville

2017-03-20 Thread Shepard Siegel
Thanks Ferruh, Our team spent the weekend clearing the issues with last week's v1 submission, knocking down as many checkpatch issues as we can, cross compiling to both 32-bit and ARM targets, and of-course, testing on DTS and other hardware. We expect to follow Thomas' suggestion and re-send the

Re: [dpdk-dev] Getting crash in rte_pktmbuf_alloc with 16.11 DPDK

2017-03-20 Thread Olivier Matz
Hi, On Fri, 17 Mar 2017 13:09:17 +0800, Yuanhan Liu wrote: > On Fri, Mar 17, 2017 at 03:46:53AM +, Dey, Souvik wrote: > > Hi , > > I am trying to do rte_pktmbuf_alloc from a mempool within a > > secondary process after doing a rte_mempool_lookup for the same mempool. > > But

Re: [dpdk-dev] [PATCH] net/ark: poll-mode driver for AtomicRules Arkville

2017-03-20 Thread Ferruh Yigit
On 3/17/2017 9:15 PM, Ed Czeck wrote: > This is the PMD for Atomic Rules's Arkville ARK family of devices. > See doc/guides/nics/ark.rst for detailed description. > > > Signed-off-by: Shepard Siegel > Signed-off-by: John Miller > Signed-off-by: Ed Czeck Hi Shepard, John, Ed, Thank you for t

Re: [dpdk-dev] [PATCH v3 1/3] net/thunderx: fix build issues with 32bit target

2017-03-20 Thread Ferruh Yigit
On 3/19/2017 2:48 PM, Jerin Jacob wrote: > Fixes: e438796617dc ("net/thunderx: add PMD skeleton") > > Signed-off-by: Jerin Jacob Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3 3/3] config: enable the thunderx nicvf driver

2017-03-20 Thread Ferruh Yigit
On 3/19/2017 2:48 PM, Jerin Jacob wrote: > Enable Thunderx nicvf PMD driver in the common > config as it does not have build dependency > with any external library and/or architecture. > > Signed-off-by: Jerin Jacob Congratulations, Thunderx PMD enabled by default now.

Re: [dpdk-dev] [PATCH] kni: fix build with kernel 4.11

2017-03-20 Thread Jerin Jacob
On Mon, Mar 20, 2017 at 11:22:08AM +, Ferruh Yigit wrote: > compile error: > .../build/build/lib/librte_eal/linuxapp/kni/kni_net.c:124:6: > error: implicit declaration of function ‘signal_pending’ > [-Werror=implicit-function-declaration] > if (signal_pending(current) || ret_val <= 0) { >

Re: [dpdk-dev] [PATCH] mk: fix message when test application is not built

2017-03-20 Thread Ferruh Yigit
On 3/17/2017 5:09 PM, Olivier Matz wrote: > To build the tests, we should use "make test-build". > > Fixes: 64592d97c1ae ("mk: do not build tests by default") > > Signed-off-by: Olivier Matz Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] mk: remove invalid phony target

2017-03-20 Thread Ferruh Yigit
On 3/17/2017 5:08 PM, Olivier Matz wrote: > There was a typo in the .PHONY for the test-build target. If we fix the > typo, the test-build target does not work, because it won't match the > '%' target anymore. > > So just remove the .PHONY. > > Fixes: 64592d97c1ae ("mk: do not build tests by defa

[dpdk-dev] [PATCH] kni: fix build with kernel 4.11

2017-03-20 Thread Ferruh Yigit
compile error: .../build/build/lib/librte_eal/linuxapp/kni/kni_net.c:124:6: error: implicit declaration of function ‘signal_pending’ [-Werror=implicit-function-declaration] if (signal_pending(current) || ret_val <= 0) { ^~ Linux 4.11 moves signal function declarations to its ow

Re: [dpdk-dev] [PATCH] vhost: fix virtio_net cache sharing of broadcast_rarp

2017-03-20 Thread Kevin Traynor
On 03/17/2017 10:01 AM, Maxime Coquelin wrote: > > > On 03/17/2017 06:47 AM, Yuanhan Liu wrote: >> On Thu, Mar 16, 2017 at 10:10:05AM +, Kevin Traynor wrote: >>> On 03/16/2017 06:21 AM, Yuanhan Liu wrote: On Wed, Mar 15, 2017 at 07:10:49PM +, Kevin Traynor wrote: > The virtio_net

Re: [dpdk-dev] KNI broken again

2017-03-20 Thread Ferruh Yigit
On 3/20/2017 10:25 AM, Jerin Jacob wrote: > Found KNI broken in v4.11-rc3 Thanks for reporting, I confirm it, and will take care of it. Thanks, ferruh > > log: > > CC [M] > /home/jerin/dpdk-next-net/build/build/lib/librte_eal/linuxapp/kni/kni_misc.o > CC [M] > /home/jerin/dpdk-next-net/b

[dpdk-dev] KNI broken again

2017-03-20 Thread Jerin Jacob
Found KNI broken in v4.11-rc3 log: CC [M] /home/jerin/dpdk-next-net/build/build/lib/librte_eal/linuxapp/kni/kni_misc.o CC [M] /home/jerin/dpdk-next-net/build/build/lib/librte_eal/linuxapp/kni/kni_net.o /home/jerin/dpdk-next-net/build/build/lib/librte_eal/linuxapp/kni/kni_net.c: In function

Re: [dpdk-dev] [PATCH v4] devtools: add tags and cscope index file generation support

2017-03-20 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Sunday, March 19, 2017 10:52 AM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Yigit, Ferruh ; > Jerin Jacob > Subject: [dpdk-dev] [PATCH v4] devtools: add tags and cscope index file > ge

[dpdk-dev] [PATCH v2 08/13] net/sfc: factor out libefx-based Tx datapath

2017-03-20 Thread Andrew Rybchenko
Split control and datapath to make datapath substitutable and possibly reusable with alternative control path. libefx-based Tx datapath is bound to libefx control path, but it should be possible to use other datapaths with alternative control path(s). Signed-off-by: Andrew Rybchenko --- doc/gui

[dpdk-dev] [PATCH v2 04/13] net/sfc: factor out libefx-based Rx datapath

2017-03-20 Thread Andrew Rybchenko
Split control and datapath to make datapath substitutable and possibly reusable with alternative control path. libefx-based Rx datapath is bound to libefx control path, but other datapaths should be possible to use with alternative control path(s). Signed-off-by: Andrew Rybchenko --- doc/guides

[dpdk-dev] [PATCH v2 10/13] net/sfc: make TSO a datapath-dependent feature

2017-03-20 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_tx.h | 1 + drivers/net/sfc/sfc_tx.c| 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_dp_tx.h b/drivers/net/sfc/sfc_dp_tx.h index 1a6d6c1..c93932e 100644 --- a/drivers/net/sfc/sfc_dp_tx.h ++

[dpdk-dev] [PATCH v2 07/13] net/sfc: implement EF10 native Rx datapath

2017-03-20 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko Reviewed-by: David Riddoch --- doc/guides/nics/sfc_efx.rst | 5 +- drivers/net/sfc/Makefile | 1 + drivers/net/sfc/sfc_dp.h | 1 + drivers/net/sfc/sfc_dp_rx.h | 22 ++ drivers/net/sfc/sfc_ef10.h| 107 +++ drivers/net/sfc/sfc_ef10_rx.c

[dpdk-dev] [PATCH v2 11/13] net/sfc: implement EF10 native Tx datapath

2017-03-20 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko Reviewed-by: David Riddoch --- doc/guides/nics/sfc_efx.rst | 5 +- drivers/net/sfc/Makefile | 1 + drivers/net/sfc/sfc_dp_tx.h | 17 ++ drivers/net/sfc/sfc_ef10_tx.c | 451 ++ drivers/net/sfc/sfc_ethdev.c |

[dpdk-dev] [PATCH v2 05/13] net/sfc: make Rx scatter a datapath-dependent feature

2017-03-20 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_rx.h | 2 ++ drivers/net/sfc/sfc_rx.c| 8 2 files changed, 10 insertions(+) diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h index 7e56d14..b3c6a6c 100644 --- a/drivers/net/sfc/sfc_dp_rx.h +++ b/drivers

[dpdk-dev] [PATCH v2 02/13] net/sfc: emphasis that RSS hash flag is an Rx queue flag

2017-03-20 Thread Andrew Rybchenko
Style fix to establish namespace for Rx queue flag defines. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_rx.c | 4 ++-- drivers/net/sfc/sfc_rx.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index 214e640..d6

[dpdk-dev] [PATCH v2 03/13] net/sfc: do not use Rx queue control state on datapath

2017-03-20 Thread Andrew Rybchenko
Rx queue flags should keep the information required on datapath. It is a preparation to split control and data paths. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ev.c | 5 +++-- drivers/net/sfc/sfc_rx.c | 12 +++- drivers/net/sfc/sfc_rx.h | 12 +--- 3 files changed,

[dpdk-dev] [PATCH v2 09/13] net/sfc: make VLAN insertion a datapath-dependent feature

2017-03-20 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_tx.h | 2 ++ drivers/net/sfc/sfc_ethdev.c | 3 ++- drivers/net/sfc/sfc_tx.c | 14 +++--- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/net/sfc/sfc_dp_tx.h b/drivers/net/sfc/sfc_dp_tx.h index 1f922e

[dpdk-dev] [PATCH v2 06/13] net/sfc: remove few conditions in Rx queue refill

2017-03-20 Thread Andrew Rybchenko
If Rx refill threshold guarantees that refill happens for one or more bulks, less checks may be done on refill. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_rx.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/net/sfc/sfc_rx.c b/

[dpdk-dev] [PATCH v2 01/13] net/sfc: use different callbacks for event queues

2017-03-20 Thread Andrew Rybchenko
Use different sets of libefx EvQ callbacks for management, transmit and receive event queue. It makes event handling more robust against unexpected events. Also it is required for alternative datapath support. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ev.c | 107 ++

[dpdk-dev] [PATCH v2 13/13] net/sfc: implement simple EF10 native Tx datapath

2017-03-20 Thread Andrew Rybchenko
The datapath does not support VLAN insertion, TSO and multi-segment mbufs. Signed-off-by: Andrew Rybchenko --- doc/guides/nics/sfc_efx.rst | 5 ++- drivers/net/sfc/sfc_dp_tx.h | 1 + drivers/net/sfc/sfc_ef10_tx.c | 73 +++ drivers/net/sfc/sfc_ethdev.

[dpdk-dev] [PATCH v2 00/13] Improve Solarflare PMD performance

2017-03-20 Thread Andrew Rybchenko
Implement EF10 (SFN7xxx and SFN8xxx) native datapaths which may be chosen per device using PCI whitelist device arguments. libefx-based datapath implementation is bound to API and structure imposed by the libefx. It has many indirect function calls to provide HW abstraction (bad for CPU pipeline)

[dpdk-dev] [PATCH v2 12/13] net/sfc: make multi-segment support a Tx datapath feature

2017-03-20 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp_tx.h | 1 + drivers/net/sfc/sfc_ef10_tx.c | 2 +- drivers/net/sfc/sfc_ethdev.c | 3 +++ drivers/net/sfc/sfc_tx.c | 10 +- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_dp_tx.h b/dri

Re: [dpdk-dev] [PATCH 1/2] test: store only the test case name

2017-03-20 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > It looks like the patch got corrupted somehow - the above line should be > app/test/test.c, not test/test/test.c > > Applying fails here, but with a s/test/app in the right places, the patches > > (this and > next) both apply cleanl

Re: [dpdk-dev] [PATCH v1] NXP DPAA2 External Mempool Driver

2017-03-20 Thread Hemant Agrawal
On 3/17/2017 10:52 PM, Olivier Matz wrote: On Fri, 17 Mar 2017 17:12:59 +, Hemant Agrawal wrote: -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Friday, March 17, 2017 7:13 PM To: Hemant Agrawal Cc: dev@dpdk.org; olivier.m...@6wind.com; Shreyansh

Re: [dpdk-dev] [PATCH 1/2] test: store only the test case name

2017-03-20 Thread Jerin Jacob
On Mon, Mar 20, 2017 at 09:58:04AM +, Van Haaren, Harry wrote: > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Sunday, March 19, 2017 1:38 PM > > To: dev@dpdk.org > > Cc: thomas.monja...@6wind.com; Van Haaren, Harry > > ; Jerin > > Jacob > > Subject: [dpdk-dev] [PATCH

[dpdk-dev] [dpdk-dev v2 1/3] examples: enable HW CRC strip by default

2017-03-20 Thread Jeff Guo
Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers, and for most case of kernel driver default enable HW CRC strip, if disable HW CRC strip in example app's rxmode, VF driver will return fail and result the VF launch failure. So this patch default to enable HW CRC strip

[dpdk-dev] [dpdk-dev v2 2/3] app: enable HW CRC strip by default

2017-03-20 Thread Jeff Guo
Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers, and for most case of kernel driver default enable HW CRC strip, if disable HW CRC strip in app's rxmode, VF driver will return fail and result the VF launch failure. So this patch default to enable HW CRC strip to let V

[dpdk-dev] [dpdk-dev v2 3/3] test: enable HW CRC strip by default

2017-03-20 Thread Jeff Guo
Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers, and for most case of kernel driver default enable HW CRC strip, if disable HW CRC strip in test app's rxmode, VF driver will return fail and result the VF launch failure. So this patch default to enable HW CRC strip to

Re: [dpdk-dev] [PATCH 2/2] test: add a new unit test case status

2017-03-20 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, March 19, 2017 1:38 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Van Haaren, Harry > ; Jerin > Jacob > Subject: [dpdk-dev] [PATCH 2/2] test: add a new unit test case status > > Add a new unit test case status c

Re: [dpdk-dev] [PATCH 1/2] test: store only the test case name

2017-03-20 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, March 19, 2017 1:38 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Van Haaren, Harry > ; Jerin > Jacob > Subject: [dpdk-dev] [PATCH 1/2] test: store only the test case name > > Store only the test case name in un

Re: [dpdk-dev] KNI offloads

2017-03-20 Thread Ferruh Yigit
On 3/17/2017 2:50 PM, Alejandro Lucero wrote: > Is there any reason for this driver not supporting LSO or CSUM offloads? > > I know this is a virtual netdev but I think it should support those > options and enabled them depending on the PMD to send or receive packets > from. > > About giving to t

[dpdk-dev] [PATCH 2/2] drivers/mempool: add ring mempool handler as driver

2017-03-20 Thread Shreyansh Jain
CONFIG_RTE_DRIVER_MEMPOOL_RING option is introduced. Ring Mempool handler moved from lib/librte_mempool into drivers/mempool. With this patch, the Ring mempool handler registration is optional and toggled via the configuration file. In case disabled (N), it would imply request for creating of memp

[dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver

2017-03-20 Thread Shreyansh Jain
CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base. Stack mempool handler moved from lib/librte_mempool into drivers/mempool. With this patch, the Stack mempool handler registration is optional and toggled via the configuration file. In case disabled (N), it would imply request for creati

  1   2   >