> On Mar 20, 2017, at 11:55 PM, Shreyansh Jain <shreyansh.j...@nxp.com> wrote:
>
> Hello David,
>
> On Monday 20 March 2017 08:20 PM, Hunt, David wrote:
>>
>> On 20/3/2017 10:03 AM, Shreyansh Jain wrote:
>>> CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base.
>>> Stack mempool handler moved from lib/librte_mempool into drivers/mempool.
>>>
>
> <...>
>
>>> -}
>>> -
>>> -static struct rte_mempool_ops ops_stack = {
>>> - .name = "stack",
>>> - .alloc = stack_alloc,
>>> - .free = stack_free,
>>> - .enqueue = stack_enqueue,
>>> - .dequeue = stack_dequeue,
>>> - .get_count = stack_get_count
>>> -};
>>> -
>>> -MEMPOOL_REGISTER_OPS(ops_stack);
>>
>> Shreyansh,
>> Could I suggest you add the parameter "--find-renames" when
>> generating the patch files, as this will reduce the size of the patches
>> significantly, making for easier review. The patch line count in this
>> particular case would be reduced by approx 75%.
>
> Thanks for suggestion.
> Yes, I forgot to use this option while creating this patch. If there
> are comments and v2 needs to be created, I will keep this in mind.
>
>> Regards,
>> Dave.
I guess I missed an email, but what is the advantage of moving the ring/stack
files to the drivers directory as they are not drivers in the sense of a NIC
PMD or any other driver. You can still enable/disable them in the config files
right?
Regards,
Keith
