Re: [dpdk-dev] [PATCH v3 3/8] crypto/armv8: add PMD optimized for ARMv8 processors

2017-01-12 Thread Hemant Agrawal
On 1/4/2017 11:03 PM, zbigniew.bo...@caviumnetworks.com wrote: From: Zbigniew Bodek This patch introduces crypto poll mode driver using ARMv8 cryptographic extensions. CPU compatibility with this driver is detected in run-time and virtual crypto device will not be created if CPU doesn't provide

Re: [dpdk-dev] [PATCH v3 3/8] crypto/armv8: add PMD optimized for ARMv8 processors

2017-01-12 Thread Jianbo Liu
On 12 January 2017 at 21:12, Zbigniew Bodek wrote: > Hello Jianbo Liu, > > Thanks for the review. Please check my answers in-line. > > Kind regards > Zbigniew > > > On 06.01.2017 03:45, Jianbo Liu wrote: >> >> On 5 January 2017 at 01:33, wrote: >>> >>> From: Zbigniew Bodek >>> >>> This patch i

[dpdk-dev] [PATCH v9 25/26] net/i40e: set/clear VF stats from PF

2017-01-12 Thread Wenzhuo Lu
From: Qi Zhang This patch add support to get/clear VF statistics from PF side. Two APIs are added: rte_pmd_i40e_get_vf_stats. rte_pmd_i40e_reset_vf_stats. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c| 73 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v9 26/26] doc: update doc for VFD

2017-01-12 Thread Wenzhuo Lu
Update the NIC doc and release note. Signed-off-by: Wenzhuo Lu --- doc/guides/nics/i40e.rst | 1 + doc/guides/rel_notes/release_17_02.rst | 29 + 2 files changed, 30 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 5

[dpdk-dev] [PATCH v9 24/26] net/i40e: enhance in sanity check of MAC

2017-01-12 Thread Wenzhuo Lu
From: "Chen Jing D(Mark)" When VF sends request to add a new MAC address, PF host will check if it's a non-zero or unicast address, or it will return with error. In fact, VF still can set multicast address. This change remove to check if it's a unicast address. Signed-off-by: Chen Jing D(Mark)

[dpdk-dev] [PATCH v9 23/26] app/testpmd: handle i40e in VF VLAN filter command

2017-01-12 Thread Wenzhuo Lu
From: Bernard Iremonger modify set_vf_rx_vlan function to handle the i40e PMD. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 41 ++--- app/test-pmd/config.c | 13 - app/test-pmd/testpmd.h | 2 -- 3 files changed, 34 insertions(+

[dpdk-dev] [PATCH v9 19/26] app/testpmd: use unicast promiscuous mode on i40e

2017-01-12 Thread Wenzhuo Lu
Add testpmd CLI to set VF unicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 97 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 106 insertions(+) diff --git a/app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v9 22/26] app/testpmd: add command to test VF VLAN tag on i40e

2017-01-12 Thread Wenzhuo Lu
From: Bernard Iremonger command is: set vf vlan tag port_id vf_id on|off Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 103 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ 2 files changed, 110 insertions(+) diff --git a/a

[dpdk-dev] [PATCH v9 20/26] app/testpmd: use multicast promiscuous mode on i40e

2017-01-12 Thread Wenzhuo Lu
Add testpmd CLI to set VF multicast promiscuous mode on i40e. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 97 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +++ 2 files changed, 106 insertions(+) diff --git a/app/test-pmd/cmdline.

[dpdk-dev] [PATCH v9 21/26] app/testpmd: add command to test VF broadcast mode on i40e

2017-01-12 Thread Wenzhuo Lu
From: Bernard Iremonger Add command to call rte_pmd_i40e_set_vf_broadcast. Add set vf broadcast in testpmd_funcs.rst file. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 97 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++

[dpdk-dev] [PATCH v9 18/26] app/testpmd: use VFD APIs on i40e

2017-01-12 Thread Wenzhuo Lu
The new VF Daemon (VFD) APIs is implemented on i40e. Change testpmd code to use them, including VF MAC anti-spoofing, VF VLAN anti-spoofing, TX loopback, VF VLAN strip, VF VLAN insert. Signed-off-by: Wenzhuo Lu Signed-off-by: Chen Jing D(Mark) Signed-off-by: Bernard Iremonger --- app/test-pmd/

[dpdk-dev] [PATCH v9 17/26] net/i40e: set VF VLAN filter from PF

2017-01-12 Thread Wenzhuo Lu
From: Bernard Iremonger add rte_pmd_i40e_set_vf_vlan_filter API. User can call the API on PF to enable/disable a set of VF's VLAN filters. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 60 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v9 16/26] net/i40e: set VF VLAN tag from PF

2017-01-12 Thread Wenzhuo Lu
From: Bernard Iremonger Add rte_pmd_i40e_set_vf_vlan_tag API. User can call the API on PF to enable/disable a specific VF's VLAN tag. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 65 +++ drivers/net/i40e/rte_pmd_i40e.h |

[dpdk-dev] [PATCH v9 15/26] net/i40e: set VF broadcast mode from PF

2017-01-12 Thread Wenzhuo Lu
From: Bernard Iremonger Support enabling/disabling VF broadcast mode from PF. User can call the API on PF to enable/disable a specific VF's broadcast mode. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 53 +++ drivers/net/i40e/rte_

[dpdk-dev] [PATCH v9 13/26] net/i40e: set VF VLAN strip from PF

2017-01-12 Thread Wenzhuo Lu
From: "Chen Jing D(Mark)" Add a function to configure vlan strip enable/disable for specific SRIOV VF device. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_ethdev.c| 33 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v9 14/26] net/i40e: set VF VLAN insertion from PF

2017-01-12 Thread Wenzhuo Lu
From: Bernard Iremonger Support inserting VF VLAN id from PF. User can call the API on PF to insert a VLAN id to a specific VF. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 62 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 ++

[dpdk-dev] [PATCH v9 10/26] net/i40e: set VF MAC from PF support

2017-01-12 Thread Wenzhuo Lu
From: Ferruh Yigit Support setting VF MAC address from PF. User can call the API on PF to set a specific VF's MAC address. PF should set MAC address before VF initialized, if PF sets the MAC address after VF initialized, new MAC address won't be effective until VF reinitialized. This will remov

[dpdk-dev] [PATCH v9 12/26] net/i40e: fix VF MAC address assignment

2017-01-12 Thread Wenzhuo Lu
From: Ferruh Yigit If PF sets vf->mac_addr, in VF initialization hw->mac.addr will be set to that same value. It is possible to check if PF set a MAC address or not through the hw->mac.addr variable. hw->mac.addr set by i40e_vf_parse_hw_config(), call stack is: In PF side i40e_pf_host_process_c

[dpdk-dev] [PATCH v9 09/26] net/i40e: fix VF reset flow

2017-01-12 Thread Wenzhuo Lu
From: Qi Zhang Add missing step during VF reset: PF should set I40E_VFGEN_RSTAT to ACTIVE at end of the VF reset operation or VF driver may not able to detect that reset is already completed. This patch also remove the unnecessary enum for vfr state. Fixes: 4861cde46116 ("i40e: new poll mode dri

[dpdk-dev] [PATCH v9 07/26] net/i40e: set VF multicast promisc mode from PF

2017-01-12 Thread Wenzhuo Lu
Support enabling/disabling VF multicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's multicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 38 +++ drivers/net/i40e/rte_pmd_i40e.

[dpdk-dev] [PATCH v9 11/26] net/i40e: set VF MAC from VF support

2017-01-12 Thread Wenzhuo Lu
From: Ferruh Yigit Support changing VF default MAC address. This function is not supported if PF set the MAC address for the PF. Signed-off-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.h| 4 +++- drivers/net/i40e/i40e_ethdev_vf.c | 49 +-- 2 files

[dpdk-dev] [PATCH v9 05/26] net/i40e: set Tx loopback from PF

2017-01-12 Thread Wenzhuo Lu
Support enabling/disabling TX loopback from PF. User can call the API on PF to enable/disable TX loopback for all the PF and VFs. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 238 ++ drivers/net/i40e/rte_pmd_i40e.h | 16 ++ driv

[dpdk-dev] [PATCH v9 08/26] net/i40e: enable VF MTU change

2017-01-12 Thread Wenzhuo Lu
From: Qi Zhang This patch implement mtu_set ops for i40e VF. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 12da0ec

[dpdk-dev] [PATCH v9 06/26] net/i40e: set VF unicast promisc mode from PF

2017-01-12 Thread Wenzhuo Lu
Support enabling/disabling VF unicast promiscuous mode from PF. User can call the API on PF to enable/disable a specific VF's unicast promiscuous mode. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 38 +++ drivers/net/i40e/rte_pmd_i40e.h

[dpdk-dev] [PATCH v9 04/26] net/i40e: set VF VLAN anti-spoofing from PF

2017-01-12 Thread Wenzhuo Lu
Support enabling/disabling VF VLAN anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's VLAN anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 137 -- drivers/net/i40e/i40e_ethdev.h|

[dpdk-dev] [PATCH v9 02/26] net/i40e: add callback to user on VF to PF mbox msg

2017-01-12 Thread Wenzhuo Lu
The callback asks the user application if it is allowed to perform the mailbox messages. If the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED then continue. If ACK or NACK, do nothing and send not_supported to VF. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_pf.c | 230 +++

[dpdk-dev] [PATCH v9 03/26] net/i40e: set VF MAC anti-spoofing from PF

2017-01-12 Thread Wenzhuo Lu
Support enabling/disabling VF MAC anti-spoofing from PF. User can call the API on PF to enable/disable a specific VF's MAC anti-spoofing. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c| 62 +++ drivers/net/i40e/rte_pmd_i40e.h | 19 +

[dpdk-dev] [PATCH v9 01/26] net/i40e: support link status notification

2017-01-12 Thread Wenzhuo Lu
Add an API to expose the ability, that PF can notify VF when link status changes, to APP. So if PF APP doesn't want to enable interruption but check link status by itself, PF APP can let VF know link status changed. Signed-off-by: Wenzhuo Lu --- MAINTAINERS | 1 +

[dpdk-dev] [PATCH v9 00/26] Support VFD on i40e - EXPERIMENTAL

2017-01-12 Thread Wenzhuo Lu
1, VF Daemon (VFD) VFD is an idea to control all the VFs from PF. As we need to support the scenario kernel PF + DPDK VF, DPDK follows the interface between kernel PF + kernel VF. We don't want to introduce too many new messages between PF and VF. So this patch set adds some new APIs to control VFs

Re: [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API

2017-01-12 Thread Dai, Wei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > Sent: Thursday, January 12, 2017 7:39 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API > > > > -Original Message- > > From: dev

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-12 Thread Yuanhan Liu
On Thu, Jan 12, 2017 at 04:02:56PM +0100, Jan Viktorin wrote: > On Thu, 12 Jan 2017 10:30:58 +0800 > Yuanhan Liu wrote: > > > On Wed, Jan 11, 2017 at 03:51:22PM +0100, Thomas Monjalon wrote: > > > 2017-01-11 12:27, Yuanhan Liu: > > > > The fact that virtio net header is initiated to zero in PMD

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-12 Thread Tan, Jianfeng
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, January 13, 2017 10:05 AM > To: Tan, Jianfeng; Alejandro Lucero > Cc: Gregory Etelson; dev; us...@dpdk.org > Subject: Re: [dpdk-users] [dpdk-dev] IGB_UIO: PCI Resources Management > > On 1/13/2017 1:51 AM, Tan, Jianfeng wrote: >

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-12 Thread Jerin Jacob
On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > >> 2017-01-12 13:16, Jerin Jacob: > >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_P

Re: [dpdk-dev] [PATCH] tools: add tags and cscope index file generation support

2017-01-12 Thread Jerin Jacob
On Thu, Jan 12, 2017 at 02:19:44PM +, Ferruh Yigit wrote: > On 11/27/2016 12:12 AM, Jerin Jacob wrote: > > This script generates cscope, gtags, and tags > > index files based on EAL environment. > > (architecture and OS(linux/bsd)) > > > > Selection of the architecture and OS environment > > i

Re: [dpdk-dev] Does DPDK i40e driver support 'Toeplitz hash'

2017-01-12 Thread Wu, Jingjing
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, January 12, 2017 7:59 PM > To: ALeX Wang ; dev@dpdk.org > Cc: Keith Amidon ; Wu, Jingjing > ; Zhang, Helin > Subject: Re: [dpdk-dev] Does DPDK i40e driver support 'Toeplitz hash' > > On 12/12/2016 6:31 AM, ALeX Wang wrote: > >

Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support

2017-01-12 Thread Jason Wang
On 2017年01月12日 17:40, Tan, Jianfeng wrote: Hi Jason, Ok, just want to show its advantages. It can be added on top. And two more suggestions: - better to split tap support out of vhost file Good suggestion! Will do that in next version. - kernel support more than 8 queues on recent kernel,

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-12 Thread Ferruh Yigit
On 1/13/2017 1:51 AM, Tan, Jianfeng wrote: > > >> -Original Message- >> From: users [mailto:users-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Thursday, January 12, 2017 8:22 PM >> To: Alejandro Lucero >> Cc: Gregory Etelson; dev; us...@dpdk.org >> Subject: Re: [dpdk-users] [dpdk-

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-12 Thread Tan, Jianfeng
> -Original Message- > From: users [mailto:users-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, January 12, 2017 8:22 PM > To: Alejandro Lucero > Cc: Gregory Etelson; dev; us...@dpdk.org > Subject: Re: [dpdk-users] [dpdk-dev] IGB_UIO: PCI Resources Management > > On 1/12/2

[dpdk-dev] [PATCH v3 2/5] app/test: add EFD functional and perf tests

2017-01-12 Thread Pablo de Lara
Signed-off-by: Byron Marohn Signed-off-by: Karla Saur Signed-off-by: Saikrishna Edupuganti Signed-off-by: Pablo de Lara Acked-by: Christian Maciocco --- MAINTAINERS | 1 + app/test/Makefile| 5 +- app/test/test_efd.c | 494

[dpdk-dev] [PATCH v3 3/5] examples/flow_distributor: sample app to demonstrate EFD usage

2017-01-12 Thread Pablo de Lara
This new sample app, based on the client/server sample app, shows the user an scenario using the EFD library. It consists of: - A front-end server which has an EFD table that stores the node id for each flow key, which will distribute the incoming packets to the different nodes - A back-end n

[dpdk-dev] [PATCH v3 5/5] doc: add flow distributor guide

2017-01-12 Thread Pablo de Lara
Signed-off-by: Sameh Gobriel Signed-off-by: Pablo de Lara Acked-by: Christian Maciocco --- MAINTAINERS |1 + doc/guides/sample_app_ug/flow_distributor.rst | 494 doc/guides/sample_app_ug/img/flow_distributor.svg | 1254

[dpdk-dev] [PATCH v3 1/5] efd: new Elastic Flow Distributor library

2017-01-12 Thread Pablo de Lara
Elastic Flow Distributor (EFD) is a distributor library that uses perfect hashing to determine a target/value for a given incoming flow key. It has the following advantages: - First, because it uses perfect hashing, it does not store the key itself and hence lookup performance is not dependent

[dpdk-dev] [PATCH v3 0/5] Elastic Flow Distributor

2017-01-12 Thread Pablo de Lara
EFD is a distributor library that uses perfect hashing to determine a target/value for a given incoming flow key. It has the following advantages: first, because it uses perfect hashing it does not store the key itself and hence lookup performance is not dependent on the key size. Second, the targe

Re: [dpdk-dev] [PATCH 0/2] make a couple eth_dev_ops const

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 7:12 PM, Stephen Hemminger wrote: > Really trivial patches. Patches are not in patchwork, and not in the mail list. > > I also consider this a litmus test of how long it takes DPDK > project to merge trivial maintaince patches. > > Stephen Hemminger (2): > bnx: make eth_dev_ops c

[dpdk-dev] [PATCH 0/2] make a couple eth_dev_ops const

2017-01-12 Thread Stephen Hemminger
Really trivial patches. I also consider this a litmus test of how long it takes DPDK project to merge trivial maintaince patches. Stephen Hemminger (2): bnx: make eth_dev_ops const ena: make eth_dev_ops const drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +- 2 fi

Re: [dpdk-dev] [PATCH v3 18/29] net/cxgbe: use eal I/O device memory read/write API

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 9:17 AM, Jerin Jacob wrote: <...> > > -#define CXGBE_PCI_REG_WRITE(reg, value) ({ \ > - CXGBE_PCI_REG((reg)) = (value); }) > +#define CXGBE_PCI_REG_WRITE(reg, value) rte_write32((value), (reg)) Almost all (if not all) PMD write macros' argument order is like write(address, valu

Re: [dpdk-dev] [PATCH v3 17/29] net/bnx2x: use eal I/O device memory read/write API

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 9:17 AM, Jerin Jacob wrote: <...> > > @@ -1560,11 +1556,9 @@ bnx2x_reg_read32(struct bnx2x_softc *sc, size_t offset) > #define DPM_TRIGGER_TYPE 0x40 > > /* Doorbell macro */ > -#define BNX2X_DB_WRITE(db_bar, val) \ > - *((volatile uint32_t *)(db_bar)) = (val) > +#define BNX2X

Re: [dpdk-dev] [PATCH v3 16/29] net/bnxt: use eal I/O device memory read/write API

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 9:17 AM, Jerin Jacob wrote: <...> > #define B_CP_DB_REARM(cpr, raw_cons) \ > - (*(uint32_t *)((cpr)->cp_doorbell) = (DB_CP_REARM_FLAGS | \ > - RING_CMP(cpr->cp_ring_struct, raw_cons))) > + rte_write32((DB_CP_R

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-12 Thread Ferruh Yigit
Hi Jerin, On 1/12/2017 9:17 AM, Jerin Jacob wrote: <...> > +#include > + > /* CSR write macro */ > -#define ADF_CSR_WR(csrAddr, csrOffset, val) \ > - (void)((*((volatile uint32_t *)(((uint8_t *)csrAddr) + csrOffset)) \ > - = (val))) > +#define ADF_CSR_WR(csrAddr, csrOffs

Re: [dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-12 Thread Thomas Monjalon
2017-01-12 15:30, Remy Horton: > > On 12/01/2017 13:22, Thomas Monjalon wrote: > > 2017-01-12 00:03, Remy Horton: > [..] > >> --- /dev/null > >> +++ b/lib/librte_metrics/rte_metrics.h > >> +/** Used to indicate port-independent information */ > >> +#define RTE_METRICS_NONPORT -1 > > > > I do not u

Re: [dpdk-dev] [PATCH v2 0/7] update ixgbe shared code to version 2017-01-05

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 2:53 PM, Wei Dai wrote: > This patch set updates ixgbe shared code to cid-ixgbe.2017.01.05.tar.gz . > The shared codes are in drivers/net/ixgbe/base/ and are developed by > another Intel team. > > This patch add more supports to some future new Intel ixgbe X550 platforms. > A new de

[dpdk-dev] [PATCH] kvargs: make pointers in string arrays const

2017-01-12 Thread Bruce Richardson
Change the parameters of functions from const char *valid[] to const char * const valid[]. This additional const is needed to allow us to fix some checkpatch warnings, as well as being good programming practice. For the checkpatch warnings, if we have a set of command line args that we want to che

Re: [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API

2017-01-12 Thread Ferruh Yigit
Hi Wei, On 1/12/2017 9:17 AM, Wei Zhao wrote: > The patches mainly finish following functions: > 1) Store and restore all kinds of filters. > 2) Parse all kinds of filters. > 3) Add flow validate function. > 4) Add flow create function. > 5) Add flow destroy function. > 6) Add flow flush function.

Re: [dpdk-dev] [PATCH v5 11/18] net/ixgbe: parse n-tuple filter

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 9:17 AM, Wei Zhao wrote: > Add rule validate function and check if the rule is a n-tuple rule, > and get the n-tuple info. > > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu > --- <...> > /* Destroy all flow rules associated with a port on ixgbe. */ > static int > ixgbe_flo

Re: [dpdk-dev] [PATCH v5 12/18] net/ixgbe: parse ethertype filter

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 9:17 AM, Wei Zhao wrote: > check if the rule is a ethertype rule, and get the ethertype info. > > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu > --- > drivers/net/ixgbe/ixgbe_flow.c | 278 > + > 1 file changed, 278 insertions(+) > >

Re: [dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-12 Thread Remy Horton
On 12/01/2017 13:22, Thomas Monjalon wrote: 2017-01-12 00:03, Remy Horton: [..] --- /dev/null +++ b/lib/librte_metrics/rte_metrics.h +/** Used to indicate port-independent information */ +#define RTE_METRICS_NONPORT -1 I do not understand this constant. Why using the word "port" to name any

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 1:58 PM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: >> 2017-01-12 13:16, Jerin Jacob: >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe >>> +endif >> >> _LDLIBS is an internal variable

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/virtio: fix performance regression due to TSO enabling

2017-01-12 Thread Jan Viktorin
On Thu, 12 Jan 2017 10:30:58 +0800 Yuanhan Liu wrote: > On Wed, Jan 11, 2017 at 03:51:22PM +0100, Thomas Monjalon wrote: > > 2017-01-11 12:27, Yuanhan Liu: > > > The fact that virtio net header is initiated to zero in PMD driver > > > init stage means that these costly writes are unnecessary an

Re: [dpdk-dev] [PATCH v3 3/3] pci: Pass rte_pci_addr to functions instead of separate args

2017-01-12 Thread Thomas Monjalon
2017-01-11 10:10, Ben Walker: > Instead of passing domain, bus, devid, func, just pass > an rte_pci_addr. > > Signed-off-by: Ben Walker Added v2 acks from Shreyansh and removed unnecessary empty lines as Shreyansh commented, and Series applied, thanks

[dpdk-dev] [PATCH v2 4/7] net/ixgbe/base: support Marvell 1000BASE-T PHYs

2017-01-12 Thread Wei Dai
This patch adds initial support for Marvell 1000BASE-T PHYs on some X550 platforms. Firmware owns the link config for Marvell PHYs on these platforms, software should not touch it. Also these platforms are not capable of speeds lower than 1Gb. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ix

[dpdk-dev] [PATCH v2 6/7] net/ixgbe/base: add some debug traces

2017-01-12 Thread Wei Dai
This patch adds some traces in the reset_hw logic and semaphore acquisition logic to help debugging. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_common.c | 7 - drivers/net/ixgbe/base/ixgbe_phy.c| 16 +--- drivers/net/ixgbe/base/ixgbe_x540.c | 11 ++-- drivers/

[dpdk-dev] [PATCH v2 7/7] net/ixgbe/base: update version of shared code

2017-01-12 Thread Wei Dai
update version of shared code to 2017-01-05 in README. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README index 1936191..0a6054f 100644 --- a/drivers/net/ixgbe/

[dpdk-dev] [PATCH v2 5/7] net/ixgbe/base: use clause 22 MDIO functions for Marvell PHYs

2017-01-12 Thread Wei Dai
This patch sets the MDIO(Management Data Input/Output Interface) read/write function ponters for Marvell PHYs on some X550 platforms to use the clause 22 functions. Marvell PHYs do not support clause 45. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_x550.c | 4 1 file changed, 4 i

[dpdk-dev] [PATCH v2 3/7] net/ixgbe/base: configure speeds for KR/KX backplane

2017-01-12 Thread Wei Dai
This patch ensures that the advertised link speeds are configured for KR/KX backplane on some new platform. Without this patch the link remains at 1G when resuming from low power after being downshifted by LPLU(Low Power Link Up). This patch ensures that the advertise speeds are not changed for 2.5

[dpdk-dev] [PATCH v2 2/7] net/ixgbe/base: remove a compiler warning

2017-01-12 Thread Wei Dai
This patch fixes a compiler warning. In ixgbe_init_led_link_act_generic() of drivers/net/ixgbe/base/ixgbe_common.c, u16 i will make some C compiler generate a warning for the line mac->led_link_act = i where led_link_act is u8 . Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_common.c |

[dpdk-dev] [PATCH v2 1/7] net/ixgbe/base: support XFI backplane for X550

2017-01-12 Thread Wei Dai
This patch adds initial support for a XFI backplane interface on some future new platforms. The XFI backplane requires a custom tuned link. Hardware/Firmware owns the link config for XF backplane and software must not interfere with it. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_api

[dpdk-dev] [PATCH v2 0/7] update ixgbe shared code to version 2017-01-05

2017-01-12 Thread Wei Dai
This patch set updates ixgbe shared code to cid-ixgbe.2017.01.05.tar.gz . The shared codes are in drivers/net/ixgbe/base/ and are developed by another Intel team. This patch add more supports to some future new Intel ixgbe X550 platforms. A new device id and two PHY types are introduced and also

[dpdk-dev] [PATCH] examples/ipsec-secgw: add support for SHA256 HMAC

2017-01-12 Thread zbigniew.bodek
From: Zbigniew Bodek Add minor adjustments to support SHA256 HMAC: - extend maximum key length to match SHA256 HMAC - add SHA256 HMAC parameters and configuration string - add SHA256 HMAC to inbound and outbound cases Signed-off-by: Zbigniew Bodek --- examples/ipsec-secgw/esp.c | 2 ++ examp

Re: [dpdk-dev] [PATCH v6 4/4] latencystats: added new library for latency stats

2017-01-12 Thread Remy Horton
On 12/01/2017 13:41, Thomas Monjalon wrote: 2017-01-12 00:03, Remy Horton: Add a library designed to calculate latency statistics and report them to the application when queried. The library measures minimum, average and maximum latencies, and jitter in nano seconds. The current implementation

[dpdk-dev] [PATCH v2 1/2] cryptodev: add user defined name initializing parameter to software PMD

2017-01-12 Thread Fan Zhang
This patch adds a user defined name initializing parameter to cryptodev library. Originally, for software cryptodev PMD, the vdev name parameter is treated as the driver identifier, and will create an unique name for each device automatically, which is not necessarily as same as the vdev parameter

[dpdk-dev] [PATCH v2 2/2] crypto: add user defined name initializing parameter parsing to software PMDs

2017-01-12 Thread Fan Zhang
This patch adds user defined name parsing feature to software PMDs. Signed-off-by: Fan Zhang --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 58 ++-- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 61 ++ drivers/crypto/kasumi/rte_kasumi_pmd.c

[dpdk-dev] [PATCH v2 0/2] crypto: add user defined name initializing parameter

2017-01-12 Thread Fan Zhang
This patchset adds a user defined name initializing parameter to all software cryptodevs. v2: Fixed a line adds whitespace error Updated rte_cryptodev_version.map Fan Zhang (2): cryptodev: add user defined name initializing parameter to software PMD crypto: add user defined name initializ

Re: [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 2:08 PM, Dai, Wei wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, January 11, 2017 11:38 PM >> To: Dai, Wei ; dev@dpdk.org >> Cc: Zhang, Helin ; Ananyev, Konstantin >> >> Subject: Re: [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning >> >

Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 2:18 PM, Dai, Wei wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, January 11, 2017 11:39 PM >> To: Dai, Wei ; dev@dpdk.org >> Cc: Zhang, Helin ; Ananyev, Konstantin >> >> Subject: Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces >> >> On

Re: [dpdk-dev] [PATCH] tools: add tags and cscope index file generation support

2017-01-12 Thread Ferruh Yigit
On 11/27/2016 12:12 AM, Jerin Jacob wrote: > This script generates cscope, gtags, and tags > index files based on EAL environment. > (architecture and OS(linux/bsd)) > > Selection of the architecture and OS environment > is based on dpdk configuration target(T=) > > example usage: > make tags T=x

Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces

2017-01-12 Thread Dai, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 11:39 PM > To: Dai, Wei ; dev@dpdk.org > Cc: Zhang, Helin ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces > > On 1/10/2017 3:45 PM, Wei Dai wrote: > > This pa

Re: [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning

2017-01-12 Thread Dai, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 11:38 PM > To: Dai, Wei ; dev@dpdk.org > Cc: Zhang, Helin ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH 2/7] net/ixgbe/base: remove a compiler warning > > On 1/10/2017 3:45 PM, Wei Dai wrote: > > Thi

[dpdk-dev] [PATCH v3 0/2] net/i40e: fix segmentation fault

2017-01-12 Thread Bernard Iremonger
Changes in v3: Fix checkpatch warning in testpmd.c Tidy debug code in testpmd.c Changes in v2: These two patches were previously part of the following patchset: [PATCH v7 00/27] Support VFD on i40e They are being submitted seperately as they are not needed for VFD. The net/i40e patch has been r

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-12 Thread Jerin Jacob
On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > 2017-01-12 13:16, Jerin Jacob: > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > +endif > > _LDLIBS is an internal variable of rte.app.mk. > Please could you check that

[dpdk-dev] [PATCH v3 1/2] net/i40e: fix segmentation fault in close

2017-01-12 Thread Bernard Iremonger
Change the order of releasing the vsi's. Release the vmdq vsi's first, then release the main vsi. Fixes: 4861cde46116 ("i40e: new poll mode driver") CC: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 del

[dpdk-dev] [PATCH v3 2/2] app/testpmd: add command to configure VMDq

2017-01-12 Thread Bernard Iremonger
Add the following command to configure VMDq: port config vmdq Add new command to testpmd user guide. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 60 + app/test-pmd/testpmd.c | 126 +++- app/test-pm

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-01-12 Thread Olivier MATZ
Hi, On Wed, 11 Jan 2017 20:51:58 +, "Rowden, Aaron F" wrote: > Hi Helin, > > I'm checking on this to see why it could be failing but I don’t think > this is one part of formal validation. Intel modules are always what > is recommended. > > Aaron > > > Hi Helin, > > > > > On 11 Jan 2017,

Re: [dpdk-dev] [PATCH] ethdev: check process type before reset dev data

2017-01-12 Thread Thomas Monjalon
2017-01-12 16:33, Haibo Zhang: > Overwrite dev date by no primary process would cause > segment fault issue to primary proccess during receive pkt > > Signed-off-by: Haibo Zhang Thank you for the fix. A similar one was proposed by Yuanhan: http://dpdk.org/ml/archives/dev/2017-January/054

Re: [dpdk-dev] [PATCH v2] SDK: Add scripts to initialize DPDK runtime

2017-01-12 Thread Christian Ehrhardt
On Mon, Dec 19, 2016 at 4:15 PM, Thomas Monjalon wrote: > Thanks for sending your Debian/Ubuntu work. > > 2016-12-13 16:47, Luca Boccassi: > > From: Christian Ehrhardt > > > > A tools/init directory is added with dpdk-init, a script that can be > > used to initialize a DPDK runtime environment.

Re: [dpdk-dev] [PATCH v6 4/4] latencystats: added new library for latency stats

2017-01-12 Thread Thomas Monjalon
2017-01-12 00:03, Remy Horton: > Add a library designed to calculate latency statistics and report them > to the application when queried. The library measures minimum, average and > maximum latencies, and jitter in nano seconds. The current implementation > supports global latency stats, i.e. per

Re: [dpdk-dev] [PATCH v3 25/29] net/nfp: use eal I/O device memory read/write API

2017-01-12 Thread Jerin Jacob
On Thu, Jan 12, 2017 at 10:53:17AM +, Alejandro Lucero wrote: > Hi, > > I've tried to find out which dpdk repo should I use for testing this change > with NFP PMD. > > It seems rte_read/write functions are not with last dpdk main repo, nor > with dpdk-net-next. > > Can someone tell me which

Re: [dpdk-dev] [PATCH v6 3/4] app/test-pmd: add support for bitrate statistics

2017-01-12 Thread Thomas Monjalon
I do not understand clearly this library and the output from testpmd. It seems you have a need but you do not explain why it is not done in the application. Bitrate is specific to ethdev, right? Why not put it directly in testpmd first?

Re: [dpdk-dev] fm10k pmd limitations

2017-01-12 Thread Chen, Jing D
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, January 12, 2017 7:57 PM > To: Shaham Fridenberg ; dev@dpdk.org > Cc: Chen, Jing D > Subject: Re: [dpdk-dev] fm10k pmd limitations > > On 12/13/2016 1:49 PM, Shaham Fridenberg wrote: > > Hey guys, > > > > I'm using dpdk 16.4 a

Re: [dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-12 Thread Thomas Monjalon
2017-01-12 00:03, Remy Horton: > This patch adds a new information metric library that allows other > modules to register named metrics and update their values. It is > intended to be independent of ethdev, rather than mixing ethdev > and non-ethdev information in xstats. [...] > --- a/doc/api/dox

Re: [dpdk-dev] [PATCH 1/7] net/ixgbe/base: support Broadwell-DE XFI backplane

2017-01-12 Thread Dai, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 11:38 PM > To: Dai, Wei ; dev@dpdk.org > Cc: Zhang, Helin ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH 1/7] net/ixgbe/base: support Broadwell-DE XFI > backplane > > On 1/10/2017 3:45 PM, Wei Dai wro

Re: [dpdk-dev] [PATCH v3 3/8] crypto/armv8: add PMD optimized for ARMv8 processors

2017-01-12 Thread Zbigniew Bodek
Hello Jianbo Liu, Thanks for the review. Please check my answers in-line. Kind regards Zbigniew On 06.01.2017 03:45, Jianbo Liu wrote: On 5 January 2017 at 01:33, wrote: From: Zbigniew Bodek This patch introduces crypto poll mode driver using ARMv8 cryptographic extensions. CPU compatibi

[dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-12 Thread Olivier Matz
Fix typo when checking that no Vlan offload flags are passed at port initialization. By the way, also fix a typo in the log. Fixes: d4a27a3b092a ("nfp: add basic features") Signed-off-by: Olivier Matz --- drivers/net/nfp/nfp_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-12 Thread Alejandro Lucero
On Thu, Jan 12, 2017 at 12:22 PM, Ferruh Yigit wrote: > On 1/12/2017 12:12 PM, Alejandro Lucero wrote: > > > > > > On Thu, Jan 12, 2017 at 11:55 AM, Ferruh Yigit > > wrote: > > > > On 12/9/2016 8:54 AM, Gregory Etelson wrote: > > > Hello, > > > > >

Re: [dpdk-dev] [PATCH v2 07/11] crypto/dpaa2_sec: Add DPAA2_SEC PMD into build system

2017-01-12 Thread Akhil Goyal
On 1/9/2017 9:03 PM, Thomas Monjalon wrote: 2016-12-23 01:46, Akhil Goyal: +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_COMMON),y) +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_sec +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_qbman +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA

Re: [dpdk-dev] [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for Descriptor formation

2017-01-12 Thread Akhil Goyal
On 1/9/2017 7:25 PM, De Lara Guarch, Pablo wrote: -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Thursday, December 22, 2016 8:17 PM To: dev@dpdk.org Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; hemant.agra...@nxp.com; Mcnamara, John;

Re: [dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device pointer in cryptodevice

2017-01-12 Thread Akhil Goyal
On 1/9/2017 7:04 PM, De Lara Guarch, Pablo wrote: Hi, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal Sent: Thursday, December 22, 2016 8:17 PM To: dev@dpdk.org Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; hemant.agra...@nxp.

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 12:12 PM, Alejandro Lucero wrote: > > > On Thu, Jan 12, 2017 at 11:55 AM, Ferruh Yigit > wrote: > > On 12/9/2016 8:54 AM, Gregory Etelson wrote: > > Hello, > > > > IGB_UIO driver does not close port PCI activities after DPDK process >

Re: [dpdk-dev] After a port is bound to dpdk, when 'ip addr' or 'ip link add ~vlan' command against non-dpdk port , Linux kernel hangs

2017-01-12 Thread Ferruh Yigit
On 12/9/2016 11:27 PM, Joo Kim wrote: > Hello, > I am using dpdk 2.2.0 in this VM where several NIC ports are available. > > Also, uio, kni drivers are installed. > [root@mylinux]# lsmod | grep uio > igb_uio13224 0 > uio19259 1 igb_uio > [root@mylinux]# lsmod

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-12 Thread Alejandro Lucero
On Thu, Jan 12, 2017 at 11:55 AM, Ferruh Yigit wrote: > On 12/9/2016 8:54 AM, Gregory Etelson wrote: > > Hello, > > > > IGB_UIO driver does not close port PCI activities after DPDK process > exits. > > DPDK API provides rte_eth_dev_close() to manage port PCI, > > but it can be skipped if process

Re: [dpdk-dev] [PATCH v3 8/8] app/test: add ARMv8 crypto tests and test vectors

2017-01-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zbigniew Bodek [mailto:zbigniew.bo...@caviumnetworks.com] > Sent: Thursday, January 12, 2017 11:51 AM > To: De Lara Guarch, Pablo; dev@dpdk.org > Cc: Doherty, Declan; jerin.ja...@caviumnetworks.com > Subject: Re: [PATCH v3 8/8] app/test: add ARMv8 crypto tests

  1   2   3   >