On Thu, Jan 12, 2017 at 02:19:44PM +0000, Ferruh Yigit wrote: > On 11/27/2016 12:12 AM, Jerin Jacob wrote: > > This script generates cscope, gtags, and tags > > index files based on EAL environment. > > (architecture and OS(linux/bsd)) > > > > Selection of the architecture and OS environment > > is based on dpdk configuration target(T=) > > > > example usage: > > make tags T=x86_64-native-linuxapp-gcc > > make cscope T=x86_64-native-linuxapp-gcc > > make gtags T=x86_64-native-linuxapp-gcc > > > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > <...> > > > + > > +if [ -n "$T" ]; then > <...> > > + usage $1 > > + exit > > I would prefer fallback to RTE_TARGET parsing, or processing all files ( > cscope -Rqn ), instead of exiting here, but that is your call.
I would prefer avoid any fallback(sometimes RTE_TARGET can be "build" also) and print the usage and exit error if the requirements are not meet. > > > Also "tags.sh" needs to be moved into "devtools" after latest updates. Sure. I will send v2 to address this. > > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> Thanks for the review.
