On 11/27/2016 12:12 AM, Jerin Jacob wrote: > This script generates cscope, gtags, and tags > index files based on EAL environment. > (architecture and OS(linux/bsd)) > > Selection of the architecture and OS environment > is based on dpdk configuration target(T=) > > example usage: > make tags T=x86_64-native-linuxapp-gcc > make cscope T=x86_64-native-linuxapp-gcc > make gtags T=x86_64-native-linuxapp-gcc > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com>
<...> > + > +if [ -n "$T" ]; then <...> > + usage $1 > + exit I would prefer fallback to RTE_TARGET parsing, or processing all files ( cscope -Rqn ), instead of exiting here, but that is your call. Also "tags.sh" needs to be moved into "devtools" after latest updates. Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>