[dpdk-dev] [RFC][PATCH V2 3/3] examples/vhost: Add VMDQ vswitch device

2016-09-05 Thread Pankaj Chauhan
Add support for VMDQ vswitch device. This patch takes out all VMDQ specefic code from vhost/main.[c,h] and move it to vmdq.[c,h]. Moreover vmdq.[c,h] files plug the VMDQ vswitch device implmentation to the vhost-switch using vswitch framework. The main vhost/main.[c,h] code is now generic and can

[dpdk-dev] [RFC][PATCH V2 2/3] examples/vhost: Add vswitch command line options

2016-09-05 Thread Pankaj Chauhan
Add command line options for selecting switch implementation and maximum ports for the vswitch.following are two new command line options: --switch [char string, Selects the switch imlementation] --max-ports [int, selects maximum number of ports to support] For example: $ ./vhost-switch -c 3 -n

[dpdk-dev] [RFC][PATCH V2 1/3] examples/vhost: Add vswitch (generic switch) framework

2016-09-05 Thread Pankaj Chauhan
Introduce support for a generic framework for handling of switching between physical and vhost devices. The vswitch framework introduces the following concept: 1. vswitch_dev: Vswitch device is a logical switch which can have physical and virtio devices. The devices are operated/used using standar

[dpdk-dev] [RFC][PATCH V2 0/3] example/vhost: Introduce Vswitch Framework

2016-09-05 Thread Pankaj Chauhan
Introduce generic vswitch framework in vhost-switch application. Following are the goals/aim of the framework: 1. Make vhost-switch application generic so that it can support devices which don't support VMDQ. 2. Provide a framework so that any switching logic (generic in software or vendor spece

[dpdk-dev] [PATCH v2] virtio: enable indirect descriptors feature

2016-09-05 Thread Maxime Coquelin
Thanks Pierre for sending the fix. Minor comments below: On 09/05/2016 08:52 AM, Pierre Pfister (ppfister) wrote: > Indirect descriptors support was disabled by commit 4a92b67151be11, > presumably by accident as it was correctly supported. > > This patch simply adds VIRTIO_RING_F_INDIRECT_DESC ba

[dpdk-dev] [PATCH 1/2] net/virtio: support modern device id

2016-09-05 Thread Jason Wang
On 2016?09?02? 20:57, Thomas Monjalon wrote: > 2016-09-02 14:36, Jason Wang: >> Spec said "The PCI Device ID is calculated by adding 0x1040 to the >> Virtio Device ID". So this patch makes pmd can recognize modern virtio >> net id. > Please could you describe what is a modern virtio-net? I think

[dpdk-dev] sysfs permission problem when running dpdk app in lxc

2016-09-05 Thread Moon-Sang Lee
I'm using ubuntu 16.04 LTS as my host and installed lxd on it. When I try to run my dpdk(2.2.0) app in the container, I got following error message. EAL: lcore 9 is ready (tid=17fd700;cpuset=[9]) EAL: lcore 3 is ready (tid=c915700;cpuset=[3]) EAL: lcore 11 is ready (tid=ffc700;cpuset=[11]) EAL: lc

[dpdk-dev] [PATCH 2/2] virtio: support IOMMU platform

2016-09-05 Thread Jason Wang
On 2016?09?04? 16:08, Alejandro Lucero wrote: > I know RedHat is working on a vIOMMU so I guess this work is related > to that effort, but it is a surprise virtio using IOMMU. I thought > IOMMU just made sense when using SRIOV. My second guess is using IOMMU > with virtio is a matter of securi

[dpdk-dev] [PATCH 2/2] virtio: support IOMMU platform

2016-09-05 Thread Jason Wang
On 2016?09?02? 21:04, Thomas Monjalon wrote: > 2016-09-02 14:37, Jason Wang: >> Virtio pmd doesn't support VFIO in the past since devices bypass IOMMU >> completely. But recently, the work of making virtio device work with >> IOMMU is near to complete. > Good news! > What are the requirements for

[dpdk-dev] [PATCH] virtio: xstats name issue

2016-09-05 Thread Yuanhan Liu
On Mon, Sep 05, 2016 at 12:33:29PM +0800, Yuanhan Liu wrote: > Few generic (trivial) comments first: > > - cc to related maintainers > > - follow the right prefix, "net/virtio" but not "virtio" > > - start commit summary with a verb, and start with "fix" for bug fixing patch. I forgot to menti

[dpdk-dev] [PATCH v2] virtio: enable indirect descriptors feature

2016-09-05 Thread Stephen Hemminger
On Mon, 5 Sep 2016 16:24:13 +0200 Maxime Coquelin wrote: > Thanks Pierre for sending the fix. > > Minor comments below: > > On 09/05/2016 08:52 AM, Pierre Pfister (ppfister) wrote: > > Indirect descriptors support was disabled by commit 4a92b67151be11, > > presumably by accident as it was corre

[dpdk-dev] [dpdk-stable] [PATCH v4 1/6] vhost: fix windows vm hang

2016-09-05 Thread Yuanhan Liu
On Mon, Sep 05, 2016 at 05:25:31AM +, Wang, Zhihong wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Monday, September 5, 2016 1:25 PM > > To: Wang, Zhihong > > Cc: dev at dpdk.org; maxime.coquelin at redhat.com; > > yuanhan.li

[dpdk-dev] [dpdk-stable] [PATCH v4 1/6] vhost: fix windows vm hang

2016-09-05 Thread Yuanhan Liu
On Mon, Aug 29, 2016 at 11:35:59PM -0400, Zhihong Wang wrote: > This patch fixes a Windows VM compatibility issue in DPDK 16.07 vhost code, > which causes the guest to hang once any packets are enqueued when mrg_rxbuf > is turned on. This commit log lacks two important pieces: why does the hang ha

[dpdk-dev] [PATCH 2/2] virtio: support IOMMU platform

2016-09-05 Thread Jason Wang
On 2016?09?02? 21:04, Thomas Monjalon wrote: > 2016-09-02 14:37, Jason Wang: >> Virtio pmd doesn't support VFIO in the past since devices bypass IOMMU >> completely. But recently, the work of making virtio device work with >> IOMMU is near to complete. > Good news! > What are the requirements for

[dpdk-dev] [PATCH] virtio: xstats name issue

2016-09-05 Thread Yuanhan Liu
Few generic (trivial) comments first: - cc to related maintainers - follow the right prefix, "net/virtio" but not "virtio" - start commit summary with a verb, and start with "fix" for bug fixing patch. On Thu, Sep 01, 2016 at 04:01:14PM +0800, Zhiyong Yang wrote: > The patch fixes some xstats

[dpdk-dev] virtio kills qemu VM after stopping/starting ports

2016-09-05 Thread Yuanhan Liu
On Thu, Sep 01, 2016 at 08:53:31PM +, Kyle Larose wrote: > Hello everyone, Hi, Firstly, thanks for the report and detailed analysis! > > In my own testing, I recently stumbled across an issue where I could get qemu > to exit when sending traffic to my application. To do this, I simply need

[dpdk-dev] [PATCH] crypto/qat: fix memzone creation to use a fixed size string

2016-09-05 Thread Yuanhan Liu
On Thu, Sep 01, 2016 at 11:21:38AM +0100, John Griffin wrote: > Remove the dependency on dev->driver->pci_drv.name when > creating the memzone for the qat hardware queues. > The pci_drv.name may grow too large for RTE_MEMZONE_NAMESIZE. Will the "may grow too large" cause any issues? If so, state i

[dpdk-dev] [PATCH] virtio: remove obsolete comment

2016-09-05 Thread Matthias Gatto
On Mon, Sep 5, 2016 at 4:25 AM, Yuanhan Liu wrote: > On Fri, Sep 02, 2016 at 05:05:21PM +0200, Matthias Gatto wrote: >> As new_device and destroy_device use an int instead of a "struct virtio_net >> *", >> The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus >> If I've c

[dpdk-dev] [PATCH] virtio: remove obsolete comment

2016-09-05 Thread Yuanhan Liu
On Fri, Sep 02, 2016 at 05:05:21PM +0200, Matthias Gatto wrote: > As new_device and destroy_device use an int instead of a "struct virtio_net > *", > The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus > If I've correctly understand the code, the drivers take care of > se

[dpdk-dev] [PATCH] virtio: enable indirect descriptors feature

2016-09-05 Thread Yuanhan Liu
On Fri, Sep 02, 2016 at 03:55:24PM +, Pierre Pfister (ppfister) wrote: > Indirect descriptors support was disabled by commit 59d593f472a7, Hi, I failed to find this commit: $ git show 59d593f472a7 fatal: ambiguous argument '59d593f472a7': unknown revision or path not in the working

[dpdk-dev] [PATCH v2] virtio: enable indirect descriptors feature

2016-09-05 Thread Pierre Pfister (ppfister)
Indirect descriptors support was disabled by commit 4a92b67151be11, presumably by accident as it was correctly supported. This patch simply adds VIRTIO_RING_F_INDIRECT_DESC back to the supported features bit mask, hence enabling the use of indirect descriptors when the feature is negociated with t

[dpdk-dev] [PATCH] virtio: enable indirect descriptors feature

2016-09-05 Thread Pierre Pfister (ppfister)
> Le 5 sept. 2016 ? 04:20, Yuanhan Liu a ?crit > : > > On Fri, Sep 02, 2016 at 03:55:24PM +, Pierre Pfister (ppfister) wrote: >> Indirect descriptors support was disabled by commit 59d593f472a7, > > Hi, > > I failed to find this commit: > >$ git show 59d593f472a7 >fatal: ambiguou

[dpdk-dev] [PATCH] drivers/i40e: Add new PCTYPE for x722 hardware driver

2016-09-05 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Friday, August 26, 2016 5:25 PM > To: Zhang, Helin; Wu, Jingjing > Cc: dev at dpdk.org; Guo, Jia > Subject: [PATCH] drivers/i40e: Add new PCTYPE for x722 hardware driver > > There are 6 new PCTYPE be enabled in the i40e hardware driver for x7

[dpdk-dev] [PATCH] drivers/i40e: Add FD PCTYPE translation for x722

2016-09-05 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Friday, August 26, 2016 5:25 PM > To: Zhang, Helin; Wu, Jingjing > Cc: dev at dpdk.org; Guo, Jia > Subject: [PATCH] drivers/i40e: Add FD PCTYPE translation for x722 > > Before the filter is programmed, the PCTYPE in the FD programming > descr

[dpdk-dev] [PATCH v2] net/i40e: fix parsing QinQ packets type issue

2016-09-05 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, August 23, 2016 5:45 PM > To: Wu, Jingjing > Cc: dev at dpdk.org; Xing, Beilei > Subject: [PATCH v2] net/i40e: fix parsing QinQ packets type issue > > Previously, PTYPE filed in the RX descriptors is not set properly for QinQ > p

[dpdk-dev] [PATCH] virtio: xstats name issue

2016-09-05 Thread Yang, Zhiyong
Hi, Yuanhan: Thanks for your comments and suggestions. Zhiyong > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, September 5, 2016 12:33 PM > To: Yang, Zhiyong > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] virtio: xstats n

[dpdk-dev] [dpdk-stable] [PATCH v4 1/6] vhost: fix windows vm hang

2016-09-05 Thread Wang, Zhihong
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, September 5, 2016 1:25 PM > To: Wang, Zhihong > Cc: dev at dpdk.org; maxime.coquelin at redhat.com; > yuanhan.liu at linux.intel.com; thomas.monjalon at 6wind.com; > stable at dpdk.org > Subj

[dpdk-dev] [PATCH] mk: gcc -march support for intel processors code names

2016-09-05 Thread Liu, Yong
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pattan, Reshma > Sent: Monday, August 22, 2016 7:46 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk: gcc -march support for intel > processors code names > > > > > -Orig

[dpdk-dev] virtio kills qemu VM after stopping/starting ports

2016-09-05 Thread Tan, Jianfeng
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tan, Jianfeng > Sent: Friday, September 2, 2016 8:54 PM > To: Kyle Larose; dev at dpdk.org > Cc: Xie, Huawei; yuanhan.liu at linux.intel.com > Subject: Re: [dpdk-dev] virtio kills qemu VM after stopping/star

[dpdk-dev] [PATCH v4 2/6] vhost: rewrite enqueue

2016-09-05 Thread Yuanhan Liu
On Mon, Aug 29, 2016 at 11:36:00PM -0400, Zhihong Wang wrote: > This patch implements the vhost logic from scratch into a single function > designed for high performance and better maintainability. > > This is the baseline version of the new code, more optimization will be > added in the following