On Thu, Sep 01, 2016 at 11:21:38AM +0100, John Griffin wrote:
> Remove the dependency on dev->driver->pci_drv.name when
> creating the memzone for the qat hardware queues.
> The pci_drv.name may grow too large for RTE_MEMZONE_NAMESIZE.
Will the "may grow too large" cause any issues? If so, state it here. If
not, marking this patch as a "fix" patch doesn't make sense to me then.
>
> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
>
> Signed-off-by: John Griffin <john.griffin at intel.com>
> ---
> drivers/crypto/qat/qat_qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/qat_qp.c b/drivers/crypto/qat/qat_qp.c
> index 5de47e3..a29ed66 100644
> --- a/drivers/crypto/qat/qat_qp.c
> +++ b/drivers/crypto/qat/qat_qp.c
> @@ -300,7 +300,7 @@ qat_queue_create(struct rte_cryptodev *dev, struct
> qat_queue *queue,
> * Allocate a memzone for the queue - create a unique name.
> */
> snprintf(queue->memz_name, sizeof(queue->memz_name), "%s_%s_%d_%d_%d",
> - dev->driver->pci_drv.name, "qp_mem", dev->data->dev_id,
> + "qat_pmd", "qp_mem", dev->data->dev_id,
Besides that, why not putting "qat_pmd" and "qp_mem" inside the format
string?
--yliu
