Hi, Yuanhan: Thanks for your comments and suggestions.
Zhiyong > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, September 5, 2016 12:33 PM > To: Yang, Zhiyong <zhiyong.yang at intel.com> > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] virtio: xstats name issue > > Few generic (trivial) comments first: > > - cc to related maintainers > > - follow the right prefix, "net/virtio" but not "virtio" > > - start commit summary with a verb, and start with "fix" for bug fixing patch. > > On Thu, Sep 01, 2016 at 04:01:14PM +0800, Zhiyong Yang wrote: > > The patch fixes some xstats name issues and make the xstats name > > conform to code implementation(the function virtio_update_packet_stats). > > I would fix it inside virtio_update_packet_stats(), to keep the consistency of > name style: starts with an even number, and ends with an odd number. > > --yliu