On 2016?09?02? 20:57, Thomas Monjalon wrote: > 2016-09-02 14:36, Jason Wang: >> Spec said "The PCI Device ID is calculated by adding 0x1040 to the >> Virtio Device ID". So this patch makes pmd can recognize modern virtio >> net id. > Please could you describe what is a modern virtio-net?
I think it means the device that only support virtio 1.0. > >> #define VIRTIO_PCI_DEVICEID_MIN 0x1000 >> #define VIRTIO_PCI_DEVICEID_MAX 0x103F >> +#define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041 > It doesn't match the sentence above: 1000 + 1040 = 2040 According to the spec (5.1.1), Virtio Device id (not pci device id) is 1. > > By the way, VIRTIO_PCI_DEVICEID_MAX is not used in the code. > Yes, we can remove this. Thanks
