[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-09 Thread Huawei Xie
--- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 07fdf5e..b4327d3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_* F: examples/vhost_xen/ F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch

[dpdk-dev] [PATCH] claim responsibility for KVM virtio PMD, vhost backend, and XEN virtio solution.

2015-03-09 Thread Huawei Xie
--- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 07fdf5e..b4327d3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -131,6 +131,12 @@ F: app/test-pmd/mempool_* F: examples/vhost_xen/ F: doc/guides/prog_guide/intel_dpdk_xen_based_packet_switch

[dpdk-dev] [PATCH v3 07/10] vmxnet3: support jumbo frames

2015-03-09 Thread Yong Wang
On 3/9/15, 4:28 PM, "Yong Wang" wrote: >On 3/5/15, 4:10 PM, "Stephen Hemminger" >wrote: > >>From: Stephen Hemminger >> >>Add support for linking multi-segment buffers together to >>handle Jumbo packets. >> >>Signed-off-by: Stephen Hemminger >>--- >> lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 3

[dpdk-dev] [PATCH v3 07/10] vmxnet3: support jumbo frames

2015-03-09 Thread Yong Wang
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote: >From: Stephen Hemminger > >Add support for linking multi-segment buffers together to >handle Jumbo packets. > >Signed-off-by: Stephen Hemminger >--- > lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 3 +- > lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 2 +

[dpdk-dev] [PATCH] doc: update of testpmd user guide

2015-03-09 Thread Helin Zhang
It updated the user guide of testpmd, for the newly supported commands of getting/setting hash functions, and the command of showing port information. Signed-off-by: Helin Zhang --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 76 +++-- 1 file changed, 73 insertions(+),

[dpdk-dev] Running IP_fragmentation application

2015-03-09 Thread Sridhar Ramasamy
I installed and compiled DPDK in my virtual machine. I am using intel 82540EM NIC in the virtual machine. I have defined as host only adaptor(Apart from the one behind NAT to connect with the host). I ran the application, everything was set and after running, cursor is just blinking on screen. I am

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 21:13, Ananyev, Konstantin wrote: > >> From: Vladislav Zolotarov [mailto:vladz at cloudius-systems.com] >> Sent: Monday, March 09, 2015 6:22 PM >> To: Mcnamara, John >> Cc: dev at dpdk.org; Ananyev, Konstantin >> Subject: RE: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >> >> >> On Mar 9

[dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 09:58, Thomas Monjalon wrote: > 2015-03-09 09:08, Vlad Zolotarov: >> On 03/08/15 23:12, Thomas Monjalon wrote: >>> Hi Vlad, >>> >>> 2015-03-08 16:04, Vlad Zolotarov: According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as

[dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 09:58, Thomas Monjalon wrote: > 2015-03-09 09:08, Vlad Zolotarov: >> On 03/08/15 23:12, Thomas Monjalon wrote: >>> Hi Vlad, >>> >>> 2015-03-08 16:04, Vlad Zolotarov: According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as

[dpdk-dev] Guest Machine is not Pingable from Host Machine

2015-03-09 Thread Arkajit Ghosh
Hi, Can any one please suggest how to proceed. Thanks & Regards Arkajit Ghosh -Arkajit Ghosh/DEL/TCS wrote: - To: Ngo Doan Lap From: Arkajit Ghosh/DEL/TCS Date: 03/09/2015 09:39AM Cc: dev at dpdk.org Subject: Re: [dpdk-dev] Guest Machine is

[dpdk-dev] [PATCH v3 07/10] vmxnet3: support jumbo frames

2015-03-09 Thread Stephen Hemminger
On Mon, 9 Mar 2015 23:28:39 + Yong Wang wrote: > I didn?t see where mtu is used to calculate how many rx descriptors will > be needed for each packet. Furthermore, as pointed out by the following > code comments, the device requires the first rx buffer of a packet be of > type VMXNET3_RXD_BT

[dpdk-dev] [PATCH v6 3/3] ixgbe: Add LRO support

2015-03-09 Thread Vlad Zolotarov
- Only x540 and 82599 devices support LRO. - Add the appropriate HW configuration. - Add RSC aware rx_pkt_burst() handlers: - Implemented bulk allocation and non-bulk allocation versions. - Add LRO-specific fields to rte_eth_rxmode, to rte_eth_dev_data and to igb_

[dpdk-dev] [PATCH v6 2/3] ixgbe: Code refactoring

2015-03-09 Thread Vlad Zolotarov
- ixgbe_rx_alloc_bufs(): - Reset the rte_mbuf fields only when requested. - Take the RDT update out of the function. - Add the stub when RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC is not defined. - ixgbe_recv_scattered_pkts(): - Take the code that updates the fields of

[dpdk-dev] [PATCH v6 1/3] ixgbe: Cleanups

2015-03-09 Thread Vlad Zolotarov
- Removed the not needed casting. - ixgbe_dev_rx_init(): shorten the lines by defining a local alias variable to access &dev->data->dev_conf.rxmode. Signed-off-by: Vlad Zolotarov --- New in v6: - Fixed of a compilation error caused by a patches recomposition du

[dpdk-dev] [PATCH v6 0/3]: Add LRO support to ixgbe PMD

2015-03-09 Thread Vlad Zolotarov
This series adds the missing flow for enabling the LRO in the ethdev and adds a support for this feature in the ixgbe PMD. There is a big hope that this initiative is going to be picked up by some Intel developer that would add the LRO support to other Intel PMDs. The series starts with some cle

[dpdk-dev] [PATCH v1 1/3] ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 18:35, Ananyev, Konstantin wrote: > >> -Original Message- >> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] >> Sent: Monday, March 09, 2015 12:43 PM >> To: Ananyev, Konstantin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v1 1/3] ixgbe: Use the >> rte_le_to_

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Vladislav Zolotarov
On Mar 9, 2015 8:01 PM, "Mcnamara, John" wrote: > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladislav Zolotarov > > Sent: Monday, March 9, 2015 5:14 PM > > To: Ananyev, Konstantin > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ix

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Vladislav Zolotarov
On Mar 9, 2015 8:01 PM, "Mcnamara, John" wrote: > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladislav Zolotarov > > Sent: Monday, March 9, 2015 5:14 PM > > To: Ananyev, Konstantin > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ix

[dpdk-dev] [PATCH v6 1/3] ixgbe: Cleanups

2015-03-09 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Monday, March 09, 2015 7:07 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v6 1/3] ixgbe: Cleanups > >- Removed the not needed casting. >- ixgbe_dev_rx_init(): shorten the

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Ananyev, Konstantin
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Monday, March 09, 2015 7:32 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > > > > On 03/09/15 21:13, Ananyev, Konstantin wrote: > > >

[dpdk-dev] [PATCH v1 1/3] ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields

2015-03-09 Thread Ananyev, Konstantin
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Monday, March 09, 2015 6:51 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/3] ixgbe: Use the > rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting H

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Ananyev, Konstantin
> > From: Vladislav Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Monday, March 09, 2015 6:22 PM > To: Mcnamara, John > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: RE: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > > > On Mar 9, 2015 8:01 PM, "Mcnamara, John" wrote: > > > > >

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Vladislav Zolotarov
On Mar 9, 2015 6:39 PM, "Ananyev, Konstantin" wrote: > > > > > -Original Message- > > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > > Sent: Monday, March 09, 2015 3:58 PM > > To: Ananyev, Konstantin; Wodkowski, PawelX; dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v5 1

[dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 15:39, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Monday, March 9, 2015 10:13 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback >> initializa

[dpdk-dev] [PATCH v2 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization

2015-03-09 Thread Vlad Zolotarov
- Set the callback in a single function that is called from ixgbe_dev_rx_init() for a primary process and from eth_ixgbe_dev_init() for a secondary processes. This is instead of multiple, hard to track places. - Added ixgbe_hw.rx_bulk_alloc_allowed - see ixgbe_hw.rx_vec_allowed de

[dpdk-dev] [PATCH v2 2/3] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices

2015-03-09 Thread Vlad Zolotarov
According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3

[dpdk-dev] [PATCH v2 1/3] ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields

2015-03-09 Thread Vlad Zolotarov
Fixed the above in ixgbe_rx_alloc_bufs() and in ixgbe_recv_scattered_pkts(). Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.

[dpdk-dev] [PATCH v2 0/3]: bug fixes in the ixgbe PF PMD Rx flow

2015-03-09 Thread Vlad Zolotarov
This series contains some bug fixes that were found during my work on the ixgbe LRO patches. Sending this series separately on Thomas request so that it may be integrated into the 2.0 release. New in v2: - Fixed a compilation failure. Vlad Zolotarov (3): ixgbe: Use the rte_le_to_cpu_xx()/r

[dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 09:58, Thomas Monjalon wrote: > 2015-03-09 09:08, Vlad Zolotarov: >> On 03/08/15 23:12, Thomas Monjalon wrote: >>> Hi Vlad, >>> >>> 2015-03-08 16:04, Vlad Zolotarov: According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as

[dpdk-dev] [PATCH 0/3] dpdk2.0-rc1 build error fix

2015-03-09 Thread Thomas Monjalon
2015-03-05 21:15, Michael Qiu: > This patch set is to fix dpdk2.0-rc1 compile error. > > Michael Qiu (3): > librte_hash: Fix unsupported instruction `crc32' in i686 platform > app/test: Fix size_t printf formart issue > librte_eal/common: Fix redeclaration of enumerator ?REG_EAX? v3 of each

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladislav Zolotarov > Sent: Monday, March 9, 2015 5:14 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > > On Mar 9, 2015 6:39 PM, "Ananyev, Konstantin

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 13:29, Ananyev, Konstantin wrote: > >> -Original Message- >> From: Wodkowski, PawelX >> Sent: Monday, March 09, 2015 11:09 AM >> To: Ananyev, Konstantin; Vlad Zolotarov; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >> >> On 2015-03-09 11:49, Ananye

[dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 15:39, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Monday, March 9, 2015 10:13 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback >> initializa

[dpdk-dev] rte_memcpy.h: additional cflags required with OVS

2015-03-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Kavanagh, Mark B > Sent: Monday, March 9, 2015 4:44 PM > To: dev at dpdk.org > Subject: [dpdk-dev] rte_memcpy.h: additional cflags required with OVS > > Compilation of Open vSwitch fails when linked against curr

[dpdk-dev] [PATCHv2] headers: typeof -> __typeof__ to unbreak C++11 code

2015-03-09 Thread Thomas Monjalon
2015-03-06 15:59, Konstantin Ananyev: > v2: > Instead of changing all the affected files, > define 'typeofi' and 'asm' if needed. > > When compiling C++11-code or above (--std=c++11), the build fails with > lots of > > rte_eth_ctrl.h:517:3: note: in expansion of macro RTE_ALIGN > (RTE_ALIGN

[dpdk-dev] [PATCH 1/2] example: fix minor bug in l2fwd-jobstats init sequence

2015-03-09 Thread Pawel Wodkowski
On 2015-03-09 17:05, Pawel Wodkowski wrote: > [PATCH 1/2] This is standalone patch. '1/2' generated by accident. -- Pawel

[dpdk-dev] [PATCH 1/2] example: fix minor bug in l2fwd-jobstats init sequence

2015-03-09 Thread Pawel Wodkowski
Fix check of returned values during application init phase. Signed-off-by: Pawel Wodkowski --- examples/l2fwd-jobstats/main.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index a5a1aaa..ba9d3c0 1

[dpdk-dev] [PATCH v5] af_packet: Fix some klocwork errors

2015-03-09 Thread Ouyang Changchun
Fix possible memory leak issue: free kvlist before return; Fix possible resource lost issue: close qssockfd before return; Signed-off-by: Changchun Ouyang --- Change in v5: - Initialize qsockfd with -1; Change in v4: - Check sockfd in internals->rx_queue against 0. Change in v3: - Also cl

[dpdk-dev] rte_memcpy.h: additional cflags required with OVS

2015-03-09 Thread Kavanagh, Mark B
Hi, Compilation of Open vSwitch fails when linked against current HEAD of DPDK (f2552cd5). The source of this issue appears to be commit ID 9144d6b: "eal/x86: optimize memcpy for SSE and AVX", and can be resolved by passing an additional argument to OVS when building same (CFLAGS="-march=nativ

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Ananyev, Konstantin
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Monday, March 09, 2015 3:58 PM > To: Ananyev, Konstantin; Wodkowski, PawelX; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > > > > On 03/09/15 13:29, Ananyev, Konstanti

[dpdk-dev] [PATCH v1 1/3] ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields

2015-03-09 Thread Ananyev, Konstantin
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Monday, March 09, 2015 12:43 PM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/3] ixgbe: Use the > rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ri

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-03-09 Thread David Marchand
Playing with virtio link status triggers a segfault because of an incorrect io privilege level. To reproduce the problem, virtio device must be bound to igb_uio to have lsc enabled. $ lspci |grep Ethernet 00:03.0 Ethernet controller: Red Hat, Inc Virtio network device $ modprobe uio $ insmod ./x8

[dpdk-dev] [PATCH 1/2] eal/linux: move plugin load to very start of eal init

2015-03-09 Thread David Marchand
Loading shared libraries should be done at the very start of eal init so that the code statically built in dpdk and the code loaded from shared objects is handled (almost) the same way wrt to call to rte_eal_init(). The only thing that must be done before is filling the solib_list which is done by

[dpdk-dev] [PATCH 0/2] fix virtio interrupt handling

2015-03-09 Thread David Marchand
This patchset fixes a segfault in eal linux when using virtio pmd with link status change interrupts in place because of an incorrect io privilege level. Ouyang, Fixing this has revealed some problems to be fixed (for 2.0.0 at least for the first): - changing link status from qemu monitor trigge

[dpdk-dev] [PATCH v5] af_packet: Fix some klocwork errors

2015-03-09 Thread John W. Linville
On Mon, Mar 09, 2015 at 04:58:11PM +0800, Ouyang Changchun wrote: > Fix possible memory leak issue: free kvlist before return; > Fix possible resource lost issue: close qssockfd before return; > > Signed-off-by: Changchun Ouyang > --- > Change in v5: > - Initialize qsockfd with -1; > > Change

[dpdk-dev] [PATCH] testpmd: Fix action of operationg invalid port

2015-03-09 Thread Tetsuya Mukawa
On 2015/03/09 15:05, Michael Qiu wrote: > Currently, if try to start/stop/close one invalid prot, > no error shows in testpmd. > This is a bug, need check the port number. > > Signed-off-by: Michael Qiu > --- > app/test-pmd/config.c | 3 +++ > app/test-pmd/testpmd.c | 14 -- > 2 fi

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 Thread Thomas Monjalon
2015-03-09 09:12, Mcnamara, John: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xuelin Shi > > Yes, the patch http://dpdk.org/dev/patchwork/patch/3132/ should be > > abandoned. > > If you register and login to the DPDK patchwork site you can mark the patch > as "Not Applicable" or what

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 12:49, Ananyev, Konstantin wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Monday, March 09, 2015 10:21 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >> >> - Removed the not

[dpdk-dev] [PATCH v1 1/3] ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 12:29, Ananyev, Konstantin wrote: > Hi Vlad, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Monday, March 09, 2015 10:13 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v1 1/3] ixgbe: Use the >> rte_le_to_cpu

[dpdk-dev] [PATCH] testpmd: Fix port validation code of "port stop all" command

2015-03-09 Thread Tetsuya Mukawa
On 2015/03/09 12:49, Qiu, Michael wrote: > On 3/9/2015 10:22 AM, Tetsuya Mukawa wrote: >> On 2015/03/06 22:53, De Lara Guarch, Pablo wrote: >>> Hi Michael, >>> -Original Message- From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael Sent: Thursday, March 05, 20

[dpdk-dev] [PATCH] app/testpmd: fix potential out of bounds read

2015-03-09 Thread Julien Cretin
After the last enabled port has been seen, and the last time we evaluate the loop condition, there is an out of bounds read in ports[p].enabled because p is equal to size, which is the length of ports. Signed-off-by: Julien Cretin --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+)

[dpdk-dev] [PATCH] testpmd: Fix action of operationg invalid port

2015-03-09 Thread Michael Qiu
Currently, if try to start/stop/close one invalid prot, no error shows in testpmd. This is a bug, need check the port number. Signed-off-by: Michael Qiu --- app/test-pmd/config.c | 3 +++ app/test-pmd/testpmd.c | 14 -- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 Thread Bruce Richardson
On Wed, Mar 04, 2015 at 02:34:12PM +0800, xuelin.shi at freescale.com wrote: > From: Xuelin Shi > > This module uses type conversion between struct and int. > Also truncation and comparison is used with this int. > It is not safe for different endian arch. > > Add ifdef for big endian struct to

[dpdk-dev] [PATCH 1/3 v3] librte_hash: Fix unsupported instruction `crc32' in i686 platform

2015-03-09 Thread Michael Qiu
CC rte_hash.o Error: unsupported instruction `crc32' The root cause is that i686 platform does not support 'crc32q' Need make it only available in x86_64 platform Signed-off-by: Michael Qiu Acked-by: Yerden Zhumabekov --- v3 --> v2: Add sub function for #else which returns 0 v2 --> v1:

[dpdk-dev] [PATCH 5/5] ixgbe: rename igb_* to ixgbe_*

2015-03-09 Thread Bruce Richardson
On Fri, Mar 06, 2015 at 06:23:24PM -0800, Stephen Hemminger wrote: > To avoid any possible confusion or breakage, rename all the structures > of ixgbe driver to use ixgbe_ rather than igb_ because igb is a > different driver. > > Signed-off-by: Stephen Hemminger Apart from one small fix to a call

[dpdk-dev] [PATCH 4/5] ixgbe: rename set_tx_function

2015-03-09 Thread Bruce Richardson
On Fri, Mar 06, 2015 at 06:23:23PM -0800, Stephen Hemminger wrote: > All global functions in a driver should use the same prefix > to avoid any future name collisions. > > Signed-off-by: Stephen Hemminger I think this patch is missing one instance of set_tx_function at line 1963 of ixgbe_rxtx.c

[dpdk-dev] [PATCH 3/5] ixgbe: make bulk alloc static

2015-03-09 Thread Bruce Richardson
On Fri, Mar 06, 2015 at 06:23:22PM -0800, Stephen Hemminger wrote: > Only used in this file, make it static. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 5 - > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 2 +- > 2 files changed, 1

[dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization

2015-03-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Monday, March 9, 2015 10:13 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback > initialization > > @@ -3641,23 +3676,17 @@ ixgbe_dev_rx_in

[dpdk-dev] [PATCH 2/5] ixgbe: make register maps const

2015-03-09 Thread Bruce Richardson
On Fri, Mar 06, 2015 at 06:23:21PM -0800, Stephen Hemminger wrote: > These are const data structures, just put them in txt segment > rather than having compiler emit code to set them up on the stack. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/i

[dpdk-dev] [PATCH 1/5] ixgbe: make txq_ops const

2015-03-09 Thread Bruce Richardson
On Fri, Mar 06, 2015 at 06:23:20PM -0800, Stephen Hemminger wrote: > All virtual function tables should be const so they are put > in text segment rather than data. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 2 +- > lib/librt

[dpdk-dev] [PATCH v5 0/3]This series adds the missing flow for enabling the LRO in the ethdev and

2015-03-09 Thread Vlad Zolotarov
On 03/09/15 12:20, Vlad Zolotarov wrote: > The series starts with some cleanup work in the code the final patch (the > actual adding of > the LRO support) is going to touch/use/change. There are still quite a few > issues in the ixgbe > PMD code left but they have to be a matter of a different

[dpdk-dev] [PATCH] A fix to work around strict-aliasing rules breaking

2015-03-09 Thread Thomas Monjalon
> > Fixed strict-aliasing rules breaking errors for some GCC version. > > > > Signed-off-by: Zhihong Wang > > Acked-by:Cunming Liang > Applied, thanks

[dpdk-dev] [PATCH] librte_eal/common: Fix cast from pointer to integer of different size

2015-03-09 Thread Thomas Monjalon
> > ./i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error: > > cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > > > > dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16; > > > > Type 'long long' is 64-bit in i686 platform while 'void *' > > is 32-bit.

[dpdk-dev] [PATCH] testpmd: Fix action of operationg invalid port

2015-03-09 Thread Thomas Monjalon
> > Currently, if try to start/stop/close one invalid prot, > > no error shows in testpmd. > > This is a bug, need check the port number. > > > > Signed-off-by: Michael Qiu > > Acked-by: Tetsuya Mukawa Applied, thanks

[dpdk-dev] [PATCH v3 0/2] New HW VLAN command in testpmd

2015-03-09 Thread Thomas Monjalon
> This patch enables testpmd user can config port hw_vlan with more fine > granularity: > hw vlan filter, hw vlan strip, and hw vlan extend; > > Update testpmd doc accordingly. > > Changchun Ouyang (2): > testpmd: HW vlan command > doc: Update for new HW vlan command It may help in validati

[dpdk-dev] [PATCH v5 3/3] ixgbe: Add LRO support

2015-03-09 Thread Vlad Zolotarov
- Only x540 and 82599 devices support LRO. - Add the appropriate HW configuration. - Add RSC aware rx_pkt_burst() handlers: - Implemented bulk allocation and non-bulk allocation versions. - Add LRO-specific fields to rte_eth_rxmode, to rte_eth_dev_data and to igb_

[dpdk-dev] [PATCH v5 2/3] ixgbe: Code refactoring

2015-03-09 Thread Vlad Zolotarov
- ixgbe_rx_alloc_bufs(): - Reset the rte_mbuf fields only when requested. - Take the RDT update out of the function. - Add the stub when RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC is not defined. - ixgbe_recv_scattered_pkts(): - Take the code that updates the fields of

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Vlad Zolotarov
- Removed the not needed casting. - ixgbe_dev_rx_init(): shorten the lines by defining a local alias variable to access &dev->data->dev_conf.rxmode. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 27 --- 1 file chang

[dpdk-dev] [PATCH v5 0/3]This series adds the missing flow for enabling the LRO in the ethdev and

2015-03-09 Thread Vlad Zolotarov
The series starts with some cleanup work in the code the final patch (the actual adding of the LRO support) is going to touch/use/change. There are still quite a few issues in the ixgbe PMD code left but they have to be a matter of a different series and I've left a few "TODO" remarks in the cod

[dpdk-dev] [PATCH 2/2] e1000: silence noisy log messages

2015-03-09 Thread Stephen Hemminger
Same as ixgbe. Should not be as chatty in log and should be possible to compile away all the debug messages. Signed-off-by: Stephen Hemminger --- a/lib/librte_pmd_e1000/e1000_logs.h +++ b/lib/librte_pmd_e1000/e1000_logs.h @@ -35,8 +35,7 @@ #define _E1000_LOGS_H_ #define PMD_INIT_LOG(level, fm

[dpdk-dev] [PATCH 1/2] ixgbe: silence noisy log messages

2015-03-09 Thread Stephen Hemminger
The ixgbe driver likes to be far to chatty in the system log which is good for the original developer but not good for a production product. Reduce the log spam by doing: * All the normal messages should be changed from INFO to DEBUG. * The log messages should be done with RTE_LOG so that they c

[dpdk-dev] [PATCH 0/2] Intel driver silence excess logging

2015-03-09 Thread Stephen Hemminger
The Intel drivers seem to be getting more verbose in the log with each release. This is not a good thing. Stephen Hemminger (2): ixgbe: silence noisy log messages e1000: silence noisy log messages lib/librte_pmd_e1000/e1000_logs.h | 3 +-- lib/librte_pmd_e1000/em_ethdev.c| 10

[dpdk-dev] [PATCH] Move mk/rte.extvars.mk to mk/internal/rte.extvars.mk

2015-03-09 Thread Thomas Monjalon
2015-03-07 21:38, Thomas Monjalon: > 2015-03-06 09:46, Olivier MATZ: > > Hi Keith, > > > > On 03/04/2015 06:13 PM, Keith Wiles wrote: > > > Move the rte.extvars.mk to an internal directory and > > > update rte.vars.mk to find the file in the new location. > > > > > > Signed-off-by: Keith Wiles >

[dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization

2015-03-09 Thread Vlad Zolotarov
- Set the callback in a single function that is called from ixgbe_dev_rx_init() for a primary process and from eth_ixgbe_dev_init() for a secondary processes. This is instead of multiple, hard to track places. - Added ixgbe_hw.rx_bulk_alloc_allowed - see ixgbe_hw.rx_vec_allowed de

[dpdk-dev] [PATCH v1 2/3] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices

2015-03-09 Thread Vlad Zolotarov
According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3

[dpdk-dev] [PATCH v1 1/3] ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields

2015-03-09 Thread Vlad Zolotarov
Fixed the above in ixgbe_rx_alloc_bufs() and in ixgbe_recv_scattered_pkts(). Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.

[dpdk-dev] [PATCH v1 0/3]: bug fixes in the ixgbe PF PMD Rx flow

2015-03-09 Thread Vlad Zolotarov
This series contains some bug fixes that were found during my work on the ixgbe LRO patches. Sending this series separately on Thomas request so that it may be integrated into the 2.0 release. Vlad Zolotarov (3): ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW

[dpdk-dev] [PATCH] virtio: Add default_txconf

2015-03-09 Thread Thomas Monjalon
> > When I tried to launch test-pmd on KVM guest of Fedora21, I got following > > error: > > > > Configuring Port 0 (socket 0) > > Fail to configure port 0 tx queues > > EAL: Error - exiting with code: 1 > > Cause: Start ports failed > > > > I found that the error caused here, and actual error

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Pawel Wodkowski
On 2015-03-09 11:49, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Monday, March 09, 2015 10:21 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >> >> - Removed the n

[dpdk-dev] [PATCH 1/2] virtio: initialize iopl when device is initialized

2015-03-09 Thread David Marchand
So, a little summary. On Fri, Mar 6, 2015 at 5:20 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > > > The virtio driver needs to use in/out instructions therefore it must > initialize > > > using iopl(2) system call. The problem is that virtio initialization > happens very > > > e

[dpdk-dev] [PATCH v3 0/2] testpmd: check return value of rte_eth_dev_vlan_filter()

2015-03-09 Thread Thomas Monjalon
> > v3 changes: > > - add seperate patch with testpmd_funcs.rst changes > > > > v2 changes: > > - fix formatting errors > > > > This patchset modifies testpmd behavior when setting: > > rx_vlan add all vf_port (enabling all vlanids > > to be passed thru rx filter on VF). > > Rx_vlan_all_filter_se

[dpdk-dev] [PATCH v4] af_packet: Fix some klocwork errors

2015-03-09 Thread Ouyang Changchun
Fix possible memory leak issue: free kvlist before return; Fix possible resource lost issue: close qssockfd before return; Signed-off-by: Changchun Ouyang --- Change in v4: - Check sockfd in internals->rx_queue against 0. Change in v3: - Also close sockets for all queues. Change in v2: -

[dpdk-dev] [PATCH] testpmd: bond port creation did not enable bond port

2015-03-09 Thread Thomas Monjalon
> > When invoking creation of bonded device using: > > create bonded device mode socket in testpmd the bonded port was not > > enabled at the end of cmd_create_bonded_device_parsed function. > > This caused commands 'show port info' and 'show port stats' not working > > properly with bonding device

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Ananyev, Konstantin
> -Original Message- > From: Wodkowski, PawelX > Sent: Monday, March 09, 2015 11:09 AM > To: Ananyev, Konstantin; Vlad Zolotarov; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > > On 2015-03-09 11:49, Ananyev, Konstantin wrote: > > > > > >> -Original Messag

[dpdk-dev] [PATCH 1/3] BSD: Support Port Hotplug function

2015-03-09 Thread Tetsuya Mukawa
On 2015/03/06 19:32, Iremonger, Bernard wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa >> Sent: Wednesday, March 4, 2015 3:12 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH 1/3] BSD: Support Port Hotplug function >> >> This pa

[dpdk-dev] [PATCH] lib/librte_vhost: exchange kickfd and callfd to avoid confusion

2015-03-09 Thread Tetsuya Mukawa
On 2015/03/06 19:39, Huawei Xie wrote: > Previous vhost implementation wrongly name kickfd as callfd and callfd as > kickfd. > It is functional correct, but causes confusion. > > Signed-off-by: Huawei Xie > --- > examples/vhost/main.c | 6 +++--- > lib/librte_vhost/rte_v

[dpdk-dev] [PATCH] test whether file descriptor is valid before close it

2015-03-09 Thread Tetsuya Mukawa
On 2015/03/06 20:05, Huawei Xie wrote: > This avoids closing -1 in our case. > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/virtio-net.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c > index 6

[dpdk-dev] [PATCH] testpmd: Fix port validation code of "port stop all" command

2015-03-09 Thread Tetsuya Mukawa
On 2015/03/06 22:53, De Lara Guarch, Pablo wrote: > Hi Michael, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael >> Sent: Thursday, March 05, 2015 1:33 PM >> To: Tetsuya Mukawa; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix po

[dpdk-dev] [PATCH 1/2] eal/linux: move plugin load to very start of eal init

2015-03-09 Thread Neil Horman
On Mon, Mar 09, 2015 at 03:56:38PM +0100, David Marchand wrote: > Loading shared libraries should be done at the very start of eal init so that > the code statically built in dpdk and the code loaded from shared objects is > handled (almost) the same way wrt to call to rte_eal_init(). > The only th

[dpdk-dev] Memory issues seen while running pktgen with DPDK sample application

2015-03-09 Thread Bruce Richardson
On Sun, Mar 08, 2015 at 09:40:06PM +0530, Shankari Vaidyalingam wrote: > Hi, > > I'm trying to send packets from pktgen to exception path sample application. > My configuration is like this: > > |--Terminal 1--- ---Terminal 2 > |

[dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups

2015-03-09 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Monday, March 09, 2015 10:21 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > >- Removed the not needed casting. >- ixgbe_dev_rx_init(): shorten th

[dpdk-dev] [PATCH v1 1/3] ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring descriptor fields

2015-03-09 Thread Ananyev, Konstantin
Hi Vlad, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Monday, March 09, 2015 10:13 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/3] ixgbe: Use the > rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when reading/setting HW ring des

[dpdk-dev] [PATCH v3] pci: save list of detached devices, and re-probe during driver unload

2015-03-09 Thread Bruce Richardson
On Mon, Mar 09, 2015 at 10:07:29AM +0200, Raz Amir wrote: > Hi, gentle reminder about this patch... > > On Mar 4, 2015, at 1:15 PM, Raz Amir wrote: > > Added code that saves the pointers to the detached devices, during > driver loading, and during driver unloading, go over the list, > and re-att

[dpdk-dev] [PATCH v3] pci: save list of detached devices, and re-probe during driver unload

2015-03-09 Thread Raz Amir
Hi, gentle reminder about this patch... On Mar 4, 2015, at 1:15 PM, Raz Amir wrote: Added code that saves the pointers to the detached devices, during driver loading, and during driver unloading, go over the list, and re-attach them by calling device_probe_and_attach on each device. Signed-off-

[dpdk-dev] Guest Machine is not Pingable from Host Machine

2015-03-09 Thread Arkajit Ghosh
Hi, I have executed below commands: ./utilities/ovs-vsctl add-br ovsbr0 ./utilities/ovs-vsctl set bridge datapath_type=netdev ./utilities/ovs-vsctl add-port ovsbr0 dpdk0 -- set Interface dpdk0 type=dpdk ./utilities/ovs-vsctl add-port ovsbr0 dpdk1 -- set Interface dpdk1 type=dpdk ./utilities/ovs

[dpdk-dev] [PATCH] rte_mbuf: scattered pktmbufs freeing optimization

2015-03-09 Thread Olivier MATZ
Hi Vadim, On 03/07/2015 12:24 AM, Vadim Suraev wrote: > Hi, Olivier, > I realized that if local cache for the mempool is enabled and greater > than 0, > if, say, the mempool size is X and local cache length is Y (and it is > not empty,Y>0) > an attempt to allocate a bulk, whose size is greater tha

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 Thread Xuelin Shi
Hi, OK, done. Marked as "not applicable". Thanks, Shi > -Original Message- > From: Mcnamara, John [mailto:john.mcnamara at intel.com] > Sent: Monday, March 09, 2015 17:13 > To: Shi Xuelin-B29237; Richardson, Bruce > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] librte_lpm: defin

[dpdk-dev] [PATCH] test whether file descriptor is valid before close it

2015-03-09 Thread Thomas Monjalon
> > This avoids closing -1 in our case. > > > > Signed-off-by: Huawei Xie > > Acked-by: Changchun Ouyang Applied, thanks

[dpdk-dev] [PATCH] lib/librte_vhost: exchange kickfd and callfd to avoid confusion

2015-03-09 Thread Thomas Monjalon
> > Previous vhost implementation wrongly name kickfd as callfd and callfd as > > kickfd. > > It is functional correct, but causes confusion. > > > > Signed-off-by: Huawei Xie > > Acked-by: Changchun Ouyang Applied, thanks

[dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices

2015-03-09 Thread Vlad Zolotarov
On 03/08/15 23:12, Thomas Monjalon wrote: > Hi Vlad, > > 2015-03-08 16:04, Vlad Zolotarov: >> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should >> be configured to the same value as HLREG0.RXCRCSTRP. >> >> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by

  1   2   >