On 03/09/15 15:39, Mcnamara, John wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Monday, March 9, 2015 10:13 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback >> initialization >> >> @@ -3641,23 +3676,17 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) >> buf_size = (uint16_t) ((srrctl & IXGBE_SRRCTL_BSIZEPKT_MASK) >> << >> IXGBE_SRRCTL_BSIZEPKT_SHIFT); >> >> - if (dev->data->dev_conf.rxmode.enable_scatter || >> - /* It adds dual VLAN length for supporting dual VLAN */ >> - (dev->data->dev_conf.rxmode.max_rx_pkt_len + >> - 2 * IXGBE_VLAN_TAG_SIZE) > buf_size){ >> - if (!dev->data->scattered_rx) >> - PMD_INIT_LOG(DEBUG, "forcing scatter mode"); >> + /* It adds dual VLAN length for supporting dual VLAN */ >> + if (dev->data->dev_conf.rxmode.max_rx_pkt_len + >> + 2 * IXGBE_VLAN_TAG_SIZE > buf_size) >> dev->data->scattered_rx = 1; >> -#ifdef RTE_IXGBE_INC_VECTOR >> - if (rte_is_power_of_2(rxq->nb_rx_desc)) >> - dev->rx_pkt_burst = >> - ixgbe_recv_scattered_pkts_vec; >> - else >> -#endif >> - dev->rx_pkt_burst = ixgbe_recv_scattered_pkts; >> - } >> } >> >> + if (rx_conf->enable_scatter) >> + dev->data->scattered_rx = 1; > Hi, > > There is a compilation issue here when this patch is applied to the current > master (with previous 2 patches applied as well): > > make T=x86_64-native-linuxapp-gcc install CC=gcc > ... > == Build lib/librte_pmd_ixgbe > CC ixgbe_rxtx.o > /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function > 'ixgbe_dev_rx_init': > /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3689:6: error: 'rx_conf' > undeclared (first use in this function) > /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3689:6: note: each > undeclared identifier is reported only once for each function it appears in > make[5]: *** [ixgbe_rxtx.o] Error 1 > > This is using the default DPDK linuxapp config.
v2 is out. Again, my apologize. ;) > > John >
