great, I will trim it in my PR.
checkstyle.xml need more discussion
On Thu, Apr 14, 2022 at 5:48 PM morrysnow wrote:
> I agree with u.
>
> For the first point, I want to list rules first, and then change
> checkstyle.xml.
>
> For the second point, original change information in git is not lost,
I agree with u.
For the first point, I want to list rules first, and then change checkstyle.xml.
For the second point, original change information in git is not lost, we just
need to do blame on the version prior to the ‘code style’ commit and some gui
tools could list history of one file. Any
very good
-- Original --
From: morrysnow https://github.com/apache/incubator-doris/pull/8987
>
> On Thu, Apr 14, 2022 at 4:37 PM morrysnow
Great! But I think maybe we should list all rules in a some place and checked
by every one care about it before we merge it to ensure the new code style is
good enough.
> 2022年4月14日 17:09，vin jake 写道：
>
> I have add it in PR https://github.com/apache/incubator-doris/pull/8987
>
> On Thu, Apr
In general, I believe that we should do some work to make the code clean
and readable.
My concern is:
1. We should have an agreement on the code style specification in the
community at first.
2. If the many lines of code change after applying the code style rule, we
would lose the original changel
I don’t know what exactly mean in ‘compile time’.
Maven indeed to it with Checkstyle.xml in when compile.
but we only check 'import with star' and 'unused import’ in fe now.
We could do more than that such as import order, tabs and intents, comments
style and etc..
We can provide code style scheme
> I have add it in PR https://github.com/apache/incubator-doris/pull/8987
Good job!
On Thu, Apr 14, 2022 at 5:12 PM vin jake wrote:
> I have add it in PR https://github.com/apache/incubator-doris/pull/8987
>
> On Thu, Apr 14, 2022 at 4:37 PM morrysnow wrote:
>
> > Hi, devs,
> >
> > Currently,
I have add it in PR https://github.com/apache/incubator-doris/pull/8987
On Thu, Apr 14, 2022 at 4:37 PM morrysnow wrote:
> Hi, devs,
>
> Currently, we only have two rules in checkstyle.xml in fe. These are all
> about import. So, the code style in fe is very casual.
> I want to add more rules to
Is there a way to check the imports order?
Now we can only manually remind the order by reviewers.
Jianliang Qi
On Thu, Apr 14, 2022 at 5:02 PM ling miao wrote:
> It is best to check the code style at compile time.
>
> Ling Miao
>
> morrysnow 于2022年4月14日周四 16:37写道：
>
> > Hi, devs,
> >
> > Curr
It is best to check the code style at compile time.
Ling Miao
morrysnow 于2022年4月14日周四 16:37写道：
> Hi, devs,
>
> Currently, we only have two rules in checkstyle.xml in fe. These are all
> about import. So, the code style in fe is very casual.
> I want to add more rules to checkstyle.xml in fe to
Hi, devs,
Currently, we only have two rules in checkstyle.xml in fe. These are all about
import. So, the code style in fe is very casual.
I want to add more rules to checkstyle.xml in fe to Improve code readability,
and adjust all fe code to satisfy new code style step by step.
What do you think
11 matches
Mail list logo
