Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-21 Thread Gary Gregory
On Feb 21, 2012, at 2:38, Simone Tripodi wrote: > Sorry but I lost you, at that point I don't understand what meaning we > want to attribute to the "checkstyle configuration can be overridden" > sentence. > > Do you mean that we add the suppressions file, in order to skip some > violations (i.e.

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-20 Thread Simone Tripodi
Sorry but I lost you, at that point I don't understand what meaning we want to attribute to the "checkstyle configuration can be overridden" sentence. Do you mean that we add the suppressions file, in order to skip some violations (i.e. signature too long of the default 80 char estimated by the de

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-20 Thread Gary Gregory
On Mon, Feb 20, 2012 at 4:10 AM, Benedikt Ritter wrote: > Am 19.02.2012 22:57, schrieb Simone Tripodi: > > I think it is reasonable to have Commons wide defaults but let projects >>> override them if they want to. >>> >> > I think that is, what Gary meant in the first place ;-) > http://mail-arch

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-20 Thread Ralph Goers
On Feb 20, 2012, at 7:28 AM, sebb wrote: > On 20 February 2012 09:10, Benedikt Ritter wrote: >> Am 19.02.2012 22:57, schrieb Simone Tripodi: >> I think it is reasonable to have Commons wide defaults but let projects override them if they want to. >> >> >> I think that is, what Gary

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-20 Thread sebb
On 20 February 2012 09:10, Benedikt Ritter wrote: > Am 19.02.2012 22:57, schrieb Simone Tripodi: > >>> I think it is reasonable to have Commons wide defaults but let projects >>> override them if they want to. > > > I think that is, what Gary meant in the first place ;-) > http://mail-archives.apa

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-20 Thread Benedikt Ritter
Am 19.02.2012 22:57, schrieb Simone Tripodi: I think it is reasonable to have Commons wide defaults but let projects override them if they want to. I think that is, what Gary meant in the first place ;-) http://mail-archives.apache.org/mod_mbox/commons-dev/201202.mbox/%3C-662605764588844473%4

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-19 Thread Simone Tripodi
> I think it is reasonable to have Commons wide defaults but let projects > override them if they want to. that is much more than reasonable, we are on the same path now! :) -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi htt

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-19 Thread Ralph Goers
On Feb 19, 2012, at 12:26 PM, Simone Tripodi wrote: > While I agree that checkstyle has to be consistent inside each > component, so I would be +1 on having the plugin in the parent (with > PMD and Findbugs as mentioned by Gary), I am still reluctant with > adopting a general checkstyle *configur

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-19 Thread Christian Grobmeier
On Sun, Feb 19, 2012 at 9:26 PM, Simone Tripodi wrote: > main OGNL contributors have been olamy, mcucchiara, grobmeier and > simonetripodi > . > We all (except grobmeier :P) like the mvn style (brought by > c

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-19 Thread Niall Pemberton
On Sun, Feb 19, 2012 at 8:30 PM, Mark Thomas wrote: > On 19/02/2012 20:26, Simone Tripodi wrote: >> So please explain me why the PMC should "force" OGNL guys on adopting >> a different style in a component where just a small subset of commons >> people (mainly Struts guys) is interested. > > It sh

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-19 Thread Mark Thomas
On 19/02/2012 20:26, Simone Tripodi wrote: > So please explain me why the PMC should "force" OGNL guys on adopting > a different style in a component where just a small subset of commons > people (mainly Struts guys) is interested. It shouldn't. Those that do the work get to make the decisions. M

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-19 Thread Simone Tripodi
While I agree that checkstyle has to be consistent inside each component, so I would be +1 on having the plugin in the parent (with PMD and Findbugs as mentioned by Gary), I am still reluctant with adopting a general checkstyle *configuration* for all components, and I make you a sample: commons-og

Re: Common checkstyle (was Re: [vfs] checkstyle)

2012-02-19 Thread Christian Grobmeier
On Sun, Feb 19, 2012 at 4:23 PM, Ralph Goers wrote: > On Feb 19, 2012, at 6:55 AM, Simone Tripodi wrote: > >>> Unlike Commons, you have to be granted permission to commit at other >>> projects at the ASF and each of them have their own PMC and build their own >>> communities.  Commons is a sing