While I agree that checkstyle has to be consistent inside each component, so I would be +1 on having the plugin in the parent (with PMD and Findbugs as mentioned by Gary), I am still reluctant with adopting a general checkstyle *configuration* for all components, and I make you a sample: commons-ognl.
main OGNL contributors have been olamy, mcucchiara, grobmeier and simonetripodi <http://svnsearch.org/svnsearch/repos/ASF/search?path=%2Fcommons%2Fproper%2Fognl%2Ftrunk>. We all (except grobmeier :P) like the mvn style (brought by checkstyle-plugin) and we are comfortable on working with it. No one else committed on OGNL. So please explain me why the PMC should "force" OGNL guys on adopting a different style in a component where just a small subset of commons people (mainly Struts guys) is interested. Concluding: PMD, findbugs and checkstyle by default: +1; deciding which style has to be applied: -1. Good practice are one thing, strict rules are different. -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Feb 19, 2012 at 4:26 PM, Christian Grobmeier <grobme...@gmail.com> wrote: > On Sun, Feb 19, 2012 at 4:23 PM, Ralph Goers <rgo...@apache.org> wrote: >> On Feb 19, 2012, at 6:55 AM, Simone Tripodi <simonetrip...@apache.org> wrote: >> >>>> Unlike Commons, you have to be granted permission to commit at other >>>> projects at the ASF and each of them have their own PMC and build their >>>> own communities. Commons is a single community and thus it makes sense >>>> for developers to be able to easily switch between sub projects. Having >>>> commonality between the projects encourages that as it means you don't >>>> have to figure out what style settings you need as you switch between >>>> projects. >>>> >>> >>> I continue seeing it an imposition that can be avoided, since not >>> everybody commits in each component. >>> I switched across components and I just respected the original code >>> format (well, not always true, because I reformatted Discovery and >>> still regret for it) - that doesn't mean that style was always the >>> same, since each component defined its own config (and often the >>> exception rules) >>> >>> If a common style has to be applied to all commons components, IMHO a >>> VOTE should be subjected to the PMC >> >> I agree with that. However, there is nothing wrong with discussing it first >> to see if a vote is even warranted. > > If the question is to have a common commons codestyle, so yes. I think > public projects should follow standards. And there are sun/oracle > coding conventions. > > Cheers > Christian > >> >> Ralph >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > > -- > http://www.grobmeier.de > https://www.timeandbill.de > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
