> I think it is reasonable to have Commons wide defaults but let projects > override them if they want to.
that is much more than reasonable, we are on the same path now! :) -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Feb 19, 2012 at 10:49 PM, Ralph Goers <rgo...@apache.org> wrote: > On Feb 19, 2012, at 12:26 PM, Simone Tripodi <simonetrip...@apache.org> wrote: > >> While I agree that checkstyle has to be consistent inside each >> component, so I would be +1 on having the plugin in the parent (with >> PMD and Findbugs as mentioned by Gary), I am still reluctant with >> adopting a general checkstyle *configuration* for all components, and >> I make you a sample: commons-ognl. >> >> main OGNL contributors have been olamy, mcucchiara, grobmeier and >> simonetripodi >> <http://svnsearch.org/svnsearch/repos/ASF/search?path=%2Fcommons%2Fproper%2Fognl%2Ftrunk>. >> We all (except grobmeier :P) like the mvn style (brought by >> checkstyle-plugin) and we are comfortable on working with it. No one >> else committed on OGNL. >> So please explain me why the PMC should "force" OGNL guys on adopting >> a different style in a component where just a small subset of commons >> people (mainly Struts guys) is interested. >> >> Concluding: PMD, findbugs and checkstyle by default: +1; deciding >> which style has to be applied: -1. Good practice are one thing, strict >> rules are different. > > I think it is reasonable to have Commons wide defaults but let projects > override them if they want to. > > Ralph > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
