Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-04 Thread Stefan Bodewig
On 2009-03-04, Wolfgang Glas wrote: > Hello Stefan reviewed you code and found out, that you did not > strictly use the same encoding for filenames and comments in one > entry. Good catch, thanks! svn rev 750310 Stefan - To u

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-04 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-03-04, Stefan Bodewig wrote: > >> On 2009-03-03, Wolfgang Glas wrote: > >>> The implementation should be be straightforward, shall I prepare a >>> patch or can you afford doing it at your own? > >> Will do it myself. > > svn revisions 749906 and 749907 Hello

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-04 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-03-04, Stefan Bodewig wrote: > >> On 2009-03-03, Wolfgang Glas wrote: > >>> The implementation should be be straightforward, shall I prepare a >>> patch or can you afford doing it at your own? > >> Will do it myself. > > svn revisions 749906 and 749907 ThX v

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-03 Thread Stefan Bodewig
On 2009-03-04, Stefan Bodewig wrote: > On 2009-03-03, Wolfgang Glas wrote: >> The implementation should be be straightforward, shall I prepare a >> patch or can you afford doing it at your own? > Will do it myself. svn revisions 749906 and 749907 Stefan -

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-03 Thread Stefan Bodewig
On 2009-03-03, Wolfgang Glas wrote: > Stefan Bodewig schrieb: >> On 2009-03-03, Wolfgang Glas wrote: >>> Stefan Bodewig schrieb: On 2009-03-02, Wolfgang Glas wrote: >>> Acccording to my tests WinZip recognizes the EFS flag upon >>> reading. >> Then my documenation is wrong 8-) > Sorry

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-03 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-03-03, Wolfgang Glas wrote: > >> Stefan Bodewig schrieb: >>> On 2009-03-02, Wolfgang Glas wrote: > Stefan Bodewig schrieb: > On 2009-03-01, Wolfgang Glas wrote: > >> 1) Unicode extra fields are written for all ZIP entries and not only >> for

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-03 Thread Stefan Bodewig
On 2009-03-03, Wolfgang Glas wrote: > Stefan Bodewig schrieb: >> On 2009-03-02, Wolfgang Glas wrote: >>> Stefan Bodewig schrieb: On 2009-03-01, Wolfgang Glas wrote: > 1) Unicode extra fields are written for all ZIP entries and not only > for entries, which are not encodable by th

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-03 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-03-02, Wolfgang Glas wrote: > >> Stefan Bodewig schrieb: >>> On 2009-03-01, Wolfgang Glas wrote: > 1) Unicode extra fields are written for all ZIP entries and not only for entries, which are not encodable by the encoding set to ZipArchiveOutputSt

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-02 Thread Stefan Bodewig
On 2009-03-02, Wolfgang Glas wrote: > Stefan Bodewig schrieb: >> On 2009-03-01, Wolfgang Glas wrote: >>> 1) Unicode extra fields are written for all ZIP entries and not only >>> for entries, which are not encodable by the encoding set to >>> ZipArchiveOutputStream. >> Maybe room for yet anothe

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-02 Thread Stefan Bodewig
On 2009-03-02, Wolfgang Glas wrote: > ...another small patch with even more javadoc typos and superfluent imports > fixed is attached. svn rev 749524 Thanks Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apa

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-02 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-03-01, Wolfgang Glas wrote: > >> 1) Unicode extra fields are written for all ZIP entries and not only >> for entries, which are not encodable by the encoding set to >> ZipArchiveOutputStream. > > Maybe room for yet another flag? Or an enum-like option > > setC

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-02 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-03-02, Stefan Bodewig wrote: > >> some cosmetics and commented out the "only create Unicode field for >> non-encodable paths" part - svn revision 749342. > > and 749344 - you misspet encoding in Simple8BitEncoding.java and I > didn't see it in time. ...another

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-02 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-03-02, Stefan Bodewig wrote: > >> some cosmetics and commented out the "only create Unicode field for >> non-encodable paths" part - svn revision 749342. > > and 749344 - you misspet encoding in Simple8BitEncoding.java and I > didn't see it in time. Yes, ThX, t

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-02 Thread Stefan Bodewig
On 2009-03-02, Stefan Bodewig wrote: > some cosmetics and commented out the "only create Unicode field for > non-encodable paths" part - svn revision 749342. and 749344 - you misspet encoding in Simple8BitEncoding.java and I didn't see it in time. Stefan ---

Re: [compress] [PATCH] Refactoring of zip encoding support.

2009-03-02 Thread Stefan Bodewig
On 2009-03-01, Wolfgang Glas wrote: > 1) Unicode extra fields are written for all ZIP entries and not only > for entries, which are not encodable by the encoding set to > ZipArchiveOutputStream. Maybe room for yet another flag? Or an enum-like option setCreateUnicodeExtraFields(NEVER | ALWAYS

[compress] [PATCH] Refactoring of zip encoding support.

2009-03-01 Thread Wolfgang Glas
Hello all, Well, the latest discussions with Stefan showed two shortcoming of our current ZIP unicode support: 1) Unicode extra fields are written for all ZIP entries and not only for entries, which are not encodable by the encoding set to ZipArchiveOutputStream. 2) In order to implement selec